deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Performance enhancement switching nodeType to a var

Browse source
This commit is contained in:
timmywil 2011-03-17 22:59:05 -04:00
parent d28922bc03
commit dfeeb872d6
1 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/attributes.js
View file

@ -278,9 +278,10 @@ jQuery.extend({
attrFix: {}, attrFix: {},
attr: function( elem, name, value, pass ) { attr: function( elem, name, value, pass ) {
var nType = elem.nodeType;
// don't get/set attributes on text, comment and attribute nodes // don't get/set attributes on text, comment and attribute nodes
if ( !elem || elem.nodeType === 3 || elem.nodeType === 8 || elem.nodeType === 2 ) { if ( !elem || nType === 3 || nType === 8 || nType === 2 ) {
return undefined; return undefined;
} }
@ -288,9 +289,8 @@ jQuery.extend({
return jQuery(elem)[name](value); return jQuery(elem)[name](value);
} }
var ret, var ret, hooks,
notxml = elem.nodeType !== 1 || !jQuery.isXMLDoc( elem ), notxml = nType !== 1 || !jQuery.isXMLDoc( elem );
hooks;
// Normalize the name if needed // Normalize the name if needed
name = notxml && jQuery.attrFix[ name ] || name; name = notxml && jQuery.attrFix[ name ] || name;
@ -357,13 +357,15 @@ jQuery.extend({
propFix: {}, propFix: {},
prop: function( elem, name, value ) { prop: function( elem, name, value ) {
var nType = elem.nodeType;
// don't get/set properties on text, comment and attribute nodes // don't get/set properties on text, comment and attribute nodes
if ( !elem || elem.nodeType === 3 || elem.nodeType === 8 || elem.nodeType === 2 ) { if ( !elem || nType === 3 || nType === 8 || nType === 2 ) {
return undefined; return undefined;
} }
var ret, hooks, notxml = elem.nodeType !== 1 || !jQuery.isXMLDoc( elem ); var ret, hooks,
notxml = nType !== 1 || !jQuery.isXMLDoc( elem );
// Try to normalize/fix the name // Try to normalize/fix the name
name = notxml && jQuery.propFix[ name ] || name; name = notxml && jQuery.propFix[ name ] || name;