From dfeeb872d611c7ff7270fceb7234dd0e04671eb8 Mon Sep 17 00:00:00 2001 From: timmywil Date: Thu, 17 Mar 2011 22:59:05 -0400 Subject: [PATCH] Performance enhancement switching nodeType to a var --- src/attributes.js | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/attributes.js b/src/attributes.js index 972a02f7..55d22eb9 100644 --- a/src/attributes.js +++ b/src/attributes.js @@ -278,20 +278,20 @@ jQuery.extend({ attrFix: {}, attr: function( elem, name, value, pass ) { + var nType = elem.nodeType; // don't get/set attributes on text, comment and attribute nodes - if ( !elem || elem.nodeType === 3 || elem.nodeType === 8 || elem.nodeType === 2 ) { + if ( !elem || nType === 3 || nType === 8 || nType === 2 ) { return undefined; } if ( pass && name in jQuery.attrFn ) { return jQuery(elem)[name](value); } - - var ret, - notxml = elem.nodeType !== 1 || !jQuery.isXMLDoc( elem ), - hooks; - + + var ret, hooks, + notxml = nType !== 1 || !jQuery.isXMLDoc( elem ); + // Normalize the name if needed name = notxml && jQuery.attrFix[ name ] || name; @@ -357,13 +357,15 @@ jQuery.extend({ propFix: {}, prop: function( elem, name, value ) { + var nType = elem.nodeType; // don't get/set properties on text, comment and attribute nodes - if ( !elem || elem.nodeType === 3 || elem.nodeType === 8 || elem.nodeType === 2 ) { + if ( !elem || nType === 3 || nType === 8 || nType === 2 ) { return undefined; } - var ret, hooks, notxml = elem.nodeType !== 1 || !jQuery.isXMLDoc( elem ); + var ret, hooks, + notxml = nType !== 1 || !jQuery.isXMLDoc( elem ); // Try to normalize/fix the name name = notxml && jQuery.propFix[ name ] || name;