Commit graph

1567 commits

Author SHA1 Message Date
randx 6d92aa6d12 Fix IssueObserver current_user assign. Refactored observers 2012-06-24 10:01:42 +03:00
randx 55f8338502 Merge branch 'separate_user_and_issue_observer_from_mail_observer' of https://github.com/robbkidd/gitlabhq into robbkidd-separate_user_and_issue_observer_from_mail_observer 2012-06-24 09:33:22 +03:00
Valeriy Sizov 1e1c5b7afe Diff refactoring 2012-06-24 01:14:45 +03:00
Valeriy Sizov 279c4262f9 small clean of CommitDecorator 2012-06-24 00:55:23 +03:00
Valeriy Sizov 1548baa17c update doc 2012-06-23 13:16:21 +03:00
Valeriy Sizov 65717f7040 Update master 2012-06-23 13:09:06 +03:00
randx 39fecb554f Up to 2.6.2 2012-06-22 23:50:58 +03:00
randx 68389588d6 Force resque protection 2012-06-22 23:46:57 +03:00
randx f3edea7ed7 Fixed network graph keyboard nav 2012-06-22 23:29:31 +03:00
randx d92a22c9e6 Up to 2.6.1 2012-06-22 22:49:03 +03:00
randx 193804516b Fix project redirect after destroy 2012-06-22 22:48:03 +03:00
Dmitriy Zaporozhets f48e0cca6d Merge pull request #961 from NARKOZ/load_assets_group
load assets group to allow lazy compilation in production
2012-06-22 03:11:23 -07:00
Nihad Abbasov a21bda5ac9 load assets group to allow lazy compilation in production 2012-06-22 03:09:36 -07:00
Dmitriy Zaporozhets d773db8dbe Merge pull request #959 from NARKOZ/raphael-js
Downgrade Raphael.js
2012-06-22 02:15:36 -07:00
Nihad Abbasov fd44b6b69d move assets gems to assets group 2012-06-22 02:00:09 -07:00
Nihad Abbasov da5cf9d085 downgrade raphael js to 1.5.2 2012-06-22 01:57:05 -07:00
randx b32465712b Up to 2.6 2012-06-21 20:25:23 +03:00
randx 1903f6ade0 admin area -> search for users 2012-06-21 19:05:09 +03:00
randx 98a45ce6ee admin area -> search for projecs 2012-06-21 18:54:57 +03:00
randx 77cf662034 Pushed widget improved 2012-06-21 18:41:22 +03:00
randx ed247b3893 resque auth example 2012-06-21 17:23:51 +03:00
randx 2d16585eae Few minor css improvements 2012-06-21 17:23:25 +03:00
randx e0805ec469 Backgrounds for Issues 2012-06-21 16:43:40 +03:00
Dmitriy Zaporozhets 75cf927d3b Issues & MR legend 2012-06-21 08:29:53 +03:00
randx b64ceadbf2 lets comment browse feature 2012-06-21 09:58:18 +03:00
Robb Kidd 65989141dc Protect IssueObserver#send_reassigned_email method. 2012-06-20 21:23:05 -04:00
Zevs 5fd2f7158e remove double negative 2012-06-21 00:21:13 +03:00
Dmitriy Zaporozhets bbb926f3c4 Merge pull request #952 from gitlabhq/remove_link_to_function
Get rid of deprecated link_to_function
2012-06-20 13:09:33 -07:00
randx d5b41831d1 missed ; 2012-06-20 23:08:10 +03:00
randx 1a05f2f7c9 Get rid of deprecated link_to_function 2012-06-20 21:29:55 +03:00
Robb Kidd 70c6b48ebc Remove :issue from MailerObserver; handled by IssueObserver now.
:issue snuck back in during rebasing.
2012-06-20 14:09:46 -04:00
Robb Kidd eba61c111d Remove upvotes method from Issue.
Must have snuck in during one of the multiple rebases while observers were
being refactored.
2012-06-20 14:09:46 -04:00
Robb Kidd 88964132ed Extract observation of User to a UserObserver 2012-06-20 14:09:46 -04:00
Robb Kidd 97ca4f5dda Deliver issue mails.
It helps to actually deliver messages.
2012-06-20 14:09:46 -04:00
Robb Kidd dfb5da9da3 Disable observers in specs. Enable only when observer is under test.
Used the built-in observer enable/disable feature in ActiveModel[1].
ActiveRecord::Base includes ActiveModel::Observing which provides this
behavior.

Simple wraps to enable the observer under test were added to the specs
for: ActivityObserver, IssueObserver, Admin::Users and Issues.

The spec for Project.last_activity was refactored to separate the tests
for #last_activity and #last_activity_date. Each had doubles added to
isolate the spec from the hidden dependency on the ActivityObserver
action to create an Event for the project when an Issue is created. This
ActivityObserver behavior is already tested by its spec.

[1] http://api.rubyonrails.org/classes/ActiveModel/ObserverArray.html
2012-06-20 14:09:46 -04:00
Robb Kidd 5303cc285a Add resque_spec to test queuing mail. 2012-06-20 14:09:46 -04:00
Robb Kidd 6617eaaf9b Make IssueObserver handle issus, not MailerObserver 2012-06-20 14:09:46 -04:00
Robb Kidd 356430c3c0 Add method for an issue to know whether it is being closed
Update IssueObserver to create a Note on the issue its being closed.
2012-06-20 14:09:46 -04:00
Robb Kidd 02924de3e1 Add method to Note to create notes about status changes. 2012-06-20 14:09:46 -04:00
Robb Kidd 00ec81eacb Update IssueObserver to send reassigned emails when an issue is reassigned. 2012-06-20 14:09:46 -04:00
Robb Kidd 2416e3cb19 Add new utility method for an issue to know whether it is being reassigned 2012-06-20 14:09:46 -04:00
Robb Kidd f6035552e5 New IssueObserver class and spec.
Handles emails for new issues and reassigned issues.
Need to add creating a Note on Issue close.
2012-06-20 14:09:46 -04:00
Zevs 6507c1085e Revert "Handle Commit "show suppressed diff" link with a doc-ready event handler."
This reverts commit ef1598b4af.
2012-06-20 21:01:27 +03:00
Zevs a9c7de8815 Revert "Handle MR "show all commits" link with a doc-ready event handler."
This reverts commit 5b1ede6280.
2012-06-20 21:01:00 +03:00
Zevs 581a822326 Revert "Invert "unless .empty?" to "if .present?"; unless-else is evil."
This reverts commit 7484bcfff7.
2012-06-20 21:00:34 +03:00
Valeriy Sizov 65c35394eb Merge pull request #951 from robbkidd/remove_link_to_function
Replace calls to deprecated link_to_function with doc-ready functions.
2012-06-20 10:43:32 -07:00
randx 4ac0160a11 Hande error with huge commits 2012-06-20 20:08:18 +03:00
Dmitriy Zaporozhets c7542eb801 Merge pull request #950 from netdata/Create_link_from_keys_count
make a hyperlink from the counted keys
2012-06-20 08:29:05 -07:00
Wouter D'Haeseleer c3d1f2eb9b make a hyperlink from the counted keys
Refs Ticket #948
2012-06-20 17:16:56 +02:00
Robb Kidd ef1598b4af Handle Commit "show suppressed diff" link with a doc-ready event handler.
Replaces link_to_function use which was deprecated in Rails v3.2.4.
https://github.com/rails/rails/commit/9dc57fe9c

Still absent is a graceful degrade for no-JS.
2012-06-20 11:11:17 -04:00