deac/gitlabhq
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

API: fixed adding a note

Browse source 
Now the correct attribute is checked if it's available or not. Also fixed a test.
This commit is contained in:
Sebastian Ziebell 2013-02-27 18:12:02 +01:00
parent 3bb342b961
commit d269d107d8
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/api/notes.rb
View file

@ -93,7 +93,7 @@ module Gitlab
# POST /projects/:id/issues/:noteable_id/notes # POST /projects/:id/issues/:noteable_id/notes
# POST /projects/:id/snippets/:noteable_id/notes # POST /projects/:id/snippets/:noteable_id/notes
post ":id/#{noteables_str}/:#{noteable_id_str}/notes" do post ":id/#{noteables_str}/:#{noteable_id_str}/notes" do
required_attributes! [:"#{noteable_id_str}"] required_attributes! [:body]
@noteable = user_project.send(:"#{noteables_str}").find(params[:"#{noteable_id_str}"]) @noteable = user_project.send(:"#{noteables_str}").find(params[:"#{noteable_id_str}"])
@note = @noteable.notes.new(note: params[:body]) @note = @noteable.notes.new(note: params[:body])

3
spec/requests/api/projects_spec.rb
View file

@ -466,8 +466,7 @@ describe Gitlab::API do
response.status.should == 200 response.status.should == 200
json_response.should be_an Array json_response.should be_an Array
#json_response.first['id'].should == project.repository.commit.id json_response.first['id'].should == project.repository.commit.id
json_response.size.should == 1
end end
end end