From d269d107d86c600ab2add651f47cced8f601ae84 Mon Sep 17 00:00:00 2001 From: Sebastian Ziebell Date: Wed, 27 Feb 2013 18:12:02 +0100 Subject: [PATCH] API: fixed adding a note Now the correct attribute is checked if it's available or not. Also fixed a test. --- lib/api/notes.rb | 2 +- spec/requests/api/projects_spec.rb | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/api/notes.rb b/lib/api/notes.rb index 759fd3a9..097cc7ea 100644 --- a/lib/api/notes.rb +++ b/lib/api/notes.rb @@ -93,7 +93,7 @@ module Gitlab # POST /projects/:id/issues/:noteable_id/notes # POST /projects/:id/snippets/:noteable_id/notes post ":id/#{noteables_str}/:#{noteable_id_str}/notes" do - required_attributes! [:"#{noteable_id_str}"] + required_attributes! [:body] @noteable = user_project.send(:"#{noteables_str}").find(params[:"#{noteable_id_str}"]) @note = @noteable.notes.new(note: params[:body]) diff --git a/spec/requests/api/projects_spec.rb b/spec/requests/api/projects_spec.rb index 71a33f85..994c8d5e 100644 --- a/spec/requests/api/projects_spec.rb +++ b/spec/requests/api/projects_spec.rb @@ -466,8 +466,7 @@ describe Gitlab::API do response.status.should == 200 json_response.should be_an Array - #json_response.first['id'].should == project.repository.commit.id - json_response.size.should == 1 + json_response.first['id'].should == project.repository.commit.id end end