Commit graph

130 commits

Author SHA1 Message Date
mildmojo 43bd628e05 Fixes case-sensitive SQLite3 adapter name typos.
The SQLite3 adapter name was referenced as
`ActiveRecord::ConnectionAdapters::Sqlite3Adapter`, but the
ActiveRecord class is spelled `SQLite3Adapter` (upper-case "SQL"). As
a result, `active_record/adapters/sqlite3_adapter.rb` wasn't actually
including the methods from `adapters/sqlite3_adapter.rb` into the AR
adapter class.

This adds a test for proper inheritance and fixes the spelling of
`SQLite3Adapter`, unifying all references to the ActiveRecord version.
2012-10-01 03:08:07 -04:00
Zach Dennis c08d31b528 Merge pull request #65 from jabley/missing-column
Provide more detailed error message
2012-09-14 08:00:18 -07:00
James Abley b03af0cd3e Provide more detailed error message
If we don't have a mapping for a column name, provide the column name
as well as the index in the array.
2012-09-14 14:01:00 +01:00
Zach Dennis 6182b944ef Merge pull request #56 from grzuy/support_all_or_none_records
Adds support for :all_or_none option on #import
2012-08-29 20:48:18 -07:00
Zach Dennis 0b03543612 Merge pull request #58 from alexagranov/e6cafdb23a64e68a246a838565afaecf6faf952a
The jdbcmysql_adapter was left out of the InstanceMethods refactoring.
2012-08-29 20:47:07 -07:00
Zach Dennis b4bc1466f1 Adding gemspec. To re-generate use: rake gemspec:generate 2012-08-29 23:45:16 -04:00
Zach Dennis 75a63d77d1 Merge pull request #62 from spectator/seamless_database_pool
Seamless database pool adapter
2012-08-29 20:41:52 -07:00
Zach Dennis 0e14c5f643 Version bump to 0.2.10 2012-08-29 23:38:02 -04:00
Yury Velikanau 190fcd32ff Remove remain of ruby-debug-19 from Gemfile.lock 2012-08-22 19:51:47 -07:00
Yury Velikanau 1d9b30cf83 Put together tests for seamless_database_pool adapter 2012-08-22 19:50:37 -07:00
Yury Velikanau 23a07371dd Add seamless_database_pool gem 2012-08-22 19:49:48 -07:00
Yury Velikanau 151c2f271f Gemfile.lock changes for debugger gem 2012-08-22 19:49:27 -07:00
Yury Velikanau 7628e0a9d8 debugger gem supports ruby 1.9.3 just fine 2012-08-22 18:57:41 -07:00
Yury Velikanau de048bb61e Remove whitespace. 2012-08-22 18:57:15 -07:00
Evan Petrie 9ee02d87ff fix file name 2012-08-22 18:44:48 -07:00
Evan Petrie cc0185abb3 make work with seamless database pool 2012-08-22 18:44:37 -07:00
Zach Dennis 2bb1150e00 Merge pull request #61 from benpickles/missing-column-error
Raise a useful message when passing validate: false and a value doesn't have a corresponding column
2012-08-20 05:53:45 -07:00
Ben Pickles f12d72b0b1 Raise a useful message when a value doesn't have a corresponding column. 2012-08-19 19:41:02 +01:00
Zach Dennis a1a183e43d Updating Gemfile to latest versions of libraries:
* updating deprecated require 'rake/rdoctask' with 'rdoc/task'
* preparing to remove deprecated ActiveRecord set_table_name with self.table_name=
2012-08-06 09:24:34 -04:00
Zach Dennis b500ebe5a1 Updating tests around working with non-standard ActiveRecord models with non-sequence based primary keys.
* move into test/import_test so it runs across all supported adapters

[#60]
2012-08-06 09:23:01 -04:00
Zach Dennis 71a393d000 Merge pull request #60 from jluxenberg/master
Model#import fails to find model's primary key sequence
2012-08-06 06:10:43 -07:00
Jared Luxenberg e12f9c4951 Model#import fails to find model's primary key sequence
Fixes a bug where Model#import does not work when a model's primary key
has no associated 'sequence' in the database. If a value for the primary
key is specified, then the insert should not require a database
'sequence' to generate a value for that primary key field.
2012-08-04 17:35:50 -07:00
Gonzalo Rodriguez eac7d5f949 Adds support for :all_or_none option on #import 2012-05-19 17:40:04 -03:00
Zach Dennis f74bd2fbbd Merge pull request #51 from seamusabshere/patch-1
memoize MySQL's max_allowed_packet
2012-05-03 17:09:20 -07:00
Seamus Abshere b36259af29 Solving #50 - memoize MySQL's max_allowed_packet instead of querying it every time you run .import 2012-03-20 16:40:10 -05:00
Alex Agranov e6cafdb23a somehow the jdbcmysql_adapter was left out in the refactoring that removed usage of the InstanceMethods module 2012-02-28 19:31:55 -05:00
Zach Dennis 3dc99c357d Merge pull request #46 from ebarendt/patch-1
Update README.markdown with correct link
2012-02-17 10:54:22 -08:00
Eric Barendt 8544641260 Update README.markdown 2012-02-15 15:38:37 -08:00
Zach Dennis 41952485a4 Version bump to 0.2.9 2012-01-20 17:50:58 -05:00
Zach Dennis b5c550860c Bumping sqlite3 dependency for development 2012-01-20 17:50:27 -05:00
Zach Dennis a5a9928b26 Making activerecord dependency be require a version of activerecord 3.x. https://github.com/zdennis/activerecord-import/pull/43 2012-01-20 17:48:04 -05:00
Zach Dennis 7fa043cf31 Merge pull request #43 from duckpond/c9a4313f8ba5805bfcca314a5b93d4720130de10
Active record dependency does not work with rails 3.2
2012-01-20 14:38:59 -08:00
Samantha John c9a4313f8b remove dependency on activerecord 3.0 2012-01-20 16:07:53 -05:00
Zach Dennis b2c71336ca Merge pull request #20 from Empact/drop_sum_sizes
Rely on ActiveSupport #sum rather than #sum_sizes
2012-01-06 15:47:53 -08:00
Zach Dennis 2539a71574 Merge pull request #38 from wycats/module_cleanup
Clean up module usage.
2012-01-03 06:20:48 -08:00
Yehuda Katz b5261d0225 Clean up module usage. There's no need to use InstanceMethods -- normal Ruby modules and includes will work fine here. 2012-01-03 00:41:04 -08:00
Zach Dennis a41050c2b5 Merge pull request #33 from nbudin/master
Use connection pool instead of actual connection on load (helps with Rails 3.1 on Heroku)
2011-12-14 15:23:58 -08:00
Nat Budin 08c36d33e4 Use connection pool instead of actual connection to avoid having to connect to the database until necessary 2011-10-10 13:07:10 -04:00
Ben Woosley 8d20594f12 Replace #sum_sizes with calls to ActiveSupport #sum, as splatting large numbers of values is resource intensive andcan cause stack overflows of the sort 'SystemStackError: stack level too deep' 2011-08-16 17:01:11 -07:00
Zach Dennis 3c08fad1a2 Bumping to 0.2.8 2011-08-14 01:39:44 -04:00
Zach Dennis 65dbc9e051 Bumping VERSION to 0.2.8.rc3 2011-07-12 23:43:18 -04:00
Zach Dennis 7cc7c33186 Merge pull request #27 from msgehard/fix_gemfile
Relax pg version dependency a bit.
2011-07-12 20:39:00 -07:00
Mike Gehard 4653feab96 Relax pg version dependency a bit. The Gemfile specifies pg ~>0.9.0 and Rails 3.1 specifies pg 0.11 so there is no way for bundler to install pg for a new download. 2011-07-12 19:04:53 -06:00
Zach Dennis ff0acfa433 Bumping VERSION to 0.2.8.rc2 2011-06-22 22:53:33 -04:00
Zach Dennis 5a71efa2b4 Merge pull request #21 from jamiecobbett/master
Fix import of very large datasets containing multibyte chars on Ruby 1.9
2011-06-22 19:51:29 -07:00
Zach Dennis 92ec1b478d Merge pull request #26 from fallwith/master
Ruby 1.9.2 / RubyGems 1.8.5 compatibility fix (pass String instead of Pathname to require)
2011-06-22 19:45:17 -07:00
Zach Dennis 449a11cd1c Updated Gemfile to include ~> 3.0pre so pre-releases are considered.
[fixes #24]
2011-06-22 22:32:21 -04:00
Zach Dennis 2cefff2219 Updating Gemfile to include activerecord ~> 3.0 instead of 3.0.0 so it works with 3.1.
[fixes #24]
2011-06-22 22:17:06 -04:00
fallwith 8f91eeb93d Regexp.escape which is called by Gem.loaded_path? (/usr/local/lib/ruby/site_ruby/1.9.1/rubygems.rb) expects the path as a String, not a Pathname. Convert Pathnames to Strings prior to calling 'require' 2011-06-22 16:01:33 -07:00
Jamie Cobbett 6555fd70ba Correctly obey MySQL MAX PACKET
Use String's bytesize instead of size, because we're talking about byte length,
not string length. This resolves a problem on Ruby 1.9 with multi-byte
characters.
2011-05-08 21:35:47 +00:00