From 8d8a2be5f8d9687961ef0f00c405e2fc3b86928b Mon Sep 17 00:00:00 2001
From: blackhedd <blackhedd@005445c4-6811-0410-8301-cae4f0071d1d>
Date: Sat, 2 Sep 2006 14:45:25 +0000
Subject: [PATCH] noticed a possible parameter problem in paged-search, added
 comments.

---
 lib/net/ldap.rb | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/lib/net/ldap.rb b/lib/net/ldap.rb
index 810aef8..3c84b97 100644
--- a/lib/net/ldap.rb
+++ b/lib/net/ldap.rb
@@ -1217,6 +1217,14 @@ module Net
         # then query again for the next page of results.
         # If not, we're done.
         # Don't screw this up or we'll break every search we do.
+        #
+        # Noticed 02Sep06, look at the read_ber call in this loop,
+        # shouldn't that have a parameter of AsnSyntax? Does this
+        # just accidentally work? According to RFC-2696, the value
+        # expected in this position is of type OCTET STRING, covered
+        # in the default syntax supported by read_ber, so I guess
+        # we're ok.
+        #
         more_pages = false
         if result_code == 0 and controls
           controls.each do |c|