! Fixes all tests

Some code has been removed. Version control is not synonymous with code storage - if you're not using it now, you probably don't have working tests and the code will be buggy anyway. Write it when you need it.

lib/net/ldap/core_ext/bignum.rb

@@ -4,32 +4,19 @@ module Net
       module Bignum
 
         def to_ber
-          #i = [self].pack('w')
-          #i.length > 126 and raise Net::BER::BerError.new( "range error in bignum" )
-          #[2, i.length].pack("CC") + i
+          # NOTE: Array#pack's 'w' is a BER _compressed_ integer. We need uncompressed
+          # BER integers, so we're not using that.
+          # See also: http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-talk/228864
+          result = []
 
-          # Ruby represents Bignums as two's-complement numbers so we may actually be
-          # good as far as representing negatives goes.
-          # I'm sure this implementation can be improved performance-wise if necessary.
-          # Ruby's Bignum#size returns the number of bytes in the internal representation
-          # of the number, but it can and will include leading zero bytes on at least
-          # some implementations. Evidently Ruby stores these as sets of quadbytes.
-          # It's not illegal in BER to encode all of the leading zeroes but let's strip
-          # them out anyway.
-          #
-          sz = self.size
-          out = "\000" * sz
-          (sz*8).times {|bit|
-      	if self[bit] == 1
-      	    out[bit/8] += (1 << (bit % 8))
-      	end
-          }
-
-          while out.length > 1 and out[-1] == 0
-      	out.slice!(-1,1)
+          n = self
+          while n>0
+              b = n & 0xff
+              result << b
+              n = n >> 8
           end
 
-          [2, out.length].pack("CC") + out.reverse
+          "\002" + ([result.size] + result.reverse).pack('C*')
         end
 
       end