deac/osd-contiki
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

x86: Isolate SoC specific cpu_init code

Browse source 
This commit turns cpu_init() into a SoC-agnostic function by
removing any SoC specific calls and isolating them into their
own SoC implementation.

We start this by isolating all IRQs initialization code from
the legacy-pc target, pic_init() and spurious IRQ7 registration,
into a new interface: irq_init() from irq.h. Future SoCs will have
to provide their own implementation of this interface.

This model is to be followed by future initialization code that
we may need to add and which is not common to all x86 SoCs.
This commit is contained in:
Jesus Sanchez-Palencia 2015-05-08 09:34:32 -03:00
parent e4bc1a1e8c
commit 80fe1de0b1
4 changed files with 100 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

25
cpu/x86/init/common/cpu.c
View file

@ -32,9 +32,7 @@
#include "helpers.h"
#include "idt.h"
#include "interrupt.h"
#include "pic.h"
#define IRQ7_INT PIC_INT(7)
#include "irq.h"
static void
double_fault_handler(struct interrupt_context context)
@ -42,20 +40,6 @@ double_fault_handler(struct interrupt_context context)
halt();
}
/*---------------------------------------------------------------------------*/
static void
spurious_irq7_handler(void)
{
/*
* NOTE: Originally IRQ7 was used for the parallel port interrupts. Nowadays,
* though, it is only used if some other IRQ (i.e.: a PCIx interrupt) is
* mapped to it. In this case we will have to check the PIC ISR register in
* order to confirm this was a real interrupt.
*
* In case of a spurious interrupt, we should NEVER send an EOI here so the PIC
* doesn't trigger the next queued interrupt.
*/
}
/*---------------------------------------------------------------------------*/
void
cpu_init(void)
{
@ -67,10 +51,5 @@ cpu_init(void)
*/
SET_INTERRUPT_HANDLER(8, 1, double_fault_handler);
pic_init();
/* Set a 'fake' handler for the Spurious IRQ7 interrupts.
* Refer to http://wiki.osdev.org/PIC .
*/
SET_INTERRUPT_HANDLER(IRQ7_INT, 0, spurious_irq7_handler);
irq_init();
}