From 0e0bf33d311528adf4e293fc73044e5af0fbcf05 Mon Sep 17 00:00:00 2001 From: Tommy Sparber Date: Tue, 3 Nov 2015 14:19:47 +1100 Subject: [PATCH] uIP Stats: Count sent ICMP6 packets The sent ICMP6 packets (for example from RPL) are currently not counted towards the sum of sent ip and icmp packets. Is there any reason behind this or is it just a bug? Looking at the code I found no side effects of adding these two lines. Debug output: ``` uip_stat.ip .recv 10 .sent 23 .forwared 0 .drop 0 uip_stat.icmp .recv 10 .sent 11 .drop 0 uip_stat.udp .recv 0 .sent 12 .drop 0 ``` (Sum of ip.sent matches icmp.sent and udp.sent) --- core/net/ipv6/uip-icmp6.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/core/net/ipv6/uip-icmp6.c b/core/net/ipv6/uip-icmp6.c index a9dc9e352..8f5772833 100644 --- a/core/net/ipv6/uip-icmp6.c +++ b/core/net/ipv6/uip-icmp6.c @@ -38,7 +38,7 @@ /** * \file * ICMPv6 (RFC 4443) implementation, with message and error handling - * \author Julien Abeille + * \author Julien Abeille * \author Mathilde Durvy */ @@ -313,6 +313,10 @@ uip_icmp6_send(const uip_ipaddr_t *dest, int type, int code, int payload_len) UIP_ICMP_BUF->icmpchksum = ~uip_icmp6chksum(); uip_len = UIP_IPH_LEN + UIP_ICMPH_LEN + payload_len; + + UIP_STAT(++uip_stat.icmp.sent); + UIP_STAT(++uip_stat.ip.sent); + tcpip_ipv6_output(); } /*---------------------------------------------------------------------------*/