From 41d9078ed44cb90f1ea5a676e45eb43e2384ac8b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Beno=C3=AEt=20Th=C3=A9baudeau?=
 <benoit.thebaudeau.dev@gmail.com>
Date: Wed, 8 Apr 2015 23:27:37 +0200
Subject: [PATCH] cc2538: gpio: Factor out duplicated ISR code
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This makes the code easier to maintain, and this reduces the binary
image size.

Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau.dev@gmail.com>
---
 cpu/cc2538/dev/gpio.c | 73 +++++++++++++------------------------------
 1 file changed, 21 insertions(+), 52 deletions(-)

diff --git a/cpu/cc2538/dev/gpio.c b/cpu/cc2538/dev/gpio.c
index 581e52839..0d6bb3610 100644
--- a/cpu/cc2538/dev/gpio.c
+++ b/cpu/cc2538/dev/gpio.c
@@ -79,69 +79,38 @@ notify(uint8_t mask, uint8_t port)
   }
 }
 /*---------------------------------------------------------------------------*/
-/** \brief Interrupt service routine for Port A */
-void
-gpio_port_a_isr()
+/** \brief Interrupt service routine for Port \a port
+ * \param port Number between 0 and 3. Port A: 0, Port B: 1, etc.
+ */
+static void
+gpio_port_isr(uint8_t port)
 {
+  uint32_t base;
+
   lpm_exit();
 
   ENERGEST_ON(ENERGEST_TYPE_IRQ);
 
-  notify(REG(GPIO_A_BASE + GPIO_MIS), GPIO_A_NUM);
+  base = GPIO_PORT_TO_BASE(port);
 
-  GPIO_CLEAR_INTERRUPT(GPIO_A_BASE, 0xFF);
-  GPIO_CLEAR_POWER_UP_INTERRUPT(GPIO_A_NUM, 0xFF);
+  notify(REG(base + GPIO_MIS), port);
+
+  GPIO_CLEAR_INTERRUPT(base, 0xFF);
+  GPIO_CLEAR_POWER_UP_INTERRUPT(port, 0xFF);
 
   ENERGEST_OFF(ENERGEST_TYPE_IRQ);
 }
 /*---------------------------------------------------------------------------*/
-/** \brief Interrupt service routine for Port B */
-void
-gpio_port_b_isr()
-{
-  lpm_exit();
-
-  ENERGEST_ON(ENERGEST_TYPE_IRQ);
-
-  notify(REG(GPIO_B_BASE + GPIO_MIS), GPIO_B_NUM);
-
-  GPIO_CLEAR_INTERRUPT(GPIO_B_BASE, 0xFF);
-  GPIO_CLEAR_POWER_UP_INTERRUPT(GPIO_B_NUM, 0xFF);
-
-  ENERGEST_OFF(ENERGEST_TYPE_IRQ);
-}
-/*---------------------------------------------------------------------------*/
-/** \brief Interrupt service routine for Port C */
-void
-gpio_port_c_isr()
-{
-  lpm_exit();
-
-  ENERGEST_ON(ENERGEST_TYPE_IRQ);
-
-  notify(REG(GPIO_C_BASE + GPIO_MIS), GPIO_C_NUM);
-
-  GPIO_CLEAR_INTERRUPT(GPIO_C_BASE, 0xFF);
-  GPIO_CLEAR_POWER_UP_INTERRUPT(GPIO_C_NUM, 0xFF);
-
-  ENERGEST_OFF(ENERGEST_TYPE_IRQ);
-}
-/*---------------------------------------------------------------------------*/
-/** \brief Interrupt service routine for Port D */
-void
-gpio_port_d_isr()
-{
-  lpm_exit();
-
-  ENERGEST_ON(ENERGEST_TYPE_IRQ);
-
-  notify(REG(GPIO_D_BASE + GPIO_MIS), GPIO_D_NUM);
-
-  GPIO_CLEAR_INTERRUPT(GPIO_D_BASE, 0xFF);
-  GPIO_CLEAR_POWER_UP_INTERRUPT(GPIO_D_NUM, 0xFF);
-
-  ENERGEST_OFF(ENERGEST_TYPE_IRQ);
+#define GPIO_PORT_ISR(lowercase_port, uppercase_port) \
+void \
+gpio_port_##lowercase_port##_isr(void) \
+{ \
+  gpio_port_isr(GPIO_##uppercase_port##_NUM); \
 }
+GPIO_PORT_ISR(a, A)
+GPIO_PORT_ISR(b, B)
+GPIO_PORT_ISR(c, C)
+GPIO_PORT_ISR(d, D)
 /*---------------------------------------------------------------------------*/
 void
 gpio_init()