deac/osd-contiki
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

enc28j60: The MACON2 register is reserved

Browse source 
The register 0x01 in bank 2, named MACON2 in the code, is actually
reserved, so its contents must not be changed.

This register has been marked as reserved from the revision B of the
data sheet in July 2006. The current revision of the data sheet is E,
and it is quite clear about this register.

Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau.dev@gmail.com>
This commit is contained in:
Benoît Thébaudeau 2015-07-14 21:10:56 +02:00
parent b21da96e67
commit 2b08c32528
1 changed files with 9 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
dev/enc28j60/enc28j60.c
View file

@ -84,7 +84,6 @@
#define MACONX_BANK 0x02 #define MACONX_BANK 0x02
#define MACON1 0x00 #define MACON1 0x00
#define MACON2 0x01
#define MACON3 0x02 #define MACON3 0x02
#define MACON4 0x03 #define MACON4 0x03
#define MABBIPG 0x04 #define MABBIPG 0x04
@ -97,8 +96,6 @@
#define MACON1_RXPAUS 0x04 #define MACON1_RXPAUS 0x04
#define MACON1_MARXEN 0x01 #define MACON1_MARXEN 0x01
#define MACON2_MARST 0x80
#define MACON3_PADCFG_FULL 0xe0 #define MACON3_PADCFG_FULL 0xe0
#define MACON3_TXCRCEN 0x10 #define MACON3_TXCRCEN 0x10
#define MACON3_FRMLNEN 0x02 #define MACON3_FRMLNEN 0x02
@ -351,13 +348,11 @@ reset(void)
initialization. This only needs to be done once; the order of initialization. This only needs to be done once; the order of
programming is unimportant. programming is unimportant.
1. Clear the MARST bit in MACON2 to pull the MAC out of Reset. 1. Set the MARXEN bit in MACON1 to enable the MAC to receive
2. Set the MARXEN bit in MACON1 to enable the MAC to receive
frames. If using full duplex, most applications should also set frames. If using full duplex, most applications should also set
TXPAUS and RXPAUS to allow IEEE defined flow control to function. TXPAUS and RXPAUS to allow IEEE defined flow control to function.
3. Configure the PADCFG, TXCRCEN and FULDPX bits of MACON3. Most 2. Configure the PADCFG, TXCRCEN and FULDPX bits of MACON3. Most
applications should enable automatic padding to at least 60 bytes applications should enable automatic padding to at least 60 bytes
and always append a valid CRC. For convenience, many applications and always append a valid CRC. For convenience, many applications
may wish to set the FRMLNEN bit as well to enable frame length may wish to set the FRMLNEN bit as well to enable frame length
@ -365,41 +360,38 @@ reset(void)
will be connected to a full-duplex configured remote node; will be connected to a full-duplex configured remote node;
otherwise, it should be left clear. otherwise, it should be left clear.
4. Configure the bits in MACON4. Many applications may not need to 3. Configure the bits in MACON4. Many applications may not need to
modify the Reset default. modify the Reset default.
5. Program the MAMXFL registers with the maximum frame length to 4. Program the MAMXFL registers with the maximum frame length to
be permitted to be received or transmitted. Normal network nodes be permitted to be received or transmitted. Normal network nodes
are designed to handle packets that are 1518 bytes or less. are designed to handle packets that are 1518 bytes or less.
6. Configure the Back-to-Back Inter-Packet Gap register, 5. Configure the Back-to-Back Inter-Packet Gap register,
MABBIPG. Most applications will program this register with 15h MABBIPG. Most applications will program this register with 15h
when Full-Duplex mode is used and 12h when Half-Duplex mode is when Full-Duplex mode is used and 12h when Half-Duplex mode is
used. used.
7. Configure the Non-Back-to-Back Inter-Packet Gap register low 6. Configure the Non-Back-to-Back Inter-Packet Gap register low
byte, MAIPGL. Most applications will program this register with byte, MAIPGL. Most applications will program this register with
12h. 12h.
8. If half duplex is used, the Non-Back-to-Back Inter-Packet Gap 7. If half duplex is used, the Non-Back-to-Back Inter-Packet Gap
register high byte, MAIPGH, should be programmed. Most register high byte, MAIPGH, should be programmed. Most
applications will program this register to 0Ch. applications will program this register to 0Ch.
9. If Half-Duplex mode is used, program the Retransmission and 8. If Half-Duplex mode is used, program the Retransmission and
Collision Window registers, MACLCON1 and MACLCON2. Most Collision Window registers, MACLCON1 and MACLCON2. Most
applications will not need to change the default Reset values. If applications will not need to change the default Reset values. If
the network is spread over exceptionally long cables, the default the network is spread over exceptionally long cables, the default
value of MACLCON2 may need to be increased. value of MACLCON2 may need to be increased.
10. Program the local MAC address into the 9. Program the local MAC address into the
MAADR0:MAADR5 registers. MAADR0:MAADR5 registers.
*/ */
setregbank(MACONX_BANK); setregbank(MACONX_BANK);
/* Pull MAC out of reset */
writereg(MACON2, 0);//readreg(MACON2) & (~MACON2_MARST));
/* Turn on reception and IEEE-defined flow control */ /* Turn on reception and IEEE-defined flow control */
writereg(MACON1, readreg(MACON1) | (MACON1_MARXEN + MACON1_TXPAUS + writereg(MACON1, readreg(MACON1) | (MACON1_MARXEN + MACON1_TXPAUS +
MACON1_RXPAUS)); MACON1_RXPAUS));