deac/middleman
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Merge pull request #1266 from 747/working

Browse source 
A quick fix for finding eponymous parents
This commit is contained in:
Thomas Reynolds 2014-05-30 14:20:11 -07:00
parent 430521be83 038d2a64f7
commit ca0573d92a
3 changed files with 34 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
middleman-core/features/more-sitemap_traversal.feature
View file

@ -71,3 +71,13 @@ Feature: Step through sitemap as a tree (more)
Then I should see "Child: directory-indexed/sibling2.html"
Then I should see "Child: directory-indexed/sub2/index.html"
Then I should see "Sibling: root.html"
Scenario: Child pages can see their parent and siblings too in named directory
Given the Server is running at "more-traversal-app"
When I go to "/directory-indexed/sibling"
Then I should see "Path: directory-indexed/sibling.html"
Then I should see "Parent: directory-indexed.html"
Then I should see "Sibling: directory-indexed/fake.html"
Then I should see "Sibling: directory-indexed/fake2.html"
Then I should see "Sibling: directory-indexed/sibling2.html"
Then I should see "Sibling: directory-indexed/sub2/index.html"

10
middleman-core/features/sitemap_traversal.feature
View file

@ -71,3 +71,13 @@ Feature: Step through sitemap as a tree
Then I should see "Child: directory-indexed/sibling2.html"
Then I should see "Child: directory-indexed/sub2/index.html"
Then I should see "Sibling: root.html"
Scenario: Child pages can see their parent and siblings too in named directory
Given the Server is running at "traversal-app"
When I go to "/directory-indexed/sibling.html"
Then I should see "Path: directory-indexed/sibling.html"
Then I should see "Parent: directory-indexed.html"
Then I should see "Sibling: directory-indexed/fake.html"
Then I should see "Sibling: directory-indexed/fake2.html"
Then I should see "Sibling: directory-indexed/sibling2.html"
Then I should see "Sibling: directory-indexed/sub2/index.html"

21
middleman-core/lib/middleman-core/sitemap/extensions/traversal.rb
View file

@ -6,16 +6,23 @@ module Middleman
# @return [Middleman::Sitemap::Resource, nil]
def parent
parts = path.split('/')
parts.pop if path.include?(app.index_file)
tail = parts.pop
is_index = (tail == app.index_file)
return nil if parts.length < 1
return nil if is_index && parts.length < 1
parts.pop
parts << app.index_file
test_expr = parts.join('\\/')
# A makeshift for eponymous reverse-lookup
found = store.resources.find { |candidate|
candidate.path =~ %r!^#{test_expr}(?:\.[a-zA-Z0-9]+|\/)$!
}
parent_path = '/' + parts.join('/')
store.find_resource_by_destination_path(parent_path)
if found
return found
else
parts.pop if is_index
return store.find_resource_by_destination_path("#{parts.join('/')}/#{app.index_file}")
end
end
# This resource's child resources