Fix regex which was allowing i18n to file yaml files in the data folder

This commit is contained in:
Thomas Reynolds 2013-06-24 13:56:32 -07:00
parent 37752dc291
commit c7d3e7d601
7 changed files with 8 additions and 1 deletions

View file

@ -1,6 +1,7 @@
3.1.x 3.1.x
=== ===
* Locales regex was broken, selecting .yml files from data folder.
* Fix for implied extensions getting a layout. (Mentioned in #901) * Fix for implied extensions getting a layout. (Mentioned in #901)
3.1.2 3.1.2

View file

@ -22,6 +22,8 @@ Feature: i18n Builder
| password.txt | | password.txt |
Then the following files should not exist: Then the following files should not exist:
| en/index.html | | en/index.html |
| defaults_en/index.html |
| en_defaults/index.html |
And the file "index.html" should contain "Howdy" And the file "index.html" should contain "Howdy"
And the file "hello.html" should contain "Hello World" And the file "hello.html" should contain "Hello World"
And the file "morning.html" should contain "Good morning" And the file "morning.html" should contain "Good morning"

View file

@ -16,10 +16,14 @@ Feature: i18n Preview
Then I should see "Good morning" Then I should see "Good morning"
When I go to "/one.html" When I go to "/one.html"
Then I should see "Only one" Then I should see "Only one"
When I go to "/defaults_en/index.html"
Then I should see "File Not Found"
When I go to "/en/index.html" When I go to "/en/index.html"
Then I should see "File Not Found" Then I should see "File Not Found"
When I go to "/en/morning.html" When I go to "/en/morning.html"
Then I should see "File Not Found" Then I should see "File Not Found"
When I go to "/defaults_es/index.html"
Then I should see "File Not Found"
When I go to "/es/index.html" When I go to "/es/index.html"
Then I should see "Como Esta?" Then I should see "Como Esta?"
When I go to "/es/hola.html" When I go to "/es/hola.html"

View file

@ -93,7 +93,7 @@ class Middleman::CoreExtensions::Internationalization < ::Middleman::Extension
def convert_glob_to_regex(glob) def convert_glob_to_regex(glob)
# File.fnmatch doesn't support brackets: {rb,yml,yaml} # File.fnmatch doesn't support brackets: {rb,yml,yaml}
regex = @locales_glob.sub(/\./, '\.').sub(File.join("**", "*"), ".*").sub(/\//, '\/').sub("{rb,yml,yaml}", "rb|ya?ml") regex = @locales_glob.sub(/\./, '\.').sub(File.join("**", "*"), ".*").sub(/\//, '\/').sub("{rb,yml,yaml}", "(rb|ya?ml)")
%r{^#{regex}} %r{^#{regex}}
end end