Apply CLI options later in process. Fixes 1843

middleman-cli/bin/middleman

@@ -22,12 +22,12 @@ module Middleman::Cli
       if setting.default.is_a?(String) || setting.default.is_a?(NilClass)
         base.class_option setting.key,
                           type: :string,
-                          default: setting.default,
+                          default: :undefined,
                           desc: setting.description
       elsif setting.default.is_a?(TrueClass) || setting.default.is_a?(FalseClass)
         base.class_option setting.key,
                           type: :boolean,
-                          default: setting.default,
+                          default: :undefined,
                           desc: setting.description
       end
     end

middleman-cli/lib/middleman-cli/build.rb

@@ -63,14 +63,9 @@ module Middleman::Cli
         @app = ::Middleman::Application.new do
           config[:mode] = :build
           config[:show_exceptions] = false
-
+          config[:cli_options] = cli_options.reduce({}) do |sum, (k, v)|
-          cli_options.each do |k, v|
+            sum[k] = v unless v == :undefined
-            setting = config.setting(k.to_sym)
+            sum
-            next unless setting
-
-            v = setting.options[:import].call(v) if setting.options[:import]
-
-            config[k.to_sym] = v
           end
         end
 

middleman-core/lib/middleman-core/application.rb

@@ -194,6 +194,8 @@ module Middleman
 
     define_setting :skip_build_clean, proc { |p| [/\.git/].any? { |r| p =~ r } }, 'Whether some paths should not be removed during a clean build.'
 
+    define_setting :cli_options, {}, 'Options from the Command Line.'
+
     define_setting :watcher_disable, false, 'If the Listen watcher should not run'
     define_setting :watcher_force_polling, false, 'If the Listen watcher should run in polling mode'
     define_setting :watcher_latency, nil, 'The Listen watcher latency'
@@ -281,6 +283,15 @@ module Middleman
       # Run any `configure` blocks for the current mode.
       execute_callbacks([:configure, config[:mode]])
 
+      config[:cli_options].each do |k, v|
+        setting = config.setting(k.to_sym)
+        next unless setting
+
+        v = setting.options[:import].call(v) if setting.options[:import]
+
+        config[k.to_sym] = v
+      end
+
       # Post parsing, pre-extension callback
       execute_callbacks(:after_configuration_eval)
 

middleman-core/lib/middleman-core/preview_server.rb

@@ -140,13 +140,9 @@ module Middleman
         )
 
         app = ::Middleman::Application.new do
-          cli_options.each do |k, v|
+          cli_options.reduce({}) do |sum, (k, v)|
-            setting = config.setting(k.to_sym)
+            sum[k] = v unless v == :undefined
-            next unless setting
+            sum
-
-            v = setting.options[:import].call(v) if setting.options[:import]
-
-            config[k.to_sym] = v
           end
 
           ready do