Merge pull request #1416 from dg-ratiodata/feature/fix_offenses

Fix rubocop offenses

.rubocop.yml

@@ -50,3 +50,7 @@ FormatString:
   Enabled: false
 CaseIndentation:
   IndentWhenRelativeTo: end
+Metrics/AbcSize:
+  Enabled: false
+Metrics/PerceivedComplexity:
+  Enabled: false

middleman-core/lib/middleman-core/renderers/kramdown.rb

@@ -31,7 +31,7 @@ module Middleman
           mail_addr = el.attr['href'].sub(/\Amailto:/, '')
           href = obfuscate('mailto') << ':' << obfuscate(mail_addr)
           content = obfuscate(content) if content == mail_addr
-          return %Q(<a href="#{href}">#{content}</a>)
+          return %(<a href="#{href}">#{content}</a>)
         end
 
         attr = el.attr.dup

middleman-core/lib/middleman-core/renderers/redcarpet.rb

@@ -61,7 +61,7 @@ module Middleman
           middleman_app.image_tag(link, title: title, alt: alt_text)
         else
           link_string = link.dup
-          link_string << %Q("#{title}") if title && title.length > 0 && title != alt_text
+          link_string << %("#{title}") if title && title.length > 0 && title != alt_text
           "![#{alt_text}](#{link_string})"
         end
       end
@@ -74,7 +74,7 @@ module Middleman
           middleman_app.link_to(content, link, attributes)
         else
           link_string = link.dup
-          link_string << %Q("#{title}") if title && title.length > 0 && title != alt_text
+          link_string << %("#{title}") if title && title.length > 0 && title != alt_text
           "[#{content}](#{link_string})"
         end
       end

middleman-core/lib/middleman-core/sitemap/extensions/proxies.rb

@@ -53,7 +53,7 @@ module Middleman
             proxy_resource
           end
 
-          # rubocop:disable AccessorMethodName
+          # rubocop:disable Style/AccessorMethodName
           def get_source_file
             if proxy?
               proxied_to_resource.source_file
@@ -61,18 +61,17 @@ module Middleman
               super
             end
           end
+          # rubocop:enable Style/AccessorMethodName
 
           def content_type
             mime_type = super
             return mime_type if mime_type
 
-            if proxy?
+            return proxied_to_resource.content_type if proxy?
-              proxied_to_resource.content_type
+
-            else
             nil
           end
         end
-        end
 
         module InstanceMethods
           def proxy_manager

middleman-core/lib/middleman-core/sitemap/extensions/redirects.rb

@@ -66,9 +66,11 @@ module Middleman
             super(store, path)
           end
 
+          # rubocop:disable Style/AccessorMethodName
           def get_source_file
             nil
           end
+          # rubocop:enable Style/AccessorMethodName
 
           def template?
             true

middleman-core/lib/middleman-more/core_extensions/default_helpers.rb

@@ -36,7 +36,6 @@ class Middleman::CoreExtensions::DefaultHelpers < ::Middleman::Extension
 
   # The helpers
   helpers do
-
     # Make all block content html_safe
     # rubocop:disable Semicolon
     def content_tag(name, content=nil, options=nil, &block)