Minor minify_javascript cleanup

This commit is contained in:
Thomas Reynolds 2012-04-26 15:57:37 -07:00
parent 2292c32773
commit 8bf0124241

View file

@ -1,112 +1,111 @@
# Extension namespace
module Middleman::Extensions
module Middleman
module Extensions
# Minify Javascript Extension
module MinifyJavascript
# Minify Javascript Extension
module MinifyJavascript
# Setup extension
class << self
# Setup extension
class << self
# Once registered
def registered(app, options={})
app.set :js_compressor, false
# Once registered
def registered(app, options={})
app.set :js_compressor, false
ignore = Array(options[:ignore]) << /\.min\./
inline = options[:inline] || false
ignore = Array(options[:ignore]) << /\.min\./
inline = options[:inline] || false
# Once config is parsed
app.after_configuration do
chosen_compressor = js_compressor || options[:compressor] || begin
require 'uglifier'
::Uglifier.new
end
# Setup Rack middlware to minify JS
use MinifyJavascriptRack, :compressor => chosen_compressor,
:ignore => ignore,
:inline => inline
end
end
alias :included :registered
end
# Rack middleware to look for JS and compress it
class MinifyJavascriptRack
# Init
# @param [Class] app
# @param [Hash] options
def initialize(app, options={})
@app = app
@compressor = options[:compressor]
@ignore = options[:ignore]
@inline = options[:inline]
end
# Rack interface
# @param [Rack::Environmemt] env
# @return [Array]
def call(env)
status, headers, response = @app.call(env)
path = env["PATH_INFO"]
begin
if (path.end_with?('.html') || path.end_with?('.php')) && @inline
uncompressed_source = extract_response_text(response)
minified = uncompressed_source.gsub(/(<script[^>]*>\s*(?:\/\/(?:(?:<!--)|(?:<!\[CDATA\[))\n)?)(.*?)((?:(?:\n\s*)?\/\/(?:(?:-->)|(?:\]\]>)))?\s*<\/script>)/m) do |match|
first = $1
javascript = $2
last = $3
# Only compress script tags that contain JavaScript (as opposed
# to something like jQuery templates, identified with a "text/html"
# type.
if first =~ /<script>/ || first.include?('text/javascript')
minified_js = @compressor.compress(javascript)
first << minified_js << last
else
match
end
# Once config is parsed
app.after_configuration do
chosen_compressor = js_compressor || options[:compressor] || begin
require 'uglifier'
::Uglifier.new
end
headers["Content-Length"] = ::Rack::Utils.bytesize(minified).to_s
response = [minified]
elsif path.end_with?('.js') && @ignore.none? {|ignore| path =~ ignore }
uncompressed_source = extract_response_text(response)
minified_js = @compressor.compress(uncompressed_source)
headers["Content-Length"] = ::Rack::Utils.bytesize(minified_js).to_s
response = [minified_js]
# Setup Rack middlware to minify JS
use Rack, :compressor => chosen_compressor,
:ignore => ignore,
:inline => inline
end
rescue ExecJS::ProgramError => e
warn "WARNING: Couldn't compress JavaScript in #{path}: #{e.message}"
end
[status, headers, response]
end
alias :included :registered
end
private
# Rack middleware to look for JS and compress it
class Rack
# Init
# @param [Class] app
# @param [Hash] options
def initialize(app, options={})
@app = app
@compressor = options[:compressor]
@ignore = options[:ignore]
@inline = options[:inline]
end
def extract_response_text(response)
case(response)
when String
response
when Array
response.join
when Rack::Response
response.body.join
when Rack::File
File.read(response.path)
else
response.to_s
# Rack interface
# @param [Rack::Environmemt] env
# @return [Array]
def call(env)
status, headers, response = @app.call(env)
path = env["PATH_INFO"]
begin
if (path.end_with?('.html') || path.end_with?('.php')) && @inline
uncompressed_source = extract_response_text(response)
minified = uncompressed_source.gsub(/(<script[^>]*>\s*(?:\/\/(?:(?:<!--)|(?:<!\[CDATA\[))\n)?)(.*?)((?:(?:\n\s*)?\/\/(?:(?:-->)|(?:\]\]>)))?\s*<\/script>)/m) do |match|
first = $1
javascript = $2
last = $3
# Only compress script tags that contain JavaScript (as opposed
# to something like jQuery templates, identified with a "text/html"
# type.
if first =~ /<script>/ || first.include?('text/javascript')
minified_js = @compressor.compress(javascript)
first << minified_js << last
else
match
end
end
headers["Content-Length"] = ::Rack::Utils.bytesize(minified).to_s
response = [minified]
elsif path.end_with?('.js') && @ignore.none? {|ignore| path =~ ignore }
uncompressed_source = extract_response_text(response)
minified_js = @compressor.compress(uncompressed_source)
headers["Content-Length"] = ::Rack::Utils.bytesize(minified_js).to_s
response = [minified_js]
end
rescue ExecJS::ProgramError => e
warn "WARNING: Couldn't compress JavaScript in #{path}: #{e.message}"
end
[status, headers, response]
end
private
def extract_response_text(response)
case(response)
when String
response
when Array
response.join
when ::Rack::Response
response.body.join
when ::Rack::File
File.read(response.path)
else
response.to_s
end
end
end
end
end
# Register extension
# register :minify_javascript, MinifyJavascript
end
end