Clean up whitespace, play with cane for testing style quality and code complexity

Gemfile

@@ -17,6 +17,7 @@ group :test do
   gem "slim"
   gem "coffee-filter", "~> 0.1.1"
   gem "liquid", "~> 2.2"
+  gem "cane"
 
   platforms :ruby do
     gem "therubyracer"

Rakefile

@@ -87,5 +87,12 @@ task :test do
   end
 end
 
+desc "Rune cane for all middleman gems"
+task :cane do
+  GEM_PATHS.each do |g|
+    sh "cd #{File.join(ROOT, g)} && #{Gem.ruby} -S cane"
+  end
+end
+
 desc "Run tests for all middleman gems"
 task :default => :test

middleman-core/.cane

@@ -0,0 +1,2 @@
+--exclusions-file .cane-exclusions.yml
+--no-doc

middleman-core/.cane-exclusions.yml

@@ -0,0 +1,5 @@
+style:
+  - lib/middleman-core/vendor/hooks-0.2.0/lib/hooks/inheritable_attribute.rb
+  - lib/middleman-core/vendor/hooks-0.2.0/test/hooks_test.rb
+  - lib/middleman-core/vendor/hooks-0.2.0/test/inheritable_attribute_test.rb
+  - lib/middleman-core/vendor/hooks-0.2.0/lib/hooks.rb

middleman-more/.cane

@@ -0,0 +1,2 @@
+--exclusions-file .cane-exclusions.yml
+--no-doc

middleman-more/.cane-exclusions.yml

@@ -0,0 +1,3 @@
+style:
+  - lib/middleman-more/extensions/minify_css/rainpress.rb
+  - lib/middleman-more/extensions/automatic_image_sizes/fastimage.rb

middleman-more/lib/middleman-more.rb

@@ -48,8 +48,8 @@ module Middleman
         # Setup Optional Extensions
         ###
 
-        # CacheBuster adds a query string to assets in dynamic templates to avoid
+        # CacheBuster adds a query string to assets in dynamic templates to
-        # browser caches failing to update to your new content.
+        # avoid browser caches failing to update to your new content.
         Middleman::Extensions.register(:cache_buster) do
           require "middleman-more/extensions/cache_buster"
           Middleman::Extensions::CacheBuster

middleman-more/lib/middleman-more/core_extensions/compass.rb

@@ -71,7 +71,7 @@ module Middleman
 
     end
 
-    # A Compass template for Tilt
+    # A Compass Sass template for Tilt, adding our options in
     class CompassSassTemplate < ::Middleman::Renderers::Sass::SassPlusCSSFilenameTemplate
     private
       def sass_options
@@ -79,6 +79,7 @@ module Middleman
       end
     end
 
+    # A Compass Scss template for Tilt, adding our options in
     class CompassScssTemplate < ::Middleman::Renderers::Sass::ScssPlusCSSFilenameTemplate
     private
       def sass_options

middleman-more/lib/middleman-more/core_extensions/i18n.rb

@@ -22,6 +22,7 @@ module Middleman
         alias :included :registered
       end
 
+      # Central class for managing i18n extension
       class Localizer
         attr_reader :app
         delegate :logger, :to => :app

middleman-more/lib/middleman-more/extensions/asset_hash.rb

@@ -20,6 +20,7 @@ module Middleman
         alias :included :registered
       end
 
+      # Central class for managing asset_hash extension
       class AssetHashManager
         def initialize(app, exts, ignore)
           @app = app

middleman-more/lib/middleman-more/extensions/directory_indexes.rb

@@ -21,6 +21,7 @@ module Middleman
         alias :included :registered
       end
 
+      # Central class for managing the directory indexes extension
       class DirectoryIndexManager
         def initialize(app)
           @app = app

middleman-more/lib/middleman-more/extensions/relative_assets.rb

@@ -35,8 +35,8 @@ module Middleman
           if path.include?("//")
             path
           else
-            current_dir = Pathname('/' + current_resource.destination_path).dirname
+            current_dir = Pathname('/' + current_resource.destination_path)
-            Pathname(path).relative_path_from(current_dir)
+            Pathname(path).relative_path_from(current_dir.dirname)
           end
         end
       end