Make build fail when external_pipeline fails

This commit is contained in:
Adam Heath 2016-02-18 12:41:48 +08:00
parent 476287452d
commit 351003b4fe
4 changed files with 18 additions and 4 deletions

View file

@ -43,6 +43,10 @@ Feature: Builder
Given a built app at "empty-app" Given a built app at "empty-app"
Then the exit status should be 1 Then the exit status should be 1
Scenario: Build external_pipeline errors
Given a built app at "external-pipeline-error"
Then the exit status should be 1
Scenario: Build alias (b) Scenario: Build alias (b)
Given a fixture app "large-build-app" Given a fixture app "large-build-app"
When I run `middleman b` When I run `middleman b`

View file

@ -0,0 +1,5 @@
activate :external_pipeline,
name: :failing,
command: "mv does-not-exist tmp/file.js",
source: "tmp",
latency: 2

View file

@ -34,6 +34,11 @@ class Middleman::Extensions::ExternalPipeline < ::Middleman::Extension
end end
end end
unless $?.success?
logger.error '== External: Command failed with non-zero exit status'
exit(1)
end
@watcher.poll_once! @watcher.poll_once!
rescue ::Errno::ENOENT => e rescue ::Errno::ENOENT => e
logger.error "== External: Command failed with message: #{e.message}" logger.error "== External: Command failed with message: #{e.message}"