deac/middleman
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Merge pull request #1128 from coffeencoke/fixes_call_to_newline_constant

Browse source 
Specify the full path to the NEWLINE constant
This commit is contained in:
Ben Hollis 2013-12-28 19:09:03 -08:00
parent bbfbcf7583 21f575af3a
commit 2a89de8e2b
2 changed files with 20 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
middleman-core/features/helpers_select_tag.feature Normal file
View file

@ -0,0 +1,19 @@
Feature: select_tag helper
Scenario: select_tag produces correct options
Given a fixture app "indexable-app"
And an empty file named "config.rb"
And a file named "source/select_tag.html.erb" with:
"""
options as array: <%= select_tag :colors, options: ["red", "blue", "blorange"], include_blank: "Choose a color" %>
"""
And the Server is running at "indexable-app"
When I go to "/select_tag.html"
Then I should see:
"""
<select name="colors"><option value="">Choose a color</option>
<option value="red">red</option>
<option value="blue">blue</option>
<option value="blorange">blorange</option>
</select>
"""

2
middleman-core/lib/middleman-more/core_extensions/default_helpers.rb
View file

@ -49,7 +49,7 @@ class Middleman::CoreExtensions::DefaultHelpers < ::Middleman::Extension
output = ActiveSupport::SafeBuffer.new output = ActiveSupport::SafeBuffer.new
output.safe_concat "<#{name}#{attributes}>" output.safe_concat "<#{name}#{attributes}>"
if content.respond_to?(:each) && !content.is_a?(String) if content.respond_to?(:each) && !content.is_a?(String)
content.each { |c| output.safe_concat c; output.safe_concat NEWLINE } content.each { |c| output.safe_concat c; output.safe_concat ::Padrino::Helpers::TagHelpers::NEWLINE }
else else
output.safe_concat "#{content}" output.safe_concat "#{content}"
end end