From 0a80be67f4fe968d99777564a02aeddbde1fbf35 Mon Sep 17 00:00:00 2001 From: timmywil Date: Mon, 6 Jun 2011 20:13:50 -0400 Subject: [PATCH 01/22] Add catch block to try/finally in deferred. Fixes #9033. Test case needed. --- src/deferred.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/deferred.js b/src/deferred.js index 5cc5fb5b..3d53344e 100644 --- a/src/deferred.js +++ b/src/deferred.js @@ -58,8 +58,9 @@ jQuery.extend({ while( callbacks[ 0 ] ) { callbacks.shift().apply( context, args ); } - } - finally { + } catch( e ) { + throw e; + } finally { fired = [ context, args ]; firing = 0; } From db437be6e31c924aade13bb719f9facc122b3d9c Mon Sep 17 00:00:00 2001 From: timmywil Date: Tue, 7 Jun 2011 20:54:11 -0400 Subject: [PATCH 02/22] Check classes passed for duplicates. Fixes #9499. --- src/attributes.js | 47 ++++++++++++++++++++++------------------- src/effects.js | 4 ++-- test/data/testsuite.css | 2 +- test/unit/attributes.js | 13 ++++++++++-- 4 files changed, 39 insertions(+), 27 deletions(-) diff --git a/src/attributes.js b/src/attributes.js index abe52b89..5b68773c 100644 --- a/src/attributes.js +++ b/src/attributes.js @@ -37,30 +37,31 @@ jQuery.fn.extend({ }, addClass: function( value ) { + var classNames, i, l, elem, setClass, c, cl; + if ( jQuery.isFunction( value ) ) { - return this.each(function(i) { - var self = jQuery(this); - self.addClass( value.call(this, i, self.attr("class") || "") ); + return this.each(function( j ) { + var self = jQuery( this ); + self.addClass( value.call(this, j, self.attr("class") || "") ); }); } if ( value && typeof value === "string" ) { - var classNames = (value || "").split( rspace ); + classNames = value.split( rspace ); - for ( var i = 0, l = this.length; i < l; i++ ) { - var elem = this[i]; + for ( i = 0, l = this.length; i < l; i++ ) { + elem = this[ i ]; if ( elem.nodeType === 1 ) { - if ( !elem.className ) { + if ( !elem.className && classNames.length === 1 ) { elem.className = value; } else { - var className = " " + elem.className + " ", - setClass = elem.className; + setClass = elem.className; - for ( var c = 0, cl = classNames.length; c < cl; c++ ) { - if ( className.indexOf( " " + classNames[c] + " " ) < 0 ) { - setClass += " " + classNames[c]; + for ( c = 0, cl = classNames.length; c < cl; c++ ) { + if ( !~setClass.indexOf(classNames[ c ]) ) { + setClass += " " + classNames[ c ]; } } elem.className = jQuery.trim( setClass ); @@ -73,24 +74,26 @@ jQuery.fn.extend({ }, removeClass: function( value ) { - if ( jQuery.isFunction(value) ) { - return this.each(function(i) { - var self = jQuery(this); - self.removeClass( value.call(this, i, self.attr("class")) ); + var classNames, i, l, elem, className, c, cl; + + if ( jQuery.isFunction( value ) ) { + return this.each(function( j ) { + var self = jQuery( this ); + self.removeClass( value.call(this, j, self.attr("class")) ); }); } if ( (value && typeof value === "string") || value === undefined ) { - var classNames = (value || "").split( rspace ); + classNames = (value || "").split( rspace ); - for ( var i = 0, l = this.length; i < l; i++ ) { - var elem = this[i]; + for ( i = 0, l = this.length; i < l; i++ ) { + elem = this[ i ]; if ( elem.nodeType === 1 && elem.className ) { if ( value ) { - var className = (" " + elem.className + " ").replace(rclass, " "); - for ( var c = 0, cl = classNames.length; c < cl; c++ ) { - className = className.replace(" " + classNames[c] + " ", " "); + className = (" " + elem.className + " ").replace( rclass, " " ); + for ( c = 0, cl = classNames.length; c < cl; c++ ) { + className = className.replace(" " + classNames[ c ] + " ", " "); } elem.className = jQuery.trim( className ); diff --git a/src/effects.js b/src/effects.js index 22496277..3a4e2663 100644 --- a/src/effects.js +++ b/src/effects.js @@ -15,8 +15,8 @@ var elemdisplay = {}, ], fxNow, requestAnimationFrame = window.webkitRequestAnimationFrame || - window.mozRequestAnimationFrame || - window.oRequestAnimationFrame; + window.mozRequestAnimationFrame || + window.oRequestAnimationFrame; jQuery.fn.extend({ show: function( speed, easing, callback ) { diff --git a/test/data/testsuite.css b/test/data/testsuite.css index 47caf34a..295740f5 100644 --- a/test/data/testsuite.css +++ b/test/data/testsuite.css @@ -119,5 +119,5 @@ sup { display: none; } dfn { display: none; } /* #9239 Attach a background to the body( avoid crashes in removing the test element in support ) */ -body, div { background: url(http://www.ctemploymentlawblog.com/test.jpg) no-repeat -1000px 0; } +body, div { background: url(http://static.jquery.com/files/rocker/images/logo_jquery_215x53.gif) no-repeat -1000px 0; } diff --git a/test/unit/attributes.js b/test/unit/attributes.js index 56c398e5..37260f2f 100644 --- a/test/unit/attributes.js +++ b/test/unit/attributes.js @@ -761,12 +761,14 @@ test("val(select) after form.reset() (Bug #2551)", function() { }); var testAddClass = function(valueObj) { - expect(5); + expect(7); var div = jQuery("div"); div.addClass( valueObj("test") ); var pass = true; for ( var i = 0; i < div.size(); i++ ) { - if ( div.get(i).className.indexOf("test") == -1 ) pass = false; + if ( !~div.get(i).className.indexOf("test") ) { + pass = false; + } } ok( pass, "Add Class" ); @@ -787,6 +789,13 @@ var testAddClass = function(valueObj) { div.attr("class", "foo"); div.addClass( valueObj("bar baz") ); equals( div.attr("class"), "foo bar baz", "Make sure there isn't too much trimming." ); + + div.removeAttr("class"); + div.addClass( valueObj("foo") ).addClass( valueObj("foo") ) + equal( div.attr("class"), "foo", "Do not add the same class twice in separate calls." ); + div.removeAttr("class"); + div.addClass( valueObj("bar bar") ); + equal( div.attr("class"), "bar", "Do not add the same class twice in the same call." ); }; test("addClass(String)", function() { From 39a2f29c29fdb296bb178b3c55d805ea0dc2f0ce Mon Sep 17 00:00:00 2001 From: timmywil Date: Wed, 8 Jun 2011 10:55:52 -0400 Subject: [PATCH 03/22] Revert "Add catch block to try/finally in deferred. Fixes #9033. Test case needed." Line of exception was lost when debugging. This reverts commit 0a80be67f4fe968d99777564a02aeddbde1fbf35. --- src/deferred.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/deferred.js b/src/deferred.js index 3d53344e..5cc5fb5b 100644 --- a/src/deferred.js +++ b/src/deferred.js @@ -58,9 +58,8 @@ jQuery.extend({ while( callbacks[ 0 ] ) { callbacks.shift().apply( context, args ); } - } catch( e ) { - throw e; - } finally { + } + finally { fired = [ context, args ]; firing = 0; } From 641ad802111d2dc16ccf4b3721784a6addaf20df Mon Sep 17 00:00:00 2001 From: timmywil Date: Mon, 13 Jun 2011 10:02:13 -0400 Subject: [PATCH 04/22] Attribute hooks do not need to be attached in XML docs. Fixes #9568. --- src/attributes.js | 31 +++++++++++++++++-------------- test/data/dashboard.xml | 2 +- test/unit/attributes.js | 7 ++++--- 3 files changed, 22 insertions(+), 18 deletions(-) diff --git a/src/attributes.js b/src/attributes.js index 5b68773c..ce7b3502 100644 --- a/src/attributes.js +++ b/src/attributes.js @@ -320,21 +320,23 @@ jQuery.extend({ notxml = nType !== 1 || !jQuery.isXMLDoc( elem ); // Normalize the name if needed - name = notxml && jQuery.attrFix[ name ] || name; + if ( notxml ) { + name = jQuery.attrFix[ name ] || name; - hooks = jQuery.attrHooks[ name ]; + hooks = jQuery.attrHooks[ name ]; - if ( !hooks ) { - // Use boolHook for boolean attributes - if ( rboolean.test( name ) ) { + if ( !hooks ) { + // Use boolHook for boolean attributes + if ( rboolean.test( name ) ) { - hooks = boolHook; + hooks = boolHook; - // Use formHook for forms and if the name contains certain characters - } else if ( formHook && name !== "className" && - (jQuery.nodeName( elem, "form" ) || rinvalidChar.test( name )) ) { + // Use formHook for forms and if the name contains certain characters + } else if ( formHook && name !== "className" && + (jQuery.nodeName( elem, "form" ) || rinvalidChar.test( name )) ) { - hooks = formHook; + hooks = formHook; + } } } @@ -465,10 +467,11 @@ jQuery.extend({ var ret, hooks, notxml = nType !== 1 || !jQuery.isXMLDoc( elem ); - // Try to normalize/fix the name - name = notxml && jQuery.propFix[ name ] || name; - - hooks = jQuery.propHooks[ name ]; + if ( notxml ) { + // Fix name and attach hooks + name = jQuery.propFix[ name ] || name; + hooks = jQuery.propHooks[ name ]; + } if ( value !== undefined ) { if ( hooks && "set" in hooks && (ret = hooks.set( elem, value, name )) !== undefined ) { diff --git a/test/data/dashboard.xml b/test/data/dashboard.xml index 10f6b334..5a6f5614 100644 --- a/test/data/dashboard.xml +++ b/test/data/dashboard.xml @@ -1,7 +1,7 @@ - + diff --git a/test/unit/attributes.js b/test/unit/attributes.js index 37260f2f..831f729c 100644 --- a/test/unit/attributes.js +++ b/test/unit/attributes.js @@ -132,11 +132,12 @@ test("attr(String)", function() { if ( !isLocal ) { test("attr(String) in XML Files", function() { - expect(2); + expect(3); stop(); jQuery.get("data/dashboard.xml", function( xml ) { - equals( jQuery( "locations", xml ).attr("class"), "foo", "Check class attribute in XML document" ); - equals( jQuery( "location", xml ).attr("for"), "bar", "Check for attribute in XML document" ); + equal( jQuery( "locations", xml ).attr("class"), "foo", "Check class attribute in XML document" ); + equal( jQuery( "location", xml ).attr("for"), "bar", "Check for attribute in XML document" ); + equal( jQuery( "location", xml ).attr("checked"), "different", "Check that hooks are not attached in XML document" ); start(); }); }); From 6926247bf441deaa0441872849bb3786c257a4cf Mon Sep 17 00:00:00 2001 From: rwldrn Date: Tue, 14 Jun 2011 15:38:46 -0400 Subject: [PATCH 05/22] Landing pull request 397. withinElement rewrite in event. Fixes #6234, #9357, #9447. More Details: - https://github.com/jquery/jquery/pull/397 - http://bugs.jquery.com/ticket/6234 - http://bugs.jquery.com/ticket/9357 - http://bugs.jquery.com/ticket/9447 --- src/event.js | 31 ++++++++++++------------------- test/unit/event.js | 37 +++++++++++++++++++++++++++++++++++++ 2 files changed, 49 insertions(+), 19 deletions(-) diff --git a/src/event.js b/src/event.js index 3f53ab5c..131739b1 100644 --- a/src/event.js +++ b/src/event.js @@ -650,34 +650,27 @@ jQuery.Event.prototype = { // Checks if an event happened on an element within another element // Used in jQuery.event.special.mouseenter and mouseleave handlers var withinElement = function( event ) { - // Check if mouse(over|out) are still within the same parent element - var parent = event.relatedTarget; - // set the correct event type + // Check if mouse(over|out) are still within the same parent element + var related = event.relatedTarget, + inside = false, + eventType = event.type; + event.type = event.data; - // Firefox sometimes assigns relatedTarget a XUL element - // which we cannot access the parentNode property of - try { + if ( related !== this ) { - // Chrome does something similar, the parentNode property - // can be accessed but is null. - if ( parent && parent !== document && !parent.parentNode ) { - return; + if ( related ) { + inside = jQuery.contains( this, related ); } - // Traverse up the tree - while ( parent && parent !== this ) { - parent = parent.parentNode; - } + if ( !inside ) { - if ( parent !== this ) { - // handle event if we actually just moused on to a non sub-element jQuery.event.handle.apply( this, arguments ); - } - // assuming we've left the element since we most likely mousedover a xul element - } catch(e) { } + event.type = eventType; + } + } }, // In case of event delegation, we only need to rename the event.type, diff --git a/test/unit/event.js b/test/unit/event.js index f71c7b29..7c628880 100644 --- a/test/unit/event.js +++ b/test/unit/event.js @@ -780,6 +780,43 @@ test("mouseover triggers mouseenter", function() { elem.remove(); }); +test("withinElement implemented with jQuery.contains()", function() { + + expect(1); + + jQuery("#qunit-fixture").append('
'); + + jQuery("#jc-outer").bind("mouseenter mouseleave", function( event ) { + + equal( this.id, "jc-outer", this.id + " " + event.type ); + + }).trigger("mouseenter"); + + jQuery("#jc-inner").trigger("mousenter"); + + jQuery("#jc-outer").unbind("mouseenter mouseleave").remove(); + jQuery("#jc-inner").remove(); + +}); + +test("mouseenter, mouseleave don't catch exceptions", function() { + expect(2); + + var elem = jQuery("#firstp").hover(function() { throw "an Exception"; }); + + try { + elem.mouseenter(); + } catch (e) { + equals( e, "an Exception", "mouseenter doesn't catch exceptions" ); + } + + try { + elem.mouseleave(); + } catch (e) { + equals( e, "an Exception", "mouseleave doesn't catch exceptions" ); + } +}); + test("trigger() shortcuts", function() { expect(6); From 13ceb0f56b380b395ed5a26b468bf2bf00d88216 Mon Sep 17 00:00:00 2001 From: Greg Hazel Date: Tue, 14 Jun 2011 15:51:03 -0400 Subject: [PATCH 06/22] Landing pull request 410. Moves jQuery attachment comment to outro. More Details: - https://github.com/jquery/jquery/pull/410 --- src/core.js | 1 - src/outro.js | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core.js b/src/core.js index 3a32d6f0..2c27bf7c 100644 --- a/src/core.js +++ b/src/core.js @@ -923,7 +923,6 @@ function doScrollCheck() { jQuery.ready(); } -// Expose jQuery to the global object return jQuery; })(); diff --git a/src/outro.js b/src/outro.js index 32b0d087..b49305e7 100644 --- a/src/outro.js +++ b/src/outro.js @@ -1,2 +1,3 @@ +// Expose jQuery to the global object window.jQuery = window.$ = jQuery; })(window); From 5eef5917fdb399ace2698154c4cd7bbd24f13182 Mon Sep 17 00:00:00 2001 From: rwldrn Date: Tue, 14 Jun 2011 15:59:22 -0400 Subject: [PATCH 07/22] Landing pull request 409. Adds fillOpacity to internal cssNumber. Fixes #9548. More Details: - https://github.com/jquery/jquery/pull/409 - http://bugs.jquery.com/ticket/9548 --- src/css.js | 9 +++++---- test/unit/css.js | 10 ++++++++++ 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/src/css.js b/src/css.js index fcc784d2..c60bcdde 100644 --- a/src/css.js +++ b/src/css.js @@ -50,13 +50,14 @@ jQuery.extend({ // Exclude the following css properties to add px cssNumber: { - "zIndex": true, + "fillOpacity": true, "fontWeight": true, - "opacity": true, - "zoom": true, "lineHeight": true, + "opacity": true, + "orphans": true, "widows": true, - "orphans": true + "zIndex": true, + "zoom": true }, // Add in properties whose names you wish to fix before diff --git a/test/unit/css.js b/test/unit/css.js index e631f496..f421f7bd 100644 --- a/test/unit/css.js +++ b/test/unit/css.js @@ -475,3 +475,13 @@ test("widows & orphans #8936", function () { $p.remove(); }); + +test("Do not append px to 'fill-opacity' #9548", 1, function() { + + var $div = jQuery("
").appendTo("#qunit-fixture"); + + $div.css("fill-opacity", 0).animate({ "fill-opacity": 1.0 }, 0, function () { + equal( jQuery(this).css("fill-opacity"), 1, "Do not append px to 'fill-opacity'"); + }); + +}); From 8a532d15757f8c3ba491ae14d024e353de6b4c7f Mon Sep 17 00:00:00 2001 From: Schalk Neethling Date: Tue, 14 Jun 2011 16:01:50 -0400 Subject: [PATCH 08/22] Landing pull request 378. Comment typo in core.js. More Details: - https://github.com/jquery/jquery/pull/378 --- src/core.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core.js b/src/core.js index 2c27bf7c..ab0d9f7b 100644 --- a/src/core.js +++ b/src/core.js @@ -792,7 +792,7 @@ jQuery.extend({ }, // Mutifunctional method to get and set values to a collection - // The value/s can be optionally by executed if its a function + // The value/s can optionally be executed if it's a function access: function( elems, key, value, exec, fn, pass ) { var length = elems.length; From d443e533aa83e89e6a1b02280dfc77f741cb4db6 Mon Sep 17 00:00:00 2001 From: John Resig Date: Tue, 14 Jun 2011 14:54:23 -0700 Subject: [PATCH 09/22] Tagging the 1.6.2rc1 release. --- build/release-notes.js | 4 ++-- test/qunit | 2 +- version.txt | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/build/release-notes.js b/build/release-notes.js index 0166732e..57d03789 100644 --- a/build/release-notes.js +++ b/build/release-notes.js @@ -9,8 +9,8 @@ var fs = require("fs"), extract = /(.*?)<[^"]+"component">\s*(\S+)/g; var opts = { - version: "1.6.1 RC 1", - short_version: "1.6rc1", + version: "1.6.1", + short_version: "1.6.1", final_version: "1.6.1", categories: [] }; diff --git a/test/qunit b/test/qunit index d4f23f8a..d97b37ec 160000 --- a/test/qunit +++ b/test/qunit @@ -1 +1 @@ -Subproject commit d4f23f8a882d13b71768503e2db9fa33ef169ba0 +Subproject commit d97b37ec322136406790e75d03333559f38bbecb diff --git a/version.txt b/version.txt index 22e67ce2..a0de7ec1 100644 --- a/version.txt +++ b/version.txt @@ -1 +1 @@ -1.6.2pre \ No newline at end of file +1.6.2rc1 \ No newline at end of file From 138d5b7b811845950279f5ee5391339d7d31e360 Mon Sep 17 00:00:00 2001 From: John Resig Date: Tue, 14 Jun 2011 14:55:14 -0700 Subject: [PATCH 10/22] Updating the source version to 1.6.2pre --- version.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/version.txt b/version.txt index a0de7ec1..22e67ce2 100644 --- a/version.txt +++ b/version.txt @@ -1 +1 @@ -1.6.2rc1 \ No newline at end of file +1.6.2pre \ No newline at end of file From d269e426e0844fa025e8ca5510c56860a9cde784 Mon Sep 17 00:00:00 2001 From: John Resig Date: Tue, 14 Jun 2011 15:05:27 -0700 Subject: [PATCH 11/22] Updating version in release notes script. --- build/release-notes.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/build/release-notes.js b/build/release-notes.js index 57d03789..b112d998 100644 --- a/build/release-notes.js +++ b/build/release-notes.js @@ -9,9 +9,9 @@ var fs = require("fs"), extract = /(.*?)<[^"]+"component">\s*(\S+)/g; var opts = { - version: "1.6.1", - short_version: "1.6.1", - final_version: "1.6.1", + version: "1.6.2 RC 1", + short_version: "1.6.2rc1", + final_version: "1.6.2", categories: [] }; From d59b0f3e27827d189b8b2595142ec6bbc3941dd9 Mon Sep 17 00:00:00 2001 From: John Resig Date: Tue, 14 Jun 2011 15:06:28 -0700 Subject: [PATCH 12/22] Re-updating QUnit, oops. --- test/qunit | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/qunit b/test/qunit index d97b37ec..d4f23f8a 160000 --- a/test/qunit +++ b/test/qunit @@ -1 +1 @@ -Subproject commit d97b37ec322136406790e75d03333559f38bbecb +Subproject commit d4f23f8a882d13b71768503e2db9fa33ef169ba0 From 124817e6684086ccf74e509309b73d4b4dd89932 Mon Sep 17 00:00:00 2001 From: Mike Sherov Date: Fri, 17 Jun 2011 17:33:29 -0400 Subject: [PATCH 13/22] Landing pull request 413. Move border/padding checks to after width validation to avoid unnecessary fallbacks. Fixes #9598. More Details: - https://github.com/jquery/jquery/pull/413 - http://bugs.jquery.com/ticket/9300 - http://bugs.jquery.com/ticket/9441 - http://bugs.jquery.com/ticket/9598 --- src/css.js | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/src/css.js b/src/css.js index c60bcdde..cb7df9f8 100644 --- a/src/css.js +++ b/src/css.js @@ -315,21 +315,20 @@ function getWH( elem, name, extra ) { var val = name === "width" ? elem.offsetWidth : elem.offsetHeight, which = name === "width" ? cssWidth : cssHeight; - if ( extra !== "margin" && extra !== "border" ) { - jQuery.each( which, function() { - val -= parseFloat( jQuery.css( elem, "border" + this + "Width" ) ) || 0; - if ( !extra ) { - val -= parseFloat( jQuery.css( elem, "padding" + this ) ) || 0; - } - }); - } - if ( val > 0 ) { - if ( extra === "margin" ) { + if ( extra !== "border" ) { jQuery.each( which, function() { - val += parseFloat( jQuery.css( elem, extra + this ) ) || 0; + if ( !extra ) { + val -= parseFloat( jQuery.css( elem, "padding" + this ) ) || 0; + } + if ( extra === "margin" ) { + val += parseFloat( jQuery.css( elem, extra + this ) ) || 0; + } else { + val -= parseFloat( jQuery.css( elem, "border" + this + "Width" ) ) || 0; + } }); } + return val + "px"; } From 96501d38a935187461d45c40f17f8327b2e7cd91 Mon Sep 17 00:00:00 2001 From: timmywil Date: Sun, 19 Jun 2011 18:58:47 -0400 Subject: [PATCH 14/22] Allow similarly named classes (regression from 9499) and switch class retrieval to property when passing class to value functions. Fixes #9617. --- src/attributes.js | 20 +++++++++----------- test/unit/attributes.js | 15 +++++++++++---- 2 files changed, 20 insertions(+), 15 deletions(-) diff --git a/src/attributes.js b/src/attributes.js index ce7b3502..1e0e79f4 100644 --- a/src/attributes.js +++ b/src/attributes.js @@ -37,12 +37,12 @@ jQuery.fn.extend({ }, addClass: function( value ) { - var classNames, i, l, elem, setClass, c, cl; + var classNames, i, l, elem, + setClass, c, cl; if ( jQuery.isFunction( value ) ) { return this.each(function( j ) { - var self = jQuery( this ); - self.addClass( value.call(this, j, self.attr("class") || "") ); + jQuery( this ).addClass( value.call(this, j, this.className) ); }); } @@ -57,11 +57,11 @@ jQuery.fn.extend({ elem.className = value; } else { - setClass = elem.className; + setClass = " " + elem.className + " "; for ( c = 0, cl = classNames.length; c < cl; c++ ) { - if ( !~setClass.indexOf(classNames[ c ]) ) { - setClass += " " + classNames[ c ]; + if ( !~setClass.indexOf( " " + classNames[ c ] + " " ) ) { + setClass += classNames[ c ] + " "; } } elem.className = jQuery.trim( setClass ); @@ -78,8 +78,7 @@ jQuery.fn.extend({ if ( jQuery.isFunction( value ) ) { return this.each(function( j ) { - var self = jQuery( this ); - self.removeClass( value.call(this, j, self.attr("class")) ); + jQuery( this ).removeClass( value.call(this, j, this.className) ); }); } @@ -112,9 +111,8 @@ jQuery.fn.extend({ isBool = typeof stateVal === "boolean"; if ( jQuery.isFunction( value ) ) { - return this.each(function(i) { - var self = jQuery(this); - self.toggleClass( value.call(this, i, self.attr("class"), stateVal), stateVal ); + return this.each(function( i ) { + jQuery( this ).toggleClass( value.call(this, i, this.className, stateVal), stateVal ); }); } diff --git a/test/unit/attributes.js b/test/unit/attributes.js index 831f729c..4716e5b5 100644 --- a/test/unit/attributes.js +++ b/test/unit/attributes.js @@ -762,7 +762,8 @@ test("val(select) after form.reset() (Bug #2551)", function() { }); var testAddClass = function(valueObj) { - expect(7); + expect(9); + var div = jQuery("div"); div.addClass( valueObj("test") ); var pass = true; @@ -791,10 +792,16 @@ var testAddClass = function(valueObj) { div.addClass( valueObj("bar baz") ); equals( div.attr("class"), "foo bar baz", "Make sure there isn't too much trimming." ); - div.removeAttr("class"); + div.removeClass(); div.addClass( valueObj("foo") ).addClass( valueObj("foo") ) equal( div.attr("class"), "foo", "Do not add the same class twice in separate calls." ); - div.removeAttr("class"); + + div.addClass( valueObj("fo") ); + equal( div.attr("class"), "foo fo", "Adding a similar class does not get interrupted." ); + div.removeClass().addClass("wrap2"); + ok( div.addClass("wrap").hasClass("wrap"), "Can add similarly named classes"); + + div.removeClass(); div.addClass( valueObj("bar bar") ); equal( div.attr("class"), "bar", "Do not add the same class twice in the same call." ); }; @@ -959,7 +966,7 @@ test("toggleClass(Function[, boolean])", function() { test("toggleClass(Fucntion[, boolean]) with incoming value", function() { expect(14); - var e = jQuery("#firstp"), old = e.attr("class"); + var e = jQuery("#firstp"), old = e.attr("class") || ""; ok( !e.is(".test"), "Assert class not present" ); e.toggleClass(function(i, val) { From ab1504f14f56944a5a6297c68b323f0af01d5be8 Mon Sep 17 00:00:00 2001 From: timmywil Date: Tue, 28 Jun 2011 11:46:03 -0400 Subject: [PATCH 15/22] Set timerId to true instead of a number so that intervals set to 1 are not accidentally cleared when stopped. Fixes #9678. - Adding a working test case would not be possible in this case, but all tests pass. --- src/effects.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/effects.js b/src/effects.js index 3a4e2663..a7529a0f 100644 --- a/src/effects.js +++ b/src/effects.js @@ -411,7 +411,7 @@ jQuery.fx.prototype = { if ( t() && jQuery.timers.push(t) && !timerId ) { // Use requestAnimationFrame instead of setInterval if available if ( requestAnimationFrame ) { - timerId = 1; + timerId = true; raf = function() { // When timerId gets set to null at any point, this stops if ( timerId ) { From aa6f8c8cd399d50e91dc0a3634395b6ebf54b209 Mon Sep 17 00:00:00 2001 From: John Resig Date: Thu, 30 Jun 2011 14:16:56 -0400 Subject: [PATCH 16/22] Tagging the 1.6.2 release. --- version.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/version.txt b/version.txt index 22e67ce2..308b6faa 100644 --- a/version.txt +++ b/version.txt @@ -1 +1 @@ -1.6.2pre \ No newline at end of file +1.6.2 \ No newline at end of file From e2ab2ba1d51b47f90fd8022e500ea3df563e7d74 Mon Sep 17 00:00:00 2001 From: John Resig Date: Thu, 30 Jun 2011 14:17:44 -0400 Subject: [PATCH 17/22] Updating the source version to 1.6.3pre --- version.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/version.txt b/version.txt index 308b6faa..e37c079f 100644 --- a/version.txt +++ b/version.txt @@ -1 +1 @@ -1.6.2 \ No newline at end of file +1.6.3pre \ No newline at end of file From 5b92a5f5eccf69d480c11dbd2870f8161ae0441b Mon Sep 17 00:00:00 2001 From: jaubourg Date: Thu, 30 Jun 2011 18:18:44 +0200 Subject: [PATCH 18/22] Replaces typo (status instead of state) as observed in #9585. --- src/ajax.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ajax.js b/src/ajax.js index a16717b0..e4e48dc7 100644 --- a/src/ajax.js +++ b/src/ajax.js @@ -727,7 +727,7 @@ jQuery.extend({ transport.send( requestHeaders, done ); } catch (e) { // Propagate exception as error if not done - if ( status < 2 ) { + if ( state < 2 ) { done( -1, e ); // Simply rethrow otherwise } else { From 139135a98aab1c422e5ae05b026535a40d58328f Mon Sep 17 00:00:00 2001 From: jaubourg Date: Fri, 1 Jul 2011 01:51:50 +0200 Subject: [PATCH 19/22] Fixes #9446. Context is properly propagated using pipe. If context was the original deferred, then context is updated to next deferred in the chain. Unit tests added. --- src/deferred.js | 2 +- test/unit/deferred.js | 27 +++++++++++++++++++++++++++ 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/src/deferred.js b/src/deferred.js index 5cc5fb5b..e543f151 100644 --- a/src/deferred.js +++ b/src/deferred.js @@ -122,7 +122,7 @@ jQuery.extend({ if ( returned && jQuery.isFunction( returned.promise ) ) { returned.promise().then( newDefer.resolve, newDefer.reject ); } else { - newDefer[ action ]( returned ); + newDefer[ action + "With" ]( this === deferred ? newDefer : this, [ returned ] ); } }); } else { diff --git a/test/unit/deferred.js b/test/unit/deferred.js index 89c9c612..fbe29070 100644 --- a/test/unit/deferred.js +++ b/test/unit/deferred.js @@ -275,6 +275,33 @@ test( "jQuery.Deferred.pipe - deferred (fail)", function() { strictEqual( value3, 6, "result of filter ok" ); }); +test( "jQuery.Deferred.pipe - context", function() { + + expect(4); + + var context = {}; + + jQuery.Deferred().resolveWith( context, [ 2 ] ).pipe(function( value ) { + return value * 3; + }).done(function( value ) { + strictEqual( this, context, "custom context correctly propagated" ); + strictEqual( value, 6, "proper value received" ); + }); + + var defer = jQuery.Deferred(), + piped = defer.pipe(function( value ) { + return value * 3; + }); + + defer.resolve( 2 ); + + piped.done(function( value ) { + strictEqual( this.promise(), piped, "default context gets updated to latest defer in the chain" ); + strictEqual( value, 6, "proper value received" ); + }); +}); + + test( "jQuery.when" , function() { expect( 23 ); From e83fcdcb02d676d91d764a58f7e8d2eb1c95de69 Mon Sep 17 00:00:00 2001 From: jaubourg Date: Fri, 1 Jul 2011 02:11:26 +0200 Subject: [PATCH 20/22] Fixes #9682. Removes data from the options for request with no content so that it is not used again in case of a retry. Unit test added. --- src/ajax.js | 2 ++ test/unit/ajax.js | 25 ++++++++++++++++++++----- 2 files changed, 22 insertions(+), 5 deletions(-) diff --git a/src/ajax.js b/src/ajax.js index e4e48dc7..650f3318 100644 --- a/src/ajax.js +++ b/src/ajax.js @@ -644,6 +644,8 @@ jQuery.extend({ // If data is available, append data to url if ( s.data ) { s.url += ( rquery.test( s.url ) ? "&" : "?" ) + s.data; + // #9682: remove data so that it's not used in an eventual retry + delete s.data; } // Get ifModifiedKey before adding the anti-cache parameter diff --git a/test/unit/ajax.js b/test/unit/ajax.js index 9f084136..33433922 100644 --- a/test/unit/ajax.js +++ b/test/unit/ajax.js @@ -321,25 +321,40 @@ test("jQuery.ajax() - responseText on error", function() { test(".ajax() - retry with jQuery.ajax( this )", function() { - expect( 1 ); + expect( 2 ); stop(); - var firstTime = 1; + var firstTime = true, + previousUrl; jQuery.ajax({ url: url("data/errorWithText.php"), error: function() { if ( firstTime ) { - firstTime = 0; + firstTime = false; jQuery.ajax( this ); } else { ok( true , "Test retrying with jQuery.ajax(this) works" ); - start(); + jQuery.ajax({ + url: url("data/errorWithText.php"), + data: { x: 1 }, + beforeSend: function() { + if ( !previousUrl ) { + previousUrl = this.url; + } else { + strictEqual( this.url , previousUrl, "url parameters are not re-appended" ); + start(); + return false; + } + }, + error: function() { + jQuery.ajax( this ); + } + }); } } }); - }); test(".ajax() - headers" , function() { From e6f8951983b8ce1af8986651fd412f9e569504c6 Mon Sep 17 00:00:00 2001 From: jaubourg Date: Fri, 1 Jul 2011 02:18:05 +0200 Subject: [PATCH 21/22] Fixes #9632. Adds res:// protocol to the list of local protocols. --- src/ajax.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ajax.js b/src/ajax.js index 650f3318..087f2feb 100644 --- a/src/ajax.js +++ b/src/ajax.js @@ -7,7 +7,7 @@ var r20 = /%20/g, rheaders = /^(.*?):[ \t]*([^\r\n]*)\r?$/mg, // IE leaves an \r character at EOL rinput = /^(?:color|date|datetime|email|hidden|month|number|password|range|search|tel|text|time|url|week)$/i, // #7653, #8125, #8152: local protocol detection - rlocalProtocol = /^(?:about|app|app\-storage|.+\-extension|file|widget):$/, + rlocalProtocol = /^(?:about|app|app\-storage|.+\-extension|file|res|widget):$/, rnoContent = /^(?:GET|HEAD)$/, rprotocol = /^\/\//, rquery = /\?/, From bb7d98f018c284a27b286a819238bac5541aad5e Mon Sep 17 00:00:00 2001 From: Denis Knauf Date: Thu, 7 Jul 2011 12:13:10 +0200 Subject: [PATCH 22/22] input type=datetime-local support for ajax. --- src/ajax.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ajax.js b/src/ajax.js index 087f2feb..355fd7e4 100644 --- a/src/ajax.js +++ b/src/ajax.js @@ -5,7 +5,7 @@ var r20 = /%20/g, rCRLF = /\r?\n/g, rhash = /#.*$/, rheaders = /^(.*?):[ \t]*([^\r\n]*)\r?$/mg, // IE leaves an \r character at EOL - rinput = /^(?:color|date|datetime|email|hidden|month|number|password|range|search|tel|text|time|url|week)$/i, + rinput = /^(?:color|date|datetime|datetime-local|email|hidden|month|number|password|range|search|tel|text|time|url|week)$/i, // #7653, #8125, #8152: local protocol detection rlocalProtocol = /^(?:about|app|app\-storage|.+\-extension|file|res|widget):$/, rnoContent = /^(?:GET|HEAD)$/,