timmywil
de79e8c7e0
Make the new attr/prop changes pass the test suite (in Webkit). There are still errors in IE.
...
+ Added hooks for selected, checked, readonly, disabled to removeAttr if set to falsey
+ Removed all attrs from attrFix, these aren't needed for setAttribute
+ If prop is used for class, do we want a propFix for class?
- We could just assume the user should know to use className with prop. I've done the latter for now.
+ Created tests for $.fn.prop and $.fn.removeProp
- Actually all I did was change broken attr tests to prop where it made sense.
2011-04-03 19:13:38 -04:00
rwldrn
43a41ba7ec
Make sure .val() works after form.reset() in IE. Fixes #2551 .
2011-02-10 23:50:02 +01:00
Colin Snover
e2941d5a98
Update unit tests with a leak detection mechanism for the various jQuery globals and fix all leaks in the tests.
2011-01-09 15:58:47 -06:00
Colin Snover
8e59a99e0a
Change the way jQuery.data works so that there is no longer a chance of collision between user data and internal data. Fixes #6968 .
2011-01-09 15:52:33 -06:00
Colin Snover
3e0cc81504
Clean trailing whitespace from all files.
2010-12-30 00:34:48 -06:00
jeresig
b2ea79c401
Merge branch 'attrFollowupFix' of https://github.com/jitter/jquery into jitter-attrFollowupFix
2010-12-09 12:43:10 -05:00
jeresig
b67154fd10
Merge branch 'support_6897' of https://github.com/rwldrn/jquery into rwldrn-support_6897
2010-12-09 12:33:26 -05:00
Anton M
cc9dbd06e5
Fix attr() problems in IE with attribute nodes. Followup to commit b50f41a2.
...
IE can't add properties on an attribute-node element, thus we handle it
like text-/comment-nodes.
2010-12-07 03:17:42 +01:00
John Resig
d4a9d45527
Merge branch 'restrictAttr' of https://github.com/jitter/jquery into jitter-restrictAttr
2010-12-06 17:02:00 -05:00
Anton M
df0a3fb853
Handle carriage return characters in className property. Fixes #7673 .
2010-12-01 21:31:22 +01:00
Anton M
b50f41a2e3
Make sure attr() works on non DOM element nodes. Fixes #7202 , #7451 , #7500 .
...
Also added some tests for this attr(name), attr(name, value) and removeAttr(name).
2010-11-13 14:39:28 +01:00
rwldrn
e2d0671f4c
Support unit test for #6897
2010-11-09 16:31:52 -05:00
Colin Snover
a64dc04050
Remove conditional that prevents attr from working on non-Element nodes. Fixes #7451 .
2010-11-09 15:52:20 -05:00
Anton M
4fcfee4369
Update number of expected assertions in attribute tests
...
Followup to commit 97dfa0d5a8
2010-10-19 11:14:07 +02:00
Colin Snover
b03416954d
Coerce all array values to strings before comparison in val(). Fixes bug #7123 .
2010-10-08 22:48:06 -05:00
John Resig
879799fe95
Make sure that ambiguous val() selection works correctly.
2010-09-28 08:36:28 -07:00
John Resig
c7c0677230
Make .attr(name, null) equivalent to removeAttr(name). (Was roughly this before - but is now consistent across platforms). Fixes #6341 .
2010-09-28 11:12:13 -04:00
dmethvin
0636dffc24
Make .val(undefined) == .val("") and chainable; fixes #4130 .
...
Ensure .val(null) sets an empty string on IE6/7; fixes #5163 .
2010-09-25 05:57:14 +08:00
Dave Methvin
2c4b20809e
Don't have .val() return selected-but-disabled options, or selected options inside a disabled optgroup. Doesn't change the .val() returned for a disabled select. Fixes #3240 , adapted from Nathan Hammond's patch there.
2010-09-24 17:26:22 -04:00
John Resig
a32f4d7b6c
Fixed the number of expected class tests from a previous commit. Thanks to @bugbegone in 1f667aa035 for the catch.
2010-09-22 12:35:42 -04:00
John Resig
dc060f08cd
Tweaked anchor test to work better on Blackberry 4.7.
2010-08-26 12:36:50 -04:00
John Resig
1bdcffba8e
Simplifying some of the .val() test code.
2010-08-23 14:23:13 -07:00
jzaefferer
6f031c1015
Replace usage of the removed global reset() method with QUnit.reset().
2010-07-28 17:19:01 +02:00
jeresig
8effe3a7de
Made it so that you no longer need to build jQuery in order to run the test suite (but you'll still need a checkout of QUnit and Sizzle, at least).
2010-03-23 12:12:16 -04:00
jeresig
437ddb931d
No need to run trim on every class iteration in addClass, thanks for the heads-up Leeoniya.
2010-02-13 14:30:27 -05:00
jeresig
abcc1a76ee
If .attr() is run on no elements undefined should be returned (as should be the case when no attribute is found). Fixes #6012 .
2010-02-13 02:23:38 -05:00
jeresig
83a044f1b5
Make sure that no extra whitespace is leftover after an addClass. Fixes #6050 .
2010-02-13 02:18:38 -05:00
jeresig
e76ba32ceb
Make sure the resulting className from removeClass is nicely trimmed. Fixes #5988 .
2010-02-01 21:33:58 -05:00
jeresig
f126f1ce85
Added tests for attribute function setters.
2010-01-07 11:15:40 -05:00
jeresig
12e8f07e34
Moved the val() tests from manipulation into attributes.
2010-01-07 09:55:15 -05:00
jeresig
4729f4d443
Make sure that selected works in Safari on options in optgroups. Fixes #5701 .
2009-12-22 15:02:52 -05:00
jeresig
5e811146ee
Temporarily disabling test for bug #4299 .
2009-12-18 19:24:19 -05:00
jeresig
d40083c866
Disabled the passthrough .attr(method_name) functionality. You can now use it if you do: .attr({method_name: value}, true) OR as an easy initialization method: jQuery('<div/>', {html: '...', id: 'test'}).
2009-12-18 12:41:53 -05:00
Karl Swedberg
aa81bb5e45
added a couple missing semicolons and fixed a typo in the comments
2009-12-18 03:58:16 +08:00
jeresig
1d921e2171
Follow-up to 100ed68642, forgot to remove one of the tests.
2009-12-17 14:18:15 -05:00
Batiste Bieler
649024909d
Enforce that hasClass and removeClass work even with tabs and endlines in class attributes. Fixes #5505 .
2009-12-14 16:24:28 -05:00
John Resig
0ab118ae0d
Removed .attr(removeClass) and .attr(each) tests as they don't really make sense.
2009-12-10 14:40:11 -08:00
Yehuda Katz
1a4d1904ae
Fix up whitespace and a couple of glitches.
2009-12-09 21:17:10 -08:00
Yehuda Katz
da51cd0e43
Add function values to addClass, removeClass, toggleClass, text, and removeAttr
2009-12-09 20:57:53 -08:00
David Petersen
841f9ff7a1
Handle changing form attributes correctly when there is a child element with the same name. Fixes #4299
2009-12-09 14:43:55 +08:00
jeresig
122e5dcf14
Changed the style attribute test to handle hex colors (as that's what Opera returns, in this case.
2009-11-30 14:31:32 -05:00
Ariel Flesler
5550356a12
jquery attributes: closes #5234 . attr() supports jQuery.fn methods.
2009-09-15 17:23:26 +00:00
Ariel Flesler
d1285504fb
jquery core: Closes #5189 . Added a generic function to handle getting/setting key-value/setting a hash.
2009-09-09 21:14:28 +00:00
John Resig
96dd06ea50
Removed jQuery.className.(has|remove|add) in favor of .addClass/removeClass/hasClass. Also rewrote the functions for additional performance.
2009-09-08 01:07:50 +00:00
John Resig
2a268f5f4b
Fixes regression in .attr(), patch by David Flanagan. Fixes #4884 .
2009-07-11 13:57:38 +00:00
Brandon Aaron
a073ee8596
unit tests for setting cellspacing, rowspan, and colspan
2009-05-16 15:10:24 +00:00
Brandon Aaron
e45b41602f
make sure toggleClass does not delete classNames when forcefully removing classes and they are already removed
2009-05-02 22:35:39 +00:00
Brandon Aaron
5e6e53835e
toggleClass can now toggle multiple classNames (space seperated list) and toggle the whole className. fixes #3825 .
2009-05-02 21:14:38 +00:00
John Resig
4130319e97
Added explicit module names to the new unit tests.
2009-04-20 17:05:18 +00:00
Brandon Aaron
e06da1724c
moving dimension related unit tests to dimensions test module
2009-03-22 23:25:58 +00:00
Brandon Aaron
d7d908b05a
decoupling styles retrieval from the attr method
2009-03-22 23:25:03 +00:00
Brandon Aaron
7c04a64016
breaking jquery out into smaller modules. added attributes.js, manipulation.js, and traversing.js
2009-03-18 21:15:38 +00:00
