timmywil
9f88fa9165
Full test suite now passes in all browsers! There are probably some tweaks we can make to shorten and simplify.
...
- removeAttr now only uses setAttribute if camelCase setAttribute is not supported
+ Might want to rename jQuery.support.getSetAttribute
- tabIndex is a special case now for hooks where undefined should be returned.
+ Should we be checking if hooks returns undefined? undefined might be the desired return value in future hooks.
As of now, tabIndex is the only one that needs it, but the test suite will still pass if we don't check if hooks are undefined.
2011-04-03 19:13:39 -04:00
timmywil
8cd30c62d8
Continuing IE7 testing, conditional attr fixes and hooks with feature testing. Will figure out a way to shorten after the test suite passes.
2011-04-03 19:13:39 -04:00
timmywil
ebb8e8e300
Fix feature test, accidentally got rid of closure end
2011-04-03 19:13:39 -04:00
timmywil
00abeaee17
Didn't actually need the hooks anymore
2011-04-03 19:13:38 -04:00
timmywil
4baa213d88
First proposed solution for IE6/7 get/setAttribute quirks. Needs more testing, but solves some issues
2011-04-03 19:13:38 -04:00
timmywil
607210e010
Speed up hasAttr a little
2011-04-03 19:13:38 -04:00
timmywil
5eecb13fa3
Now passes in IE8, changed around $.hasAttr and switched the attrHook for selected to be a propHook
2011-04-03 19:13:38 -04:00
timmywil
de79e8c7e0
Make the new attr/prop changes pass the test suite (in Webkit). There are still errors in IE.
...
+ Added hooks for selected, checked, readonly, disabled to removeAttr if set to falsey
+ Removed all attrs from attrFix, these aren't needed for setAttribute
+ If prop is used for class, do we want a propFix for class?
- We could just assume the user should know to use className with prop. I've done the latter for now.
+ Created tests for $.fn.prop and $.fn.removeProp
- Actually all I did was change broken attr tests to prop where it made sense.
2011-04-03 19:13:38 -04:00
jeresig
ab4e300919
Very crude first pass at splitting apart the attr/prop logic. Also adding in attrHooks/propHooks. All of it is completely untested.
2011-04-03 19:13:38 -04:00
timmywil
64a0005a3b
A more modest valHooks proposal
...
- The main difference is that this does not allow arbitrarily adding hooks to any collection of elements.
- Modularizes val into a set of easily maintainable and conditional hooks.
- valHooks is placed at jQuery.valHooks
+ This could technically be extended, but I do not see it being used except in very rare cases since you can only apply valHooks to nodeNames and input types, and not a collection of elements as before. We could theoretically privatize valHooks taking it off of jQuery and only use it internally for our own convenience, but again, I do not believe this patch carries with it the dangers of the first proposal.
- Slightly improved performance of val on radios and checkboxes for browsers that support checkOn, given the conditional attachment of its hook.
2011-04-02 17:05:04 -04:00
John Resig
fcc112f406
Updating the source version to 1.6pre.
2011-03-31 15:28:33 -04:00
John Resig
a507f719ab
Tagging the 1.5.2 release.
2011-03-31 15:28:23 -04:00
Ben Alman
de0c25bef4
Updated DOM ready unit tests.
2011-03-31 13:36:16 -04:00
Ben Alman
368bfc0fe0
DOM Ready unit tests (but not the supporting fixed code).
2011-03-31 11:37:48 -04:00
Dave Methvin
ff06d411d2
Merge branch 'bug_8316' of https://github.com/timmywil/jquery into timmywil-bug_8316
2011-03-31 10:25:59 -04:00
Dave Methvin
459bd7f89d
Followup commit for #7340 test case; make sure second test fires properly on IE by focusing to another element rather than blurring off the first.
2011-03-31 09:10:30 -04:00
timmywil
f9cc5597a4
Fix test cases for bug #8316 fix.
...
- Removed special page, just needed another test in the fixed offset tests
- Checks it's position related to scrolling
2011-03-31 02:55:16 -04:00
timmywil
a807451a23
Fixes #7369 - Using an attribute selector for a non-existent attribute raised an exception on disconnected nodes
2011-03-30 23:39:19 -04:00
timmywil
1a16776730
Remove test for bug #7369 to move the fix to a separate branch for a sooner pull
2011-03-30 23:23:38 -04:00
Dave Methvin
6c28a394c2
Remove crossDomain:null comment, it's not needed since undefined==null below.
2011-03-30 21:59:38 -04:00
timmywil
6da3885cc3
Merge branch 'master' of git://github.com/jquery/jquery into 2773_find_closest
2011-03-30 21:52:09 -04:00
Dave Methvin
adbe5e95f3
Merge branch 'crossDomain' of https://github.com/JessThrysoee/jquery into JessThrysoee-crossDomain
2011-03-30 21:52:04 -04:00
Dave Methvin
ad4152709c
Fixes #8203 . Remove some misguided nulling of elements done in the name of IE memory cleanup. Based on a patch by davidmurdoch in pull 226.
2011-03-30 21:21:49 -04:00
John Resig
8cdafe7704
Merge branch 'makefile_fixes' of https://github.com/azatoth/jquery into azatoth-makefile_fixes
2011-03-30 15:23:31 -04:00
John Resig
b89b66657c
Merge branch 'fix_8346' of https://github.com/lrbabe/jquery into lrbabe-fix_8346
2011-03-30 14:54:52 -04:00
Jordan Boesch
926884bf1f
Bug 4366; removing extra space
2011-03-30 11:26:20 -06:00
Jordan Boesch
3296116041
Bug 4366; fixing $.each(document.styleSheets) from throwing errors in IE
2011-03-30 11:17:48 -06:00
jaubourg
f2ce87df8e
Fixes #8692 . Strange FF4 bug: values changed onto the arguments object sometimes end up as undefined values outside the $.when method. Cloning the object into a fresh array solves the issue.
2011-03-30 18:54:32 +02:00
John Resig
2555a5a232
Update the Sizzle location to point to the newly-moved repo.
2011-03-28 13:10:12 -04:00
rwldrn
ef0157d191
Bug #8635 Firefox uncaught exception
2011-03-28 12:31:03 -04:00
timmywil
e93ca40aa7
Bug #7369 : Check non-existent attribute as well to be sure
2011-03-25 23:52:36 -04:00
timmywil
e6da0fa6a9
Bug #7369 : Add test for disconnected node in closest when passing attribute selector; this was recently fixed in 1.5.2rc
2011-03-25 23:46:29 -04:00
jeresig
ee81d4da92
Merge branch 'bug-3333' of https://github.com/rdworth/jquery
2011-03-24 22:10:38 -04:00
jeresig
23e8cc5608
Updating the source version to 1.5.2pre.
2011-03-24 20:12:40 -04:00
jeresig
2d80710ab0
Tagging the 1.5.2rc1 release.
2011-03-24 20:12:31 -04:00
jeresig
d86c48679a
Land new sizzle commit.
2011-03-24 20:08:40 -04:00
Richard Worth
735a949a06
Further fix for #3333 , refactored marginRight css hook to use jQuery.swap and computed. Thanks timmywil
2011-03-24 19:55:55 -04:00
jeresig
7b985c4ca0
Oops, that test file for bug #8316 was needed - was also missing an include and was causing errors.
2011-03-24 19:52:45 -04:00
jeresig
5ee4eefb9e
Updating Sizzle submodule to bring in the latest commit.
2011-03-24 19:40:09 -04:00
jeresig
53697d10ef
Fix missing semicolon.
2011-03-24 19:36:38 -04:00
Michael Murray
e8f4629b92
Offset setter for fixed position elements in Webkit. Fixes #8316 .
2011-03-24 19:02:38 -04:00
jeresig
1912ded3ee
Merge branch 'bug-3333' of https://github.com/rdworth/jquery into rdworth-bug-3333
2011-03-24 18:58:20 -04:00
Richard Worth
c3c507e900
Added css hook to work around bug in WebKit computed margin-right. Fixes #3333 - .css("marginRight") is incorrect in WebKit
2011-03-24 15:41:46 -04:00
timmywil
85232c97bf
Traversing unit tests: added tests for passing invalid arguments to $.fn.not (should have no effect on existing object rather than return an empty object as filter does)
2011-03-23 16:04:12 -04:00
timmywil
d2eafa0bb8
Merge branch 'master' of git://github.com/jquery/jquery into bug_2773
2011-03-23 15:59:33 -04:00
timmywil
b8013581ce
Closest unit tests: add one for passing a jQuery collection with multiple elements
2011-03-23 15:56:05 -04:00
Carl Fürstenberg
50e8837207
Makefile: pull_submodules cleaning
...
Empirical testing confirms that pulling the url again is enough
2011-03-22 23:18:15 +01:00
Carl Fürstenberg
07392bb090
Merge branch 'master' into makefile_fixes
2011-03-22 21:55:49 +01:00
timmywil
e09d8898d8
Add node and jQuery object support to $.fn.closest
2011-03-21 20:59:20 -04:00
Dan Heberden
00dd6013b6
Clean up tab spacing
2011-03-21 12:24:53 -07:00
