deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

jquery core: Patch from #2619 applied, making makeArray more flexible and faster; removed hint to ticket from (previously failing) test

Browse source
This commit is contained in:
Jörn Zaefferer 2008-04-24 21:23:36 +00:00
parent f12d94a628
commit f8e5fd6fef
2 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/core.js
View file

@ -1123,12 +1123,13 @@ jQuery.extend({
makeArray: function( array ) { makeArray: function( array ) {
var ret = []; var ret = [];
// Need to use typeof to fight Safari childNodes crashes if( array != undefined )
if ( array.constructor != Array ) //strings and functions also have 'length'
for ( var i = 0, length = array.length; i < length; i++ ) if( array.length != undefined && !array.split && !array.call )
ret.push( array[ i ] ); for( var i = array.length; i; )
ret[--i] = array[i];
else else
ret = array.slice( 0 ); ret[0] = array;
return ret; return ret;
}, },

2
test/unit/core.js
View file

@ -1562,7 +1562,7 @@ test("contents()", function() {
equals( c[0].nodeValue, "hi", "Check node,textnode,comment contents is just the one from span" ); equals( c[0].nodeValue, "hi", "Check node,textnode,comment contents is just the one from span" );
}); });
test("makeArray(#2619)", function(){ test("$.makeArray", function(){
expect(11); expect(11);
equals( $.makeArray(document.getElementsByName("PWD")).slice(0,1)[0].name, "PWD", "Pass makeArray a nodelist" ); equals( $.makeArray(document.getElementsByName("PWD")).slice(0,1)[0].name, "PWD", "Pass makeArray a nodelist" );