deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Update jQuery.hasData to always return a boolean, with unit tests.

Browse source
This commit is contained in:
Colin Snover 2010-12-22 14:54:37 -06:00
parent 445fdf720c
commit f5d4bf8920
2 changed files with 22 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/data.js
View file

@ -22,7 +22,7 @@ jQuery.extend({
}, },
hasData: function( elem ) { hasData: function( elem ) {
return !elem.nodeType || (elem[ jQuery.expando ] && !jQuery.isEmptyObject(jQuery.cache[ elem[jQuery.expando] ])); return !elem.nodeType || (!!elem[ jQuery.expando ] && !jQuery.isEmptyObject(jQuery.cache[ elem[jQuery.expando] ]));
}, },
data: function( elem, name, data ) { data: function( elem, name, data ) {

9
test/unit/data.js
View file

@ -78,6 +78,15 @@ test("jQuery.data", function() {
ok( jQuery.data( window, "BAD" ), "Make sure that the value was set." ); ok( jQuery.data( window, "BAD" ), "Make sure that the value was set." );
}); });
test("jQuery.hasData", function() {
var div = document.createElement( "div" );
equals( jQuery.hasData(div), false, "No data exists" );
jQuery.data( div, "foo", "bar" );
equals( jQuery.hasData(div), true, "Data exists" );
jQuery.removeData( div, "foo" );
equals( jQuery.hasData(div), false, "Data was removed" );
});
test(".data()", function() { test(".data()", function() {
expect(5); expect(5);