From f337b8a6377d4920503015af4c2b3cb1262da1da Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rn=20Zaefferer?= <joern.zaefferer@gmail.com> Date: Fri, 8 Sep 2006 17:48:21 +0000 Subject: [PATCH] Added more test for attr, one for filter; Added test to check IE issue $('input').attr('name', 'something'), modified fixture to test this --- build/test/index.html | 2 ++ src/jquery/jquery.js | 15 +++++++++++++-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/build/test/index.html b/build/test/index.html index 7d10fc77..3af22407 100644 --- a/build/test/index.html +++ b/build/test/index.html @@ -44,6 +44,8 @@ <input type="hidden" name="hidden" id="hidden1"/> <input type="text" style="display:none;" id="hidden2"/> + <input type="text" id="name" name="name" value="name" /> + <select name="select1" id="select1"> <option id="option1a" value="">Nothing</option> <option id="option1b" value="1">1</option> diff --git a/src/jquery/jquery.js b/src/jquery/jquery.js index 3edc3033..b6bffc7c 100644 --- a/src/jquery/jquery.js +++ b/src/jquery/jquery.js @@ -384,6 +384,12 @@ jQuery.fn = jQuery.prototype = { * @test ok( $('#text1').attr('type') == "text", 'Check for type attribute' ); * @test ok( $('#radio1').attr('type') == "radio", 'Check for type attribute' ); * @test ok( $('#check1').attr('type') == "checkbox", 'Check for type attribute' ); + * @test ok( $('#simon1').attr('rel') == "bookmark", 'Check for rel attribute' ); + * @test ok( $('#google').attr('title') == "Google!", 'Check for title attribute' ); + * @test ok( $('#mark').attr('hreflang') == "en", 'Check for hreflang attribute' ); + * @test ok( $('#en').attr('lang') == "en", 'Check for lang attribute' ); + * @test ok( $('#simon').attr('class') == "blog link", 'Check for class attribute' ); + * @test ok( $('#name').attr('name') == "name", 'Check for name attribute' ); * * @name attr * @type Object @@ -427,6 +433,9 @@ jQuery.fn = jQuery.prototype = { * } * ok( pass, "Set Attribute" ); * + * @test $("#name").attr('name', 'something'); + * ok( $("#name").name() == 'something', 'Set name attribute' ); + * * @name attr * @type jQuery * @param String key The name of the property to set. @@ -954,6 +963,8 @@ jQuery.fn = jQuery.prototype = { * @before <p class="selected">Hello</p><p>How are you?</p> * @result $("p").filter(".selected") == [ <p class="selected">Hello</p> ] * + * @test isSet( $("input").filter(":checked").get(), q("radio2", "check1"), "Filter elements" ); + * * @name filter * @type jQuery * @param String expr An expression to search with. @@ -1580,7 +1591,7 @@ jQuery.extend({ * @test t( "Last Child", "p:last-child", ["sap"] ); * @test t( "Only Child", "a:only-child", ["simon1","anchor1","yahoo","anchor2"] ); * @test t( "Empty", "ul:empty", ["firstUL"] ); - * @test t( "Enabled UI Element", "input:enabled", ["text1","radio1","radio2","check1","check2","hidden1","hidden2"] ); + * @test t( "Enabled UI Element", "input:enabled", ["text1","radio1","radio2","check1","check2","hidden1","hidden2","name"] ); * @test t( "Disabled UI Element", "input:disabled", ["text2"] ); * @test t( "Checked UI Element", "input:checked", ["radio2","check1"] ); * @test t( "Selected Option Element", "option:selected", ["option1a","option2d","option3b","option3c"] ); @@ -1613,7 +1624,7 @@ jQuery.extend({ * @test t( "Position Greater Than", "p:gt(0)", ["ap","sndp","en","sap","first"] ); * @test t( "Position Less Than", "p:lt(3)", ["firstp","ap","sndp"] ); * @test t( "Is A Parent", "p:parent", ["firstp","ap","sndp","en","sap","first"] ); - * @test t( "Is Visible", "input:visible", ["text1","text2","radio1","radio2","check1","check2"] ); + * @test t( "Is Visible", "input:visible", ["text1","text2","radio1","radio2","check1","check2","name"] ); * @test t( "Is Hidden", "input:hidden", ["hidden1","hidden2"] ); * * @name $.find