deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Expose cleanData, make sure that all bound event handlers are properly cleaned up after html/empty/remove. Fixes #5856 and #5906.

Browse source
This commit is contained in:
jeresig 2010-01-23 21:20:19 -05:00
parent 4f9aa62a85
commit f06e0e5575
2 changed files with 81 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

70
test/unit/manipulation.js
View file

@ -971,3 +971,73 @@ test("empty()", function() {
equals( j.html(), "", "Check node,textnode,comment empty works" );
});
test("jQuery.cleanData", function() {
expect(10);
var type, pos, div, child;
type = "remove";
// Should trigger 4 remove event
div = getDiv().remove();
// Should both do nothing
pos = "Outer";
div.trigger("click");
pos = "Inner";
div.children().trigger("click");
type = "empty";
div = getDiv();
child = div.children();
// Should trigger 2 remove event
div.empty();
// Should trigger 1
pos = "Outer";
div.trigger("click");
// Should do nothing
pos = "Inner";
child.trigger("click");
type = "html";
div = getDiv();
child = div.children();
// Should trigger 2 remove event
div.html("<div></div>");
// Should trigger 1
pos = "Outer";
div.trigger("click");
// Should do nothing
pos = "Inner";
child.trigger("click");
function getDiv() {
var div = jQuery("<div class='outer'><div class='inner'></div></div>").click(function(){
ok( true, type + " " + pos + " Click event fired." );
}).focus(function(){
ok( true, type + " " + pos + " Focus event fired." );
}).find("div").click(function(){
ok( false, type + " " + pos + " Click event fired." );
}).focus(function(){
ok( false, type + " " + pos + " Focus event fired." );
}).end().appendTo("body");
div[0].detachEvent = div[0].removeEventListener = function(t){
ok( true, type + " Outer " + t + " event unbound" );
};
div[0].firstChild.detachEvent = div[0].firstChild.removeEventListener = function(t){
ok( true, type + " Inner " + t + " event unbound" );
};
return div;
}
});