deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fixed the issue where weird characters were being used in ID selectors. Fixes jQuery bug #3913.

Browse source
This commit is contained in:
John Resig 2009-02-15 22:46:54 +00:00
parent 22c9c9b9d3
commit f0189d6181
3 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/selector.js
View file

@ -6,7 +6,7 @@
*/ */
(function(){ (function(){
var chunker = /((?:\((?:\([^()]+\)|[^()]+)+\)|\[(?:\[[^[\]]*\]|['"][^'"]*['"]|[^[\]'"]+)+\]|\\.|[^ >+~,(\[]+)+|[>+~])(\s*,\s*)?/g, var chunker = /((?:\((?:\([^()]+\)|[^()]+)+\)|\[(?:\[[^[\]]*\]|['"][^'"]*['"]|[^[\]'"]+)+\]|\\.|[^ >+~,(\[\\]+)+|[>+~])(\s*,\s*)?/g,
done = 0, done = 0,
toString = Object.prototype.toString; toString = Object.prototype.toString;

1
test/index.html
View file

@ -50,6 +50,7 @@
<p id="sap">This link has <code><a href="#2" id="anchor2">class="blog"</a></code>: <a href="http://simon.incutio.com/" class="blog link" id="simon">Simon Willison's Weblog</a></p> <p id="sap">This link has <code><a href="#2" id="anchor2">class="blog"</a></code>: <a href="http://simon.incutio.com/" class="blog link" id="simon">Simon Willison's Weblog</a></p>
</div> </div>
<span id="name+value"></span>
<p id="first">Try them out:</p> <p id="first">Try them out:</p>
<ul id="firstUL"></ul> <ul id="firstUL"></ul>
<ol id="empty"></ol> <ol id="empty"></ol>

4
test/unit/selector.js
View file

@ -69,7 +69,7 @@ test("broken", function() {
}); });
test("id", function() { test("id", function() {
expect(27); expect(28);
t( "ID Selector", "#body", ["body"] ); t( "ID Selector", "#body", ["body"] );
t( "ID Selector w/ Element", "body#body", ["body"] ); t( "ID Selector w/ Element", "body#body", ["body"] );
t( "ID Selector w/ Element", "ul#first", [] ); t( "ID Selector w/ Element", "ul#first", [] );
@ -105,6 +105,8 @@ test("id", function() {
t( "Underscore ID", "#types_all", ["types_all"] ); t( "Underscore ID", "#types_all", ["types_all"] );
t( "Dash ID", "#fx-queue", ["fx-queue"] ); t( "Dash ID", "#fx-queue", ["fx-queue"] );
t( "ID with weird characters in it", "#name\\+value", ["name+value"] );
}); });
test("class", function() { test("class", function() {