From 7164615f6727c67da612fecc63867d30e1b4b4a3 Mon Sep 17 00:00:00 2001 From: rwldrn Date: Tue, 12 Apr 2011 11:48:07 -0400 Subject: [PATCH 01/11] Ticket 8099, Reattempt with iframe --- src/effects.js | 33 +++++++++++++++++++++++++++++---- test/data/testsuite.css | 3 +++ test/unit/effects.js | 13 +++++++++++++ 3 files changed, 45 insertions(+), 4 deletions(-) diff --git a/src/effects.js b/src/effects.js index 7aec8300..73ce33a8 100644 --- a/src/effects.js +++ b/src/effects.js @@ -548,17 +548,42 @@ if ( jQuery.expr && jQuery.expr.filters ) { } function defaultDisplay( nodeName ) { - if ( !elemdisplay[ nodeName ] ) { - var elem = jQuery("<" + nodeName + ">").appendTo("body"), - display = elem.css("display"); + var stylesheets = document.styleSheets, + disabled = [], + elem, display, style, idx; + if ( !elemdisplay[ nodeName ] ) { + + // #8099 - If the end-dev has globally changed a default + // display, we can temporarily disable their styles to check + // for the correct default value + for ( idx = 0; idx < stylesheets.length; ++idx ) { + style = stylesheets[ idx ]; + disabled[ idx ] = style.disabled; + style.disabled = true; + } + + // To accurately check an element's default display value, + // create a temp element and check it's default display, this + // will ensure that the value returned is not a user-tampered + // value. + elem = jQuery("<" + nodeName + ">").appendTo("body"), + display = elem.css("display"); + + // Remove temp element elem.remove(); if ( display === "none" || display === "" ) { display = "block"; } - + + // Store the correct default display elemdisplay[ nodeName ] = display; + + // Restore stylesheets + for ( idx = 0; idx < stylesheets.length; ++idx ) { + stylesheets[ idx ].disabled = disabled[ idx ]; + } } return elemdisplay[ nodeName ]; diff --git a/test/data/testsuite.css b/test/data/testsuite.css index 02900681..b307d498 100644 --- a/test/data/testsuite.css +++ b/test/data/testsuite.css @@ -109,3 +109,6 @@ div#show-tests * { display: none; } #nothiddendiv { font-size: 16px; } #nothiddendivchild.em { font-size: 2em; } #nothiddendivchild.prct { font-size: 150%; } + +/* 8099 changes to default styles are read correctly */ +tt { display: none; } diff --git a/test/unit/effects.js b/test/unit/effects.js index 4faf6174..b68b9b6b 100644 --- a/test/unit/effects.js +++ b/test/unit/effects.js @@ -162,6 +162,19 @@ test("Persist correct display value", function() { }); }); +test("show() resolves correct default display #8099", function() { + expect(3); + var bug8099 = jQuery("").appendTo("#main"); + + equals( bug8099.css("display"), "none", "default display override for all tt" ); + equals( bug8099.show().css("display"), "inline", "Correctly resolves display:inline" ); + + bug8099.remove(); + + equals( jQuery("#foo").hide().show().css("display"), "block", "Correctly resolves display:block after hide/show" ); +}); + + test("animate(Hash, Object, Function)", function() { expect(1); stop(); From 885b64d4e683bce475a4ec8495cbba80b6b2e1b3 Mon Sep 17 00:00:00 2001 From: rwldrn Date: Tue, 12 Apr 2011 13:47:27 -0400 Subject: [PATCH 02/11] Fixes #8099 using iframe to capture an element's real default display; suggested by lrbabe/louisremi --- src/effects.js | 54 +++++++++++++++++++++++++++----------------------- 1 file changed, 29 insertions(+), 25 deletions(-) diff --git a/src/effects.js b/src/effects.js index 73ce33a8..e7987d21 100644 --- a/src/effects.js +++ b/src/effects.js @@ -548,45 +548,49 @@ if ( jQuery.expr && jQuery.expr.filters ) { } function defaultDisplay( nodeName ) { - var stylesheets = document.styleSheets, - disabled = [], - elem, display, style, idx; + var iframe, iframeDoc, iframeNode, display; if ( !elemdisplay[ nodeName ] ) { - // #8099 - If the end-dev has globally changed a default - // display, we can temporarily disable their styles to check - // for the correct default value - for ( idx = 0; idx < stylesheets.length; ++idx ) { - style = stylesheets[ idx ]; - disabled[ idx ] = style.disabled; - style.disabled = true; + iframe = defaultDisplay.iframe.clone()[ 0 ]; + + iframe.style.display = "none"; + + document.body.appendChild( iframe ); + + iframeDoc = iframe.contentWindow && iframe.contentWindow || + iframe.contentDocument.document && iframe.contentDocument.document || + iframe.contentDocument; + + iframeNode = jQuery( "<" + nodeName + ">" ).appendTo( jQuery( "body", iframeDoc.document ) ); + + if ( !iframeNode.length ) { + // this will only occur in IE + iframeDoc.document.open(); + iframeDoc.document.write(""); + elem = iframeDoc.document.createElement( nodeName ); + iframeDoc.document.body.appendChild( elem ); + iframeDoc.document.close(); + + iframeNode = jQuery( elem ); } - - // To accurately check an element's default display value, - // create a temp element and check it's default display, this - // will ensure that the value returned is not a user-tampered - // value. - elem = jQuery("<" + nodeName + ">").appendTo("body"), - display = elem.css("display"); - - // Remove temp element - elem.remove(); + + // firefox returns undefined from css("display") + display = iframeNode.css("display") || iframeNode[ 0 ].style.display; if ( display === "none" || display === "" ) { display = "block"; } - + // Store the correct default display elemdisplay[ nodeName ] = display; - // Restore stylesheets - for ( idx = 0; idx < stylesheets.length; ++idx ) { - stylesheets[ idx ].disabled = disabled[ idx ]; - } + iframe.parentNode.removeChild( iframe ); } return elemdisplay[ nodeName ]; } +defaultDisplay.iframe = jQuery("