deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Clone fragments in domManip using jQuery.clone instead of DocumentFragment.cloneNode in order to carry over event data. Fixes #5566, #6997.

Browse source
This commit is contained in:
Colin Snover 2010-12-06 19:37:16 -06:00
parent c8be9461ee
commit e4900df838
2 changed files with 77 additions and 57 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/manipulation.js
View file

@ -349,7 +349,7 @@ jQuery.fn.extend({
root(this[i], first) : root(this[i], first) :
this[i], this[i],
i > 0 || results.cacheable || this.length > 1 ? i > 0 || results.cacheable || this.length > 1 ?
fragment.cloneNode(true) : jQuery(fragment).clone(true)[0] :
fragment fragment
); );
} }

20
test/unit/manipulation.js
View file

@ -381,6 +381,26 @@ test("append(Function) with incoming value", function() {
QUnit.reset(); QUnit.reset();
}); });
test("append the same fragment with events (Bug #6997, 5566)", function () {
expect(2);
stop(1000);
var element = jQuery("<a class='test6997'></a>").click(function () {
ok(true, "Append second element events work");
});
jQuery("#listWithTabIndex li").append(element)
.find('a.test6997').eq(1).click();
element = jQuery("<li class='test6997'></li>").click(function () {
ok(true, "Before second element events work");
start();
});
jQuery("#listWithTabIndex li").before(element);
jQuery("#listWithTabIndex li.test6997").eq(1).click();
});
test("appendTo(String|Element|Array&lt;Element&gt;|jQuery)", function() { test("appendTo(String|Element|Array&lt;Element&gt;|jQuery)", function() {
expect(16); expect(16);