deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Disabled the passthrough .attr(method_name) functionality. You can now use it if you do: .attr({method_name: value}, true) OR as an easy initialization method: jQuery('<div/>', {html: '...', id: 'test'}).

Browse source
This commit is contained in:
jeresig 2009-12-18 12:41:53 -05:00
parent 148fb7ba8e
commit d40083c866
4 changed files with 35 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

12
test/unit/attributes.js
View file

@ -5,7 +5,7 @@ var functionReturningObj = function(value) { return (function() { return value;
test("attr(String)", function() {
expect(28);
// This one sometimes fails randomly ?!
equals( jQuery('#text1').attr('value'), "Test", 'Check for value attribute' );
@ -190,16 +190,16 @@ test("attr(jquery_method)", function(){
elem = $elem[0];
// one at a time
$elem.attr('html', 'foo');
$elem.attr({'html': 'foo'}, true);
equals( elem.innerHTML, 'foo', 'attr(html)');
$elem.attr('text', 'bar');
$elem.attr({'text': 'bar'}, true);
equals( elem.innerHTML, 'bar', 'attr(text)');
$elem.attr('css', {color:'red'});
$elem.attr({'css': {color:'red'}}, true);
ok( /^(#ff0000|red)$/i.test(elem.style.color), 'attr(css)');
$elem.attr('height', 10);
$elem.attr({'height': 10}, true);
equals( elem.style.height, '10px', 'attr(height)');
// Multiple attributes
@ -207,7 +207,7 @@ test("attr(jquery_method)", function(){
$elem.attr({
width:10,
css:{ paddingLeft:1, paddingRight:1 }
});
}, true);
equals( elem.style.width, '10px', 'attr({...})');
equals( elem.style.paddingLeft, '1px', 'attr({...})');

18
test/unit/core.js
View file

@ -12,7 +12,7 @@ test("Basic requirements", function() {
});
test("jQuery()", function() {
expect(15);
expect(22);
// Basic constructor's behavior
@ -62,6 +62,22 @@ test("jQuery()", function() {
equals( jQuery([1,2,3]).get(1), 2, "Test passing an array to the factory" );
equals( jQuery(document.body).get(0), jQuery('body').get(0), "Test passing an html node to the factory" );
var elem = jQuery("<div/>", {
width: 10,
css: { paddingLeft:1, paddingRight:1 },
text: "test",
"class": "test2",
id: "test3"
});
equals( elem[0].style.width, '10px', 'jQuery() quick setter width');
equals( elem[0].style.paddingLeft, '1px', 'jQuery quick setter css');
equals( elem[0].style.paddingRight, '1px', 'jQuery quick setter css');
equals( elem[0].childNodes.length, 1, 'jQuery quick setter text');
equals( elem[0].firstChild.nodeValue, "test", 'jQuery quick setter text');
equals( elem[0].className, "test2", 'jQuery() quick setter class');
equals( elem[0].id, "test3", 'jQuery() quick setter id');
});
test("selector state", function() {