deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Coerce all array values to strings before comparison in val(). Fixes bug #7123.

Browse source
This commit is contained in:
Colin Snover 2010-10-08 22:48:06 -05:00
parent a2aefbf3b1
commit b03416954d
2 changed files with 17 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/attributes.js
View file

@ -215,6 +215,10 @@ jQuery.fn.extend({
val = "";
} else if ( typeof val === "number" ) {
val += "";
} else if ( jQuery.isArray(val) ) {
val = jQuery.map(val, function (value) {
return value == null ? "" : value + "";
});
}
if ( jQuery.isArray(val) && rradiocheck.test( this.type ) ) {

14
test/unit/attributes.js
View file

@ -409,7 +409,19 @@ test("val(String/Number)", function() {
test("val(Function)", function() {
testVal(functionReturningObj);
})
});
test( "val(Array of Numbers) (Bug #7123)", function() {
expect(4);
jQuery('#form').append('<input type="checkbox" name="arrayTest" value="1" /><input type="checkbox" name="arrayTest" value="2" /><input type="checkbox" name="arrayTest" value="3" checked="checked" /><input type="checkbox" name="arrayTest" value="4" />');
var elements = jQuery('input[name=arrayTest]').val([ 1, 2 ]);
ok( elements[0].checked, "First element was checked" );
ok( elements[1].checked, "Second element was checked" );
ok( !elements[2].checked, "Third element was unchecked" );
ok( !elements[3].checked, "Fourth element remained unchecked" );
elements.remove();
});
test("val(Function) with incoming value", function() {
expect(10);