deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Standardized the type checks across core. isFunction and isArray now use Object.prototype.toString to verify the type, .constructor use was removed in favor of typeof, typeof checks now use ===, undefined checks use === undefined. All of this is outlined in the new style guidelines: http://docs.jquery.com/JQuery_Core_Style_Guidelines#Type_Checks. Fixes bug #3618.

Browse source
This commit is contained in:
John Resig 2008-11-17 16:32:05 +00:00
parent 0aa8d40cdf
commit ab551c2b14
6 changed files with 52 additions and 54 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/selector.js
View file

@ -92,7 +92,7 @@ jQuery.extend({
find: function( t, context ) {
// Quickly handle non-string expressions
if ( typeof t != "string" )
if ( typeof t !== "string" )
return [ t ];
// check to make sure context is a DOM element or a document
@ -214,7 +214,7 @@ jQuery.extend({
// Do a quick check for the existence of the actual ID attribute
// to avoid selecting by the name attribute in IE
// also check to insure id is a string to avoid selecting an element with the name of 'id' inside a form
if ( (jQuery.browser.msie||jQuery.browser.opera) && oid && typeof oid.id == "string" && oid.id != m[2] )
if ( (jQuery.browser.msie||jQuery.browser.opera) && oid && typeof oid.id === "string" && oid.id != m[2] )
oid = jQuery('[@id="'+m[2]+'"]', elem)[0];
// Do a quick check for node name (where applicable) so
@ -391,10 +391,10 @@ jQuery.extend({
// Otherwise, find the expression to execute
} else {
var fn = jQuery.expr[ m[1] ];
if ( typeof fn == "object" )
if ( typeof fn === "object" )
fn = fn[ m[2] ];
if ( typeof fn == "string" )
if ( typeof fn === "string" )
fn = eval("false||function(a,i){return " + fn + ";}");
// Execute it against the current filter