Added in integrated JSLint checking against the jQuery source. Just run 'make lint' to see the result.

This commit is contained in:
jeresig 2010-03-01 21:51:44 -05:00
parent dcf0fa5048
commit 950b5d64a2
5 changed files with 5548 additions and 3 deletions

View file

@ -29,11 +29,12 @@ JQ_MIN = ${DIST_DIR}/jquery.min.js
JQ_VER = `cat version.txt` JQ_VER = `cat version.txt`
VER = sed s/@VERSION/${JQ_VER}/ VER = sed s/@VERSION/${JQ_VER}/
RHINO = java -jar ${BUILD_DIR}/js.jar
MINJAR = java -jar ${BUILD_DIR}/google-compiler-20091218.jar MINJAR = java -jar ${BUILD_DIR}/google-compiler-20091218.jar
DATE=`git log -1 | grep Date: | sed 's/[^:]*: *//'` DATE=`git log -1 | grep Date: | sed 's/[^:]*: *//'`
all: jquery min all: jquery lint min
@@echo "jQuery build complete." @@echo "jQuery build complete."
${DIST_DIR}: ${DIST_DIR}:
@ -49,7 +50,7 @@ init:
jquery: ${DIST_DIR} selector ${JQ} jquery: ${DIST_DIR} selector ${JQ}
jq: ${DIST_DIR} ${JQ} jq: ${DIST_DIR} ${JQ}
${JQ}: ${MODULES} ${JQ}: selector ${MODULES}
@@echo "Building" ${JQ} @@echo "Building" ${JQ}
@@mkdir -p ${DIST_DIR} @@mkdir -p ${DIST_DIR}
@ -58,10 +59,14 @@ ${JQ}: ${MODULES}
sed 's/Date:./&'"${DATE}"'/' | \ sed 's/Date:./&'"${DATE}"'/' | \
${VER} > ${JQ}; ${VER} > ${JQ};
selector: init selector: ${DIST_DIR} init
@@echo "Building selector code from Sizzle" @@echo "Building selector code from Sizzle"
@@sed '/EXPOSE/r src/sizzle-jquery.js' src/sizzle/sizzle.js > src/selector.js @@sed '/EXPOSE/r src/sizzle-jquery.js' src/sizzle/sizzle.js > src/selector.js
lint: ${JQ}
@@echo "Checking jQuery against JSLint..."
@@${RHINO} build/jslint-check.js
min: ${JQ_MIN} min: ${JQ_MIN}
${JQ_MIN}: ${JQ} ${JQ_MIN}: ${JQ}

View file

@ -36,6 +36,10 @@ Makes: ./dist/jquery.js
A compressed version of jQuery (made the Closure Compiler). A compressed version of jQuery (made the Closure Compiler).
Makes: ./dist/jquery.min.js Makes: ./dist/jquery.min.js
`make lint`
Tests a build of jQuery against JSLint, looking for potential errors or bits of confusing code.
`make selector` `make selector`
Builds the selector library for jQuery from Sizzle. Builds the selector library for jQuery from Sizzle.

BIN
build/js.jar Normal file

Binary file not shown.

36
build/jslint-check.js Normal file
View file

@ -0,0 +1,36 @@
load("build/jslint.js");
var src = readFile("dist/jquery.js");
JSLINT(src, { evil: true, forin: true });
// All of the following are known issues that we think are 'ok'
// (in contradiction with JSLint) more information here:
// http://docs.jquery.com/JQuery_Core_Style_Guidelines
var ok = {
"Expected an identifier and instead saw 'undefined' (a reserved word).": true,
"Use '===' to compare with 'null'.": true,
"Use '!==' to compare with 'null'.": true,
"Expected an assignment or function call and instead saw an expression.": true,
"Expected a 'break' statement before 'case'.": true
};
var e = JSLINT.errors, found = 0, w;
for ( var i = 0; i < e.length; i++ ) {
w = e[i];
if ( !ok[ w.reason ] ) {
found++;
print( "\n" + w.evidence + "\n" );
print( " Problem at line " + w.line + " character " + w.character + ": " + w.reason );
}
}
if ( found > 0 ) {
print( "\n" + found + " Error(s) found." );
} else {
print( "JSLint check passed." );
}

5500
build/jslint.js Normal file

File diff suppressed because it is too large Load diff