deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fixed #2062 by adding a check to see if the selector is array-like in .not() before testing it as an array. Otherwise it does a straight comparison during the filter test.

Browse source
This commit is contained in:
David Serduke 2007-12-17 16:54:44 +00:00
parent d7f5a0835b
commit 90b25efa6c
2 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/core.js
View file

@ -353,7 +353,10 @@ jQuery.fn = jQuery.prototype = {
selector = jQuery.multiFilter( selector, this ); selector = jQuery.multiFilter( selector, this );
return this.filter(function() { return this.filter(function() {
return jQuery.inArray( this, selector ) < 0; // check to see if the selector is array-like otherwise assume it is just a DOM element
return ( selector.length && selector[selector.length - 1] !== undefined )
? jQuery.inArray( this, selector ) < 0
: this != selector;
}); });
}, },

4
test/unit/core.js
View file

@ -1058,11 +1058,13 @@ test("filter()", function() {
}); });
test("not()", function() { test("not()", function() {
expect(5); expect(7);
ok( $("#main > p#ap > a").not("#google").length == 2, "not('selector')" ); ok( $("#main > p#ap > a").not("#google").length == 2, "not('selector')" );
ok( $("#main > p#ap > a").not(document.getElementById("google")).length == 2, "not(DOMElement)" );
isSet( $("p").not(".result").get(), q("firstp", "ap", "sndp", "en", "sap", "first"), "not('.class')" ); isSet( $("p").not(".result").get(), q("firstp", "ap", "sndp", "en", "sap", "first"), "not('.class')" );
isSet( $("p").not("#ap, #sndp, .result").get(), q("firstp", "en", "sap", "first"), "not('selector, selector')" ); isSet( $("p").not("#ap, #sndp, .result").get(), q("firstp", "en", "sap", "first"), "not('selector, selector')" );
isSet( $("p").not($("#ap, #sndp, .result")).get(), q("firstp", "en", "sap", "first"), "not(jQuery)" ); isSet( $("p").not($("#ap, #sndp, .result")).get(), q("firstp", "en", "sap", "first"), "not(jQuery)" );
ok( $("p").not(document.getElementsByTagName("p")).length == 0, "not(Array-like DOM collection)" );
isSet( $("#form option").not("option.emptyopt:contains('Nothing'),[selected],[value='1']").get(), q("option1c", "option1d", "option2c", "option3d" ), "not('complex selector')"); isSet( $("#form option").not("option.emptyopt:contains('Nothing'),[selected],[value='1']").get(), q("option1c", "option1d", "option2c", "option3d" ), "not('complex selector')");
}); });