deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Make sure that .data() (no args) returns a list of all the data- properties as well. Also make sure that accessing a data- property via .data() doesn't cause it to change again at a later time (it should be static). Fixes #7222, #7223.

Browse source
This commit is contained in:
John Resig 2010-10-17 11:42:53 -04:00
parent a7d0b0b9e8
commit 8a5df39045
2 changed files with 66 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

23
test/unit/data.js
View file

@ -184,14 +184,17 @@ test(".data(String) and .data(String, Object)", function() {
});
test("data-* attributes", function() {
expect(27);
expect(33);
var div = jQuery("<div>"),
child = jQuery("<div data-myobj='old data' data-ignored=\"DOM\"></div>");
child = jQuery("<div data-myobj='old data' data-ignored=\"DOM\" data-other='test'></div>");
equals( div.data("attr"), undefined, "Check for non-existing data-attr attribute" );
div.attr("data-attr", "exists");
equals( div.data("attr"), "exists", "Check for existing data-attr attribute" );
div.attr("data-attr", "exists2");
equals( div.data("attr"), "exists", "Check that updates to data- don't update .data()" );
div.data("attr", "internal").attr("data-attr", "external");
equals( div.data("attr"), "internal", "Check for .data('attr') precedence (internal > external data-* attribute)" );
@ -205,6 +208,22 @@ test("data-* attributes", function() {
child.data("ignored", "cache");
equals( child.data("ignored"), "cache", "Cached data used before DOM data-* fallback");
var obj = child.data(), check = [ "myobj", "ignored", "other" ], num = 0;
for ( var i = 0, l = check.length; i < l; i++ ) {
ok( obj[ check[i] ], "Make sure data- property exists when calling data-." );
}
for ( var prop in obj ) {
num++;
}
equals( num, check.length, "Make sure that the right number of properties came through." );
child.attr("data-other", "newvalue");
equals( child.data("other"), "test", "Make sure value was pulled in properly from a .data()." );
child
.attr("data-true", "true")
.attr("data-false", "false")