deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Make sure that the correct args are passed in to the filter callback (and by extension, the not callback). Fixes #5594.

Browse source
This commit is contained in:
John Resig 2009-12-09 22:03:14 -08:00
parent a5f8a14411
commit 88572ee692
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/traversing.js
View file

@ -8,7 +8,7 @@ var runtil = /Until$/,
var winnow = function( elements, qualifier, keep ) {
if ( jQuery.isFunction( qualifier ) ) {
return jQuery.grep(elements, function(elem, i) {
return !!qualifier.call( elem, i ) === keep;
return !!qualifier.call( elem, i, elem ) === keep;
});
} else if ( qualifier.nodeType ) {

4
test/unit/traversing.js
View file

@ -64,9 +64,11 @@ test("filter(Selector)", function() {
});
test("filter(Function)", function() {
expect(1);
expect(2);
same( jQuery("p").filter(function() { return !jQuery("a", this).length }).get(), q("sndp", "first"), "filter(Function)" );
same( jQuery("p").filter(function(i, elem) { return !jQuery("a", elem).length }).get(), q("sndp", "first"), "filter(Function) using arg" );
});
test("filter(Element)", function() {