deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Handle changing form attributes correctly when there is a child element with the same name. Fixes #4299

Browse source
This commit is contained in:
David Petersen 2009-12-08 07:43:36 +08:00 • committed by John Resig
parent d3dc2d1234
commit 841f9ff7a1
2 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/attributes.js
View file

@ -218,8 +218,14 @@ jQuery.extend({
if ( name == "type" && /(button|input)/i.test(elem.nodeName) && elem.parentNode ) { if ( name == "type" && /(button|input)/i.test(elem.nodeName) && elem.parentNode ) {
throw "type property can't be changed"; throw "type property can't be changed";
} }
// browsers index elements by id/name on forms, give priority to attributes.
if( jQuery.nodeName( elem, "form" ) ) {
// convert the value to a string (all browsers do this but IE) see #1070
elem.setAttribute( name, "" + value );
} else {
elem[ name ] = value; elem[ name ] = value;
} }
}
// browsers index elements by id/name on forms, give priority to attributes. // browsers index elements by id/name on forms, give priority to attributes.
if( jQuery.nodeName( elem, "form" ) && elem.getAttributeNode(name) ) { if( jQuery.nodeName( elem, "form" ) && elem.getAttributeNode(name) ) {

3
test/unit/attributes.js
View file

@ -1,7 +1,7 @@
module("attributes"); module("attributes");
test("attr(String)", function() { test("attr(String)", function() {
expect(27); expect(28);
// This one sometimes fails randomally ?! // This one sometimes fails randomally ?!
equals( jQuery('#text1').attr('value'), "Test", 'Check for value attribute' ); equals( jQuery('#text1').attr('value'), "Test", 'Check for value attribute' );
@ -18,6 +18,7 @@ test("attr(String)", function() {
equals( jQuery('#name').attr('name'), "name", 'Check for name attribute' ); equals( jQuery('#name').attr('name'), "name", 'Check for name attribute' );
equals( jQuery('#text1').attr('name'), "action", 'Check for name attribute' ); equals( jQuery('#text1').attr('name'), "action", 'Check for name attribute' );
ok( jQuery('#form').attr('action').indexOf("formaction") >= 0, 'Check for action attribute' ); ok( jQuery('#form').attr('action').indexOf("formaction") >= 0, 'Check for action attribute' );
ok( jQuery('#form').attr('action','newformaction').attr('action').indexOf("newformaction") >= 0, 'Check that action attribute was changed' );
equals( jQuery('#text1').attr('maxlength'), '30', 'Check for maxlength attribute' ); equals( jQuery('#text1').attr('maxlength'), '30', 'Check for maxlength attribute' );
equals( jQuery('#text1').attr('maxLength'), '30', 'Check for maxLength attribute' ); equals( jQuery('#text1').attr('maxLength'), '30', 'Check for maxLength attribute' );
equals( jQuery('#area1').attr('maxLength'), '30', 'Check for maxLength attribute' ); equals( jQuery('#area1').attr('maxLength'), '30', 'Check for maxLength attribute' );