deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Make sure that unbinding on a plain javascript object works correctly. Fixes #6184.

Browse source
This commit is contained in:
jeresig 2010-02-26 11:32:12 -05:00
parent 28b489bfc8
commit 7f5179b654
2 changed files with 35 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/event.js
View file

@ -525,10 +525,14 @@ jQuery.event = {
var removeEvent = document.removeEventListener ?
function( elem, type, handle ) {
elem.removeEventListener( type, handle, false );
if ( elem.removeEventListener ) {
elem.removeEventListener( type, handle, false );
}
} :
function( elem, type, handle ) {
elem.detachEvent( "on" + type, handle );
if ( elem.detachEvent ) {
elem.detachEvent( "on" + type, handle );
}
};
jQuery.Event = function( src ) {

29
test/unit/event.js
View file

@ -373,6 +373,35 @@ test("bind(), with different this object", function() {
ok( !jQuery.data(jQuery("#firstp")[0], "events"), "Event handler unbound when using different this object and data." );
});
test("bind()/trigger()/unbind() on plain object", function() {
expect( 2 );
var obj = {};
// Make sure it doesn't complain when no events are found
jQuery(obj).trigger("test");
// Make sure it doesn't complain when no events are found
jQuery(obj).unbind("test");
jQuery(obj).bind("test", function(){
ok( true, "Custom event run." );
});
ok( jQuery(obj).data("events"), "Object has events bound." );
// Should trigger 1
jQuery(obj).trigger("test");
jQuery(obj).unbind("test");
// Should trigger 0
jQuery(obj).trigger("test");
// Make sure it doesn't complain when no events are found
jQuery(obj).unbind("test");
});
test("unbind(type)", function() {
expect( 0 );