deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Normalize css property names to lowercase for comparisons on a .attr('style') call since IE uppercases everything

Browse source
This commit is contained in:
timmywil 2011-04-03 18:47:44 -04:00
parent ad2b3bc9f9
commit 6f79bee3e3
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/attributes.js
View file

@ -477,7 +477,8 @@ if ( !jQuery.support.style ) {
jQuery.attrHooks.style = { jQuery.attrHooks.style = {
get: function( elem ) { get: function( elem ) {
// Return undefined in the case of empty string // Return undefined in the case of empty string
return elem.style.cssText || undefined; // Normalize to lowercase since IE uppercases css property names
return elem.style.cssText.toLowerCase() || undefined;
}, },
set: function( elem, value ) { set: function( elem, value ) {
return (elem.style.cssText = "" + value); return (elem.style.cssText = "" + value);

4
test/unit/attributes.js
View file

@ -135,8 +135,8 @@ test("attr(String)", function() {
equals( $img.attr('height'), "53", "Retrieve height attribute an an element with display:none." ); equals( $img.attr('height'), "53", "Retrieve height attribute an an element with display:none." );
// Check for style support // Check for style support
ok( !!~jQuery('#dl').attr('style').indexOf('absolute'), 'Check style attribute getter' ); ok( !!~jQuery('#dl').attr('style').indexOf('position'), 'Check style attribute getter, also normalize css props to lowercase' );
ok( !!~jQuery('#foo').attr('style', 'position:absolute;').attr('style').indexOf('absolute'), 'Check style setter' ); ok( !!~jQuery('#foo').attr('style', 'position:absolute;').attr('style').indexOf('position'), 'Check style setter' );
ok( jQuery("<div/>").attr("doesntexist") === undefined, "Make sure undefined is returned when no attribute is found." ); ok( jQuery("<div/>").attr("doesntexist") === undefined, "Make sure undefined is returned when no attribute is found." );
ok( jQuery().attr("doesntexist") === undefined, "Make sure undefined is returned when no element is there." ); ok( jQuery().attr("doesntexist") === undefined, "Make sure undefined is returned when no element is there." );