deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Use prop to retrieve boolean properties (so the selected hook will be used)

Browse source
This commit is contained in:
timmywil 2011-05-12 19:42:53 -04:00
parent ec829431fe
commit 6f676e692d
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/attributes.js
View file

@ -466,7 +466,7 @@ jQuery.extend({
boolHook = { boolHook = {
get: function( elem, name ) { get: function( elem, name ) {
// Align boolean attributes with corresponding properties // Align boolean attributes with corresponding properties
return elem[ jQuery.propFix[ name ] || name ] ? return jQuery.prop( elem, name ) ?
name.toLowerCase() : name.toLowerCase() :
undefined; undefined;
}, },

8
test/unit/attributes.js
View file

@ -40,7 +40,7 @@ test("jQuery.attrFix/jQuery.propFix integrity test", function() {
}); });
test("attr(String)", function() { test("attr(String)", function() {
expect(37); expect(38);
equals( jQuery("#text1").attr("type"), "text", "Check for type attribute" ); equals( jQuery("#text1").attr("type"), "text", "Check for type attribute" );
equals( jQuery("#radio1").attr("type"), "radio", "Check for type attribute" ); equals( jQuery("#radio1").attr("type"), "radio", "Check for type attribute" );
@ -92,6 +92,12 @@ test("attr(String)", function() {
body.removeAttribute("foo"); // Cleanup body.removeAttribute("foo"); // Cleanup
var select = document.createElement("select"), optgroup = document.createElement("optgroup"), option = document.createElement("option");
optgroup.appendChild( option );
select.appendChild( optgroup );
equal( jQuery( option ).attr("selected"), "selected", "Make sure that a single option is selected, even when in an optgroup." );
var $img = jQuery("<img style='display:none' width='215' height='53' src='http://static.jquery.com/files/rocker/images/logo_jquery_215x53.gif'/>").appendTo("body"); var $img = jQuery("<img style='display:none' width='215' height='53' src='http://static.jquery.com/files/rocker/images/logo_jquery_215x53.gif'/>").appendTo("body");
equals( $img.attr("width"), "215", "Retrieve width attribute an an element with display:none." ); equals( $img.attr("width"), "215", "Retrieve width attribute an an element with display:none." );
equals( $img.attr("height"), "53", "Retrieve height attribute an an element with display:none." ); equals( $img.attr("height"), "53", "Retrieve height attribute an an element with display:none." );