Implemented a better error handling for ajax requests. Exceptions caused by dropping connections are now handled, too.

This commit is contained in:
Jörn Zaefferer 2006-12-21 13:35:32 +00:00
parent 0f5292b991
commit 6b8ffe79f4
4 changed files with 63 additions and 53 deletions

View file

@ -35,7 +35,10 @@ function process() {
function stop() { function stop() {
_config.blocking = true; _config.blocking = true;
_config.timeout = setTimeout(start, _config.asyncTimeout * 1000); _config.timeout = setTimeout(function() {
ok( false, "Test timed out" );
start();
}, _config.asyncTimeout * 1000);
} }
function start() { function start() {
if(_config.timeout) if(_config.timeout)

View file

@ -12,6 +12,7 @@ New and Noteworthy
- Improved jQuery.merge to avoid unnecessary loops - Improved jQuery.merge to avoid unnecessary loops
- Fixed docs for html(): Now mentions that is not available for XML documents - Fixed docs for html(): Now mentions that is not available for XML documents
- Improved docs for blur() and focus(), mentioning the difference between calling the jQuery method and the DOM method - Improved docs for blur() and focus(), mentioning the difference between calling the jQuery method and the DOM method
- Implemented a better error handling for ajax requests. Exceptions caused by dropping connections are now handled, too.
1.0.4 1.0.4
----- -----

View file

@ -207,7 +207,8 @@ if ( jQuery.browser.msie && typeof XMLHttpRequest == "undefined" )
* Attach a function to be executed whenever an AJAX request fails. * Attach a function to be executed whenever an AJAX request fails.
* *
* The XMLHttpRequest and settings used for that request are passed * The XMLHttpRequest and settings used for that request are passed
* as arguments to the callback. * as arguments to the callback. A third argument, an exception object,
* is passed if an exception occured while processing the request.
* *
* @example $("#msg").ajaxError(function(request, settings){ * @example $("#msg").ajaxError(function(request, settings){
* $(this).append("<li>Error requesting page " + settings.url + "</li>"); * $(this).append("<li>Error requesting page " + settings.url + "</li>");
@ -480,8 +481,9 @@ jQuery.extend({
* like ajaxStart or ajaxStop are triggered. * like ajaxStart or ajaxStop are triggered.
* *
* (Function) error - A function to be called if the request fails. The * (Function) error - A function to be called if the request fails. The
* function gets passed two arguments: The XMLHttpRequest object and a * function gets passed tree arguments: The XMLHttpRequest object, a
* string describing the type of error that occurred. * string describing the type of error that occurred and an optional
* exception object, if one occured.
* *
* (Function) success - A function to be called if the request succeeds. The * (Function) success - A function to be called if the request succeeds. The
* function gets passed one argument: The data returned from the server, * function gets passed one argument: The data returned from the server,
@ -618,10 +620,10 @@ jQuery.extend({
// The transfer is complete and the data is available, or the request timed out // The transfer is complete and the data is available, or the request timed out
if ( xml && (xml.readyState == 4 || isTimeout == "timeout") ) { if ( xml && (xml.readyState == 4 || isTimeout == "timeout") ) {
requestDone = true; requestDone = true;
var status;
var status = jQuery.httpSuccess( xml ) && isTimeout != "timeout" ? try {
status = jQuery.httpSuccess( xml ) && isTimeout != "timeout" ?
s.ifModified && jQuery.httpNotModified( xml, s.url ) ? "notmodified" : "success" : "error"; s.ifModified && jQuery.httpNotModified( xml, s.url ) ? "notmodified" : "success" : "error";
// Make sure that the request was successful or notmodified // Make sure that the request was successful or notmodified
if ( status != "error" ) { if ( status != "error" ) {
// Cache Last-Modified header, if ifModified mode. // Cache Last-Modified header, if ifModified mode.
@ -643,15 +645,10 @@ jQuery.extend({
// Fire the global callback // Fire the global callback
if( s.global ) if( s.global )
jQuery.event.trigger( "ajaxSuccess", [xml, s] ); jQuery.event.trigger( "ajaxSuccess", [xml, s] );
}
// Otherwise, the request was not successful } catch(e) {
} else { status = "error";
// If a local callback was specified, fire it jQuery.handleError(s, xml, status, e);
if ( s.error ) s.error( xml, status );
// Fire the global callback
if( s.global )
jQuery.event.trigger( "ajaxError", [xml, s] );
} }
// The request was completed // The request was completed
@ -691,35 +688,42 @@ jQuery.extend({
var xml2 = xml; var xml2 = xml;
// Send the data // Send the data
try {
xml2.send(s.data); xml2.send(s.data);
} catch(e) {
jQuery.handleError(s, xml, null, e);
}
// return XMLHttpRequest to allow aborting the request etc. // return XMLHttpRequest to allow aborting the request etc.
return xml2; return xml2;
}, },
handleError: function(s, xml, status, e) {
// If a local callback was specified, fire it
if ( s.error ) s.error( xml, status, e );
// Fire the global callback
if( s.global )
jQuery.event.trigger( "ajaxError", [xml, s, e] );
},
// Counter for holding the number of active queries // Counter for holding the number of active queries
active: 0, active: 0,
// Determines if an XMLHttpRequest was successful or not // Determines if an XMLHttpRequest was successful or not
httpSuccess: function(r) { httpSuccess: function(r) {
try {
return !r.status && location.protocol == "file:" || return !r.status && location.protocol == "file:" ||
( r.status >= 200 && r.status < 300 ) || r.status == 304 || ( r.status >= 200 && r.status < 300 ) || r.status == 304 ||
jQuery.browser.safari && r.status == undefined; jQuery.browser.safari && r.status == undefined;
} catch(e){}
return false;
}, },
// Determines if an XMLHttpRequest returns NotModified // Determines if an XMLHttpRequest returns NotModified
httpNotModified: function(xml, url) { httpNotModified: function(xml, url) {
try {
var xmlRes = xml.getResponseHeader("Last-Modified"); var xmlRes = xml.getResponseHeader("Last-Modified");
// Firefox always returns 200. check Last-Modified date // Firefox always returns 200. check Last-Modified date
return xml.status == 304 || xmlRes == jQuery.lastModified[url] || return xml.status == 304 || xmlRes == jQuery.lastModified[url] ||
jQuery.browser.safari && xml.status == undefined; jQuery.browser.safari && xml.status == undefined;
} catch(e){}
return false;
}, },
/* Get the data out of an XMLHttpRequest. /* Get the data out of an XMLHttpRequest.

View file

@ -234,6 +234,8 @@ test("$.ajaxTimeout(Number) - with global timeout", function() {
error: pass, error: pass,
success: fail success: fail
}); });
// reset timeout
$.ajaxTimeout(0);
}); });
test("$.ajaxTimeout(Number) with localtimeout", function() { test("$.ajaxTimeout(Number) with localtimeout", function() {