deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Rewrote the hide and show methods to fix the issue with Safari not hiding distached elements. Fixed #1239, #2233, #3038, #3343, #3395. They're also faster now, as well.

Browse source
This commit is contained in:
John Resig 2008-12-19 18:21:12 +00:00
parent 18ee5a93a2
commit 5c1725d689
1 changed files with 45 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

67
src/fx.js
View file

@ -1,33 +1,56 @@
var elemdisplay = {};
jQuery.fn.extend({ jQuery.fn.extend({
show: function(speed,callback){ show: function(speed,callback){
return speed ? if ( speed ) {
this.animate({ return this.animate({
height: "show", width: "show", opacity: "show" height: "show", width: "show", opacity: "show"
}, speed, callback) : }, speed, callback);
} else {
this.filter(":hidden").each(function(){ for ( var i = 0, l = this.length; i < l; i++ ){
this.style.display = this.oldblock || ""; var old = jQuery.data(this[i], "olddisplay");
if ( jQuery.css(this,"display") == "none" ) {
var elem = jQuery("<" + this.tagName + " />").appendTo("body"); this[i].style.display = old || "";
this.style.display = elem.css("display");
// handle an edge condition where css is - div { display:none; } or similar if ( jQuery.css(this[i], "display") === "none" ) {
if (this.style.display == "none") var tagName = this[i].tagName, display;
this.style.display = "block";
elem.remove(); if ( elemdisplay[ tagName ] ) {
display = elemdisplay[ tagName ];
} else {
var elem = jQuery("<" + this[i].tagName + " />").appendTo("body");
display = elem.css("display");
if ( display === "none" )
display = "block";
elem.remove();
elemdisplay[ this[i].tagName ] = display;
}
this[i].style.display = jQuery.data(this[i], "olddisplay", display);
} }
}).end(); }
return this;
}
}, },
hide: function(speed,callback){ hide: function(speed,callback){
return speed ? if ( speed ) {
this.animate({ return this.animate({
height: "hide", width: "hide", opacity: "hide" height: "hide", width: "hide", opacity: "hide"
}, speed, callback) : }, speed, callback);
} else {
this.filter(":visible").each(function(){ for ( var i = 0, l = this.length; i < l; i++ ){
this.oldblock = this.oldblock || jQuery.css(this,"display"); var old = jQuery.data(this[i], "olddisplay");
this.style.display = "none"; if ( !old && old !== "none" )
}).end(); jQuery.data(this[i], "olddisplay", jQuery.css(this[i], "display"));
this[i].style.display = "none";
}
return this;
}
}, },
// Save the old toggle function // Save the old toggle function