deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fix a potential error in the previous commit caused by the use of a separate index variable. Thanks to dmethvin for the review.

Browse source
This commit is contained in:
Colin Snover 2010-12-22 09:13:28 -06:00
parent faefbb1ad0
commit 5607bd8d53
1 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/manipulation.js
View file

@ -370,14 +370,18 @@ function root( elem, cur ) {
} }
function cloneCopyEvent(orig, ret) { function cloneCopyEvent(orig, ret) {
var i = 0; ret.each(function (nodeIndex) {
if ( this.nodeType !== 1 || !jQuery.hasData(orig[nodeIndex]) ) {
ret.each(function() {
if ( this.nodeType !== 1 || this.nodeName !== (orig[i] && orig[i].nodeName) || !jQuery.hasData(orig[i]) ) {
return; return;
} }
var oldData = jQuery.data( orig[i++] ), // XXX remove for 1.5 RC or merge back in if there is actually a reason for this check that has been
// unexposed by unit tests
if ( this.nodeName !== (orig[nodeIndex] && orig[nodeIndex].nodeName) ) {
throw "Cloned data mismatch";
}
var oldData = jQuery.data( orig[nodeIndex] ),
curData = jQuery.data( this, jQuery.extend(true, {}, oldData) ), curData = jQuery.data( this, jQuery.extend(true, {}, oldData) ),
events = oldData && oldData.events; events = oldData && oldData.events;