From 9f8cd6c499844451468257140e71f611abb3a040 Mon Sep 17 00:00:00 2001
From: Gianni Chiappetta <gianni@runlevel6.org>
Date: Tue, 14 Dec 2010 21:53:04 -0500
Subject: [PATCH 01/91] Fixing $.proxy to work like (and use)
 Function.prototype.bind (ticket #7783)

http://bugs.jquery.com/ticket/7783
---
 src/core.js       | 49 +++++++++++++++++++++++++++++------------------
 src/event.js      | 44 ++++++++++++++++++++++++++----------------
 test/unit/core.js | 11 ++++++++---
 3 files changed, 65 insertions(+), 39 deletions(-)

diff --git a/src/core.js b/src/core.js
index 346e52d7..74ec4ea0 100644
--- a/src/core.js
+++ b/src/core.js
@@ -740,31 +740,42 @@ jQuery.extend({
 	// A global GUID counter for objects
 	guid: 1,
 
-	proxy: function( fn, proxy, thisObject ) {
-		if ( arguments.length === 2 ) {
-			if ( typeof proxy === "string" ) {
-				thisObject = fn;
-				fn = thisObject[ proxy ];
-				proxy = undefined;
+	// Bind a function to a context, optionally partially applying any
+	// arguments.
+	proxy: function( fn, context ) {
+		var args, proxy;
 
-			} else if ( proxy && !jQuery.isFunction( proxy ) ) {
-				thisObject = proxy;
-				proxy = undefined;
+		// Quick check to determine if target is callable, in the spec
+		// this throws a TypeError, but we will just return undefined.
+		if ( ! jQuery.isFunction( fn ) ) {
+			return undefined;
+		}
+
+		if ( jQuery.isFunction( Function.prototype.bind ) ) {
+			// Native bind
+			args = slice.call( arguments, 1 );
+			proxy = Function.prototype.bind.apply( fn, args );
+		} else {
+			// Simulated bind
+			args = slice.call( arguments, 2 );
+			if ( args.length ) {
+				proxy = function() {
+					return arguments.length ?
+						fn.apply( context, args.concat( slice.call( arguments ) ) ) :
+						fn.apply( context, args );
+				};
+			} else {
+				proxy = function() {
+					return arguments.length ?
+						fn.apply( context, arguments ) :
+						fn.call( context );
+				};
 			}
 		}
 
-		if ( !proxy && fn ) {
-			proxy = function() {
-				return fn.apply( thisObject || this, arguments );
-			};
-		}
-
 		// Set the guid of unique handler to the same of original handler, so it can be removed
-		if ( fn ) {
-			proxy.guid = fn.guid = fn.guid || proxy.guid || jQuery.guid++;
-		}
+		proxy.guid = fn.guid = fn.guid || proxy.guid || jQuery.guid++;
 
-		// So proxy can be declared as an argument
 		return proxy;
 	},
 
diff --git a/src/event.js b/src/event.js
index fd470e71..82e9b52d 100644
--- a/src/event.js
+++ b/src/event.js
@@ -891,6 +891,8 @@ if ( document.addEventListener ) {
 
 jQuery.each(["bind", "one"], function( i, name ) {
 	jQuery.fn[ name ] = function( type, data, fn ) {
+		var handler;
+
 		// Handle object literals
 		if ( typeof type === "object" ) {
 			for ( var key in type ) {
@@ -904,10 +906,15 @@ jQuery.each(["bind", "one"], function( i, name ) {
 			data = undefined;
 		}
 
-		var handler = name === "one" ? jQuery.proxy( fn, function( event ) {
-			jQuery( this ).unbind( event, handler );
-			return fn.apply( this, arguments );
-		}) : fn;
+		if ( name === "one" ) {
+			handler = function( event ) {
+				jQuery( this ).unbind( event, handler );
+				return fn.apply( this, arguments );
+			};
+			handler.guid = fn.guid || jQuery.guid++;
+		} else {
+			handler = fn;
+		}
 
 		if ( type === "unload" && name !== "one" ) {
 			this.one( type, data, fn );
@@ -971,24 +978,27 @@ jQuery.fn.extend({
 	toggle: function( fn ) {
 		// Save reference to arguments for access in closure
 		var args = arguments,
-			i = 1;
+			guid = fn.guid || jQuery.guid++,
+			i = 0,
+			toggler = function( event ) {
+				// Figure out which function to execute
+				var lastToggle = ( jQuery.data( this, "lastToggle" + fn.guid ) || 0 ) % i;
+				jQuery.data( this, "lastToggle" + fn.guid, lastToggle + 1 );
+
+				// Make sure that clicks stop
+				event.preventDefault();
+
+				// and execute the function
+				return args[ lastToggle ].apply( this, arguments ) || false;
+			};
 
 		// link all the functions, so any of them can unbind this click handler
+		toggler.guid = guid;
 		while ( i < args.length ) {
-			jQuery.proxy( fn, args[ i++ ] );
+			args[ i++ ].guid = guid;
 		}
 
-		return this.click( jQuery.proxy( fn, function( event ) {
-			// Figure out which function to execute
-			var lastToggle = ( jQuery.data( this, "lastToggle" + fn.guid ) || 0 ) % i;
-			jQuery.data( this, "lastToggle" + fn.guid, lastToggle + 1 );
-
-			// Make sure that clicks stop
-			event.preventDefault();
-
-			// and execute the function
-			return args[ lastToggle ].apply( this, arguments ) || false;
-		}));
+		return this.click( toggler );
 	},
 
 	hover: function( fnOver, fnOut ) {
diff --git a/test/unit/core.js b/test/unit/core.js
index 70577837..9f9078a4 100644
--- a/test/unit/core.js
+++ b/test/unit/core.js
@@ -858,7 +858,7 @@ test("jQuery.isEmptyObject", function(){
 });
 
 test("jQuery.proxy", function(){
-	expect(4);
+	expect(5);
 
 	var test = function(){ equals( this, thisObject, "Make sure that scope is set properly." ); };
 	var thisObject = { foo: "bar", method: test };
@@ -872,8 +872,13 @@ test("jQuery.proxy", function(){
 	// Make sure it doesn't freak out
 	equals( jQuery.proxy( null, thisObject ), undefined, "Make sure no function was returned." );
 
-	// Use the string shortcut
-	jQuery.proxy( thisObject, "method" )();
+        // Partial application
+        var test2 = function( a ){ equals( a, "pre-applied", "Ensure arguments can be pre-applied." ); };
+        jQuery.proxy( test2, null, "pre-applied" )();
+
+        // Partial application w/ normal arguments
+        var test3 = function( a, b ){ equals( b, "normal", "Ensure arguments can be pre-applied and passed as usual." ); };
+        jQuery.proxy( test3, null, "pre-applied" )( "normal" );
 });
 
 test("jQuery.parseJSON", function(){

From 5b1b57850cfd4c92a4f9231581dff7faac489566 Mon Sep 17 00:00:00 2001
From: Gianni Chiappetta <gianni@runlevel6.org>
Date: Wed, 15 Dec 2010 18:31:10 -0500
Subject: [PATCH 02/91] Add a quick test to $.support for native bind.

As per the suggestion by ajpiano: https://github.com/gf3/jquery/commit/9f8cd6c499844451468257140e71f611abb3a040#commitcomment-218658
---
 src/core.js    | 2 +-
 src/support.js | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/core.js b/src/core.js
index 74ec4ea0..a6e2a46f 100644
--- a/src/core.js
+++ b/src/core.js
@@ -751,7 +751,7 @@ jQuery.extend({
 			return undefined;
 		}
 
-		if ( jQuery.isFunction( Function.prototype.bind ) ) {
+		if ( jQuery.support.nativeBind ) {
 			// Native bind
 			args = slice.call( arguments, 1 );
 			proxy = Function.prototype.bind.apply( fn, args );
diff --git a/src/support.js b/src/support.js
index 67b41c4a..2913d217 100644
--- a/src/support.js
+++ b/src/support.js
@@ -60,6 +60,9 @@
 		// (WebKit defaults to false instead of true, IE too, if it's in an optgroup)
 		optSelected: opt.selected,
 
+		// Test for native Function#bind.
+		nativeBind: jQuery.isFunction( Function.prototype.bind ),
+
 		// Will be defined later
 		deleteExpando: true,
 		optDisabled: false,

From 1ebb5ab3e1c670e04024cd949fa6f341e93c4487 Mon Sep 17 00:00:00 2001
From: Gianni Chiappetta <gianni@runlevel6.org>
Date: Thu, 16 Dec 2010 16:04:23 -0500
Subject: [PATCH 03/91] Added list of browsers that currently support
 Function#bind.

---
 src/support.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/support.js b/src/support.js
index 2913d217..1fd1c2a6 100644
--- a/src/support.js
+++ b/src/support.js
@@ -60,7 +60,8 @@
 		// (WebKit defaults to false instead of true, IE too, if it's in an optgroup)
 		optSelected: opt.selected,
 
-		// Test for native Function#bind.
+		// Test for presence of native Function#bind.
+                // Currently in: Chrome 7, FireFox 4
 		nativeBind: jQuery.isFunction( Function.prototype.bind ),
 
 		// Will be defined later

From 6bc9fc7c10a6dd2c8c7132307e63323a1f59d35f Mon Sep 17 00:00:00 2001
From: Gianni Chiappetta <gianni@runlevel6.org>
Date: Sat, 18 Dec 2010 19:17:37 -0500
Subject: [PATCH 04/91] Perf. improvement based on fearphage's suggestion
 (direct vs call vs apply).

---
 src/core.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/core.js b/src/core.js
index a6e2a46f..2ffcb911 100644
--- a/src/core.js
+++ b/src/core.js
@@ -754,7 +754,11 @@ jQuery.extend({
 		if ( jQuery.support.nativeBind ) {
 			// Native bind
 			args = slice.call( arguments, 1 );
-			proxy = Function.prototype.bind.apply( fn, args );
+			if ( args.length ) {
+				proxy = Function.prototype.bind.apply( fn, args );
+			} else {
+				proxy = fn.bind( context );
+			}
 		} else {
 			// Simulated bind
 			args = slice.call( arguments, 2 );

From ade531cfaa194eb13fa6307368d1e715f3be8326 Mon Sep 17 00:00:00 2001
From: Gianni Chiappetta <gianni@runlevel6.org>
Date: Sat, 18 Dec 2010 19:26:36 -0500
Subject: [PATCH 05/91] Noted which browsers don't support Function#bind.

---
 src/support.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/support.js b/src/support.js
index 1fd1c2a6..55c19d80 100644
--- a/src/support.js
+++ b/src/support.js
@@ -61,7 +61,7 @@
 		optSelected: opt.selected,
 
 		// Test for presence of native Function#bind.
-                // Currently in: Chrome 7, FireFox 4
+		// Not in: >= Chrome 6, >= FireFox 3, Safari 5?, IE 9?, Opera 11?
 		nativeBind: jQuery.isFunction( Function.prototype.bind ),
 
 		// Will be defined later

From 574ae3b1be555dbd5242532739cd8e0a34e0569c Mon Sep 17 00:00:00 2001
From: Gianni Chiappetta <gianni@runlevel6.org>
Date: Fri, 21 Jan 2011 10:33:50 -0500
Subject: [PATCH 06/91] added: Backcompatibility with old proxy syntax.

---
 src/core.js       | 6 ++++++
 test/unit/core.js | 6 +++++-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/src/core.js b/src/core.js
index 3bdedf53..ea3506a6 100644
--- a/src/core.js
+++ b/src/core.js
@@ -739,6 +739,12 @@ jQuery.extend({
 	proxy: function( fn, context ) {
 		var args, proxy;
 
+		// XXX BACKCOMPAT: Support old string method.
+		if ( typeof context === "string" ) {
+			fn = fn[ context ];
+			context = arguments[0];
+		}
+
 		// Quick check to determine if target is callable, in the spec
 		// this throws a TypeError, but we will just return undefined.
 		if ( ! jQuery.isFunction( fn ) ) {
diff --git a/test/unit/core.js b/test/unit/core.js
index 7638554a..332fc51e 100644
--- a/test/unit/core.js
+++ b/test/unit/core.js
@@ -869,7 +869,7 @@ test("jQuery.isEmptyObject", function(){
 });
 
 test("jQuery.proxy", function(){
-	expect(5);
+	expect(6);
 
 	var test = function(){ equals( this, thisObject, "Make sure that scope is set properly." ); };
 	var thisObject = { foo: "bar", method: test };
@@ -890,6 +890,10 @@ test("jQuery.proxy", function(){
         // Partial application w/ normal arguments
         var test3 = function( a, b ){ equals( b, "normal", "Ensure arguments can be pre-applied and passed as usual." ); };
         jQuery.proxy( test3, null, "pre-applied" )( "normal" );
+
+	// Test old syntax
+	var test4 = { meth: function( a ){ equals( a, "boom", "Ensure old syntax works." ); } };
+	jQuery.proxy( test4, "meth" )( "boom" );
 });
 
 test("jQuery.parseJSON", function(){

From ed48787ec58c12917faf47e3b95e043b2b6ded10 Mon Sep 17 00:00:00 2001
From: Timmy Willison <tim.willison@thisismedium.com>
Date: Mon, 24 Jan 2011 16:18:19 -0500
Subject: [PATCH 07/91] Fix bug #2773, jQuery.fn.is to accept JQuery and node
 objects, and a small fix for winnow getting an undefined selector

---
 src/traversing.js       |  5 ++--
 test/unit/traversing.js | 60 +++++++++++++++++++++++++++++++++++++----
 2 files changed, 58 insertions(+), 7 deletions(-)

diff --git a/src/traversing.js b/src/traversing.js
index 90601df5..f8d08fa9 100644
--- a/src/traversing.js
+++ b/src/traversing.js
@@ -60,7 +60,8 @@ jQuery.fn.extend({
 	},
 
 	is: function( selector ) {
-		return !!selector && jQuery.filter( selector, this ).length > 0;
+		return !!selector && (typeof selector === "string" ? jQuery.filter( selector, this ).length > 0 :
+			this.filter( selector ).length > 0);
 	},
 
 	closest: function( selectors, context ) {
@@ -286,7 +287,7 @@ function winnow( elements, qualifier, keep ) {
 			return retVal === keep;
 		});
 
-	} else if ( qualifier.nodeType ) {
+	} else if ( qualifier && qualifier.nodeType ) {
 		return jQuery.grep(elements, function( elem, i ) {
 			return (elem === qualifier) === keep;
 		});
diff --git a/test/unit/traversing.js b/test/unit/traversing.js
index 56fed220..a74ee08b 100644
--- a/test/unit/traversing.js
+++ b/test/unit/traversing.js
@@ -13,8 +13,8 @@ test("find(String)", function() {
 	same( jQuery("#main").find("> #foo > p").get(), q("sndp", "en", "sap"), "find child elements" );
 });
 
-test("is(String)", function() {
-	expect(26);
+test("is(String|undefined)", function() {
+	expect(27);
 	ok( jQuery('#form').is('form'), 'Check for element: A form must be a form' );
 	ok( !jQuery('#form').is('div'), 'Check for element: A form is not a div' );
 	ok( jQuery('#mark').is('.blog'), 'Check for class: Expected class "blog"' );
@@ -33,11 +33,13 @@ test("is(String)", function() {
 	ok( !jQuery('#foo').is(':has(ul)'), 'Check for child: Did not expect "ul" element' );
 	ok( jQuery('#foo').is(':has(p):has(a):has(code)'), 'Check for childs: Expected "p", "a" and "code" child elements' );
 	ok( !jQuery('#foo').is(':has(p):has(a):has(code):has(ol)'), 'Check for childs: Expected "p", "a" and "code" child elements, but no "ol"' );
+
 	ok( !jQuery('#foo').is(0), 'Expected false for an invalid expression - 0' );
 	ok( !jQuery('#foo').is(null), 'Expected false for an invalid expression - null' );
 	ok( !jQuery('#foo').is(''), 'Expected false for an invalid expression - ""' );
 	ok( !jQuery('#foo').is(undefined), 'Expected false for an invalid expression - undefined' );
-
+	ok( !jQuery('#foo').is({ plain: "object" }), 'Check passing invalid object' );
+	
 	// test is() with comma-seperated expressions
 	ok( jQuery('#en').is('[lang="en"],[lang="de"]'), 'Comma-seperated; Check for lang attribute: Expect en or de' );
 	ok( jQuery('#en').is('[lang="de"],[lang="en"]'), 'Comma-seperated; Check for lang attribute: Expect en or de' );
@@ -45,6 +47,49 @@ test("is(String)", function() {
 	ok( jQuery('#en').is('[lang="de"] , [lang="en"]'), 'Comma-seperated; Check for lang attribute: Expect en or de' );
 });
 
+test("is(Object)", function() {
+	expect(18);
+	ok( jQuery('#form').is( jQuery('form') ), 'Check for element: A form is a form' );
+	ok( !jQuery('#form').is( jQuery('div') ), 'Check for element: A form is not a div' );
+	ok( jQuery('#mark').is( jQuery('.blog') ), 'Check for class: Expected class "blog"' );
+	ok( !jQuery('#mark').is( jQuery('.link') ), 'Check for class: Did not expect class "link"' );
+	ok( jQuery('#simon').is( jQuery('.blog.link') ), 'Check for multiple classes: Expected classes "blog" and "link"' );
+	ok( !jQuery('#simon').is( jQuery('.blogTest') ), 'Check for multiple classes: Expected classes "blog" and "link", but not "blogTest"' );
+	ok( jQuery('#en').is( jQuery('[lang="en"]') ), 'Check for attribute: Expected attribute lang to be "en"' );
+	ok( !jQuery('#en').is( jQuery('[lang="de"]') ), 'Check for attribute: Expected attribute lang to be "en", not "de"' );
+	ok( jQuery('#text1').is( jQuery('[type="text"]') ), 'Check for attribute: Expected attribute type to be "text"' );
+	ok( !jQuery('#text1').is( jQuery('[type="radio"]') ), 'Check for attribute: Expected attribute type to be "text", not "radio"' );
+	ok( jQuery('#text2').is( jQuery(':disabled') ), 'Check for pseudoclass: Expected to be disabled' );
+	ok( !jQuery('#text1').is( jQuery(':disabled') ), 'Check for pseudoclass: Expected not disabled' );
+	ok( jQuery('#radio2').is( jQuery(':checked') ), 'Check for pseudoclass: Expected to be checked' );
+	ok( !jQuery('#radio1').is( jQuery(':checked') ), 'Check for pseudoclass: Expected not checked' );
+	ok( jQuery('#foo').is( jQuery(':has(p)') ), 'Check for child: Expected a child "p" element' );
+	ok( !jQuery('#foo').is( jQuery(':has(ul)') ), 'Check for child: Did not expect "ul" element' );
+	ok( jQuery('#foo').is( jQuery(':has(p):has(a):has(code)') ), 'Check for childs: Expected "p", "a" and "code" child elements' );
+	ok( !jQuery('#foo').is( jQuery(':has(p):has(a):has(code):has(ol)') ), 'Check for childs: Expected "p", "a" and "code" child elements, but no "ol"' );
+});
+
+test("is(node Object)", function() {
+	expect(17);
+	ok( jQuery('#form').is( jQuery('form')[0] ), 'Check for element: A form is a form' );
+	ok( !jQuery('#form').is( jQuery('div')[0] ), 'Check for element: A form is not a div' );
+	ok( jQuery('#mark').is( jQuery('.blog')[0] ), 'Check for class: Expected class "blog"' );
+	ok( !jQuery('#mark').is( jQuery('.link')[0] ), 'Check for class: Did not expect class "link"' );
+	ok( jQuery('#simon').is( jQuery('.blog.link')[0] ), 'Check for multiple classes: Expected classes "blog" and "link"' );
+	ok( !jQuery('#simon').is( jQuery('.blogTest')[0] ), 'Check for multiple classes: Expected classes "blog" and "link", but not "blogTest"' );
+	ok( jQuery('#en').is( jQuery('[lang="en"]')[1] ), 'Check for attribute: Expected attribute lang to be "en"' );
+	ok( !jQuery('#en').is( jQuery('[lang="de"]')[0] ), 'Check for attribute: Expected attribute lang to be "en", not "de"' );
+	ok( jQuery('#text1').is( jQuery('[type="text"]')[0] ), 'Check for attribute: Expected attribute type to be "text"' );
+	ok( !jQuery('#text1').is( jQuery('[type="radio"]')[0] ), 'Check for attribute: Expected attribute type to be "text", not "radio"' );
+	ok( jQuery('#text2').is( jQuery(':disabled')[0] ), 'Check for pseudoclass: Expected to be disabled' );
+	ok( !jQuery('#text1').is( jQuery(':disabled')[0] ), 'Check for pseudoclass: Expected not disabled' );
+	ok( !jQuery('#radio1').is( jQuery(':checked')[0] ), 'Check for pseudoclass: Expected not checked' );
+	ok( jQuery('#foo').is( jQuery(':has(p)')[4] ), 'Check for child: Expected a child "p" element' );
+	ok( !jQuery('#foo').is( jQuery(':has(ul)')[0] ), 'Check for child: Did not expect "ul" element' );
+	ok( jQuery('#foo').is( jQuery(':has(p):has(a):has(code)')[4] ), 'Check for childs: Expected "p", "a" and "code" child elements' );
+	ok( !jQuery('#foo').is( jQuery(':has(p):has(a):has(code):has(ol)')[0] ), 'Check for childs: Expected "p", "a" and "code" child elements, but no "ol"' );
+});
+
 test("index()", function() {
 	expect(1);
 
@@ -82,11 +127,16 @@ test("index(Object|String|undefined)", function() {
 	equals( jQuery('#radio2').index('#form :text') , -1, "Check for index not found within a selector" );
 });
 
-test("filter(Selector)", function() {
-	expect(5);
+test("filter(Selector|undefined)", function() {
+	expect(9);
 	same( jQuery("#form input").filter(":checked").get(), q("radio2", "check1"), "filter(String)" );
 	same( jQuery("p").filter("#ap, #sndp").get(), q("ap", "sndp"), "filter('String, String')" );
 	same( jQuery("p").filter("#ap,#sndp").get(), q("ap", "sndp"), "filter('String,String')" );
+	
+	same( jQuery('p').filter(null).get(),      [], "filter(null) should return an empty jQuery object");
+	same( jQuery('p').filter(undefined).get(), [], "filter(undefined) should return an empty jQuery object");
+	same( jQuery('p').filter(0).get(),         [], "filter(0) should return an empty jQuery object");
+	same( jQuery('p').filter('').get(),        [], "filter('') should return an empty jQuery object");
 
 	// using contents will get comments regular, text, and comment nodes
 	var j = jQuery("#nonnodes").contents();

From c8a887af066a62840ec1910604ddb7e0c38728e8 Mon Sep 17 00:00:00 2001
From: Jordan Boesch <jboesch26@gmail.com>
Date: Sun, 27 Feb 2011 12:47:35 -0600
Subject: [PATCH 08/91] Bug 2616; Adding object support to jQuery.map

---
 src/core.js       | 28 +++++++++++++++++++++-------
 test/unit/core.js | 12 +++++-------
 2 files changed, 26 insertions(+), 14 deletions(-)

diff --git a/src/core.js b/src/core.js
index 036b2db6..3ff12085 100644
--- a/src/core.js
+++ b/src/core.js
@@ -712,15 +712,29 @@ jQuery.extend({
 
 	// arg is for internal usage only
 	map: function( elems, callback, arg ) {
-		var ret = [], value;
+		var ret = [],
+			value,
+			length = elems.length,
+			// same object detection used in jQuery.each, not full-proof but very speedy.
+			isObj = length === undefined;
 
-		// Go through the array, translating each of the items to their
-		// new value (or values).
-		for ( var i = 0, length = elems.length; i < length; i++ ) {
-			value = callback( elems[ i ], i, arg );
+		if ( isObj ) {
+			for ( key in elems ) {
+				value = callback( elems[ key ], key, arg );
 
-			if ( value != null ) {
-				ret[ ret.length ] = value;
+				if ( value != null ) {
+					ret[ ret.length ] = value;
+				}
+			}
+		} else {
+			// Go through the array, translating each of the items to their
+			// new value (or values).
+			for ( var i = 0; i < length; i++ ) {
+				value = callback( elems[ i ], i, arg );
+
+				if ( value != null ) {
+					ret[ ret.length ] = value;
+				}
 			}
 		}
 
diff --git a/test/unit/core.js b/test/unit/core.js
index bce0de0f..d77e6a97 100644
--- a/test/unit/core.js
+++ b/test/unit/core.js
@@ -608,7 +608,7 @@ test("first()/last()", function() {
 });
 
 test("map()", function() {
-	expect(2);//expect(6);
+	expect(6);
 
 	same(
 		jQuery("#ap").map(function(){
@@ -625,26 +625,24 @@ test("map()", function() {
 		q("ap","ap","ap"),
 		"Single Map"
 	);
-
-	return;//these haven't been accepted yet
-
+	
 	//for #2616
 	var keys = jQuery.map( {a:1,b:2}, function( v, k ){
 		return k;
-	}, [ ] );
+	});
 
 	equals( keys.join(""), "ab", "Map the keys from a hash to an array" );
 
 	var values = jQuery.map( {a:1,b:2}, function( v, k ){
 		return v;
-	}, [ ] );
+	});
 
 	equals( values.join(""), "12", "Map the values from a hash to an array" );
 
 	var scripts = document.getElementsByTagName("script");
 	var mapped = jQuery.map( scripts, function( v, k ){
 		return v;
-	}, {length:0} );
+	});
 
 	equals( mapped.length, scripts.length, "Map an array(-like) to a hash" );
 

From d4e4414451e15d23d7174e8eeddaa952ed0e4d73 Mon Sep 17 00:00:00 2001
From: jeresig <jeresig@gmail.com>
Date: Sun, 6 Mar 2011 22:47:40 -0500
Subject: [PATCH 09/91] Very crude first pass at splitting apart the attr/prop
 logic. Also adding in attrHooks/propHooks. All of it is completely untested.

---
 src/attributes.js | 274 ++++++++++++++++++++++++++++------------------
 1 file changed, 168 insertions(+), 106 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index 59972105..e5425a05 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -3,38 +3,37 @@
 var rclass = /[\n\t\r]/g,
 	rspaces = /\s+/,
 	rreturn = /\r/g,
-	rspecialurl = /^(?:href|src|style)$/,
 	rtype = /^(?:button|input)$/i,
 	rfocusable = /^(?:button|input|object|select|textarea)$/i,
 	rclickable = /^a(?:rea)?$/i,
 	rradiocheck = /^(?:radio|checkbox)$/i;
 
-jQuery.props = {
-	"for": "htmlFor",
-	"class": "className",
-	readonly: "readOnly",
-	maxlength: "maxLength",
-	cellspacing: "cellSpacing",
-	rowspan: "rowSpan",
-	colspan: "colSpan",
-	tabindex: "tabIndex",
-	usemap: "useMap",
-	frameborder: "frameBorder"
-};
-
 jQuery.fn.extend({
 	attr: function( name, value ) {
 		return jQuery.access( this, name, value, true, jQuery.attr );
 	},
 
-	removeAttr: function( name, fn ) {
-		return this.each(function(){
-			jQuery.attr( this, name, "" );
+	removeAttr: function( name ) {
+		return this.each(function() {
 			if ( this.nodeType === 1 ) {
 				this.removeAttribute( name );
 			}
 		});
 	},
+	
+	prop: function( name, value ) {
+		return jQuery.access( this, name, value, true, jQuery.prop );
+	},
+	
+	removeProp: function( name ) {
+		return this.each(function() {
+			// try/catch handles cases where IE balks (such as removing a property on window)
+			try {
+				this[ name ] = undefined;
+				delete this[ name ];
+			} catch( e ) {}
+		});
+	},
 
 	addClass: function( value ) {
 		if ( jQuery.isFunction(value) ) {
@@ -275,6 +274,21 @@ jQuery.extend({
 		height: true,
 		offset: true
 	},
+	
+	// TODO: Check to see if any of these are needed anymore?
+	// If not, it may be good to standardize on all-lowercase names instead
+	attrFix: {
+		"for": "htmlFor",
+		"class": "className",
+		readonly: "readOnly",
+		maxlength: "maxLength",
+		cellspacing: "cellSpacing",
+		rowspan: "rowSpan",
+		colspan: "colSpan",
+		tabindex: "tabIndex",
+		usemap: "useMap",
+		frameborder: "frameBorder"
+	},
 
 	attr: function( elem, name, value, pass ) {
 		// don't get/set attributes on text, comment and attribute nodes
@@ -286,104 +300,152 @@ jQuery.extend({
 			return jQuery(elem)[name](value);
 		}
 
-		var notxml = elem.nodeType !== 1 || !jQuery.isXMLDoc( elem ),
-			// Whether we are setting (or getting)
-			set = value !== undefined;
-
+		var ret,
+			notxml = elem.nodeType !== 1 || !jQuery.isXMLDoc( elem ),
+			hooks;
+			
 		// Try to normalize/fix the name
-		name = notxml && jQuery.props[ name ] || name;
+		name = notxml && jQuery.attrFix[ name ] || name;
+		
+		hooks = jQuery.attrHooks[ name ];
+		
+		if ( value !== undefined ) {
+			
+			if ( hooks && "set" in hooks && notxml && (ret = hooks.set( elem, value )) !== undefined ) {
+				return ret;
+			
+			} else {
+				// convert the value to a string (all browsers do this but IE) see #1070
+				value = "" + value;
+				
+				elem.setAttribute( name, value );
+				
+				return value;
+			}
+			
+		} else {
+			
+			if ( hooks && "get" in hooks && notxml && (ret = hooks.get( elem )) !== undefined ) {
+				return ret;
+				
+			} else {
+				
+				if ( !jQuery.hasAttr( elem, name ) ) {
+					return undefined;
+				}
 
-		// Only do all the following if this is a node (faster for style)
-		if ( elem.nodeType === 1 ) {
-			// These attributes require special treatment
-			var special = rspecialurl.test( name );
+				var attr = elem.getAttribute( name );
 
-			// Safari mis-reports the default selected property of an option
-			// Accessing the parent's selectedIndex property fixes it
-			if ( name === "selected" && !jQuery.support.optSelected ) {
-				var parent = elem.parentNode;
-				if ( parent ) {
-					parent.selectedIndex;
-
-					// Make sure that it also works with optgroups, see #5701
-					if ( parent.parentNode ) {
-						parent.parentNode.selectedIndex;
-					}
+				// Non-existent attributes return null, we normalize to undefined
+				return attr === null ?
+					undefined :
+					attr;
+			}
+		}
+	},
+	
+	hasAttr: function( elem, name ) {
+		// Blackberry 4.7 returns "" from getAttribute #6938
+		return elem.attributes[ name ] || (elem.hasAttribute && elem.hasAttribute( name ));
+	},
+	
+	attrHooks: {
+		type: {
+			set: function( elem, value ) {
+				// We can't allow the type property to be changed (since it causes problems in IE)
+				if ( rtype.test( elem.nodeName ) && elem.parentNode ) {
+					jQuery.error( "type property can't be changed" );
 				}
 			}
+		},
+		
+		// elem.tabIndex doesn't always return the correct value when it hasn't been explicitly set
+		// http://fluidproject.org/blog/2008/01/09/getting-setting-and-removing-tabindex-values-with-javascript/
+		tabIndex: {
+			get: function( elem ) {
+				var attributeNode = elem.getAttributeNode( "tabIndex" );
 
-			// If applicable, access the attribute via the DOM 0 way
-			// 'in' checks fail in Blackberry 4.7 #6931
-			if ( (name in elem || elem[ name ] !== undefined) && notxml && !special ) {
-				if ( set ) {
-					// We can't allow the type property to be changed (since it causes problems in IE)
-					if ( name === "type" && rtype.test( elem.nodeName ) && elem.parentNode ) {
-						jQuery.error( "type property can't be changed" );
-					}
-
-					if ( value === null ) {
-						if ( elem.nodeType === 1 ) {
-							elem.removeAttribute( name );
-						}
-
-					} else {
-						elem[ name ] = value;
-					}
-				}
-
-				// browsers index elements by id/name on forms, give priority to attributes.
-				if ( jQuery.nodeName( elem, "form" ) && elem.getAttributeNode(name) ) {
-					return elem.getAttributeNode( name ).nodeValue;
-				}
-
-				// elem.tabIndex doesn't always return the correct value when it hasn't been explicitly set
-				// http://fluidproject.org/blog/2008/01/09/getting-setting-and-removing-tabindex-values-with-javascript/
-				if ( name === "tabIndex" ) {
-					var attributeNode = elem.getAttributeNode( "tabIndex" );
-
-					return attributeNode && attributeNode.specified ?
-						attributeNode.value :
-						rfocusable.test( elem.nodeName ) || rclickable.test( elem.nodeName ) && elem.href ?
-							0 :
-							undefined;
-				}
-
+				return attributeNode && attributeNode.specified ?
+					attributeNode.value :
+					rfocusable.test( elem.nodeName ) || rclickable.test( elem.nodeName ) && elem.href ?
+						0 :
+						undefined;
+			}
+		}
+	},
+	
+	// TODO: Check to see if we really need any here.
+	propFix: {},
+	
+	prop: function( elem, name, value ) {
+		var ret, hooks;
+		
+		// Try to normalize/fix the name
+		name = notxml && jQuery.propFix[ name ] || name;
+		
+		hooks = jQuery.propHooks[ name ];
+		
+		if ( value !== undefined ) {
+			if ( hooks && "set" in hooks && (ret = hooks.set( elem, value )) !== undefined ) {
+				return ret;
+			
+			} else {
+				return (elem[ name ] = value);
+			}
+		
+		} else {
+			if ( hooks && "get" in hooks && (ret = hooks.get( elem )) !== undefined ) {
+				return ret;
+				
+			} else {
 				return elem[ name ];
 			}
-
-			if ( !jQuery.support.style && notxml && name === "style" ) {
-				if ( set ) {
-					elem.style.cssText = "" + value;
-				}
-
-				return elem.style.cssText;
-			}
-
-			if ( set ) {
-				// convert the value to a string (all browsers do this but IE) see #1070
-				elem.setAttribute( name, "" + value );
-			}
-
-			// Ensure that missing attributes return undefined
-			// Blackberry 4.7 returns "" from getAttribute #6938
-			if ( !elem.attributes[ name ] && (elem.hasAttribute && !elem.hasAttribute( name )) ) {
-				return undefined;
-			}
-
-			var attr = !jQuery.support.hrefNormalized && notxml && special ?
-					// Some attributes require a special call on IE
-					elem.getAttribute( name, 2 ) :
-					elem.getAttribute( name );
-
-			// Non-existent attributes return null, we normalize to undefined
-			return attr === null ? undefined : attr;
 		}
-		// Handle everything which isn't a DOM element node
-		if ( set ) {
-			elem[ name ] = value;
-		}
-		return elem[ name ];
-	}
+	},
+	
+	propHooks: {}
 });
 
+// Some attributes require a special call on IE
+if ( !jQuery.support.hrefNormalized ) {
+	jQuery.each([ "href", "src", "style" ], function( i, name ) {
+		jQuery.attrHooks[ name ] = jQuery.extend( jQuery.attrHooks[ name ], {
+			get: function( elem ) {
+				return elem.getAttribute( name, 2 );
+			}
+		});
+	});
+}
+
+if ( !jQuery.support.style ) {
+	jQuery.attrHooks.style = {
+		get: function( elem ) {
+			return elem.style.cssText;
+		},
+		
+		set: function( elem, value ) {
+			return (elem.style.cssText = "" + value);
+		}
+	};
+}
+
+// Safari mis-reports the default selected property of an option
+// Accessing the parent's selectedIndex property fixes it
+if ( !jQuery.support.optSelected ) {
+	jQuery.attrHooks.selected = {
+		get: function( elem ) {
+			var parent = elem.parentNode;
+			
+			if ( parent ) {
+				parent.selectedIndex;
+
+				// Make sure that it also works with optgroups, see #5701
+				if ( parent.parentNode ) {
+					parent.parentNode.selectedIndex;
+				}
+			}
+		}
+	};
+}
+
 })( jQuery );

From 8246347b7191e79ed09bf1fc4c4a0a58211cf345 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Sun, 13 Mar 2011 21:12:10 -0400
Subject: [PATCH 10/91] Starting with adding the test

---
 test/unit/traversing.js | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/test/unit/traversing.js b/test/unit/traversing.js
index f5108bde..9216bb5e 100644
--- a/test/unit/traversing.js
+++ b/test/unit/traversing.js
@@ -13,6 +13,15 @@ test("find(String)", function() {
 	same( jQuery("#main").find("> #foo > p").get(), q("sndp", "en", "sap"), "find child elements" );
 });
 
+test("find(node|jQuery object)", function() {
+	expect( 2 );
+	
+	var $blog = jQuery('.blogTest'),
+		blog = $blog[0];
+	equals( jQuery('#foo').find( $blog ).text(), 'Yahoo', 'Find with blog jQuery object' );
+	equals( jQuery('#foo').find( blog ).text(), 'Yahoo', 'Find with blog node' );
+});
+
 test("is(String)", function() {
 	expect(26);
 	ok( jQuery('#form').is('form'), 'Check for element: A form must be a form' );

From 7a69e34a5cd4df37762cbee9c9468c96c0ac3017 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Wed, 16 Mar 2011 01:16:32 -0400
Subject: [PATCH 11/91] 2773: first pass adding node/jQuery object support to
 jQuery.fn.find; unit tests added

---
 src/core.js             |  2 +-
 src/traversing.js       | 23 ++++++++++++++++++-----
 test/unit/traversing.js | 25 ++++++++++++++++++++-----
 3 files changed, 39 insertions(+), 11 deletions(-)

diff --git a/src/core.js b/src/core.js
index 9312ee28..812ecde5 100644
--- a/src/core.js
+++ b/src/core.js
@@ -88,7 +88,7 @@ jQuery.fn = jQuery.prototype = {
 		if ( selector === "body" && !context && document.body ) {
 			this.context = document;
 			this[0] = document.body;
-			this.selector = "body";
+			this.selector = selector;
 			this.length = 1;
 			return this;
 		}
diff --git a/src/traversing.js b/src/traversing.js
index fe2e33d8..fa6aae2f 100644
--- a/src/traversing.js
+++ b/src/traversing.js
@@ -17,17 +17,30 @@ var runtil = /Until$/,
 
 jQuery.fn.extend({
 	find: function( selector ) {
-		var ret = this.pushStack( "", "find", selector ),
-			length = 0;
+		var self = this,
+			ret, i, l;
 
-		for ( var i = 0, l = this.length; i < l; i++ ) {
+		if ( typeof selector !== "string" ) {
+			return jQuery( selector ).filter(function() {
+				for ( i = 0, l = self.length; i < l; i++ ) {
+					if ( jQuery.contains( self[ i ], this ) ) {
+						return true;
+					}
+				}
+			});
+		}
+
+		ret = this.pushStack( "", "find", selector );
+		
+		var length, n, r;
+		for ( i = 0, l = this.length; i < l; i++ ) {
 			length = ret.length;
 			jQuery.find( selector, this[i], ret );
 
 			if ( i > 0 ) {
 				// Make sure that the results are unique
-				for ( var n = length; n < ret.length; n++ ) {
-					for ( var r = 0; r < length; r++ ) {
+				for ( n = length; n < ret.length; n++ ) {
+					for ( r = 0; r < length; r++ ) {
 						if ( ret[r] === ret[n] ) {
 							ret.splice(n--, 1);
 							break;
diff --git a/test/unit/traversing.js b/test/unit/traversing.js
index 9216bb5e..76b93d84 100644
--- a/test/unit/traversing.js
+++ b/test/unit/traversing.js
@@ -14,12 +14,27 @@ test("find(String)", function() {
 });
 
 test("find(node|jQuery object)", function() {
-	expect( 2 );
+	expect( 11 );
+	
+	var $foo = jQuery('#foo'),
+		$blog = jQuery('.blogTest'),
+		$first = jQuery('#first'),
+		$two = $blog.add( $first ),
+		$fooTwo = $foo.add( $blog );
+
+	equals( $foo.find( $blog ).text(), 'Yahoo', 'Find with blog jQuery object' );
+	equals( $foo.find( $blog[0] ).text(), 'Yahoo', 'Find with blog node' );
+	equals( $foo.find( $first ).length, 0, '#first is not in #foo' );
+	equals( $foo.find( $first[0]).length, 0, '#first not in #foo (node)' );
+	ok( $foo.find( $two ).is('.blogTest'), 'Find returns only nodes within #foo' );
+	ok( $fooTwo.find( $blog ).is('.blogTest'), 'Blog is part of the collection, but also within foo' );
+	ok( $fooTwo.find( $blog[0] ).is('.blogTest'), 'Blog is part of the collection, but also within foo(node)' );
+	
+	equals( $two.find( $foo ).length, 0, 'Foo is not in two elements' );
+	equals( $two.find( $foo[0] ).length, 0, 'Foo is not in two elements(node)' );
+	equals( $two.find( $first ).length, 0, 'first is in the collection and not within two' );
+	equals( $two.find( $first ).length, 0, 'first is in the collection and not within two(node)' );
 	
-	var $blog = jQuery('.blogTest'),
-		blog = $blog[0];
-	equals( jQuery('#foo').find( $blog ).text(), 'Yahoo', 'Find with blog jQuery object' );
-	equals( jQuery('#foo').find( blog ).text(), 'Yahoo', 'Find with blog node' );
 });
 
 test("is(String)", function() {

From 929792834f77e075e4b5397fb4b25b1a2dcbd49a Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Wed, 16 Mar 2011 14:41:26 -0400
Subject: [PATCH 12/91] Organizing vars

---
 src/traversing.js | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/traversing.js b/src/traversing.js
index fa6aae2f..30d60435 100644
--- a/src/traversing.js
+++ b/src/traversing.js
@@ -18,7 +18,7 @@ var runtil = /Until$/,
 jQuery.fn.extend({
 	find: function( selector ) {
 		var self = this,
-			ret, i, l;
+			i, l;
 
 		if ( typeof selector !== "string" ) {
 			return jQuery( selector ).filter(function() {
@@ -30,9 +30,8 @@ jQuery.fn.extend({
 			});
 		}
 
-		ret = this.pushStack( "", "find", selector );
-		
-		var length, n, r;
+		var ret = this.pushStack( "", "find", selector ),
+			length, n, r;
 		for ( i = 0, l = this.length; i < l; i++ ) {
 			length = ret.length;
 			jQuery.find( selector, this[i], ret );

From 2407690ef9b3ec59920917935dc1a312f6c2b56e Mon Sep 17 00:00:00 2001
From: Dan Heberden <danheberden@gmail.com>
Date: Mon, 21 Mar 2011 08:10:27 -0700
Subject: [PATCH 13/91] Fixes 2616; Pull in #252 by jboesch: jQuery.map with
 object support

---
 test/qunit | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/qunit b/test/qunit
index d404faf8..cc8460c7 160000
--- a/test/qunit
+++ b/test/qunit
@@ -1 +1 @@
-Subproject commit d404faf8f587fcbe6b8907943022e6318dd51e0c
+Subproject commit cc8460c7b44f023c4f84ab1810b72bf6c6ee4542

From e38f074d14fd65b3f8b0e1bd7956cd75b3dafe2b Mon Sep 17 00:00:00 2001
From: Dan Heberden <danheberden@gmail.com>
Date: Mon, 21 Mar 2011 08:39:53 -0700
Subject: [PATCH 14/91] jQuery.map to conform with style guidelines - improved
 size/DRY code

---
 src/core.js | 32 +++++++++++++++++---------------
 1 file changed, 17 insertions(+), 15 deletions(-)

diff --git a/src/core.js b/src/core.js
index 1077d38c..a0dd7b5b 100644
--- a/src/core.js
+++ b/src/core.js
@@ -706,29 +706,31 @@ jQuery.extend({
 
 	// arg is for internal usage only
 	map: function( elems, callback, arg ) {
-		var ret = [],
-			value,
+		var ret = [], value, i = 0,
 			length = elems.length,
 			// same object detection used in jQuery.each, not full-proof but very speedy.
 			isObj = length === undefined;
-
-		if ( isObj ) {
-			for ( key in elems ) {
-				value = callback( elems[ key ], key, arg );
-
+			
+			// the work for the loops - run elems[x] through callback
+			inLoop = function( key ) {
+			  value = callback( elems[ key ], key, arg );
+			  
 				if ( value != null ) {
 					ret[ ret.length ] = value;
 				}
 			}
-		} else {
-			// Go through the array, translating each of the items to their
-			// new value (or values).
-			for ( var i = 0; i < length; i++ ) {
-				value = callback( elems[ i ], i, arg );
 
-				if ( value != null ) {
-					ret[ ret.length ] = value;
-				}
+    // Go thorugh every key on the object
+		if ( isObj ) {
+			for ( key in elems ) {
+			  inLoop( key );
+			}
+		
+		// Go through the array, translating each of the items to their
+		// new value (or values).
+		} else {			
+			for ( ; i < length; i++ ) {
+				inLoop( i );
 			}
 		}
 

From d832f4f71ec51e67d4cae2557221ef582818f607 Mon Sep 17 00:00:00 2001
From: Dan Heberden <danheberden@gmail.com>
Date: Mon, 21 Mar 2011 12:12:31 -0700
Subject: [PATCH 15/91] jQuery.map to iterate over objects with a .length
 property

---
 src/core.js       | 40 ++++++++++++++++++++--------------------
 test/unit/core.js | 12 +++++++-----
 2 files changed, 27 insertions(+), 25 deletions(-)

diff --git a/src/core.js b/src/core.js
index a0dd7b5b..951f1b55 100644
--- a/src/core.js
+++ b/src/core.js
@@ -704,33 +704,33 @@ jQuery.extend({
 		return ret;
 	},
 
-	// arg is for internal usage only
+		// arg is for internal usage only
 	map: function( elems, callback, arg ) {
-		var ret = [], value, i = 0,
-			length = elems.length,
-			// same object detection used in jQuery.each, not full-proof but very speedy.
-			isObj = length === undefined;
-			
-			// the work for the loops - run elems[x] through callback
-			inLoop = function( key ) {
-			  value = callback( elems[ key ], key, arg );
-			  
+		var value, ret = [],
+					i = 0,		
+					length = elems.length,
+					// process .length if it's just an object member
+					isArray = length !== undefined && ( elems[ length - 1 ] || jQuery.isArray( elems ) );
+		
+		// Go through the array, translating each of the items to their
+		// new value (or values).
+		if ( isArray ) {
+			for ( ; i < length; i++ ) {
+				value = callback( elems[ i ], i, arg );
+
 				if ( value != null ) {
 					ret[ ret.length ] = value;
 				}
 			}
 
-    // Go thorugh every key on the object
-		if ( isObj ) {
+		// Go thorugh every key on the object, 
+		} else {		
 			for ( key in elems ) {
-			  inLoop( key );
-			}
-		
-		// Go through the array, translating each of the items to their
-		// new value (or values).
-		} else {			
-			for ( ; i < length; i++ ) {
-				inLoop( i );
+				value = callback( elems[ key ], key, arg );
+
+				if ( value != null ) {
+					ret[ ret.length ] = value;
+				}
 			}
 		}
 
diff --git a/test/unit/core.js b/test/unit/core.js
index c1ffe10b..08d80400 100644
--- a/test/unit/core.js
+++ b/test/unit/core.js
@@ -608,7 +608,7 @@ test("first()/last()", function() {
 });
 
 test("map()", function() {
-	expect(6);
+	expect(7);
 
 	same(
 		jQuery("#ap").map(function(){
@@ -630,26 +630,28 @@ test("map()", function() {
 	var keys = jQuery.map( {a:1,b:2}, function( v, k ){
 		return k;
 	});
-
 	equals( keys.join(""), "ab", "Map the keys from a hash to an array" );
 
 	var values = jQuery.map( {a:1,b:2}, function( v, k ){
 		return v;
 	});
-
 	equals( values.join(""), "12", "Map the values from a hash to an array" );
+	
+	// object with length prop
+	var values = jQuery.map( {a:1,b:2, length:3}, function( v, k ){
+		return v;
+	});
+	equals( values.join(""), "123", "Map the values from a hash with a length property to an array" );
 
 	var scripts = document.getElementsByTagName("script");
 	var mapped = jQuery.map( scripts, function( v, k ){
 		return v;
 	});
-
 	equals( mapped.length, scripts.length, "Map an array(-like) to a hash" );
 
 	var flat = jQuery.map( Array(4), function( v, k ){
 		return k % 2 ? k : [k,k,k];//try mixing array and regular returns
 	});
-
 	equals( flat.join(""), "00012223", "try the new flatten technique(#2616)" );
 });
 

From 00dd6013b6b53455ef7b788801a5dc0616651580 Mon Sep 17 00:00:00 2001
From: Dan Heberden <danheberden@gmail.com>
Date: Mon, 21 Mar 2011 12:24:53 -0700
Subject: [PATCH 16/91] Clean up tab spacing

---
 src/core.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/core.js b/src/core.js
index 951f1b55..49c191b9 100644
--- a/src/core.js
+++ b/src/core.js
@@ -707,10 +707,10 @@ jQuery.extend({
 		// arg is for internal usage only
 	map: function( elems, callback, arg ) {
 		var value, ret = [],
-					i = 0,		
-					length = elems.length,
-					// process .length if it's just an object member
-					isArray = length !== undefined && ( elems[ length - 1 ] || jQuery.isArray( elems ) );
+			i = 0,		
+			length = elems.length,
+			// process .length if it's just an object member
+			isArray = length !== undefined && ( elems[ length - 1 ] || jQuery.isArray( elems ) );
 		
 		// Go through the array, translating each of the items to their
 		// new value (or values).

From e09d8898d8a8df27bb72ebc64a4cd08c11f21ddd Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Mon, 21 Mar 2011 20:59:20 -0400
Subject: [PATCH 17/91] Add node and jQuery object support to $.fn.closest

---
 src/traversing.js       | 20 ++++++++++++--------
 test/unit/traversing.js | 14 ++++++++++++++
 2 files changed, 26 insertions(+), 8 deletions(-)

diff --git a/src/traversing.js b/src/traversing.js
index 30d60435..49197c1f 100644
--- a/src/traversing.js
+++ b/src/traversing.js
@@ -32,6 +32,7 @@ jQuery.fn.extend({
 
 		var ret = this.pushStack( "", "find", selector ),
 			length, n, r;
+
 		for ( i = 0, l = this.length; i < l; i++ ) {
 			length = ret.length;
 			jQuery.find( selector, this[i], ret );
@@ -77,7 +78,8 @@ jQuery.fn.extend({
 
 	closest: function( selectors, context ) {
 		var ret = [], i, l, cur = this[0];
-
+		
+		// Array
 		if ( jQuery.isArray( selectors ) ) {
 			var match, selector,
 				matches = {},
@@ -87,8 +89,8 @@ jQuery.fn.extend({
 				for ( i = 0, l = selectors.length; i < l; i++ ) {
 					selector = selectors[i];
 
-					if ( !matches[selector] ) {
-						matches[selector] = jQuery.expr.match.POS.test( selector ) ?
+					if ( !matches[ selector ] ) {
+						matches[ selector ] = POS.test( selector ) ?
 							jQuery( selector, context || this.context ) :
 							selector;
 					}
@@ -96,9 +98,9 @@ jQuery.fn.extend({
 
 				while ( cur && cur.ownerDocument && cur !== context ) {
 					for ( selector in matches ) {
-						match = matches[selector];
+						match = matches[ selector ];
 
-						if ( match.jquery ? match.index(cur) > -1 : jQuery(cur).is(match) ) {
+						if ( match.jquery ? match.index( cur ) > -1 : jQuery( cur ).is( match ) ) {
 							ret.push({ selector: selector, elem: cur, level: level });
 						}
 					}
@@ -110,9 +112,11 @@ jQuery.fn.extend({
 
 			return ret;
 		}
-
-		var pos = POS.test( selectors ) ?
-			jQuery( selectors, context || this.context ) : null;
+		
+		// String
+		var pos = POS.test( selectors ) || typeof selectors !== "string" ?
+				jQuery( selectors, context || this.context ) :
+				0;
 
 		for ( i = 0, l = this.length; i < l; i++ ) {
 			cur = this[i];
diff --git a/test/unit/traversing.js b/test/unit/traversing.js
index 76b93d84..bd05f470 100644
--- a/test/unit/traversing.js
+++ b/test/unit/traversing.js
@@ -182,6 +182,20 @@ test("closest(Array)", function() {
 	same( jQuery("body").closest(["span","html"]), [{selector:"html", elem:document.documentElement, level:2}], "closest([body, html])" );
 });
 
+test("closest(jQuery)", function() {
+	expect(7);
+	var $child = jQuery("#nothiddendivchild"),
+		$parent = jQuery("#nothiddendiv"),
+		$main = jQuery("#main");
+	ok( $child.closest( $parent ).is('#nothiddendiv'), "closest( jQuery('#nothiddendiv') )" );
+	ok( $child.closest( $parent[0] ).is('#nothiddendiv'), "closest( jQuery('#nothiddendiv') ) :: node" );
+	ok( $child.closest( $child ).is('#nothiddendivchild'), "child is included" );
+	ok( $child.closest( $child[0] ).is('#nothiddendivchild'), "child is included  :: node" );
+	equals( $child.closest( document.createElement('div') ).length, 0, "created element is not related" );
+	equals( $child.closest( $main ).length, 0, "Main not a parent of child" );
+	equals( $child.closest( $main[0] ).length, 0, "Main not a parent of child :: node" );
+});
+
 test("not(Selector)", function() {
 	expect(7);
 	equals( jQuery("#main > p#ap > a").not("#google").length, 2, "not('selector')" );

From b8013581ced78fb6c2005e76b44211e01fc2e466 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Wed, 23 Mar 2011 15:56:05 -0400
Subject: [PATCH 18/91] Closest unit tests: add one for passing a jQuery
 collection with multiple elements

---
 test/unit/traversing.js | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/test/unit/traversing.js b/test/unit/traversing.js
index bd05f470..adca5f40 100644
--- a/test/unit/traversing.js
+++ b/test/unit/traversing.js
@@ -183,10 +183,11 @@ test("closest(Array)", function() {
 });
 
 test("closest(jQuery)", function() {
-	expect(7);
+	expect(8);
 	var $child = jQuery("#nothiddendivchild"),
 		$parent = jQuery("#nothiddendiv"),
-		$main = jQuery("#main");
+		$main = jQuery("#main"),
+		$body = jQuery("body");
 	ok( $child.closest( $parent ).is('#nothiddendiv'), "closest( jQuery('#nothiddendiv') )" );
 	ok( $child.closest( $parent[0] ).is('#nothiddendiv'), "closest( jQuery('#nothiddendiv') ) :: node" );
 	ok( $child.closest( $child ).is('#nothiddendivchild'), "child is included" );
@@ -194,6 +195,7 @@ test("closest(jQuery)", function() {
 	equals( $child.closest( document.createElement('div') ).length, 0, "created element is not related" );
 	equals( $child.closest( $main ).length, 0, "Main not a parent of child" );
 	equals( $child.closest( $main[0] ).length, 0, "Main not a parent of child :: node" );
+	ok( $child.closest( $body.add($parent) ).is('#nothiddendiv'), "Closest ancestor retrieved." );
 });
 
 test("not(Selector)", function() {

From 85232c97bf1f129b2bc246cf674dc3d5582aaecb Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Wed, 23 Mar 2011 16:04:12 -0400
Subject: [PATCH 19/91] Traversing unit tests: added tests for passing invalid
 arguments to $.fn.not (should have no effect on existing object rather than
 return an empty object as filter does)

---
 test/unit/traversing.js | 31 ++++++++++++-------------------
 1 file changed, 12 insertions(+), 19 deletions(-)

diff --git a/test/unit/traversing.js b/test/unit/traversing.js
index 9eb0d78b..7d15f4c1 100644
--- a/test/unit/traversing.js
+++ b/test/unit/traversing.js
@@ -47,8 +47,8 @@ test("is(String|undefined)", function() {
 	ok( jQuery('#en').is('[lang="de"] , [lang="en"]'), 'Comma-seperated; Check for lang attribute: Expect en or de' );
 });
 
-test("is(Object)", function() {
-	expect(18);
+test("is(jQuery)", function() {
+	expect(24);
 	ok( jQuery('#form').is( jQuery('form') ), 'Check for element: A form is a form' );
 	ok( !jQuery('#form').is( jQuery('div') ), 'Check for element: A form is not a div' );
 	ok( jQuery('#mark').is( jQuery('.blog') ), 'Check for class: Expected class "blog"' );
@@ -67,27 +67,14 @@ test("is(Object)", function() {
 	ok( !jQuery('#foo').is( jQuery(':has(ul)') ), 'Check for child: Did not expect "ul" element' );
 	ok( jQuery('#foo').is( jQuery(':has(p):has(a):has(code)') ), 'Check for childs: Expected "p", "a" and "code" child elements' );
 	ok( !jQuery('#foo').is( jQuery(':has(p):has(a):has(code):has(ol)') ), 'Check for childs: Expected "p", "a" and "code" child elements, but no "ol"' );
-});
-
-test("is(node Object)", function() {
-	expect(17);
+	
+	// Some raw elements
 	ok( jQuery('#form').is( jQuery('form')[0] ), 'Check for element: A form is a form' );
 	ok( !jQuery('#form').is( jQuery('div')[0] ), 'Check for element: A form is not a div' );
 	ok( jQuery('#mark').is( jQuery('.blog')[0] ), 'Check for class: Expected class "blog"' );
 	ok( !jQuery('#mark').is( jQuery('.link')[0] ), 'Check for class: Did not expect class "link"' );
 	ok( jQuery('#simon').is( jQuery('.blog.link')[0] ), 'Check for multiple classes: Expected classes "blog" and "link"' );
 	ok( !jQuery('#simon').is( jQuery('.blogTest')[0] ), 'Check for multiple classes: Expected classes "blog" and "link", but not "blogTest"' );
-	ok( jQuery('#en').is( jQuery('[lang="en"]')[1] ), 'Check for attribute: Expected attribute lang to be "en"' );
-	ok( !jQuery('#en').is( jQuery('[lang="de"]')[0] ), 'Check for attribute: Expected attribute lang to be "en", not "de"' );
-	ok( jQuery('#text1').is( jQuery('[type="text"]')[0] ), 'Check for attribute: Expected attribute type to be "text"' );
-	ok( !jQuery('#text1').is( jQuery('[type="radio"]')[0] ), 'Check for attribute: Expected attribute type to be "text", not "radio"' );
-	ok( jQuery('#text2').is( jQuery(':disabled')[0] ), 'Check for pseudoclass: Expected to be disabled' );
-	ok( !jQuery('#text1').is( jQuery(':disabled')[0] ), 'Check for pseudoclass: Expected not disabled' );
-	ok( !jQuery('#radio1').is( jQuery(':checked')[0] ), 'Check for pseudoclass: Expected not checked' );
-	ok( jQuery('#foo').is( jQuery(':has(p)')[4] ), 'Check for child: Expected a child "p" element' );
-	ok( !jQuery('#foo').is( jQuery(':has(ul)')[0] ), 'Check for child: Did not expect "ul" element' );
-	ok( jQuery('#foo').is( jQuery(':has(p):has(a):has(code)')[4] ), 'Check for childs: Expected "p", "a" and "code" child elements' );
-	ok( !jQuery('#foo').is( jQuery(':has(p):has(a):has(code):has(ol)')[0] ), 'Check for childs: Expected "p", "a" and "code" child elements, but no "ol"' );
 });
 
 test("index()", function() {
@@ -208,8 +195,8 @@ test("closest(Array)", function() {
 	same( jQuery("body").closest(["span","html"]), [{selector:"html", elem:document.documentElement, level:2}], "closest([body, html])" );
 });
 
-test("not(Selector)", function() {
-	expect(7);
+test("not(Selector|undefined)", function() {
+	expect(11);
 	equals( jQuery("#main > p#ap > a").not("#google").length, 2, "not('selector')" );
 	same( jQuery("p").not(".result").get(), q("firstp", "ap", "sndp", "en", "sap", "first"), "not('.class')" );
 	same( jQuery("p").not("#ap, #sndp, .result").get(), q("firstp", "en", "sap", "first"), "not('selector, selector')" );
@@ -218,6 +205,12 @@ test("not(Selector)", function() {
 	same( jQuery('#ap *').not('code').get(), q("google", "groups", "anchor1", "mark"), "not('tag selector')" );
 	same( jQuery('#ap *').not('code, #mark').get(), q("google", "groups", "anchor1"), "not('tag, ID selector')" );
 	same( jQuery('#ap *').not('#mark, code').get(), q("google", "groups", "anchor1"), "not('ID, tag selector')");
+	
+	var all = jQuery('p').get();
+	same( jQuery('p').not(null).get(),      all, "not(null) should have no effect");
+	same( jQuery('p').not(undefined).get(), all, "not(undefined) should have no effect");
+	same( jQuery('p').not(0).get(),         all, "not(0) should have no effect");
+	same( jQuery('p').not('').get(),        all, "not('') should have no effect");
 });
 
 test("not(Element)", function() {

From e6da0fa6a96c9b4314303e251fd6efac98813ab8 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Fri, 25 Mar 2011 23:46:29 -0400
Subject: [PATCH 20/91] Bug #7369: Add test for disconnected node in closest
 when passing attribute selector; this was recently fixed in 1.5.2rc

---
 test/unit/traversing.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/test/unit/traversing.js b/test/unit/traversing.js
index adca5f40..f5cd8aac 100644
--- a/test/unit/traversing.js
+++ b/test/unit/traversing.js
@@ -148,7 +148,7 @@ test("filter(jQuery)", function() {
 })
 
 test("closest()", function() {
-	expect(11);
+	expect(12);
 	same( jQuery("body").closest("body").get(), q("body"), "closest(body)" );
 	same( jQuery("body").closest("html").get(), q("html"), "closest(html)" );
 	same( jQuery("body").closest("div").get(), [], "closest(div)" );
@@ -168,6 +168,8 @@ test("closest()", function() {
 
 	// Test on disconnected node
 	equals( jQuery("<div><p></p></div>").find("p").closest("table").length, 0, "Make sure disconnected closest work." );
+	// Bug #7369
+	equals( jQuery('<div foo="bar"></div>').closest('[foo]').length, 1, "Disconnected nodes with attribute selector" );
 });
 
 test("closest(Array)", function() {

From e93ca40aa7ec4337a57fcdbc699d900e01b4c67e Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Fri, 25 Mar 2011 23:52:36 -0400
Subject: [PATCH 21/91] Bug #7369: Check non-existent attribute as well to be
 sure

---
 test/unit/traversing.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/test/unit/traversing.js b/test/unit/traversing.js
index f5cd8aac..43a9f22a 100644
--- a/test/unit/traversing.js
+++ b/test/unit/traversing.js
@@ -148,7 +148,7 @@ test("filter(jQuery)", function() {
 })
 
 test("closest()", function() {
-	expect(12);
+	expect(13);
 	same( jQuery("body").closest("body").get(), q("body"), "closest(body)" );
 	same( jQuery("body").closest("html").get(), q("html"), "closest(html)" );
 	same( jQuery("body").closest("div").get(), [], "closest(div)" );
@@ -170,6 +170,7 @@ test("closest()", function() {
 	equals( jQuery("<div><p></p></div>").find("p").closest("table").length, 0, "Make sure disconnected closest work." );
 	// Bug #7369
 	equals( jQuery('<div foo="bar"></div>').closest('[foo]').length, 1, "Disconnected nodes with attribute selector" );
+	equals( jQuery('<div></div>').closest('[lang]').length, 0, "Disconnected nodes with non-existent attribute selector" );
 });
 
 test("closest(Array)", function() {

From 1a167767305202797cf4c839eb64bd7adfb00182 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Wed, 30 Mar 2011 23:23:38 -0400
Subject: [PATCH 22/91] Remove test for bug #7369 to move the fix to a separate
 branch for a sooner pull

---
 src/traversing.js       | 4 ++--
 test/unit/traversing.js | 3 ---
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/traversing.js b/src/traversing.js
index 49197c1f..91bc017e 100644
--- a/src/traversing.js
+++ b/src/traversing.js
@@ -112,7 +112,7 @@ jQuery.fn.extend({
 
 			return ret;
 		}
-		
+
 		// String
 		var pos = POS.test( selectors ) || typeof selectors !== "string" ?
 				jQuery( selectors, context || this.context ) :
@@ -135,7 +135,7 @@ jQuery.fn.extend({
 			}
 		}
 
-		ret = ret.length > 1 ? jQuery.unique(ret) : ret;
+		ret = ret.length > 1 ? jQuery.unique( ret ) : ret;
 
 		return this.pushStack( ret, "closest", selectors );
 	},
diff --git a/test/unit/traversing.js b/test/unit/traversing.js
index 43a9f22a..117e4600 100644
--- a/test/unit/traversing.js
+++ b/test/unit/traversing.js
@@ -168,9 +168,6 @@ test("closest()", function() {
 
 	// Test on disconnected node
 	equals( jQuery("<div><p></p></div>").find("p").closest("table").length, 0, "Make sure disconnected closest work." );
-	// Bug #7369
-	equals( jQuery('<div foo="bar"></div>').closest('[foo]').length, 1, "Disconnected nodes with attribute selector" );
-	equals( jQuery('<div></div>').closest('[lang]').length, 0, "Disconnected nodes with non-existent attribute selector" );
 });
 
 test("closest(Array)", function() {

From a807451a23577ad04140a32f7888e6c7b26a8838 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Wed, 30 Mar 2011 23:39:19 -0400
Subject: [PATCH 23/91] Fixes #7369 - Using an attribute selector for a
 non-existent attribute raised an exception on disconnected nodes

---
 src/traversing.js       | 2 +-
 test/unit/traversing.js | 6 +++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/traversing.js b/src/traversing.js
index fe2e33d8..468aa097 100644
--- a/src/traversing.js
+++ b/src/traversing.js
@@ -112,7 +112,7 @@ jQuery.fn.extend({
 
 				} else {
 					cur = cur.parentNode;
-					if ( !cur || !cur.ownerDocument || cur === context ) {
+					if ( !cur || !cur.ownerDocument || cur === context || cur.nodeType === 11 ) {
 						break;
 					}
 				}
diff --git a/test/unit/traversing.js b/test/unit/traversing.js
index f5108bde..4cccd650 100644
--- a/test/unit/traversing.js
+++ b/test/unit/traversing.js
@@ -124,7 +124,7 @@ test("filter(jQuery)", function() {
 })
 
 test("closest()", function() {
-	expect(11);
+	expect(13);
 	same( jQuery("body").closest("body").get(), q("body"), "closest(body)" );
 	same( jQuery("body").closest("html").get(), q("html"), "closest(html)" );
 	same( jQuery("body").closest("div").get(), [], "closest(div)" );
@@ -144,6 +144,10 @@ test("closest()", function() {
 
 	// Test on disconnected node
 	equals( jQuery("<div><p></p></div>").find("p").closest("table").length, 0, "Make sure disconnected closest work." );
+
+	// Bug #7369
+	equals( jQuery('<div foo="bar"></div>').closest('[foo]').length, 1, "Disconnected nodes with attribute selector" );
+	equals( jQuery('<div>text</div>').closest('[lang]').length, 0, "Disconnected nodes with text and non-existent attribute selector" );
 });
 
 test("closest(Array)", function() {

From 64a0005a3b5a168a421efa1d8b253de234620229 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Sat, 2 Apr 2011 17:05:04 -0400
Subject: [PATCH 24/91] A more modest valHooks proposal

- The main difference is that this does not allow arbitrarily adding hooks to any collection of elements.

- Modularizes val into a set of easily maintainable and conditional hooks.

- valHooks is placed at jQuery.valHooks

  + This could technically be extended, but I do not see it being used except in very rare cases since you can only apply valHooks to nodeNames and input types, and not a collection of elements as before. We could theoretically privatize valHooks taking it off of jQuery and only use it internally for our own convenience, but again, I do not believe this patch carries with it the dangers of the first proposal.

- Slightly improved performance of val on radios and checkboxes for browsers that support checkOn, given the conditional attachment of its hook.
---
 src/attributes.js | 178 +++++++++++++++++++++++++++-------------------
 1 file changed, 103 insertions(+), 75 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index 59972105..4c59a675 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -154,82 +154,35 @@ jQuery.fn.extend({
 	},
 
 	val: function( value ) {
+		var hooks, val,
+			elem = this[0];
+		
 		if ( !arguments.length ) {
-			var elem = this[0];
-
 			if ( elem ) {
-				if ( jQuery.nodeName( elem, "option" ) ) {
-					// attributes.value is undefined in Blackberry 4.7 but
-					// uses .value. See #6932
-					var val = elem.attributes.value;
-					return !val || val.specified ? elem.value : elem.text;
+				hooks = jQuery.valHooks[ elem.nodeName.toLowerCase() ] || jQuery.valHooks[ elem.type ];
+
+				if ( hooks && "get" in hooks && (val = hooks.get( elem )) !== undefined ) {
+					return val;
 				}
 
-				// We need to handle select boxes special
-				if ( jQuery.nodeName( elem, "select" ) ) {
-					var index = elem.selectedIndex,
-						values = [],
-						options = elem.options,
-						one = elem.type === "select-one";
-
-					// Nothing was selected
-					if ( index < 0 ) {
-						return null;
-					}
-
-					// Loop through all the selected options
-					for ( var i = one ? index : 0, max = one ? index + 1 : options.length; i < max; i++ ) {
-						var option = options[ i ];
-
-						// Don't return options that are disabled or in a disabled optgroup
-						if ( option.selected && (jQuery.support.optDisabled ? !option.disabled : option.getAttribute("disabled") === null) &&
-								(!option.parentNode.disabled || !jQuery.nodeName( option.parentNode, "optgroup" )) ) {
-
-							// Get the specific value for the option
-							value = jQuery(option).val();
-
-							// We don't need an array for one selects
-							if ( one ) {
-								return value;
-							}
-
-							// Multi-Selects return an array
-							values.push( value );
-						}
-					}
-
-					// Fixes Bug #2551 -- select.val() broken in IE after form.reset()
-					if ( one && !values.length && options.length ) {
-						return jQuery( options[ index ] ).val();
-					}
-
-					return values;
-				}
-
-				// Handle the case where in Webkit "" is returned instead of "on" if a value isn't specified
-				if ( rradiocheck.test( elem.type ) && !jQuery.support.checkOn ) {
-					return elem.getAttribute("value") === null ? "on" : elem.value;
-				}
-
-				// Everything else, we just grab the value
 				return (elem.value || "").replace(rreturn, "");
-
 			}
 
 			return undefined;
 		}
 
-		var isFunction = jQuery.isFunction(value);
+		var isFunction = jQuery.isFunction( value );
 
-		return this.each(function(i) {
-			var self = jQuery(this), val = value;
+		return this.each(function( i ) {
+			var self = jQuery(this);
 
 			if ( this.nodeType !== 1 ) {
 				return;
 			}
 
+			val = value;
 			if ( isFunction ) {
-				val = value.call(this, i, self.val());
+				val = value.call( this, i, self.val() );
 			}
 
 			// Treat null/undefined as ""; convert numbers to string
@@ -237,27 +190,16 @@ jQuery.fn.extend({
 				val = "";
 			} else if ( typeof val === "number" ) {
 				val += "";
-			} else if ( jQuery.isArray(val) ) {
-				val = jQuery.map(val, function (value) {
+			} else if ( jQuery.isArray( val ) ) {
+				val = jQuery.map(val, function ( value ) {
 					return value == null ? "" : value + "";
 				});
 			}
 
-			if ( jQuery.isArray(val) && rradiocheck.test( this.type ) ) {
-				this.checked = jQuery.inArray( self.val(), val ) >= 0;
+			hooks = jQuery.valHooks[ this.nodeName.toLowerCase() ] || jQuery.valHooks[ this.type ];
 
-			} else if ( jQuery.nodeName( this, "select" ) ) {
-				var values = jQuery.makeArray(val);
-
-				jQuery( "option", this ).each(function() {
-					this.selected = jQuery.inArray( jQuery(this).val(), values ) >= 0;
-				});
-
-				if ( !values.length ) {
-					this.selectedIndex = -1;
-				}
-
-			} else {
+			// If set returns undefined, fall back to normal setting
+			if ( !hooks || ("set" in hooks && hooks.set( this, val ) === undefined) ) {
 				this.value = val;
 			}
 		});
@@ -265,6 +207,71 @@ jQuery.fn.extend({
 });
 
 jQuery.extend({
+	valHooks: {
+		option: {
+			get: function( elem ) {
+				// attributes.value is undefined in Blackberry 4.7 but
+				// uses .value. See #6932
+				var val = elem.attributes.value;
+				return !val || val.specified ? elem.value : elem.text;
+			}
+		},
+		select: {
+			get: function( elem ) {
+				var index = elem.selectedIndex,
+					values = [],
+					options = elem.options,
+					one = elem.type === "select-one";
+
+				// Nothing was selected
+				if ( index < 0 ) {
+					return null;
+				}
+
+				// Loop through all the selected options
+				for ( var i = one ? index : 0, max = one ? index + 1 : options.length; i < max; i++ ) {
+					var option = options[ i ];
+
+					// Don't return options that are disabled or in a disabled optgroup
+					if ( option.selected && (jQuery.support.optDisabled ? !option.disabled : option.getAttribute("disabled") === null) &&
+							(!option.parentNode.disabled || !jQuery.nodeName( option.parentNode, "optgroup" )) ) {
+
+						// Get the specific value for the option
+						value = jQuery( option ).val();
+
+						// We don't need an array for one selects
+						if ( one ) {
+							return value;
+						}
+
+						// Multi-Selects return an array
+						values.push( value );
+					}
+				}
+
+				// Fixes Bug #2551 -- select.val() broken in IE after form.reset()
+				if ( one && !values.length && options.length ) {
+					return jQuery( options[ index ] ).val();
+				}
+
+				return values;
+			},
+
+			set: function( elem, value ) {
+				var values = jQuery.makeArray( value );
+
+				jQuery(elem).find("option").each(function() {
+					this.selected = jQuery.inArray( jQuery(this).val(), values ) >= 0;
+				});
+
+				if ( !values.length ) {
+					elem.selectedIndex = -1;
+				}
+				return values;
+			}
+		}
+	},
+
 	attrFn: {
 		val: true,
 		css: true,
@@ -386,4 +393,25 @@ jQuery.extend({
 	}
 });
 
+// Radios and checkboxes getter/setter
+if ( !jQuery.support.checkOn ) {
+	jQuery.each([ "radio", "checkbox" ], function() {
+		jQuery.valHooks[ this ] = {
+			get: function( elem ) {
+				// Handle the case where in Webkit "" is returned instead of "on" if a value isn't specified
+				return elem.getAttribute("value") === null ? "on" : elem.value;
+			}
+		};
+	});
+}
+jQuery.each([ "radio", "checkbox" ], function() {
+	jQuery.valHooks[ this ] = jQuery.extend( jQuery.valHooks[ this ], {
+		set: function( elem, value ) {
+			if ( jQuery.isArray( value ) ) {
+				return (elem.checked = jQuery.inArray( jQuery(elem).val(), value ) >= 0);
+			}
+		}
+	});
+});
+
 })( jQuery );

From ab4e300919c5b3335e6d6c99ce9b1c314d116f19 Mon Sep 17 00:00:00 2001
From: jeresig <jeresig@gmail.com>
Date: Sun, 6 Mar 2011 22:47:40 -0500
Subject: [PATCH 25/91] Very crude first pass at splitting apart the attr/prop
 logic. Also adding in attrHooks/propHooks. All of it is completely untested.

---
 src/attributes.js | 274 ++++++++++++++++++++++++++++------------------
 1 file changed, 168 insertions(+), 106 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index 59972105..e5425a05 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -3,38 +3,37 @@
 var rclass = /[\n\t\r]/g,
 	rspaces = /\s+/,
 	rreturn = /\r/g,
-	rspecialurl = /^(?:href|src|style)$/,
 	rtype = /^(?:button|input)$/i,
 	rfocusable = /^(?:button|input|object|select|textarea)$/i,
 	rclickable = /^a(?:rea)?$/i,
 	rradiocheck = /^(?:radio|checkbox)$/i;
 
-jQuery.props = {
-	"for": "htmlFor",
-	"class": "className",
-	readonly: "readOnly",
-	maxlength: "maxLength",
-	cellspacing: "cellSpacing",
-	rowspan: "rowSpan",
-	colspan: "colSpan",
-	tabindex: "tabIndex",
-	usemap: "useMap",
-	frameborder: "frameBorder"
-};
-
 jQuery.fn.extend({
 	attr: function( name, value ) {
 		return jQuery.access( this, name, value, true, jQuery.attr );
 	},
 
-	removeAttr: function( name, fn ) {
-		return this.each(function(){
-			jQuery.attr( this, name, "" );
+	removeAttr: function( name ) {
+		return this.each(function() {
 			if ( this.nodeType === 1 ) {
 				this.removeAttribute( name );
 			}
 		});
 	},
+	
+	prop: function( name, value ) {
+		return jQuery.access( this, name, value, true, jQuery.prop );
+	},
+	
+	removeProp: function( name ) {
+		return this.each(function() {
+			// try/catch handles cases where IE balks (such as removing a property on window)
+			try {
+				this[ name ] = undefined;
+				delete this[ name ];
+			} catch( e ) {}
+		});
+	},
 
 	addClass: function( value ) {
 		if ( jQuery.isFunction(value) ) {
@@ -275,6 +274,21 @@ jQuery.extend({
 		height: true,
 		offset: true
 	},
+	
+	// TODO: Check to see if any of these are needed anymore?
+	// If not, it may be good to standardize on all-lowercase names instead
+	attrFix: {
+		"for": "htmlFor",
+		"class": "className",
+		readonly: "readOnly",
+		maxlength: "maxLength",
+		cellspacing: "cellSpacing",
+		rowspan: "rowSpan",
+		colspan: "colSpan",
+		tabindex: "tabIndex",
+		usemap: "useMap",
+		frameborder: "frameBorder"
+	},
 
 	attr: function( elem, name, value, pass ) {
 		// don't get/set attributes on text, comment and attribute nodes
@@ -286,104 +300,152 @@ jQuery.extend({
 			return jQuery(elem)[name](value);
 		}
 
-		var notxml = elem.nodeType !== 1 || !jQuery.isXMLDoc( elem ),
-			// Whether we are setting (or getting)
-			set = value !== undefined;
-
+		var ret,
+			notxml = elem.nodeType !== 1 || !jQuery.isXMLDoc( elem ),
+			hooks;
+			
 		// Try to normalize/fix the name
-		name = notxml && jQuery.props[ name ] || name;
+		name = notxml && jQuery.attrFix[ name ] || name;
+		
+		hooks = jQuery.attrHooks[ name ];
+		
+		if ( value !== undefined ) {
+			
+			if ( hooks && "set" in hooks && notxml && (ret = hooks.set( elem, value )) !== undefined ) {
+				return ret;
+			
+			} else {
+				// convert the value to a string (all browsers do this but IE) see #1070
+				value = "" + value;
+				
+				elem.setAttribute( name, value );
+				
+				return value;
+			}
+			
+		} else {
+			
+			if ( hooks && "get" in hooks && notxml && (ret = hooks.get( elem )) !== undefined ) {
+				return ret;
+				
+			} else {
+				
+				if ( !jQuery.hasAttr( elem, name ) ) {
+					return undefined;
+				}
 
-		// Only do all the following if this is a node (faster for style)
-		if ( elem.nodeType === 1 ) {
-			// These attributes require special treatment
-			var special = rspecialurl.test( name );
+				var attr = elem.getAttribute( name );
 
-			// Safari mis-reports the default selected property of an option
-			// Accessing the parent's selectedIndex property fixes it
-			if ( name === "selected" && !jQuery.support.optSelected ) {
-				var parent = elem.parentNode;
-				if ( parent ) {
-					parent.selectedIndex;
-
-					// Make sure that it also works with optgroups, see #5701
-					if ( parent.parentNode ) {
-						parent.parentNode.selectedIndex;
-					}
+				// Non-existent attributes return null, we normalize to undefined
+				return attr === null ?
+					undefined :
+					attr;
+			}
+		}
+	},
+	
+	hasAttr: function( elem, name ) {
+		// Blackberry 4.7 returns "" from getAttribute #6938
+		return elem.attributes[ name ] || (elem.hasAttribute && elem.hasAttribute( name ));
+	},
+	
+	attrHooks: {
+		type: {
+			set: function( elem, value ) {
+				// We can't allow the type property to be changed (since it causes problems in IE)
+				if ( rtype.test( elem.nodeName ) && elem.parentNode ) {
+					jQuery.error( "type property can't be changed" );
 				}
 			}
+		},
+		
+		// elem.tabIndex doesn't always return the correct value when it hasn't been explicitly set
+		// http://fluidproject.org/blog/2008/01/09/getting-setting-and-removing-tabindex-values-with-javascript/
+		tabIndex: {
+			get: function( elem ) {
+				var attributeNode = elem.getAttributeNode( "tabIndex" );
 
-			// If applicable, access the attribute via the DOM 0 way
-			// 'in' checks fail in Blackberry 4.7 #6931
-			if ( (name in elem || elem[ name ] !== undefined) && notxml && !special ) {
-				if ( set ) {
-					// We can't allow the type property to be changed (since it causes problems in IE)
-					if ( name === "type" && rtype.test( elem.nodeName ) && elem.parentNode ) {
-						jQuery.error( "type property can't be changed" );
-					}
-
-					if ( value === null ) {
-						if ( elem.nodeType === 1 ) {
-							elem.removeAttribute( name );
-						}
-
-					} else {
-						elem[ name ] = value;
-					}
-				}
-
-				// browsers index elements by id/name on forms, give priority to attributes.
-				if ( jQuery.nodeName( elem, "form" ) && elem.getAttributeNode(name) ) {
-					return elem.getAttributeNode( name ).nodeValue;
-				}
-
-				// elem.tabIndex doesn't always return the correct value when it hasn't been explicitly set
-				// http://fluidproject.org/blog/2008/01/09/getting-setting-and-removing-tabindex-values-with-javascript/
-				if ( name === "tabIndex" ) {
-					var attributeNode = elem.getAttributeNode( "tabIndex" );
-
-					return attributeNode && attributeNode.specified ?
-						attributeNode.value :
-						rfocusable.test( elem.nodeName ) || rclickable.test( elem.nodeName ) && elem.href ?
-							0 :
-							undefined;
-				}
-
+				return attributeNode && attributeNode.specified ?
+					attributeNode.value :
+					rfocusable.test( elem.nodeName ) || rclickable.test( elem.nodeName ) && elem.href ?
+						0 :
+						undefined;
+			}
+		}
+	},
+	
+	// TODO: Check to see if we really need any here.
+	propFix: {},
+	
+	prop: function( elem, name, value ) {
+		var ret, hooks;
+		
+		// Try to normalize/fix the name
+		name = notxml && jQuery.propFix[ name ] || name;
+		
+		hooks = jQuery.propHooks[ name ];
+		
+		if ( value !== undefined ) {
+			if ( hooks && "set" in hooks && (ret = hooks.set( elem, value )) !== undefined ) {
+				return ret;
+			
+			} else {
+				return (elem[ name ] = value);
+			}
+		
+		} else {
+			if ( hooks && "get" in hooks && (ret = hooks.get( elem )) !== undefined ) {
+				return ret;
+				
+			} else {
 				return elem[ name ];
 			}
-
-			if ( !jQuery.support.style && notxml && name === "style" ) {
-				if ( set ) {
-					elem.style.cssText = "" + value;
-				}
-
-				return elem.style.cssText;
-			}
-
-			if ( set ) {
-				// convert the value to a string (all browsers do this but IE) see #1070
-				elem.setAttribute( name, "" + value );
-			}
-
-			// Ensure that missing attributes return undefined
-			// Blackberry 4.7 returns "" from getAttribute #6938
-			if ( !elem.attributes[ name ] && (elem.hasAttribute && !elem.hasAttribute( name )) ) {
-				return undefined;
-			}
-
-			var attr = !jQuery.support.hrefNormalized && notxml && special ?
-					// Some attributes require a special call on IE
-					elem.getAttribute( name, 2 ) :
-					elem.getAttribute( name );
-
-			// Non-existent attributes return null, we normalize to undefined
-			return attr === null ? undefined : attr;
 		}
-		// Handle everything which isn't a DOM element node
-		if ( set ) {
-			elem[ name ] = value;
-		}
-		return elem[ name ];
-	}
+	},
+	
+	propHooks: {}
 });
 
+// Some attributes require a special call on IE
+if ( !jQuery.support.hrefNormalized ) {
+	jQuery.each([ "href", "src", "style" ], function( i, name ) {
+		jQuery.attrHooks[ name ] = jQuery.extend( jQuery.attrHooks[ name ], {
+			get: function( elem ) {
+				return elem.getAttribute( name, 2 );
+			}
+		});
+	});
+}
+
+if ( !jQuery.support.style ) {
+	jQuery.attrHooks.style = {
+		get: function( elem ) {
+			return elem.style.cssText;
+		},
+		
+		set: function( elem, value ) {
+			return (elem.style.cssText = "" + value);
+		}
+	};
+}
+
+// Safari mis-reports the default selected property of an option
+// Accessing the parent's selectedIndex property fixes it
+if ( !jQuery.support.optSelected ) {
+	jQuery.attrHooks.selected = {
+		get: function( elem ) {
+			var parent = elem.parentNode;
+			
+			if ( parent ) {
+				parent.selectedIndex;
+
+				// Make sure that it also works with optgroups, see #5701
+				if ( parent.parentNode ) {
+					parent.parentNode.selectedIndex;
+				}
+			}
+		}
+	};
+}
+
 })( jQuery );

From de79e8c7e0d1d2243447d59c70a9058eabf56bc3 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Tue, 8 Mar 2011 12:07:05 -0500
Subject: [PATCH 26/91] Make the new attr/prop changes pass the test suite (in
 Webkit).  There are still errors in IE.

+ Added hooks for selected, checked, readonly, disabled to removeAttr if set to falsey

+ Removed all attrs from attrFix, these aren't needed for setAttribute

+ If prop is used for class, do we want a propFix for class?

  - We could just assume the user should know to use className with prop.  I've done the latter for now.

+ Created tests for $.fn.prop and $.fn.removeProp

  - Actually all I did was change broken attr tests to prop where it made sense.
---
 src/attributes.js         |  48 ++++++-----
 src/manipulation.js       |   2 +-
 test/unit/attributes.js   | 177 ++++++++++++++++++++------------------
 test/unit/manipulation.js |   6 +-
 4 files changed, 124 insertions(+), 109 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index e5425a05..cb8128d2 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -36,10 +36,10 @@ jQuery.fn.extend({
 	},
 
 	addClass: function( value ) {
-		if ( jQuery.isFunction(value) ) {
+		if ( jQuery.isFunction( value ) ) {
 			return this.each(function(i) {
 				var self = jQuery(this);
-				self.addClass( value.call(this, i, self.attr("class")) );
+				self.addClass( value.call(this, i, self.attr("class") || "") );
 			});
 		}
 
@@ -278,19 +278,10 @@ jQuery.extend({
 	// TODO: Check to see if any of these are needed anymore?
 	// If not, it may be good to standardize on all-lowercase names instead
 	attrFix: {
-		"for": "htmlFor",
-		"class": "className",
-		readonly: "readOnly",
-		maxlength: "maxLength",
-		cellspacing: "cellSpacing",
-		rowspan: "rowSpan",
-		colspan: "colSpan",
-		tabindex: "tabIndex",
-		usemap: "useMap",
-		frameborder: "frameBorder"
 	},
 
 	attr: function( elem, name, value, pass ) {
+
 		// don't get/set attributes on text, comment and attribute nodes
 		if ( !elem || elem.nodeType === 3 || elem.nodeType === 8 || elem.nodeType === 2 ) {
 			return undefined;
@@ -314,6 +305,10 @@ jQuery.extend({
 			if ( hooks && "set" in hooks && notxml && (ret = hooks.set( elem, value )) !== undefined ) {
 				return ret;
 			
+			} else if ( value === null ) {
+				elem.removeAttribute( name );
+				return undefined;
+				
 			} else {
 				// convert the value to a string (all browsers do this but IE) see #1070
 				value = "" + value;
@@ -329,7 +324,7 @@ jQuery.extend({
 				return ret;
 				
 			} else {
-				
+
 				if ( !jQuery.hasAttr( elem, name ) ) {
 					return undefined;
 				}
@@ -337,16 +332,14 @@ jQuery.extend({
 				var attr = elem.getAttribute( name );
 
 				// Non-existent attributes return null, we normalize to undefined
-				return attr === null ?
-					undefined :
-					attr;
+				return attr === null ? undefined : attr;
 			}
 		}
 	},
 	
 	hasAttr: function( elem, name ) {
 		// Blackberry 4.7 returns "" from getAttribute #6938
-		return elem.attributes[ name ] || (elem.hasAttribute && elem.hasAttribute( name ));
+		return elem && elem.attributes[ name ] || (elem.hasAttribute && elem.hasAttribute( name ));
 	},
 	
 	attrHooks: {
@@ -361,7 +354,7 @@ jQuery.extend({
 		
 		// elem.tabIndex doesn't always return the correct value when it hasn't been explicitly set
 		// http://fluidproject.org/blog/2008/01/09/getting-setting-and-removing-tabindex-values-with-javascript/
-		tabIndex: {
+		tabindex: {
 			get: function( elem ) {
 				var attributeNode = elem.getAttributeNode( "tabIndex" );
 
@@ -375,10 +368,11 @@ jQuery.extend({
 	},
 	
 	// TODO: Check to see if we really need any here.
-	propFix: {},
+	propFix: {
+	},
 	
 	prop: function( elem, name, value ) {
-		var ret, hooks;
+		var ret, hooks, notxml = elem.nodeType !== 1 || !jQuery.isXMLDoc( elem );
 		
 		// Try to normalize/fix the name
 		name = notxml && jQuery.propFix[ name ] || name;
@@ -406,6 +400,20 @@ jQuery.extend({
 	propHooks: {}
 });
 
+// Remove certain attrs if set to false
+jQuery.each([ "selected", "checked", "readonly", "disabled" ], function( i, name ) {
+	jQuery.attrHooks[ name ] = jQuery.extend( jQuery.attrHooks[ name ], {
+		set: function( elem, value ) {
+			if ( !value ) { // '', undefined, false, null will remove attr
+				elem.removeAttribute( name );
+				return false;
+			}
+			elem.setAttribute( name, value );
+			return value;
+		}
+	});
+});
+
 // Some attributes require a special call on IE
 if ( !jQuery.support.hrefNormalized ) {
 	jQuery.each([ "href", "src", "style" ], function( i, name ) {
diff --git a/src/manipulation.js b/src/manipulation.js
index 27f81cc2..81a55cb8 100644
--- a/src/manipulation.js
+++ b/src/manipulation.js
@@ -377,7 +377,7 @@ function cloneCopyEvent( src, dest ) {
 	}
 }
 
-function cloneFixAttributes(src, dest) {
+function cloneFixAttributes( src, dest ) {
 	// We do not need to do anything for non-Elements
 	if ( dest.nodeType !== 1 ) {
 		return;
diff --git a/test/unit/attributes.js b/test/unit/attributes.js
index 8cf47bed..d4284556 100644
--- a/test/unit/attributes.js
+++ b/test/unit/attributes.js
@@ -3,38 +3,64 @@ module("attributes", { teardown: moduleTeardown });
 var bareObj = function(value) { return value; };
 var functionReturningObj = function(value) { return (function() { return value; }); };
 
-test("jQuery.props: itegrity test", function() {
-
-  expect(1);
-
-  //  This must be maintained and equal jQuery.props
-  //  Ensure that accidental or erroneous property
-  //  overwrites don't occur
-  //  This is simply for better code coverage and future proofing.
-  var propsShouldBe = {
-    "for": "htmlFor",
-    "class": "className",
-    readonly: "readOnly",
-    maxlength: "maxLength",
-    cellspacing: "cellSpacing",
-    rowspan: "rowSpan",
-    colspan: "colSpan",
-    tabindex: "tabIndex",
-    usemap: "useMap",
-    frameborder: "frameBorder"
-  };
-
-  same(propsShouldBe, jQuery.props, "jQuery.props passes integrity check");
+// test("jQuery.props: integrity test", function() {
+// 
+//   expect(1);
+// 
+//   //  This must be maintained and equal jQuery.props
+//   //  Ensure that accidental or erroneous property
+//   //  overwrites don't occur
+//   //  This is simply for better code coverage and future proofing.
+//   var propsShouldBe = {
+//     "for": "htmlFor",
+//     "class": "className",
+//     readonly: "readOnly",
+//     maxlength: "maxLength",
+//     cellspacing: "cellSpacing",
+//     rowspan: "rowSpan",
+//     colspan: "colSpan",
+//     tabindex: "tabIndex",
+//     usemap: "useMap",
+//     frameborder: "frameBorder"
+//   };
+// 
+//   same(propsShouldBe, jQuery.props, "jQuery.props passes integrity check");
+// 
+// });
 
+test("prop", function() {
+	equals( jQuery('#text1').prop('value'), "Test", 'Check for value attribute' );
+	equals( jQuery('#text1').prop('value', "Test2").prop('defaultValue'), "Test", 'Check for defaultValue attribute' );
+	equals( jQuery('#select2').prop('selectedIndex'), 3, 'Check for selectedIndex attribute' );
+	equals( jQuery('#foo').prop('nodeName').toUpperCase(), 'DIV', 'Check for nodeName attribute' );
+	equals( jQuery('#foo').prop('tagName').toUpperCase(), 'DIV', 'Check for tagName attribute' );
+	equals( jQuery("<option/>").prop("selected"), false, "Check selected attribute on disconnected element." );
+	
+	var body = document.body, $body = jQuery( body );
+	ok( $body.prop('nextSibling') === null, 'Make sure a null expando returns null' );
+	body.foo = 'bar';
+	equals( $body.prop('foo'), 'bar', 'Make sure the expando is preferred over the dom attribute' );
+	body.foo = undefined;
+	ok( $body.attr('foo') === undefined, 'Make sure the expando is preferred over the dom attribute, even if undefined' );
+	
+	var select = document.createElement("select"), optgroup = document.createElement("optgroup"), option = document.createElement("option");
+	optgroup.appendChild( option );
+	select.appendChild( optgroup );
+	equals( jQuery(option).prop("selected"), true, "Make sure that a single option is selected, even when in an optgroup." );
+	equals( jQuery(document).prop("nodeName"), "#document", "prop works correctly on document nodes (bug #7451)." );
+	
+	var attributeNode = document.createAttribute("irrelevant"),
+		commentNode = document.createComment("some comment"),
+		textNode = document.createTextNode("some text"),
+		obj = {};
+	jQuery.each( [document, attributeNode, commentNode, textNode, obj, "#firstp"], function( i, ele ) {
+		strictEqual( jQuery(ele).prop("nonexisting"), undefined, "prop works correctly for non existing attributes (bug #7500)." );
+	});
 });
 
 test("attr(String)", function() {
-	expect(37);
+	expect(20);
 
-	// This one sometimes fails randomly ?!
-	equals( jQuery('#text1').attr('value'), "Test", 'Check for value attribute' );
-
-	equals( jQuery('#text1').attr('value', "Test2").attr('defaultValue'), "Test", 'Check for defaultValue attribute' );
 	equals( jQuery('#text1').attr('type'), "text", 'Check for type attribute' );
 	equals( jQuery('#radio1').attr('type'), "radio", 'Check for type attribute' );
 	equals( jQuery('#check1').attr('type'), "checkbox", 'Check for type attribute' );
@@ -51,55 +77,31 @@ test("attr(String)", function() {
 	equals( jQuery('#text1').attr('maxlength'), '30', 'Check for maxlength attribute' );
 	equals( jQuery('#text1').attr('maxLength'), '30', 'Check for maxLength attribute' );
 	equals( jQuery('#area1').attr('maxLength'), '30', 'Check for maxLength attribute' );
-	equals( jQuery('#select2').attr('selectedIndex'), 3, 'Check for selectedIndex attribute' );
-	equals( jQuery('#foo').attr('nodeName').toUpperCase(), 'DIV', 'Check for nodeName attribute' );
-	equals( jQuery('#foo').attr('tagName').toUpperCase(), 'DIV', 'Check for tagName attribute' );
 
 	// using innerHTML in IE causes href attribute to be serialized to the full path
 	jQuery('<a/>').attr({ 'id': 'tAnchor5', 'href': '#5' }).appendTo('#main');
 	equals( jQuery('#tAnchor5').attr('href'), "#5", 'Check for non-absolute href (an anchor)' );
 
-	equals( jQuery("<option/>").attr("selected"), false, "Check selected attribute on disconnected element." );
-
-
 	// Related to [5574] and [5683]
 	var body = document.body, $body = jQuery(body);
 
 	ok( $body.attr('foo') === undefined, 'Make sure that a non existent attribute returns undefined' );
-	ok( $body.attr('nextSibling') === null, 'Make sure a null expando returns null' );
 
 	body.setAttribute('foo', 'baz');
 	equals( $body.attr('foo'), 'baz', 'Make sure the dom attribute is retrieved when no expando is found' );
 
-	body.foo = 'bar';
-	equals( $body.attr('foo'), 'bar', 'Make sure the expando is preferred over the dom attribute' );
-
 	$body.attr('foo','cool');
 	equals( $body.attr('foo'), 'cool', 'Make sure that setting works well when both expando and dom attribute are available' );
 
-	body.foo = undefined;
-	ok( $body.attr('foo') === undefined, 'Make sure the expando is preferred over the dom attribute, even if undefined' );
-
 	body.removeAttribute('foo'); // Cleanup
 
 	var select = document.createElement("select"), optgroup = document.createElement("optgroup"), option = document.createElement("option");
 	optgroup.appendChild( option );
 	select.appendChild( optgroup );
 
-	equals( jQuery(option).attr("selected"), true, "Make sure that a single option is selected, even when in an optgroup." );
-
 	ok( jQuery("<div/>").attr("doesntexist") === undefined, "Make sure undefined is returned when no attribute is found." );
 	ok( jQuery().attr("doesntexist") === undefined, "Make sure undefined is returned when no element is there." );
 
-	equals( jQuery(document).attr("nodeName"), "#document", "attr works correctly on document nodes (bug #7451)." );
-
-	var attributeNode = document.createAttribute("irrelevant"),
-		commentNode = document.createComment("some comment"),
-		textNode = document.createTextNode("some text"),
-		obj = {};
-	jQuery.each( [document, attributeNode, commentNode, textNode, obj, "#firstp"], function( i, ele ) {
-		strictEqual( jQuery(ele).attr("nonexisting"), undefined, "attr works correctly for non existing attributes (bug #7500)." );
-	});
 });
 
 if ( !isLocal ) {
@@ -133,7 +135,7 @@ test("attr(Hash)", function() {
 });
 
 test("attr(String, Object)", function() {
-	expect(30);
+	expect(24);
 
 	var div = jQuery("div").attr("foo", "bar"),
 		fail = false;
@@ -153,7 +155,7 @@ test("attr(String, Object)", function() {
 	jQuery("#name").attr('name', 'something');
 	equals( jQuery("#name").attr('name'), 'something', 'Set name attribute' );
 	jQuery("#name").attr('name', null);
-	equals( jQuery("#name").attr('title'), '', 'Remove name attribute' );
+	equals( jQuery("#name").attr('name'), undefined, 'Remove name attribute' );
 	jQuery("#check2").attr('checked', true);
 	equals( document.getElementById('check2').checked, true, 'Set checked attribute' );
 	jQuery("#check2").attr('checked', false);
@@ -163,28 +165,28 @@ test("attr(String, Object)", function() {
 	jQuery("#text1").attr('readonly', false);
 	equals( document.getElementById('text1').readOnly, false, 'Set readonly attribute' );
 	jQuery("#name").attr('maxlength', '5');
-	equals( document.getElementById('name').maxLength, '5', 'Set maxlength attribute' );
+	equals( document.getElementById('name').maxLength, 5, 'Set maxlength attribute' );
 	jQuery("#name").attr('maxLength', '10');
-	equals( document.getElementById('name').maxLength, '10', 'Set maxlength attribute' );
+	equals( document.getElementById('name').maxLength, 10, 'Set maxlength attribute' );
 
-	var attributeNode = document.createAttribute("irrelevant"),
-		commentNode = document.createComment("some comment"),
-		textNode = document.createTextNode("some text"),
-		obj = {};
-	jQuery.each( [document, obj, "#firstp"], function( i, ele ) {
-		var $ele = jQuery( ele );
-		$ele.attr( "nonexisting", "foo" );
-		equal( $ele.attr("nonexisting"), "foo", "attr(name, value) works correctly for non existing attributes (bug #7500)." );
-	});
-	jQuery.each( [commentNode, textNode, attributeNode], function( i, ele ) {
-		var $ele = jQuery( ele );
-		$ele.attr( "nonexisting", "foo" );
-		strictEqual( $ele.attr("nonexisting"), undefined, "attr(name, value) works correctly on comment and text nodes (bug #7500)." );
-	});
-	//cleanup
-	jQuery.each( [document, "#firstp"], function( i, ele ) {
-		jQuery( ele ).removeAttr("nonexisting");
-	});
+	// var attributeNode = document.createAttribute("irrelevant"),
+	// 	commentNode = document.createComment("some comment"),
+	// 	textNode = document.createTextNode("some text"),
+	// 	obj = {};
+	// jQuery.each( [document, obj, "#firstp"], function( i, ele ) {
+	// 	var $ele = jQuery( ele );
+	// 	$ele.attr( "nonexisting", "foo" );
+	// 	equal( $ele.attr("nonexisting"), "foo", "attr(name, value) works correctly for non existing attributes (bug #7500)." );
+	// });
+	// jQuery.each( [commentNode, textNode, attributeNode], function( i, ele ) {
+	// 	var $ele = jQuery( ele );
+	// 	$ele.attr( "nonexisting", "foo" );
+	// 	strictEqual( $ele.attr("nonexisting"), undefined, "attr(name, value) works correctly on comment and text nodes (bug #7500)." );
+	// });
+	// //cleanup
+	// jQuery.each( [document, "#firstp"], function( i, ele ) {
+	// 	jQuery( ele ).removeAttr("nonexisting");
+	// });
 
 	var table = jQuery('#table').append("<tr><td>cell</td></tr><tr><td>cell</td><td>cell</td></tr><tr><td>cell</td><td>cell</td></tr>"),
 		td = table.find('td:first');
@@ -356,25 +358,29 @@ test("attr('tabindex', value)", function() {
 });
 
 test("removeAttr(String)", function() {
-	expect(7);
+	expect(1);
 	equals( jQuery('#mark').removeAttr( "class" )[0].className, "", "remove class" );
 
+});
+
+test("removeProp(String)", function() {
+	expect(6);
 	var attributeNode = document.createAttribute("irrelevant"),
 		commentNode = document.createComment("some comment"),
 		textNode = document.createTextNode("some text"),
 		obj = {};
-	//removeAttr only really removes on DOM element nodes handle all other seperatyl
-	strictEqual( jQuery( "#firstp" ).attr( "nonexisting", "foo" ).removeAttr( "nonexisting" )[0].nonexisting, undefined, "removeAttr works correctly on DOM element nodes" );
+
+	strictEqual( jQuery( "#firstp" ).prop( "nonexisting", "foo" ).removeProp( "nonexisting" )[0].nonexisting, undefined, "removeprop works correctly on DOM element nodes" );
 
 	jQuery.each( [document, obj], function( i, ele ) {
 		var $ele = jQuery( ele );
-		$ele.attr( "nonexisting", "foo" ).removeAttr( "nonexisting" );
-		strictEqual( ele.nonexisting, "", "removeAttr works correctly on non DOM element nodes (bug #7500)." );
+		$ele.prop( "nonexisting", "foo" ).removeProp( "nonexisting" );
+		strictEqual( ele.nonexisting, undefined, "removeProp works correctly on non DOM element nodes (bug #7500)." );
 	});
 	jQuery.each( [commentNode, textNode, attributeNode], function( i, ele ) {
 		$ele = jQuery( ele );
-		$ele.attr( "nonexisting", "foo" ).removeAttr( "nonexisting" );
-		strictEqual( ele.nonexisting, undefined, "removeAttr works correctly on non DOM element nodes (bug #7500)." );
+		$ele.prop( "nonexisting", "foo" ).removeProp( "nonexisting" );
+		strictEqual( ele.nonexisting, undefined, "removeProp works correctly on non DOM element nodes (bug #7500)." );
 	});
 });
 
@@ -604,21 +610,20 @@ test("addClass(Function)", function() {
 
 test("addClass(Function) with incoming value", function() {
 	expect(45);
-
 	var div = jQuery("div"), old = div.map(function(){
-		return jQuery(this).attr("class");
+		return jQuery(this).attr("class") || "";
 	});
-
+	
 	div.addClass(function(i, val) {
-		if ( this.id !== "_firebugConsole" ) {
+		if ( this.id !== "_firebugConsole") {
 			equals( val, old[i], "Make sure the incoming value is correct." );
 			return "test";
 		}
 	});
 
 	var pass = true;
-	for ( var i = 0; i < div.size(); i++ ) {
-	 if ( div.get(i).className.indexOf("test") == -1 ) pass = false;
+	for ( var i = 0; i < div.length; i++ ) {
+		if ( div.get(i).className.indexOf("test") == -1 ) pass = false;
 	}
 	ok( pass, "Add Class" );
 });
diff --git a/test/unit/manipulation.js b/test/unit/manipulation.js
index ff3dff16..e972a479 100644
--- a/test/unit/manipulation.js
+++ b/test/unit/manipulation.js
@@ -1009,7 +1009,7 @@ test("clone()", function() {
 });
 
 test("clone(form element) (Bug #3879, #6655)", function() {
-	expect(6);
+	expect(5);
 	var element = jQuery("<select><option>Foo</option><option selected>Bar</option></select>");
 
 	equals( element.clone().find("option:selected").val(), element.find("option:selected").val(), "Selected option cloned correctly" );
@@ -1019,7 +1019,9 @@ test("clone(form element) (Bug #3879, #6655)", function() {
 
 	equals( clone.is(":checked"), element.is(":checked"), "Checked input cloned correctly" );
 	equals( clone[0].defaultValue, "foo", "Checked input defaultValue cloned correctly" );
-	equals( clone[0].defaultChecked, !jQuery.support.noCloneChecked, "Checked input defaultChecked cloned correctly" );
+	
+	// defaultChecked also gets set now due to setAttribute in attr, is this check still valid?
+	// equals( clone[0].defaultChecked, !jQuery.support.noCloneChecked, "Checked input defaultChecked cloned correctly" );
 
 	element = jQuery("<input type='text' value='foo'>");
 	clone = element.clone();

From 5eecb13fa3391870e904548f03d8a509117984f3 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Wed, 9 Mar 2011 20:20:53 -0500
Subject: [PATCH 27/91] Now passes in IE8, changed around $.hasAttr and
 switched the attrHook for selected to be a propHook

---
 src/attributes.js       | 39 ++++++++++++++++++++++++++++-----------
 test/unit/attributes.js | 34 +++++-----------------------------
 2 files changed, 33 insertions(+), 40 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index cb8128d2..8de5cf80 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -278,10 +278,11 @@ jQuery.extend({
 	// TODO: Check to see if any of these are needed anymore?
 	// If not, it may be good to standardize on all-lowercase names instead
 	attrFix: {
+		
 	},
 
 	attr: function( elem, name, value, pass ) {
-
+		
 		// don't get/set attributes on text, comment and attribute nodes
 		if ( !elem || elem.nodeType === 3 || elem.nodeType === 8 || elem.nodeType === 2 ) {
 			return undefined;
@@ -294,9 +295,6 @@ jQuery.extend({
 		var ret,
 			notxml = elem.nodeType !== 1 || !jQuery.isXMLDoc( elem ),
 			hooks;
-			
-		// Try to normalize/fix the name
-		name = notxml && jQuery.attrFix[ name ] || name;
 		
 		hooks = jQuery.attrHooks[ name ];
 		
@@ -312,9 +310,7 @@ jQuery.extend({
 			} else {
 				// convert the value to a string (all browsers do this but IE) see #1070
 				value = "" + value;
-				
 				elem.setAttribute( name, value );
-				
 				return value;
 			}
 			
@@ -332,14 +328,24 @@ jQuery.extend({
 				var attr = elem.getAttribute( name );
 
 				// Non-existent attributes return null, we normalize to undefined
-				return attr === null ? undefined : attr;
+				return attr === null || attr === "undefined" ? undefined : attr;
 			}
 		}
 	},
 	
 	hasAttr: function( elem, name ) {
-		// Blackberry 4.7 returns "" from getAttribute #6938
-		return elem && elem.attributes[ name ] || (elem.hasAttribute && elem.hasAttribute( name ));
+		var inAttrs, attrs = elem.attributes;
+		
+		if ( elem.hasAttribute ) {
+			return elem.hasAttribute( name );
+		} else {
+			// Browsers do not understand the associative indexes, look for the name in elem.attributes.name
+			for ( var i = 0, l = attrs.length; i < l; i++ ) {
+				if ( attrs[i]["name"] === name ) {
+					return true;
+				}
+			}
+		}
 	},
 	
 	attrHooks: {
@@ -369,9 +375,16 @@ jQuery.extend({
 	
 	// TODO: Check to see if we really need any here.
 	propFix: {
+		
 	},
 	
 	prop: function( elem, name, value ) {
+		
+		// don't get/set properties on text, comment and attribute nodes
+		if ( !elem || elem.nodeType === 3 || elem.nodeType === 8 || elem.nodeType === 2 ) {
+			return undefined;
+		}
+		
 		var ret, hooks, notxml = elem.nodeType !== 1 || !jQuery.isXMLDoc( elem );
 		
 		// Try to normalize/fix the name
@@ -440,13 +453,17 @@ if ( !jQuery.support.style ) {
 // Safari mis-reports the default selected property of an option
 // Accessing the parent's selectedIndex property fixes it
 if ( !jQuery.support.optSelected ) {
-	jQuery.attrHooks.selected = {
+	
+	jQuery.propHooks.selected = {
 		get: function( elem ) {
 			var parent = elem.parentNode;
 			
 			if ( parent ) {
 				parent.selectedIndex;
-
+				
+				// TODO: We may need an attrHook for selected that simply defers to prop?
+				// The attr is undefined if the option is created with createElement and not on the DOM
+				
 				// Make sure that it also works with optgroups, see #5701
 				if ( parent.parentNode ) {
 					parent.parentNode.selectedIndex;
diff --git a/test/unit/attributes.js b/test/unit/attributes.js
index d4284556..af423e34 100644
--- a/test/unit/attributes.js
+++ b/test/unit/attributes.js
@@ -3,31 +3,6 @@ module("attributes", { teardown: moduleTeardown });
 var bareObj = function(value) { return value; };
 var functionReturningObj = function(value) { return (function() { return value; }); };
 
-// test("jQuery.props: integrity test", function() {
-// 
-//   expect(1);
-// 
-//   //  This must be maintained and equal jQuery.props
-//   //  Ensure that accidental or erroneous property
-//   //  overwrites don't occur
-//   //  This is simply for better code coverage and future proofing.
-//   var propsShouldBe = {
-//     "for": "htmlFor",
-//     "class": "className",
-//     readonly: "readOnly",
-//     maxlength: "maxLength",
-//     cellspacing: "cellSpacing",
-//     rowspan: "rowSpan",
-//     colspan: "colSpan",
-//     tabindex: "tabIndex",
-//     usemap: "useMap",
-//     frameborder: "frameBorder"
-//   };
-// 
-//   same(propsShouldBe, jQuery.props, "jQuery.props passes integrity check");
-// 
-// });
-
 test("prop", function() {
 	equals( jQuery('#text1').prop('value'), "Test", 'Check for value attribute' );
 	equals( jQuery('#text1').prop('value', "Test2").prop('defaultValue'), "Test", 'Check for defaultValue attribute' );
@@ -41,11 +16,12 @@ test("prop", function() {
 	body.foo = 'bar';
 	equals( $body.prop('foo'), 'bar', 'Make sure the expando is preferred over the dom attribute' );
 	body.foo = undefined;
-	ok( $body.attr('foo') === undefined, 'Make sure the expando is preferred over the dom attribute, even if undefined' );
+	ok( $body.prop('foo') === undefined, 'Make sure the expando is preferred over the dom attribute, even if undefined' );
 	
 	var select = document.createElement("select"), optgroup = document.createElement("optgroup"), option = document.createElement("option");
 	optgroup.appendChild( option );
 	select.appendChild( optgroup );
+	
 	equals( jQuery(option).prop("selected"), true, "Make sure that a single option is selected, even when in an optgroup." );
 	equals( jQuery(document).prop("nodeName"), "#document", "prop works correctly on document nodes (bug #7451)." );
 	
@@ -85,7 +61,7 @@ test("attr(String)", function() {
 	// Related to [5574] and [5683]
 	var body = document.body, $body = jQuery(body);
 
-	ok( $body.attr('foo') === undefined, 'Make sure that a non existent attribute returns undefined' );
+	strictEqual( $body.attr('foo'), undefined, 'Make sure that a non existent attribute returns undefined' );
 
 	body.setAttribute('foo', 'baz');
 	equals( $body.attr('foo'), 'baz', 'Make sure the dom attribute is retrieved when no expando is found' );
@@ -118,8 +94,8 @@ if ( !isLocal ) {
 
 test("attr(String, Function)", function() {
 	expect(2);
-	equals( jQuery('#text1').attr('value', function() { return this.id ;})[0].value, "text1", "Set value from id" );
-	equals( jQuery('#text1').attr('title', function(i) { return i }).attr('title'), "0", "Set value with an index");
+	equals( jQuery('#text1').attr('value', function() { return this.id; })[0].value, "text1", "Set value from id" );
+	equals( jQuery('#text1').attr('title', function(i) { return i; }).attr('title'), "0", "Set value with an index");
 });
 
 test("attr(Hash)", function() {

From 607210e01068224ac613558c0a314ad4a8fba247 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Thu, 10 Mar 2011 18:34:15 -0500
Subject: [PATCH 28/91] Speed up hasAttr a little

---
 src/attributes.js | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index 8de5cf80..83d02e21 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -334,18 +334,20 @@ jQuery.extend({
 	},
 	
 	hasAttr: function( elem, name ) {
-		var inAttrs, attrs = elem.attributes;
-		
-		if ( elem.hasAttribute ) {
-			return elem.hasAttribute( name );
-		} else {
-			// Browsers do not understand the associative indexes, look for the name in elem.attributes.name
-			for ( var i = 0, l = attrs.length; i < l; i++ ) {
-				if ( attrs[i]["name"] === name ) {
-					return true;
+
+		return elem.hasAttribute ?
+			elem.hasAttribute( name ) :
+			(function() {
+				// Some browsers do not understand the associative indexes
+				// Look for the name in elem.attributes.name
+				var attrs = elem.attributes, i = 0, len = attrs.length;
+				for ( ; i < len; i++ ) {
+					if ( attrs[i]["name"] === name ) {
+						return true;
+					}
 				}
-			}
-		}
+				return false;
+			})();
 	},
 	
 	attrHooks: {

From 4baa213d881a71ffd8557bc587f81d0bc606d63c Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Fri, 11 Mar 2011 14:51:57 -0500
Subject: [PATCH 29/91] First proposed solution for IE6/7 get/setAttribute
 quirks.  Needs more testing, but solves some issues

---
 src/attributes.js | 39 ++++++++++++++++++++++++++++++---------
 src/support.js    |  5 ++++-
 2 files changed, 34 insertions(+), 10 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index 83d02e21..ee4dc1ba 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -275,12 +275,6 @@ jQuery.extend({
 		offset: true
 	},
 	
-	// TODO: Check to see if any of these are needed anymore?
-	// If not, it may be good to standardize on all-lowercase names instead
-	attrFix: {
-		
-	},
-
 	attr: function( elem, name, value, pass ) {
 		
 		// don't get/set attributes on text, comment and attribute nodes
@@ -342,7 +336,7 @@ jQuery.extend({
 				// Look for the name in elem.attributes.name
 				var attrs = elem.attributes, i = 0, len = attrs.length;
 				for ( ; i < len; i++ ) {
-					if ( attrs[i]["name"] === name ) {
+					if ( attrs[i].name === name ) {
 						return true;
 					}
 				}
@@ -455,7 +449,7 @@ if ( !jQuery.support.style ) {
 // Safari mis-reports the default selected property of an option
 // Accessing the parent's selectedIndex property fixes it
 if ( !jQuery.support.optSelected ) {
-	
+
 	jQuery.propHooks.selected = {
 		get: function( elem ) {
 			var parent = elem.parentNode;
@@ -475,4 +469,31 @@ if ( !jQuery.support.optSelected ) {
 	};
 }
 
-})( jQuery );
+// IE6/7 do not support getting/setting some attributes with get/setAttribute
+
+if ( jQuery.support.attrFix ) {
+	var attrFix = {
+		"for": "htmlFor",
+		"class": "className",
+		readonly: "readOnly",
+		maxlength: "maxLength",
+		cellspacing: "cellSpacing",
+		rowspan: "rowSpan",
+		colspan: "colSpan",
+		tabindex: "tabIndex",
+		usemap: "useMap",
+		frameborder: "frameBorder"
+	};
+	
+	jQuery.each(attrFix, function( key, name ) {
+		jQuery.attrHooks[ key ] = jQuery.extend( jQuery.attrHooks[ key ], {
+			get: function( elem ) {
+				return elem.getAttribute( name );
+			},
+			set: function( elem, value ) {
+				elem.setAttribute( name, value );
+				return value;
+			}
+		});
+	});
+}
\ No newline at end of file
diff --git a/src/support.js b/src/support.js
index 4c309562..3ca28d20 100644
--- a/src/support.js
+++ b/src/support.js
@@ -7,8 +7,9 @@
 	var div = document.createElement("div");
 
 	div.style.display = "none";
+	div.setAttribute("className", "t");
 	div.innerHTML = "   <link/><table></table><a href='/a' style='color:red;float:left;opacity:.55;'>a</a><input type='checkbox'/>";
-
+	
 	var all = div.getElementsByTagName("*"),
 		a = div.getElementsByTagName("a")[0],
 		select = document.createElement("select"),
@@ -58,6 +59,8 @@
 		// (WebKit defaults to false instead of true, IE too, if it's in an optgroup)
 		optSelected: opt.selected,
 
+		attrFix: div.getAttribute("className") === "t",
+
 		// Will be defined later
 		deleteExpando: true,
 		optDisabled: false,

From 00abeaee17a0eed8422a15ff5d48f4011490953b Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Fri, 11 Mar 2011 14:57:37 -0500
Subject: [PATCH 30/91] Didn't actually need the hooks anymore

---
 src/attributes.js | 25 +++++++++----------------
 1 file changed, 9 insertions(+), 16 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index ee4dc1ba..d6179a12 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -275,6 +275,8 @@ jQuery.extend({
 		offset: true
 	},
 	
+	attrFix: {},
+	
 	attr: function( elem, name, value, pass ) {
 		
 		// don't get/set attributes on text, comment and attribute nodes
@@ -285,11 +287,14 @@ jQuery.extend({
 		if ( pass && name in jQuery.attrFn ) {
 			return jQuery(elem)[name](value);
 		}
-
+        
 		var ret,
 			notxml = elem.nodeType !== 1 || !jQuery.isXMLDoc( elem ),
 			hooks;
 		
+		// Normalize the name if needed
+		name = notxml && jQuery.attrFix[ name ] || name;
+		
 		hooks = jQuery.attrHooks[ name ];
 		
 		if ( value !== undefined ) {
@@ -472,8 +477,8 @@ if ( !jQuery.support.optSelected ) {
 // IE6/7 do not support getting/setting some attributes with get/setAttribute
 
 if ( jQuery.support.attrFix ) {
-	var attrFix = {
-		"for": "htmlFor",
+    jQuery.extend(jQuery.attrFix, {
+        "for": "htmlFor",
 		"class": "className",
 		readonly: "readOnly",
 		maxlength: "maxLength",
@@ -483,17 +488,5 @@ if ( jQuery.support.attrFix ) {
 		tabindex: "tabIndex",
 		usemap: "useMap",
 		frameborder: "frameBorder"
-	};
-	
-	jQuery.each(attrFix, function( key, name ) {
-		jQuery.attrHooks[ key ] = jQuery.extend( jQuery.attrHooks[ key ], {
-			get: function( elem ) {
-				return elem.getAttribute( name );
-			},
-			set: function( elem, value ) {
-				elem.setAttribute( name, value );
-				return value;
-			}
-		});
-	});
+    });
 }
\ No newline at end of file

From ebb8e8e300be5da2671f62e939551bd3c859e81e Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Fri, 11 Mar 2011 15:59:34 -0500
Subject: [PATCH 31/91] Fix feature test, accidentally got rid of closure end

---
 src/attributes.js | 11 ++++++-----
 src/support.js    |  2 +-
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index d6179a12..82ebe727 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -475,10 +475,9 @@ if ( !jQuery.support.optSelected ) {
 }
 
 // IE6/7 do not support getting/setting some attributes with get/setAttribute
-
 if ( jQuery.support.attrFix ) {
-    jQuery.extend(jQuery.attrFix, {
-        "for": "htmlFor",
+	jQuery.extend( jQuery.attrFix, {
+		"for": "htmlFor",
 		"class": "className",
 		readonly: "readOnly",
 		maxlength: "maxLength",
@@ -488,5 +487,7 @@ if ( jQuery.support.attrFix ) {
 		tabindex: "tabIndex",
 		usemap: "useMap",
 		frameborder: "frameBorder"
-    });
-}
\ No newline at end of file
+	});
+}
+
+})( jQuery );
\ No newline at end of file
diff --git a/src/support.js b/src/support.js
index 3ca28d20..ebda569f 100644
--- a/src/support.js
+++ b/src/support.js
@@ -59,7 +59,7 @@
 		// (WebKit defaults to false instead of true, IE too, if it's in an optgroup)
 		optSelected: opt.selected,
 
-		attrFix: div.getAttribute("className") === "t",
+		attrFix: div.className === "t",
 
 		// Will be defined later
 		deleteExpando: true,

From 8cd30c62d813af68ccd91cc41adf43b8907f41cf Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Fri, 11 Mar 2011 21:28:42 -0500
Subject: [PATCH 32/91] Continuing IE7 testing, conditional attr fixes and
 hooks with feature testing.  Will figure out a way to shorten after the test
 suite passes.

---
 src/attributes.js       | 132 ++++++++++++++++++++--------------------
 src/core.js             |   2 +-
 src/support.js          |   2 +-
 test/unit/attributes.js |   2 +-
 4 files changed, 68 insertions(+), 70 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index 82ebe727..ad75a001 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -16,7 +16,7 @@ jQuery.fn.extend({
 	removeAttr: function( name ) {
 		return this.each(function() {
 			if ( this.nodeType === 1 ) {
-				this.removeAttribute( name );
+				jQuery.removeAttr( this, name );
 			}
 		});
 	},
@@ -287,68 +287,52 @@ jQuery.extend({
 		if ( pass && name in jQuery.attrFn ) {
 			return jQuery(elem)[name](value);
 		}
-        
+
 		var ret,
 			notxml = elem.nodeType !== 1 || !jQuery.isXMLDoc( elem ),
 			hooks;
-		
+
 		// Normalize the name if needed
 		name = notxml && jQuery.attrFix[ name ] || name;
-		
+
 		hooks = jQuery.attrHooks[ name ];
-		
+
 		if ( value !== undefined ) {
-			
+
 			if ( hooks && "set" in hooks && notxml && (ret = hooks.set( elem, value )) !== undefined ) {
 				return ret;
-			
+
 			} else if ( value === null ) {
-				elem.removeAttribute( name );
+				jQuery.removeAttr( elem, name );
 				return undefined;
-				
+
 			} else {
-				// convert the value to a string (all browsers do this but IE) see #1070
-				value = "" + value;
 				elem.setAttribute( name, value );
 				return value;
 			}
-			
+
 		} else {
-			
+
 			if ( hooks && "get" in hooks && notxml && (ret = hooks.get( elem )) !== undefined ) {
 				return ret;
-				
+
 			} else {
-
-				if ( !jQuery.hasAttr( elem, name ) ) {
-					return undefined;
-				}
-
 				var attr = elem.getAttribute( name );
 
 				// Non-existent attributes return null, we normalize to undefined
-				return attr === null || attr === "undefined" ? undefined : attr;
+				return attr === null || attr === "undefined" || attr === "null" ? undefined : attr;
 			}
 		}
 	},
 	
-	hasAttr: function( elem, name ) {
-
-		return elem.hasAttribute ?
-			elem.hasAttribute( name ) :
-			(function() {
-				// Some browsers do not understand the associative indexes
-				// Look for the name in elem.attributes.name
-				var attrs = elem.attributes, i = 0, len = attrs.length;
-				for ( ; i < len; i++ ) {
-					if ( attrs[i].name === name ) {
-						return true;
-					}
-				}
-				return false;
-			})();
+	// removeAttribute returns boolean in IE6/7
+	// set property to null in that case
+	removeAttr: function( elem, name ) {
+		if ( typeof elem.removeAttribute( name ) === "boolean" ) {
+			elem.setAttribute( name, null );
+		}
 	},
-	
+
 	attrHooks: {
 		type: {
 			set: function( elem, value ) {
@@ -357,20 +341,6 @@ jQuery.extend({
 					jQuery.error( "type property can't be changed" );
 				}
 			}
-		},
-		
-		// elem.tabIndex doesn't always return the correct value when it hasn't been explicitly set
-		// http://fluidproject.org/blog/2008/01/09/getting-setting-and-removing-tabindex-values-with-javascript/
-		tabindex: {
-			get: function( elem ) {
-				var attributeNode = elem.getAttributeNode( "tabIndex" );
-
-				return attributeNode && attributeNode.specified ?
-					attributeNode.value :
-					rfocusable.test( elem.nodeName ) || rclickable.test( elem.nodeName ) && elem.href ?
-						0 :
-						undefined;
-			}
 		}
 	},
 	
@@ -414,20 +384,64 @@ jQuery.extend({
 	propHooks: {}
 });
 
+// IE6/7 do not support getting/setting some attributes with get/setAttribute
+if ( !jQuery.support.getSetAttribute ) {
+	jQuery.attrFix = jQuery.extend( jQuery.attrFix, {
+		"for": "htmlFor",
+		"class": "className",
+		readonly: "readOnly",
+		maxlength: "maxLength",
+		cellspacing: "cellSpacing",
+		rowspan: "rowSpan",
+		colspan: "colSpan",
+		tabindex: "tabIndex",
+		usemap: "useMap",
+		frameborder: "frameBorder"
+	});
+
+	// Action attribute in ie6/7 returns form object
+	jQuery.attrHooks.action = jQuery.extend( jQuery.attrHooks.action, {
+		get: function( elem ) {
+			return elem.nodeName === "FORM" ? elem.getAttributeNode("action").nodeValue : elem.getAttribute("action");
+		},
+		set: function( elem, value ) {
+			elem.nodeName === "FORM" ? elem.getAttributeNode("action").nodeValue = value : elem.setAttribute("action", value);
+			return value;
+		}
+	});
+}
+
 // Remove certain attrs if set to false
 jQuery.each([ "selected", "checked", "readonly", "disabled" ], function( i, name ) {
+	name = jQuery.attrFix[ name ] || name;
+	
 	jQuery.attrHooks[ name ] = jQuery.extend( jQuery.attrHooks[ name ], {
 		set: function( elem, value ) {
 			if ( !value ) { // '', undefined, false, null will remove attr
-				elem.removeAttribute( name );
+				jQuery.removeAttr( elem, name );
 				return false;
 			}
+
 			elem.setAttribute( name, value );
 			return value;
 		}
 	});
 });
 
+// elem.tabIndex doesn't always return the correct value when it hasn't been explicitly set
+// http://fluidproject.org/blog/2008/01/09/getting-setting-and-removing-tabindex-values-with-javascript/
+jQuery.attrHooks[ jQuery.attrFix.tabindex || "tabindex" ] = {
+	get: function( elem ) {
+		var attributeNode = elem.getAttributeNode("tabIndex");
+
+		return attributeNode && attributeNode.specified ?
+			parseInt( attributeNode.value, 10 ) :
+			rfocusable.test( elem.nodeName ) || rclickable.test( elem.nodeName ) && elem.href ?
+				0 :
+				undefined;
+	}
+};
+
 // Some attributes require a special call on IE
 if ( !jQuery.support.hrefNormalized ) {
 	jQuery.each([ "href", "src", "style" ], function( i, name ) {
@@ -474,20 +488,4 @@ if ( !jQuery.support.optSelected ) {
 	};
 }
 
-// IE6/7 do not support getting/setting some attributes with get/setAttribute
-if ( jQuery.support.attrFix ) {
-	jQuery.extend( jQuery.attrFix, {
-		"for": "htmlFor",
-		"class": "className",
-		readonly: "readOnly",
-		maxlength: "maxLength",
-		cellspacing: "cellSpacing",
-		rowspan: "rowSpan",
-		colspan: "colSpan",
-		tabindex: "tabIndex",
-		usemap: "useMap",
-		frameborder: "frameBorder"
-	});
-}
-
 })( jQuery );
\ No newline at end of file
diff --git a/src/core.js b/src/core.js
index 9312ee28..6b00a015 100644
--- a/src/core.js
+++ b/src/core.js
@@ -894,4 +894,4 @@ function doScrollCheck() {
 // Expose jQuery to the global object
 return jQuery;
 
-})();
+})();
\ No newline at end of file
diff --git a/src/support.js b/src/support.js
index ebda569f..8e86c46c 100644
--- a/src/support.js
+++ b/src/support.js
@@ -59,7 +59,7 @@
 		// (WebKit defaults to false instead of true, IE too, if it's in an optgroup)
 		optSelected: opt.selected,
 
-		attrFix: div.className === "t",
+		getSetAttribute: div.className !== "t",
 
 		// Will be defined later
 		deleteExpando: true,
diff --git a/test/unit/attributes.js b/test/unit/attributes.js
index af423e34..d3293545 100644
--- a/test/unit/attributes.js
+++ b/test/unit/attributes.js
@@ -824,4 +824,4 @@ test("addClass, removeClass, hasClass", function() {
 	ok( jq.hasClass("cla.ss3")==false, "Check the dotted class has been removed" );
 	jq.removeClass("class4");
 	ok( jq.hasClass("class4")==false, "Check the class has been properly removed" );
-});
+});
\ No newline at end of file

From 9f88fa9165e73b879d0c955fdf81fdd681d2d192 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Sun, 13 Mar 2011 15:44:51 -0400
Subject: [PATCH 33/91] Full test suite now passes in all browsers! There are
 probably some tweaks we can make to shorten and simplify.

- removeAttr now only uses setAttribute if camelCase setAttribute is not supported

  + Might want to rename jQuery.support.getSetAttribute

- tabIndex is a special case now for hooks where undefined should be returned.

  + Should we be checking if hooks returns undefined?  undefined might be the desired return value in future hooks.
    As of now, tabIndex is the only one that needs it, but the test suite will still pass if we don't check if hooks are undefined.
---
 src/attributes.js | 16 +++++++++-------
 src/support.js    |  3 ++-
 2 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index ad75a001..64b61261 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -313,7 +313,7 @@ jQuery.extend({
 
 		} else {
 
-			if ( hooks && "get" in hooks && notxml && (ret = hooks.get( elem )) !== undefined ) {
+			if ( hooks && "get" in hooks && notxml && ((ret = hooks.get( elem )) !== undefined || name === "tabIndex") ) {
 				return ret;
 
 			} else {
@@ -325,11 +325,13 @@ jQuery.extend({
 		}
 	},
 	
-	// removeAttribute returns boolean in IE6/7
-	// set property to null in that case
+	// removeAttribute returns boolean in IE
+	// set property to null if getSetAttribute not supported (IE6-7)
 	removeAttr: function( elem, name ) {
-		if ( typeof elem.removeAttribute( name ) === "boolean" ) {
-			elem.setAttribute( name, null );
+		name = jQuery.attrFix[ name ] || name;
+		if ( typeof elem.removeAttribute( name ) === "boolean" && !jQuery.support.getSetAttribute ) {
+			// Setting className to null sets a class of "null"
+			name === "className" ? elem.className = "" : elem.setAttribute( name, null );
 		}
 	},
 
@@ -399,7 +401,7 @@ if ( !jQuery.support.getSetAttribute ) {
 		frameborder: "frameBorder"
 	});
 
-	// Action attribute in ie6/7 returns form object
+	// Action attribute in ie6/7 returns form objects
 	jQuery.attrHooks.action = jQuery.extend( jQuery.attrHooks.action, {
 		get: function( elem ) {
 			return elem.nodeName === "FORM" ? elem.getAttributeNode("action").nodeValue : elem.getAttribute("action");
@@ -414,7 +416,7 @@ if ( !jQuery.support.getSetAttribute ) {
 // Remove certain attrs if set to false
 jQuery.each([ "selected", "checked", "readonly", "disabled" ], function( i, name ) {
 	name = jQuery.attrFix[ name ] || name;
-	
+
 	jQuery.attrHooks[ name ] = jQuery.extend( jQuery.attrHooks[ name ], {
 		set: function( elem, value ) {
 			if ( !value ) { // '', undefined, false, null will remove attr
diff --git a/src/support.js b/src/support.js
index 8e86c46c..b227293d 100644
--- a/src/support.js
+++ b/src/support.js
@@ -58,7 +58,8 @@
 		// Make sure that a selected-by-default option has a working selected property.
 		// (WebKit defaults to false instead of true, IE too, if it's in an optgroup)
 		optSelected: opt.selected,
-
+		
+		// Test setAttribute on camelCase class. If it works, we need attrFixes when doing get/setAttribute (ie6/7)
 		getSetAttribute: div.className !== "t",
 
 		// Will be defined later

From b85d2cd8a5c49487dc3ea7f6fad963efd9fd0f55 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Sun, 13 Mar 2011 16:17:13 -0400
Subject: [PATCH 34/91] Simplify jQuery.removeAttr and return this

---
 src/attributes.js | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index 64b61261..c19b8292 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -325,14 +325,15 @@ jQuery.extend({
 		}
 	},
 	
-	// removeAttribute returns boolean in IE
-	// set property to null if getSetAttribute not supported (IE6-7)
 	removeAttr: function( elem, name ) {
 		name = jQuery.attrFix[ name ] || name;
-		if ( typeof elem.removeAttribute( name ) === "boolean" && !jQuery.support.getSetAttribute ) {
-			// Setting className to null sets a class of "null"
+		
+		jQuery.support.getSetAttribute ? elem.removeAttribute( name ) :
+			// set property to null if getSetAttribute not supported (IE6-7)
+			// setting className to null makes the class "null"
 			name === "className" ? elem.className = "" : elem.setAttribute( name, null );
-		}
+
+		return this;
 	},
 
 	attrHooks: {

From 77c559c3cbe361a87de735a67812695685b613e6 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Sun, 13 Mar 2011 16:23:21 -0400
Subject: [PATCH 35/91] No, don't return this.

---
 src/attributes.js | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index c19b8292..0a39cba8 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -332,8 +332,6 @@ jQuery.extend({
 			// set property to null if getSetAttribute not supported (IE6-7)
 			// setting className to null makes the class "null"
 			name === "className" ? elem.className = "" : elem.setAttribute( name, null );
-
-		return this;
 	},
 
 	attrHooks: {

From f578e0f99748ec5ae84d750f0922957e5fea25cb Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Sun, 13 Mar 2011 16:29:33 -0400
Subject: [PATCH 36/91] Don't use extend when setting the action attrHook for
 IE6/7

---
 src/attributes.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index 0a39cba8..37a6c1e5 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -401,7 +401,7 @@ if ( !jQuery.support.getSetAttribute ) {
 	});
 
 	// Action attribute in ie6/7 returns form objects
-	jQuery.attrHooks.action = jQuery.extend( jQuery.attrHooks.action, {
+	jQuery.attrHooks.action = {
 		get: function( elem ) {
 			return elem.nodeName === "FORM" ? elem.getAttributeNode("action").nodeValue : elem.getAttribute("action");
 		},
@@ -409,7 +409,7 @@ if ( !jQuery.support.getSetAttribute ) {
 			elem.nodeName === "FORM" ? elem.getAttributeNode("action").nodeValue = value : elem.setAttribute("action", value);
 			return value;
 		}
-	});
+	};
 }
 
 // Remove certain attrs if set to false

From dbe3b7a9d052b7bf0c73ead1ecd43a40152416a0 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Sun, 13 Mar 2011 21:27:45 -0400
Subject: [PATCH 37/91] Style edits according to comments from John and
 rwaldron.

---
 src/attributes.js       | 28 +++++++++++++++++++---------
 test/unit/attributes.js | 25 +++++++++++++++++++++++++
 2 files changed, 44 insertions(+), 9 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index 37a6c1e5..d045ca67 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -320,7 +320,9 @@ jQuery.extend({
 				var attr = elem.getAttribute( name );
 
 				// Non-existent attributes return null, we normalize to undefined
-				return attr === null || attr === "undefined" || attr === "null" ? undefined : attr;
+				return attr === null || attr === "undefined" || attr === "null" ?
+					undefined :
+					attr;
 			}
 		}
 	},
@@ -328,10 +330,17 @@ jQuery.extend({
 	removeAttr: function( elem, name ) {
 		name = jQuery.attrFix[ name ] || name;
 		
-		jQuery.support.getSetAttribute ? elem.removeAttribute( name ) :
+		if ( jQuery.support.getSetAttribute ) {
+			elem.removeAttribute( name )
+		} else {
 			// set property to null if getSetAttribute not supported (IE6-7)
 			// setting className to null makes the class "null"
-			name === "className" ? elem.className = "" : elem.setAttribute( name, null );
+			if ( name === "className" ) {
+				elem.className = ""
+			} else {
+				elem.setAttribute( name, null );
+			}
+		}
 	},
 
 	attrHooks: {
@@ -345,10 +354,7 @@ jQuery.extend({
 		}
 	},
 	
-	// TODO: Check to see if we really need any here.
-	propFix: {
-		
-	},
+	propFix: {},
 	
 	prop: function( elem, name, value ) {
 		
@@ -403,10 +409,14 @@ if ( !jQuery.support.getSetAttribute ) {
 	// Action attribute in ie6/7 returns form objects
 	jQuery.attrHooks.action = {
 		get: function( elem ) {
-			return elem.nodeName === "FORM" ? elem.getAttributeNode("action").nodeValue : elem.getAttribute("action");
+			return elem.nodeName === "FORM" ?
+				elem.getAttributeNode("action").nodeValue :
+				elem.getAttribute("action");
 		},
 		set: function( elem, value ) {
-			elem.nodeName === "FORM" ? elem.getAttributeNode("action").nodeValue = value : elem.setAttribute("action", value);
+			elem.nodeName === "FORM" ?
+				elem.getAttributeNode("action").nodeValue = value :
+				elem.setAttribute("action", value);
 			return value;
 		}
 	};
diff --git a/test/unit/attributes.js b/test/unit/attributes.js
index d3293545..8b483dcc 100644
--- a/test/unit/attributes.js
+++ b/test/unit/attributes.js
@@ -3,6 +3,31 @@ module("attributes", { teardown: moduleTeardown });
 var bareObj = function(value) { return value; };
 var functionReturningObj = function(value) { return (function() { return value; }); };
 
+if ( !jQuery.support.getSetAttribute ) {
+	test("jQuery.attrFix integrity test", function() {
+		expect(1);
+
+		//  This must be maintained and equal jQuery.attrFix when appropriate
+		//  Ensure that accidental or erroneous property
+		//  overwrites don't occur
+		//  This is simply for better code coverage and future proofing.
+		var propsShouldBe = {
+			"for": "htmlFor",
+			"class": "className",
+			readonly: "readOnly",
+			maxlength: "maxLength",
+			cellspacing: "cellSpacing",
+			rowspan: "rowSpan",
+			colspan: "colSpan",
+			tabindex: "tabIndex",
+			usemap: "useMap",
+			frameborder: "frameBorder"
+		};
+
+		same(propsShouldBe, jQuery.attrFix, "jQuery.attrFix passes integrity check");
+	});
+}
+
 test("prop", function() {
 	equals( jQuery('#text1').prop('value'), "Test", 'Check for value attribute' );
 	equals( jQuery('#text1').prop('value', "Test2").prop('defaultValue'), "Test", 'Check for defaultValue attribute' );

From 5ac6ca3fa52a4a27d6952c71a77420e3e4a5d88a Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Sun, 13 Mar 2011 22:24:45 -0400
Subject: [PATCH 38/91] Restored 6 tests that I had commented to come back to
 later to split up between prop and attr.  All tests still pass in all
 browsers.

- I should make it clear that I have not removed any tests, but only moved some attr tests to prop where I thought it was appropriate.
---
 test/unit/attributes.js | 45 ++++++++++++++++++++++-------------------
 1 file changed, 24 insertions(+), 21 deletions(-)

diff --git a/test/unit/attributes.js b/test/unit/attributes.js
index 8b483dcc..89762e76 100644
--- a/test/unit/attributes.js
+++ b/test/unit/attributes.js
@@ -28,7 +28,8 @@ if ( !jQuery.support.getSetAttribute ) {
 	});
 }
 
-test("prop", function() {
+test("prop(String)", function() {
+	expect(19);
 	equals( jQuery('#text1').prop('value'), "Test", 'Check for value attribute' );
 	equals( jQuery('#text1').prop('value', "Test2").prop('defaultValue'), "Test", 'Check for defaultValue attribute' );
 	equals( jQuery('#select2').prop('selectedIndex'), 3, 'Check for selectedIndex attribute' );
@@ -57,6 +58,14 @@ test("prop", function() {
 	jQuery.each( [document, attributeNode, commentNode, textNode, obj, "#firstp"], function( i, ele ) {
 		strictEqual( jQuery(ele).prop("nonexisting"), undefined, "prop works correctly for non existing attributes (bug #7500)." );
 	});
+	
+	var obj = {};
+	jQuery.each( [document, obj], function( i, ele ) {
+		var $ele = jQuery( ele );
+		$ele.prop( "nonexisting", "foo" );
+		equal( $ele.prop("nonexisting"), "foo", "prop(name, value) works correctly for non existing attributes (bug #7500)." );
+	});
+	jQuery( document ).removeProp("nonexisting");
 });
 
 test("attr(String)", function() {
@@ -136,7 +145,7 @@ test("attr(Hash)", function() {
 });
 
 test("attr(String, Object)", function() {
-	expect(24);
+	expect(28);
 
 	var div = jQuery("div").attr("foo", "bar"),
 		fail = false;
@@ -169,25 +178,19 @@ test("attr(String, Object)", function() {
 	equals( document.getElementById('name').maxLength, 5, 'Set maxlength attribute' );
 	jQuery("#name").attr('maxLength', '10');
 	equals( document.getElementById('name').maxLength, 10, 'Set maxlength attribute' );
-
-	// var attributeNode = document.createAttribute("irrelevant"),
-	// 	commentNode = document.createComment("some comment"),
-	// 	textNode = document.createTextNode("some text"),
-	// 	obj = {};
-	// jQuery.each( [document, obj, "#firstp"], function( i, ele ) {
-	// 	var $ele = jQuery( ele );
-	// 	$ele.attr( "nonexisting", "foo" );
-	// 	equal( $ele.attr("nonexisting"), "foo", "attr(name, value) works correctly for non existing attributes (bug #7500)." );
-	// });
-	// jQuery.each( [commentNode, textNode, attributeNode], function( i, ele ) {
-	// 	var $ele = jQuery( ele );
-	// 	$ele.attr( "nonexisting", "foo" );
-	// 	strictEqual( $ele.attr("nonexisting"), undefined, "attr(name, value) works correctly on comment and text nodes (bug #7500)." );
-	// });
-	// //cleanup
-	// jQuery.each( [document, "#firstp"], function( i, ele ) {
-	// 	jQuery( ele ).removeAttr("nonexisting");
-	// });
+	var $p = jQuery('#firstp').attr('nonexisting', 'foo');
+	equals( $p.attr('nonexisting'), 'foo', "attr(name, value) works correctly for non existing attributes (bug #7500).");
+	$p.removeAttr('nonexisting');
+	
+	var attributeNode = document.createAttribute("irrelevant"),
+		commentNode = document.createComment("some comment"),
+		textNode = document.createTextNode("some text");
+	
+	jQuery.each( [commentNode, textNode, attributeNode], function( i, ele ) {
+		var $ele = jQuery( ele );
+		$ele.attr( "nonexisting", "foo" );
+		strictEqual( $ele.attr("nonexisting"), undefined, "attr(name, value) works correctly on comment and text nodes (bug #7500)." );
+	});
 
 	var table = jQuery('#table').append("<tr><td>cell</td></tr><tr><td>cell</td><td>cell</td></tr><tr><td>cell</td><td>cell</td></tr>"),
 		td = table.find('td:first');

From 2580420b7e1137acff7ec9fb38c1698e231e1d68 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Tue, 15 Mar 2011 22:47:20 -0400
Subject: [PATCH 39/91] Test description

---
 test/unit/attributes.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/unit/attributes.js b/test/unit/attributes.js
index 89762e76..b9605d15 100644
--- a/test/unit/attributes.js
+++ b/test/unit/attributes.js
@@ -28,7 +28,7 @@ if ( !jQuery.support.getSetAttribute ) {
 	});
 }
 
-test("prop(String)", function() {
+test("prop(String, Object)", function() {
 	expect(19);
 	equals( jQuery('#text1').prop('value'), "Test", 'Check for value attribute' );
 	equals( jQuery('#text1').prop('value', "Test2").prop('defaultValue'), "Test", 'Check for defaultValue attribute' );

From d28922bc03ea03dd7f02bbc4abc8061ea4c7305b Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Wed, 16 Mar 2011 19:00:20 -0400
Subject: [PATCH 40/91] Pass jslint, 2 missing semicolons

---
 src/attributes.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index d045ca67..972a02f7 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -331,12 +331,12 @@ jQuery.extend({
 		name = jQuery.attrFix[ name ] || name;
 		
 		if ( jQuery.support.getSetAttribute ) {
-			elem.removeAttribute( name )
+			elem.removeAttribute( name );
 		} else {
 			// set property to null if getSetAttribute not supported (IE6-7)
 			// setting className to null makes the class "null"
 			if ( name === "className" ) {
-				elem.className = ""
+				elem.className = "";
 			} else {
 				elem.setAttribute( name, null );
 			}

From dfeeb872d611c7ff7270fceb7234dd0e04671eb8 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Thu, 17 Mar 2011 22:59:05 -0400
Subject: [PATCH 41/91] Performance enhancement switching nodeType to a var

---
 src/attributes.js | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index 972a02f7..55d22eb9 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -278,20 +278,20 @@ jQuery.extend({
 	attrFix: {},
 	
 	attr: function( elem, name, value, pass ) {
+		var nType = elem.nodeType;
 		
 		// don't get/set attributes on text, comment and attribute nodes
-		if ( !elem || elem.nodeType === 3 || elem.nodeType === 8 || elem.nodeType === 2 ) {
+		if ( !elem || nType === 3 || nType === 8 || nType === 2 ) {
 			return undefined;
 		}
 
 		if ( pass && name in jQuery.attrFn ) {
 			return jQuery(elem)[name](value);
 		}
-
-		var ret,
-			notxml = elem.nodeType !== 1 || !jQuery.isXMLDoc( elem ),
-			hooks;
-
+		
+		var ret, hooks,
+			notxml = nType !== 1 || !jQuery.isXMLDoc( elem );
+		
 		// Normalize the name if needed
 		name = notxml && jQuery.attrFix[ name ] || name;
 
@@ -357,13 +357,15 @@ jQuery.extend({
 	propFix: {},
 	
 	prop: function( elem, name, value ) {
+		var nType = elem.nodeType;
 		
 		// don't get/set properties on text, comment and attribute nodes
-		if ( !elem || elem.nodeType === 3 || elem.nodeType === 8 || elem.nodeType === 2 ) {
+		if ( !elem || nType === 3 || nType === 8 || nType === 2 ) {
 			return undefined;
 		}
 		
-		var ret, hooks, notxml = elem.nodeType !== 1 || !jQuery.isXMLDoc( elem );
+		var ret, hooks,
+			notxml = nType !== 1 || !jQuery.isXMLDoc( elem );
 		
 		// Try to normalize/fix the name
 		name = notxml && jQuery.propFix[ name ] || name;

From 11cfdb23940b2c76e1104c82afc9552ac6f3dc19 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Thu, 24 Mar 2011 00:42:00 -0400
Subject: [PATCH 42/91] Non-existent attribute for jQuery.attr no longer needs
 to check for "undefined"

- Remove an unnecessary var

- Use variable in removeAttr for better minification
---
 src/attributes.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index 55d22eb9..dc9a333b 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -317,12 +317,12 @@ jQuery.extend({
 				return ret;
 
 			} else {
-				var attr = elem.getAttribute( name );
+				ret = elem.getAttribute( name );
 
 				// Non-existent attributes return null, we normalize to undefined
-				return attr === null || attr === "undefined" || attr === "null" ?
+				return ret === null || ret === "null" ?
 					undefined :
-					attr;
+					ret;
 			}
 		}
 	},
@@ -336,7 +336,7 @@ jQuery.extend({
 			// set property to null if getSetAttribute not supported (IE6-7)
 			// setting className to null makes the class "null"
 			if ( name === "className" ) {
-				elem.className = "";
+				elem[ name ] = "";
 			} else {
 				elem.setAttribute( name, null );
 			}

From 102053abd84124b1a69606565bd8da82bc5d30e9 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Fri, 25 Mar 2011 00:35:50 -0400
Subject: [PATCH 43/91] Fix #7472 and added test for #3113

- Forms with an input that has either name="action" or name="some-other-attr-on-the-form" caused problems in IE6/7.  This is fixed.

- Changed check in $.attr for ret === null to typeof ret === "object" to catch any inputs that are accidentally retrieved in IE6/7, since attributes cannot be set to objects and typeof null === "object"
---
 src/attributes.js       | 3 ++-
 test/index.html         | 1 +
 test/unit/attributes.js | 8 +++++---
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index dc9a333b..564eaeeb 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -320,7 +320,8 @@ jQuery.extend({
 				ret = elem.getAttribute( name );
 
 				// Non-existent attributes return null, we normalize to undefined
-				return ret === null || ret === "null" ?
+				// Instead of checking for null, we check for typeof object to catch inputs in IE6/7. Bug #7472
+				return typeof ret === "object" || ret === "null" ?
 					undefined :
 					ret;
 			}
diff --git a/test/index.html b/test/index.html
index c7c2ae55..4a8aef52 100644
--- a/test/index.html
+++ b/test/index.html
@@ -203,6 +203,7 @@ Z</textarea>
 			<select name="D4" disabled="disabled">
 				<option selected="selected" value="NO">NO</option>
 			</select>
+			<input name="id">
 		</form>
 		<div id="moretests">
 			<form>
diff --git a/test/unit/attributes.js b/test/unit/attributes.js
index b9605d15..5b614446 100644
--- a/test/unit/attributes.js
+++ b/test/unit/attributes.js
@@ -69,7 +69,7 @@ test("prop(String, Object)", function() {
 });
 
 test("attr(String)", function() {
-	expect(20);
+	expect(22);
 
 	equals( jQuery('#text1').attr('type'), "text", 'Check for type attribute' );
 	equals( jQuery('#radio1').attr('type'), "radio", 'Check for type attribute' );
@@ -82,8 +82,10 @@ test("attr(String)", function() {
 	equals( jQuery('#name').attr('name'), "name", 'Check for name attribute' );
 	equals( jQuery('#text1').attr('name'), "action", 'Check for name attribute' );
 	ok( jQuery('#form').attr('action').indexOf("formaction") >= 0, 'Check for action attribute' );
-	// Temporarily disabled. See: #4299
-	// ok( jQuery('#form').attr('action','newformaction').attr('action').indexOf("newformaction") >= 0, 'Check that action attribute was changed' );
+	// [7472] & [3113] (form contains an input with name="action" or name="id")
+	equals( jQuery('#form').attr('action','newformaction').attr('action'), 'newformaction', 'Check that action attribute was changed' );
+	equals( jQuery('#testForm').removeAttr('id').attr('id'), undefined, 'Test that id does not equal the input with name=id after id is removed [#7472]' );
+	
 	equals( jQuery('#text1').attr('maxlength'), '30', 'Check for maxlength attribute' );
 	equals( jQuery('#text1').attr('maxLength'), '30', 'Check for maxLength attribute' );
 	equals( jQuery('#area1').attr('maxLength'), '30', 'Check for maxLength attribute' );

From 9e05a0a37fcc6fc4985a95370f91e1f792e2273b Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Fri, 25 Mar 2011 01:46:29 -0400
Subject: [PATCH 44/91] Fix #6562, tighten up the special code for form
 objects, add name attrHook for IE6/7, and don't check for undefined with
 getting hook'd attr

---
 src/attributes.js       | 86 +++++++++++++++++++++--------------------
 test/index.html         |  3 +-
 test/unit/attributes.js | 36 ++++++++++-------
 3 files changed, 69 insertions(+), 56 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index 564eaeeb..3c6dee8b 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -275,7 +275,10 @@ jQuery.extend({
 		offset: true
 	},
 	
-	attrFix: {},
+	attrFix: {
+		// Always normalize to ensure hook usage
+		tabindex: "tabIndex"
+	},
 	
 	attr: function( elem, name, value, pass ) {
 		var nType = elem.nodeType;
@@ -290,7 +293,8 @@ jQuery.extend({
 		}
 		
 		var ret, hooks,
-			notxml = nType !== 1 || !jQuery.isXMLDoc( elem );
+			notxml = nType !== 1 || !jQuery.isXMLDoc( elem ),
+			isFormObjects = !jQuery.support.getSetAttribute && elem.nodeName === "FORM";
 		
 		// Normalize the name if needed
 		name = notxml && jQuery.attrFix[ name ] || name;
@@ -307,17 +311,30 @@ jQuery.extend({
 				return undefined;
 
 			} else {
-				elem.setAttribute( name, value );
+				
+				// Check form objects in IE (multiple bugs related)
+				if ( isFormObjects ) {
+					elem.getAttributeNode( name ).nodeValue = value;
+				} else {
+					elem.setAttribute( name, value );
+				}
 				return value;
 			}
 
 		} else {
 
-			if ( hooks && "get" in hooks && notxml && ((ret = hooks.get( elem )) !== undefined || name === "tabIndex") ) {
-				return ret;
+			if ( hooks && "get" in hooks && notxml ) {
+				return hooks.get( elem );
 
 			} else {
-				ret = elem.getAttribute( name );
+				
+				// Check form objects in IE (multiple bugs related)
+				if ( isFormObjects ) {
+					// Returns undefined for empty string, which is the blank nodeValue in IE
+					ret = elem.getAttributeNode( name ).nodeValue || undefined;
+				} else {
+					ret = elem.getAttribute( name );
+				}
 
 				// Non-existent attributes return null, we normalize to undefined
 				// Instead of checking for null, we check for typeof object to catch inputs in IE6/7. Bug #7472
@@ -334,13 +351,9 @@ jQuery.extend({
 		if ( jQuery.support.getSetAttribute ) {
 			elem.removeAttribute( name );
 		} else {
-			// set property to null if getSetAttribute not supported (IE6-7)
-			// setting className to null makes the class "null"
-			if ( name === "className" ) {
-				elem[ name ] = "";
-			} else {
-				elem.setAttribute( name, null );
-			}
+			// use DOM level 1 if getSetAttribute not supported (IE6-7)
+			elem.setAttribute( name, "" ); // Set to default empty string
+			elem.removeAttributeNode( elem.getAttributeNode( name ) );
 		}
 	},
 
@@ -352,6 +365,19 @@ jQuery.extend({
 					jQuery.error( "type property can't be changed" );
 				}
 			}
+		},
+		tabIndex: {
+			get: function( elem ) {
+				// elem.tabIndex doesn't always return the correct value when it hasn't been explicitly set
+				// http://fluidproject.org/blog/2008/01/09/getting-setting-and-removing-tabindex-values-with-javascript/
+				var attributeNode = elem.getAttributeNode("tabIndex");
+
+				return attributeNode && attributeNode.specified ?
+					parseInt( attributeNode.value, 10 ) :
+					rfocusable.test( elem.nodeName ) || rclickable.test( elem.nodeName ) && elem.href ?
+						0 :
+						undefined;
+			}
 		}
 	},
 	
@@ -404,23 +430,15 @@ if ( !jQuery.support.getSetAttribute ) {
 		cellspacing: "cellSpacing",
 		rowspan: "rowSpan",
 		colspan: "colSpan",
-		tabindex: "tabIndex",
 		usemap: "useMap",
 		frameborder: "frameBorder"
 	});
-
-	// Action attribute in ie6/7 returns form objects
-	jQuery.attrHooks.action = {
-		get: function( elem ) {
-			return elem.nodeName === "FORM" ?
-				elem.getAttributeNode("action").nodeValue :
-				elem.getAttribute("action");
-		},
-		set: function( elem, value ) {
-			elem.nodeName === "FORM" ?
-				elem.getAttributeNode("action").nodeValue = value :
-				elem.setAttribute("action", value);
-			return value;
+	
+	// Name attribute will not get removed in browsers that do not support getSetAttribute
+	// Return undefined on empty string or null
+	jQuery.attrHooks.name = {
+		get: function( elem, value ) {
+			return elem.getAttributeNode("name").nodeValue || undefined;
 		}
 	};
 }
@@ -442,20 +460,6 @@ jQuery.each([ "selected", "checked", "readonly", "disabled" ], function( i, name
 	});
 });
 
-// elem.tabIndex doesn't always return the correct value when it hasn't been explicitly set
-// http://fluidproject.org/blog/2008/01/09/getting-setting-and-removing-tabindex-values-with-javascript/
-jQuery.attrHooks[ jQuery.attrFix.tabindex || "tabindex" ] = {
-	get: function( elem ) {
-		var attributeNode = elem.getAttributeNode("tabIndex");
-
-		return attributeNode && attributeNode.specified ?
-			parseInt( attributeNode.value, 10 ) :
-			rfocusable.test( elem.nodeName ) || rclickable.test( elem.nodeName ) && elem.href ?
-				0 :
-				undefined;
-	}
-};
-
 // Some attributes require a special call on IE
 if ( !jQuery.support.hrefNormalized ) {
 	jQuery.each([ "href", "src", "style" ], function( i, name ) {
diff --git a/test/index.html b/test/index.html
index 4a8aef52..584f1f86 100644
--- a/test/index.html
+++ b/test/index.html
@@ -203,7 +203,8 @@ Z</textarea>
 			<select name="D4" disabled="disabled">
 				<option selected="selected" value="NO">NO</option>
 			</select>
-			<input name="id">
+			<input name="id" />
+			<input id="target" name="target" />
 		</form>
 		<div id="moretests">
 			<form>
diff --git a/test/unit/attributes.js b/test/unit/attributes.js
index 5b614446..adc1d591 100644
--- a/test/unit/attributes.js
+++ b/test/unit/attributes.js
@@ -3,15 +3,18 @@ module("attributes", { teardown: moduleTeardown });
 var bareObj = function(value) { return value; };
 var functionReturningObj = function(value) { return (function() { return value; }); };
 
-if ( !jQuery.support.getSetAttribute ) {
-	test("jQuery.attrFix integrity test", function() {
-		expect(1);
 
-		//  This must be maintained and equal jQuery.attrFix when appropriate
-		//  Ensure that accidental or erroneous property
-		//  overwrites don't occur
-		//  This is simply for better code coverage and future proofing.
-		var propsShouldBe = {
+test("jQuery.attrFix integrity test", function() {
+	expect(1);
+	
+	//  This must be maintained and equal jQuery.attrFix when appropriate
+	//  Ensure that accidental or erroneous property
+	//  overwrites don't occur
+	//  This is simply for better code coverage and future proofing.
+	var propsShouldBe;
+	if ( !jQuery.support.getSetAttribute ) {
+		propsShouldBe = {
+			tabindex: "tabIndex",
 			"for": "htmlFor",
 			"class": "className",
 			readonly: "readOnly",
@@ -19,14 +22,17 @@ if ( !jQuery.support.getSetAttribute ) {
 			cellspacing: "cellSpacing",
 			rowspan: "rowSpan",
 			colspan: "colSpan",
-			tabindex: "tabIndex",
 			usemap: "useMap",
 			frameborder: "frameBorder"
 		};
+	} else {
+		propsShouldBe = {
+			tabindex: "tabIndex"
+		};
+	}
 
-		same(propsShouldBe, jQuery.attrFix, "jQuery.attrFix passes integrity check");
-	});
-}
+	same(propsShouldBe, jQuery.attrFix, "jQuery.attrFix passes integrity check");
+});
 
 test("prop(String, Object)", function() {
 	expect(19);
@@ -69,7 +75,7 @@ test("prop(String, Object)", function() {
 });
 
 test("attr(String)", function() {
-	expect(22);
+	expect(24);
 
 	equals( jQuery('#text1').attr('type'), "text", 'Check for type attribute' );
 	equals( jQuery('#radio1').attr('type'), "radio", 'Check for type attribute' );
@@ -84,7 +90,9 @@ test("attr(String)", function() {
 	ok( jQuery('#form').attr('action').indexOf("formaction") >= 0, 'Check for action attribute' );
 	// [7472] & [3113] (form contains an input with name="action" or name="id")
 	equals( jQuery('#form').attr('action','newformaction').attr('action'), 'newformaction', 'Check that action attribute was changed' );
-	equals( jQuery('#testForm').removeAttr('id').attr('id'), undefined, 'Test that id does not equal the input with name=id after id is removed [#7472]' );
+	equals( jQuery('#testForm').attr('target'), undefined, 'Retrieving target does not equal the input with name=target' );
+	equals( jQuery('#testForm').attr('target', 'newTarget').attr('target'), 'newTarget', 'Set target successfully on a form' );
+	equals( jQuery('#testForm').removeAttr('id').attr('id'), undefined, 'Retrieving id does not equal the input with name=id after id is removed [#7472]' );
 	
 	equals( jQuery('#text1').attr('maxlength'), '30', 'Check for maxlength attribute' );
 	equals( jQuery('#text1').attr('maxLength'), '30', 'Check for maxLength attribute' );

From 47c80c2050fbc15b84cb69edce309777e71b6387 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Fri, 25 Mar 2011 02:07:15 -0400
Subject: [PATCH 45/91] Add test for bug#3685, remove added html and add
 dynamicly to avoid global test suite errors

---
 test/index.html         | 2 --
 test/unit/attributes.js | 7 ++++++-
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/test/index.html b/test/index.html
index 584f1f86..c7c2ae55 100644
--- a/test/index.html
+++ b/test/index.html
@@ -203,8 +203,6 @@ Z</textarea>
 			<select name="D4" disabled="disabled">
 				<option selected="selected" value="NO">NO</option>
 			</select>
-			<input name="id" />
-			<input id="target" name="target" />
 		</form>
 		<div id="moretests">
 			<form>
diff --git a/test/unit/attributes.js b/test/unit/attributes.js
index adc1d591..96a836f3 100644
--- a/test/unit/attributes.js
+++ b/test/unit/attributes.js
@@ -75,7 +75,7 @@ test("prop(String, Object)", function() {
 });
 
 test("attr(String)", function() {
-	expect(24);
+	expect(25);
 
 	equals( jQuery('#text1').attr('type'), "text", 'Check for type attribute' );
 	equals( jQuery('#radio1').attr('type'), "radio", 'Check for type attribute' );
@@ -88,11 +88,16 @@ test("attr(String)", function() {
 	equals( jQuery('#name').attr('name'), "name", 'Check for name attribute' );
 	equals( jQuery('#text1').attr('name'), "action", 'Check for name attribute' );
 	ok( jQuery('#form').attr('action').indexOf("formaction") >= 0, 'Check for action attribute' );
+	
 	// [7472] & [3113] (form contains an input with name="action" or name="id")
+	var extras = jQuery('<input name="id" name="name" /><input id="target" name="target" />').appendTo('#testForm');
 	equals( jQuery('#form').attr('action','newformaction').attr('action'), 'newformaction', 'Check that action attribute was changed' );
 	equals( jQuery('#testForm').attr('target'), undefined, 'Retrieving target does not equal the input with name=target' );
 	equals( jQuery('#testForm').attr('target', 'newTarget').attr('target'), 'newTarget', 'Set target successfully on a form' );
 	equals( jQuery('#testForm').removeAttr('id').attr('id'), undefined, 'Retrieving id does not equal the input with name=id after id is removed [#7472]' );
+	// Bug #3685 (form contains input with name="name")
+	equals( jQuery('#testForm').attr('name'), undefined, 'Retrieving name does not retrieve input with name=name' );
+	extras.remove();
 	
 	equals( jQuery('#text1').attr('maxlength'), '30', 'Check for maxlength attribute' );
 	equals( jQuery('#text1').attr('maxLength'), '30', 'Check for maxLength attribute' );

From 3892df207d7a4a3babf5017a309263cceff48b65 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Fri, 25 Mar 2011 10:40:46 -0400
Subject: [PATCH 46/91] Add test for bug #3116

---
 src/attributes.js       |  2 +-
 test/unit/attributes.js | 16 ++++++++++++----
 2 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index 3c6dee8b..dd484402 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -330,7 +330,7 @@ jQuery.extend({
 				
 				// Check form objects in IE (multiple bugs related)
 				if ( isFormObjects ) {
-					// Returns undefined for empty string, which is the blank nodeValue in IE
+					// Return undefined for empty string, which is the blank nodeValue in IE
 					ret = elem.getAttributeNode( name ).nodeValue || undefined;
 				} else {
 					ret = elem.getAttribute( name );
diff --git a/test/unit/attributes.js b/test/unit/attributes.js
index 96a836f3..16123771 100644
--- a/test/unit/attributes.js
+++ b/test/unit/attributes.js
@@ -160,7 +160,7 @@ test("attr(Hash)", function() {
 });
 
 test("attr(String, Object)", function() {
-	expect(28);
+	expect(29);
 
 	var div = jQuery("div").attr("foo", "bar"),
 		fail = false;
@@ -220,9 +220,9 @@ test("attr(String, Object)", function() {
 	jQuery("#name").attr('someAttr', '0');
 	equals( jQuery("#name").attr('someAttr'), '0', 'Set attribute to a string of "0"' );
 	jQuery("#name").attr('someAttr', 0);
-	equals( jQuery("#name").attr('someAttr'), 0, 'Set attribute to the number 0' );
+	equals( jQuery("#name").attr('someAttr'), '0', 'Set attribute to the number 0' );
 	jQuery("#name").attr('someAttr', 1);
-	equals( jQuery("#name").attr('someAttr'), 1, 'Set attribute to the number 1' );
+	equals( jQuery("#name").attr('someAttr'), '1', 'Set attribute to the number 1' );
 
 	// using contents will get comments regular, text, and comment nodes
 	var j = jQuery("#nonnodes").contents();
@@ -232,7 +232,8 @@ test("attr(String, Object)", function() {
 	j.removeAttr("name");
 
 	QUnit.reset();
-
+	
+	// Type
 	var type = jQuery("#check2").attr('type');
 	var thrown = false;
 	try {
@@ -272,6 +273,13 @@ test("attr(String, Object)", function() {
 	}
 	ok( thrown, "Exception thrown when trying to change type property" );
 	equals( "button", button.attr('type'), "Verify that you can't change the type of a button element" );
+	
+	// Setting attributes on svg elements (bug #3116)
+	var $svg = jQuery('<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" version="1.1" baseProfile="full" width="3000" height="3000">'
+		+ '<circle cx="200" cy="200" r="150" />'
+	+ '</svg>').appendTo('body');
+	equals( $svg.attr('cx', 100).attr('cx'), "100", "Set attribute on svg element" );
+	$svg.remove();
 });
 
 test("attr(jquery_method)", function(){

From e0900a686d3c80054afd0ebe4c8908a8b5568444 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Fri, 25 Mar 2011 21:13:25 -0400
Subject: [PATCH 47/91] Fix issue where non-existant attributes on forms in
 IE6/7 were throwing errors

---
 src/attributes.js       | 12 +++++++-----
 test/unit/attributes.js |  9 +++++----
 2 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index dd484402..b68b3edf 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -311,10 +311,11 @@ jQuery.extend({
 				return undefined;
 
 			} else {
-				
+
 				// Check form objects in IE (multiple bugs related)
-				if ( isFormObjects ) {
-					elem.getAttributeNode( name ).nodeValue = value;
+				// Only use nodeValue if the attribute node exists on the form
+				if ( isFormObjects && (ret = elem.getAttributeNode( name )) ) {
+					ret.nodeValue = value;
 				} else {
 					elem.setAttribute( name, value );
 				}
@@ -330,8 +331,9 @@ jQuery.extend({
 				
 				// Check form objects in IE (multiple bugs related)
 				if ( isFormObjects ) {
-					// Return undefined for empty string, which is the blank nodeValue in IE
-					ret = elem.getAttributeNode( name ).nodeValue || undefined;
+					// Return undefined if not specified instead of empty string
+					ret = elem.getAttributeNode( name );
+					return ret && ret.specified ? ret.nodeValue : undefined;
 				} else {
 					ret = elem.getAttribute( name );
 				}
diff --git a/test/unit/attributes.js b/test/unit/attributes.js
index 16123771..0260a6c1 100644
--- a/test/unit/attributes.js
+++ b/test/unit/attributes.js
@@ -75,7 +75,7 @@ test("prop(String, Object)", function() {
 });
 
 test("attr(String)", function() {
-	expect(25);
+	expect(26);
 
 	equals( jQuery('#text1').attr('type'), "text", 'Check for type attribute' );
 	equals( jQuery('#radio1').attr('type'), "radio", 'Check for type attribute' );
@@ -88,6 +88,7 @@ test("attr(String)", function() {
 	equals( jQuery('#name').attr('name'), "name", 'Check for name attribute' );
 	equals( jQuery('#text1').attr('name'), "action", 'Check for name attribute' );
 	ok( jQuery('#form').attr('action').indexOf("formaction") >= 0, 'Check for action attribute' );
+	equals( jQuery('#form').attr('blah', 'blah').attr('blah'), 'blah', 'Set non-existant attribute on a form' );
 	
 	// [7472] & [3113] (form contains an input with name="action" or name="id")
 	var extras = jQuery('<input name="id" name="name" /><input id="target" name="target" />').appendTo('#testForm');
@@ -214,7 +215,7 @@ test("attr(String, Object)", function() {
 	td.attr("colspan", "2");
 	equals( td[0].colSpan, 2, "Check colspan is correctly set" );
 	table.attr("cellspacing", "2");
-	equals( table[0].cellSpacing, 2, "Check cellspacing is correctly set" );
+	equals( table[0].cellSpacing, "2", "Check cellspacing is correctly set" );
 
 	// for #1070
 	jQuery("#name").attr('someAttr', '0');
@@ -385,9 +386,9 @@ test("attr('tabindex', value)", function() {
 });
 
 test("removeAttr(String)", function() {
-	expect(1);
+	expect(2);
 	equals( jQuery('#mark').removeAttr( "class" )[0].className, "", "remove class" );
-
+	equals( jQuery('#form').removeAttr('id').attr('id'), undefined, 'Remove id' );
 });
 
 test("removeProp(String)", function() {

From 479b28fb6aa7ec5619e1d14c4b0578b9464d5f2b Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Fri, 25 Mar 2011 22:55:11 -0400
Subject: [PATCH 48/91] Modularize special form code for IE6/7 and clean up
 attr again

---
 src/attributes.js | 68 +++++++++++++++++++++++++----------------------
 1 file changed, 36 insertions(+), 32 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index b68b3edf..295a5682 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -6,7 +6,8 @@ var rclass = /[\n\t\r]/g,
 	rtype = /^(?:button|input)$/i,
 	rfocusable = /^(?:button|input|object|select|textarea)$/i,
 	rclickable = /^a(?:rea)?$/i,
-	rradiocheck = /^(?:radio|checkbox)$/i;
+	rradiocheck = /^(?:radio|checkbox)$/i,
+	formHook;
 
 jQuery.fn.extend({
 	attr: function( name, value ) {
@@ -294,31 +295,25 @@ jQuery.extend({
 		
 		var ret, hooks,
 			notxml = nType !== 1 || !jQuery.isXMLDoc( elem ),
-			isFormObjects = !jQuery.support.getSetAttribute && elem.nodeName === "FORM";
+			isFormObjects = !jQuery.support.getSetAttribute && ( name === "name" || elem.nodeName === "FORM" );
 		
 		// Normalize the name if needed
 		name = notxml && jQuery.attrFix[ name ] || name;
 
-		hooks = jQuery.attrHooks[ name ];
+		// Get the appropriate hook, or the formHook if getSetAttribute is not supported and we have form objects in IE6/7
+		hooks = isFormObjects && formHook ? formHook( name ) : jQuery.attrHooks[ name ];
 
 		if ( value !== undefined ) {
 
-			if ( hooks && "set" in hooks && notxml && (ret = hooks.set( elem, value )) !== undefined ) {
-				return ret;
-
-			} else if ( value === null ) {
+			if ( value === null ) {
 				jQuery.removeAttr( elem, name );
 				return undefined;
 
-			} else {
+			} else if ( hooks && "set" in hooks && notxml && (ret = hooks.set( elem, value )) !== undefined ) {
+				return ret;
 
-				// Check form objects in IE (multiple bugs related)
-				// Only use nodeValue if the attribute node exists on the form
-				if ( isFormObjects && (ret = elem.getAttributeNode( name )) ) {
-					ret.nodeValue = value;
-				} else {
-					elem.setAttribute( name, value );
-				}
+			} else {
+				elem.setAttribute( name, value );
 				return value;
 			}
 
@@ -328,15 +323,8 @@ jQuery.extend({
 				return hooks.get( elem );
 
 			} else {
-				
-				// Check form objects in IE (multiple bugs related)
-				if ( isFormObjects ) {
-					// Return undefined if not specified instead of empty string
-					ret = elem.getAttributeNode( name );
-					return ret && ret.specified ? ret.nodeValue : undefined;
-				} else {
-					ret = elem.getAttribute( name );
-				}
+
+				ret = elem.getAttribute( name );
 
 				// Non-existent attributes return null, we normalize to undefined
 				// Instead of checking for null, we check for typeof object to catch inputs in IE6/7. Bug #7472
@@ -353,8 +341,9 @@ jQuery.extend({
 		if ( jQuery.support.getSetAttribute ) {
 			elem.removeAttribute( name );
 		} else {
-			// use DOM level 1 if getSetAttribute not supported (IE6-7)
-			elem.setAttribute( name, "" ); // Set to default empty string
+			// Set to default empty string
+			elem.setAttribute( name, "" );
+			// Attempt to remove completely with DOM level 1
 			elem.removeAttributeNode( elem.getAttributeNode( name ) );
 		}
 	},
@@ -436,12 +425,27 @@ if ( !jQuery.support.getSetAttribute ) {
 		frameborder: "frameBorder"
 	});
 	
-	// Name attribute will not get removed in browsers that do not support getSetAttribute
-	// Return undefined on empty string or null
-	jQuery.attrHooks.name = {
-		get: function( elem, value ) {
-			return elem.getAttributeNode("name").nodeValue || undefined;
-		}
+	// Use this for any attribute on a form in IE6/7
+	// And the name attribute
+	formHook = function( name ) {
+		return jQuery.attrHooks[ name ] || {
+			get: function( elem ) {
+				var ret = elem.getAttributeNode( name );
+				// Return undefined if not specified instead of empty string
+				return ret && ret.specified ? ret.nodeValue : undefined;
+			},
+			set: function( elem, value ) {
+				// Check form objects in IE (multiple bugs related)
+				// Only use nodeValue if the attribute node exists on the form
+				var ret = elem.getAttributeNode( name );
+				if ( ret ) {
+					ret.nodeValue = value;
+				} else {
+					elem.setAttribute( name, value );
+				}
+				return value;
+			}
+		};
 	};
 }
 

From 56014a1a0089be9d8d44c286ce66fc9d2066acd7 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Fri, 25 Mar 2011 22:57:01 -0400
Subject: [PATCH 49/91] Shorten even further

---
 src/attributes.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index 295a5682..6011c450 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -295,13 +295,13 @@ jQuery.extend({
 		
 		var ret, hooks,
 			notxml = nType !== 1 || !jQuery.isXMLDoc( elem ),
-			isFormObjects = !jQuery.support.getSetAttribute && ( name === "name" || elem.nodeName === "FORM" );
+			isFormObjects = formHook && ( name === "name" || elem.nodeName === "FORM" );
 		
 		// Normalize the name if needed
 		name = notxml && jQuery.attrFix[ name ] || name;
 
 		// Get the appropriate hook, or the formHook if getSetAttribute is not supported and we have form objects in IE6/7
-		hooks = isFormObjects && formHook ? formHook( name ) : jQuery.attrHooks[ name ];
+		hooks = isFormObjects ? formHook( name ) : jQuery.attrHooks[ name ];
 
 		if ( value !== undefined ) {
 

From 5caf7d837630df4ac8e8fb21c79582dc897903f5 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Fri, 25 Mar 2011 23:03:02 -0400
Subject: [PATCH 50/91] Clean up

---
 src/attributes.js | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index 6011c450..bfeb6c4e 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -294,14 +294,15 @@ jQuery.extend({
 		}
 		
 		var ret, hooks,
-			notxml = nType !== 1 || !jQuery.isXMLDoc( elem ),
-			isFormObjects = formHook && ( name === "name" || elem.nodeName === "FORM" );
+			notxml = nType !== 1 || !jQuery.isXMLDoc( elem );
 		
 		// Normalize the name if needed
 		name = notxml && jQuery.attrFix[ name ] || name;
 
 		// Get the appropriate hook, or the formHook if getSetAttribute is not supported and we have form objects in IE6/7
-		hooks = isFormObjects ? formHook( name ) : jQuery.attrHooks[ name ];
+		hooks = formHook && ( name === "name" || elem.nodeName === "FORM" ) ?
+					formHook( name ) :
+					jQuery.attrHooks[ name ];
 
 		if ( value !== undefined ) {
 
@@ -432,7 +433,9 @@ if ( !jQuery.support.getSetAttribute ) {
 			get: function( elem ) {
 				var ret = elem.getAttributeNode( name );
 				// Return undefined if not specified instead of empty string
-				return ret && ret.specified ? ret.nodeValue : undefined;
+				return ret && ret.specified ?
+					ret.nodeValue :
+					undefined;
 			},
 			set: function( elem, value ) {
 				// Check form objects in IE (multiple bugs related)
@@ -482,7 +485,6 @@ if ( !jQuery.support.style ) {
 		get: function( elem ) {
 			return elem.style.cssText;
 		},
-		
 		set: function( elem, value ) {
 			return (elem.style.cssText = "" + value);
 		}

From 448111cbd432864d0ae03c70ae321e97de989e9b Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Fri, 25 Mar 2011 23:10:59 -0400
Subject: [PATCH 51/91] No longer need to check for objects or string of null
 with the special form treatment and updates to removeAttr

---
 src/attributes.js | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index bfeb6c4e..44b16825 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -328,8 +328,7 @@ jQuery.extend({
 				ret = elem.getAttribute( name );
 
 				// Non-existent attributes return null, we normalize to undefined
-				// Instead of checking for null, we check for typeof object to catch inputs in IE6/7. Bug #7472
-				return typeof ret === "object" || ret === "null" ?
+				return ret === null ?
 					undefined :
 					ret;
 			}

From 03da4c7ca719443d52104c7f47abffc2e312753d Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Fri, 25 Mar 2011 23:36:07 -0400
Subject: [PATCH 52/91] Style formatting

---
 src/attributes.js | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index 44b16825..c5f9dfbb 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -290,7 +290,7 @@ jQuery.extend({
 		}
 
 		if ( pass && name in jQuery.attrFn ) {
-			return jQuery(elem)[name](value);
+			return jQuery( elem )[ name ]( value );
 		}
 		
 		var ret, hooks,
@@ -299,7 +299,8 @@ jQuery.extend({
 		// Normalize the name if needed
 		name = notxml && jQuery.attrFix[ name ] || name;
 
-		// Get the appropriate hook, or the formHook if getSetAttribute is not supported and we have form objects in IE6/7
+		// Get the appropriate hook, or the formHook
+		// if getSetAttribute is not supported and we have form objects in IE6/7
 		hooks = formHook && ( name === "name" || elem.nodeName === "FORM" ) ?
 					formHook( name ) :
 					jQuery.attrHooks[ name ];

From 11c97bb06672a1203f39eb39ab373dcc56bd9465 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Sat, 26 Mar 2011 00:15:25 -0400
Subject: [PATCH 53/91] Add attribute name to paramaters for hooks

---
 src/attributes.js | 44 +++++++++++++++++++++-----------------------
 1 file changed, 21 insertions(+), 23 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index c5f9dfbb..6f634574 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -302,7 +302,7 @@ jQuery.extend({
 		// Get the appropriate hook, or the formHook
 		// if getSetAttribute is not supported and we have form objects in IE6/7
 		hooks = formHook && ( name === "name" || elem.nodeName === "FORM" ) ?
-					formHook( name ) :
+					jQuery.attrHooks[ name ] || formHook :
 					jQuery.attrHooks[ name ];
 
 		if ( value !== undefined ) {
@@ -311,7 +311,7 @@ jQuery.extend({
 				jQuery.removeAttr( elem, name );
 				return undefined;
 
-			} else if ( hooks && "set" in hooks && notxml && (ret = hooks.set( elem, value )) !== undefined ) {
+			} else if ( hooks && "set" in hooks && notxml && (ret = hooks.set( elem, value, name )) !== undefined ) {
 				return ret;
 
 			} else {
@@ -322,7 +322,7 @@ jQuery.extend({
 		} else {
 
 			if ( hooks && "get" in hooks && notxml ) {
-				return hooks.get( elem );
+				return hooks.get( elem, name );
 
 			} else {
 
@@ -428,27 +428,25 @@ if ( !jQuery.support.getSetAttribute ) {
 	
 	// Use this for any attribute on a form in IE6/7
 	// And the name attribute
-	formHook = function( name ) {
-		return jQuery.attrHooks[ name ] || {
-			get: function( elem ) {
-				var ret = elem.getAttributeNode( name );
-				// Return undefined if not specified instead of empty string
-				return ret && ret.specified ?
-					ret.nodeValue :
-					undefined;
-			},
-			set: function( elem, value ) {
-				// Check form objects in IE (multiple bugs related)
-				// Only use nodeValue if the attribute node exists on the form
-				var ret = elem.getAttributeNode( name );
-				if ( ret ) {
-					ret.nodeValue = value;
-				} else {
-					elem.setAttribute( name, value );
-				}
-				return value;
+	formHook = {
+		get: function( elem, name ) {
+			var ret = elem.getAttributeNode( name );
+			// Return undefined if not specified instead of empty string
+			return ret && ret.specified ?
+				ret.nodeValue :
+				undefined;
+		},
+		set: function( elem, value, name ) {
+			// Check form objects in IE (multiple bugs related)
+			// Only use nodeValue if the attribute node exists on the form
+			var ret = elem.getAttributeNode( name );
+			if ( ret ) {
+				ret.nodeValue = value;
+			} else {
+				elem.setAttribute( name, value );
 			}
-		};
+			return value;
+		}
 	};
 }
 

From 217a7abc43967cb860fc0dccee13b475de81b07d Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Sat, 26 Mar 2011 00:18:02 -0400
Subject: [PATCH 54/91] Add name to prop hooks as well

---
 src/attributes.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index 6f634574..70eeecfd 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -392,7 +392,7 @@ jQuery.extend({
 		hooks = jQuery.propHooks[ name ];
 		
 		if ( value !== undefined ) {
-			if ( hooks && "set" in hooks && (ret = hooks.set( elem, value )) !== undefined ) {
+			if ( hooks && "set" in hooks && (ret = hooks.set( elem, value, name )) !== undefined ) {
 				return ret;
 			
 			} else {
@@ -400,7 +400,7 @@ jQuery.extend({
 			}
 		
 		} else {
-			if ( hooks && "get" in hooks && (ret = hooks.get( elem )) !== undefined ) {
+			if ( hooks && "get" in hooks && (ret = hooks.get( elem, name )) !== undefined ) {
 				return ret;
 				
 			} else {

From a4d44979c6ecb4be59f1fbb50a0e5eaae804a0d3 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Tue, 29 Mar 2011 00:23:39 -0400
Subject: [PATCH 55/91] Shorten the logic for hooks, ternary was unnecessary

---
 src/attributes.js | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index 70eeecfd..e80fede9 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -301,9 +301,7 @@ jQuery.extend({
 
 		// Get the appropriate hook, or the formHook
 		// if getSetAttribute is not supported and we have form objects in IE6/7
-		hooks = formHook && ( name === "name" || elem.nodeName === "FORM" ) ?
-					jQuery.attrHooks[ name ] || formHook :
-					jQuery.attrHooks[ name ];
+		hooks = jQuery.attrHooks[ name ] || ( ( name === "name" || elem.nodeName === "FORM" ) && formHook );
 
 		if ( value !== undefined ) {
 

From fa4373c11ba10e040a982a641c74f8ff96f312f3 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Tue, 29 Mar 2011 21:49:37 -0400
Subject: [PATCH 56/91] Add style attribute support tests to $.attr

---
 test/unit/attributes.js | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/test/unit/attributes.js b/test/unit/attributes.js
index 0260a6c1..262f3499 100644
--- a/test/unit/attributes.js
+++ b/test/unit/attributes.js
@@ -75,7 +75,7 @@ test("prop(String, Object)", function() {
 });
 
 test("attr(String)", function() {
-	expect(26);
+	expect(28);
 
 	equals( jQuery('#text1').attr('type'), "text", 'Check for type attribute' );
 	equals( jQuery('#radio1').attr('type'), "radio", 'Check for type attribute' );
@@ -127,7 +127,10 @@ test("attr(String)", function() {
 
 	ok( jQuery("<div/>").attr("doesntexist") === undefined, "Make sure undefined is returned when no attribute is found." );
 	ok( jQuery().attr("doesntexist") === undefined, "Make sure undefined is returned when no element is there." );
-
+	
+	// Check for style support
+	ok( !!~jQuery('#dl').attr('style').indexOf('absolute'), 'Check style attribute getter' );
+	ok( !!~jQuery('#foo').attr('style', 'position:absolute;').attr('style').indexOf('absolute'), 'Check style setter' );
 });
 
 if ( !isLocal ) {

From 1e9b3ef3d87a0934dec969ed469cd3cc9c910ae8 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Wed, 30 Mar 2011 17:13:15 -0400
Subject: [PATCH 57/91] Move the check for the name attribute out of attr and
 down to the formHook definition

---
 src/attributes.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index e80fede9..f0398559 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -301,7 +301,7 @@ jQuery.extend({
 
 		// Get the appropriate hook, or the formHook
 		// if getSetAttribute is not supported and we have form objects in IE6/7
-		hooks = jQuery.attrHooks[ name ] || ( ( name === "name" || elem.nodeName === "FORM" ) && formHook );
+		hooks = jQuery.attrHooks[ name ] || ( elem.nodeName === "FORM" && formHook );
 
 		if ( value !== undefined ) {
 
@@ -426,7 +426,7 @@ if ( !jQuery.support.getSetAttribute ) {
 	
 	// Use this for any attribute on a form in IE6/7
 	// And the name attribute
-	formHook = {
+	formHook = jQuery.attrHooks.name = {
 		get: function( elem, name ) {
 			var ret = elem.getAttributeNode( name );
 			// Return undefined if not specified instead of empty string

From 5fc2281fcc83783b86647a5a86380b9ac21e7f79 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Fri, 1 Apr 2011 21:13:01 -0400
Subject: [PATCH 58/91] - Added a hook to swap display none for width and
 height in browsers that do not sufficiently support get/setAttribute

---
 src/attributes.js       | 14 ++++++++++++++
 src/manipulation.js     |  3 ++-
 test/unit/attributes.js | 12 ++++++++----
 3 files changed, 24 insertions(+), 5 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index f0398559..f29c340a 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -446,6 +446,20 @@ if ( !jQuery.support.getSetAttribute ) {
 			return value;
 		}
 	};
+
+	// Retrieving the width/height attributes on an
+	// element with display: none returns 0 in ie6/7 (#5413)
+	jQuery.each([ "width", "height" ], function( i, name ) {
+		jQuery.attrHooks[ name ] = jQuery.extend( jQuery.attrHooks[ name ], {
+			get: function( elem ) {
+				var ret;
+				jQuery.swap( elem, { visibility: "hidden", display: "block" }, function() {
+					ret = elem.getAttribute( name );
+				});
+				return ret;
+			}
+		});
+	});
 }
 
 // Remove certain attrs if set to false
diff --git a/src/manipulation.js b/src/manipulation.js
index 81a55cb8..758cdbae 100644
--- a/src/manipulation.js
+++ b/src/manipulation.js
@@ -549,7 +549,8 @@ jQuery.extend({
 
 		// Return the cloned set
 		return clone;
-},
+	},
+
 	clean: function( elems, context, fragment, scripts ) {
 		context = context || document;
 
diff --git a/test/unit/attributes.js b/test/unit/attributes.js
index 262f3499..a73b51fc 100644
--- a/test/unit/attributes.js
+++ b/test/unit/attributes.js
@@ -75,7 +75,7 @@ test("prop(String, Object)", function() {
 });
 
 test("attr(String)", function() {
-	expect(28);
+	expect(30);
 
 	equals( jQuery('#text1').attr('type'), "text", 'Check for type attribute' );
 	equals( jQuery('#radio1').attr('type'), "radio", 'Check for type attribute' );
@@ -125,12 +125,16 @@ test("attr(String)", function() {
 	optgroup.appendChild( option );
 	select.appendChild( optgroup );
 
-	ok( jQuery("<div/>").attr("doesntexist") === undefined, "Make sure undefined is returned when no attribute is found." );
-	ok( jQuery().attr("doesntexist") === undefined, "Make sure undefined is returned when no element is there." );
-	
+	var $img = jQuery('<img style="display:none" width="215" height="53" src="http://static.jquery.com/files/rocker/images/logo_jquery_215x53.gif"/>').appendTo('body');
+	equals( $img.attr('width'), "215", "Retrieve width attribute an an element with display:none." );
+	equals( $img.attr('height'), "53", "Retrieve height attribute an an element with display:none." );
+
 	// Check for style support
 	ok( !!~jQuery('#dl').attr('style').indexOf('absolute'), 'Check style attribute getter' );
 	ok( !!~jQuery('#foo').attr('style', 'position:absolute;').attr('style').indexOf('absolute'), 'Check style setter' );
+
+	ok( jQuery("<div/>").attr("doesntexist") === undefined, "Make sure undefined is returned when no attribute is found." );
+	ok( jQuery().attr("doesntexist") === undefined, "Make sure undefined is returned when no element is there." );
 });
 
 if ( !isLocal ) {

From 8cbf551a48cbc47eccba2050e95745f70166ae1d Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Fri, 1 Apr 2011 21:38:54 -0400
Subject: [PATCH 59/91] #5413 - Much shorter solution for getting width/height
 in ie6 - #8255 Added support for the list attribute in browsers that support
 it (it is automatically readonly, but can be set if using getAttribute( name,
 2)

---
 src/attributes.js       | 16 +---------------
 test/index.html         |  4 ++++
 test/unit/attributes.js |  6 +++++-
 3 files changed, 10 insertions(+), 16 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index f29c340a..5afcffce 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -446,20 +446,6 @@ if ( !jQuery.support.getSetAttribute ) {
 			return value;
 		}
 	};
-
-	// Retrieving the width/height attributes on an
-	// element with display: none returns 0 in ie6/7 (#5413)
-	jQuery.each([ "width", "height" ], function( i, name ) {
-		jQuery.attrHooks[ name ] = jQuery.extend( jQuery.attrHooks[ name ], {
-			get: function( elem ) {
-				var ret;
-				jQuery.swap( elem, { visibility: "hidden", display: "block" }, function() {
-					ret = elem.getAttribute( name );
-				});
-				return ret;
-			}
-		});
-	});
 }
 
 // Remove certain attrs if set to false
@@ -481,7 +467,7 @@ jQuery.each([ "selected", "checked", "readonly", "disabled" ], function( i, name
 
 // Some attributes require a special call on IE
 if ( !jQuery.support.hrefNormalized ) {
-	jQuery.each([ "href", "src", "style" ], function( i, name ) {
+	jQuery.each([ "href", "src", "style", "width", "height", "list" ], function( i, name ) {
 		jQuery.attrHooks[ name ] = jQuery.extend( jQuery.attrHooks[ name ], {
 			get: function( elem ) {
 				return elem.getAttribute( name, 2 );
diff --git a/test/index.html b/test/index.html
index c7c2ae55..a1065508 100644
--- a/test/index.html
+++ b/test/index.html
@@ -203,6 +203,10 @@ Z</textarea>
 			<select name="D4" disabled="disabled">
 				<option selected="selected" value="NO">NO</option>
 			</select>
+			<input id="list-test" type="text" />
+			<datalist id="datalist">
+				<option value="option"></option>
+			</datalist>
 		</form>
 		<div id="moretests">
 			<form>
diff --git a/test/unit/attributes.js b/test/unit/attributes.js
index a73b51fc..ad051649 100644
--- a/test/unit/attributes.js
+++ b/test/unit/attributes.js
@@ -75,7 +75,7 @@ test("prop(String, Object)", function() {
 });
 
 test("attr(String)", function() {
-	expect(30);
+	expect(31);
 
 	equals( jQuery('#text1').attr('type'), "text", 'Check for type attribute' );
 	equals( jQuery('#radio1').attr('type'), "radio", 'Check for type attribute' );
@@ -108,6 +108,10 @@ test("attr(String)", function() {
 	jQuery('<a/>').attr({ 'id': 'tAnchor5', 'href': '#5' }).appendTo('#main');
 	equals( jQuery('#tAnchor5').attr('href'), "#5", 'Check for non-absolute href (an anchor)' );
 
+	// list attribute is readonly by default in browsers that support it
+	jQuery("#list-test").attr("list", "datalist");
+	equals( jQuery("#list-test").attr("list"), "datalist", "Check setting list attribute" );
+
 	// Related to [5574] and [5683]
 	var body = document.body, $body = jQuery(body);
 

From ff7576755864193b4c1a00464bf0919bbbe96e8b Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Sat, 2 Apr 2011 14:23:33 -0400
Subject: [PATCH 60/91] Minor adjustments and cleanup, including normalizing
 the value to a string when setting( list of changes below )

- Normalize set value to string to synchronize return type cross-browser

- Add style attrHook to propHooks to support style getting in all browsers for both attr and prop

- Extend the selected propHook instead of overriding a possible set function

- Remove selected propHook TODO since there is no selected content attribute and it should return null
---
 src/attributes.js | 23 +++++++----------------
 1 file changed, 7 insertions(+), 16 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index 5afcffce..7c03cddb 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -313,7 +313,7 @@ jQuery.extend({
 				return ret;
 
 			} else {
-				elem.setAttribute( name, value );
+				elem.setAttribute( name, "" + value );
 				return value;
 			}
 
@@ -440,10 +440,8 @@ if ( !jQuery.support.getSetAttribute ) {
 			var ret = elem.getAttributeNode( name );
 			if ( ret ) {
 				ret.nodeValue = value;
-			} else {
-				elem.setAttribute( name, value );
+				return value;
 			}
-			return value;
 		}
 	};
 }
@@ -458,9 +456,6 @@ jQuery.each([ "selected", "checked", "readonly", "disabled" ], function( i, name
 				jQuery.removeAttr( elem, name );
 				return false;
 			}
-
-			elem.setAttribute( name, value );
-			return value;
 		}
 	});
 });
@@ -477,7 +472,7 @@ if ( !jQuery.support.hrefNormalized ) {
 }
 
 if ( !jQuery.support.style ) {
-	jQuery.attrHooks.style = {
+	jQuery.propHooks.style = jQuery.attrHooks.style = {
 		get: function( elem ) {
 			return elem.style.cssText;
 		},
@@ -490,24 +485,20 @@ if ( !jQuery.support.style ) {
 // Safari mis-reports the default selected property of an option
 // Accessing the parent's selectedIndex property fixes it
 if ( !jQuery.support.optSelected ) {
-
-	jQuery.propHooks.selected = {
+	jQuery.propHooks.selected = jQuery.extend( jQuery.propHooks.selected, {
 		get: function( elem ) {
 			var parent = elem.parentNode;
-			
+
 			if ( parent ) {
 				parent.selectedIndex;
-				
-				// TODO: We may need an attrHook for selected that simply defers to prop?
-				// The attr is undefined if the option is created with createElement and not on the DOM
-				
+
 				// Make sure that it also works with optgroups, see #5701
 				if ( parent.parentNode ) {
 					parent.parentNode.selectedIndex;
 				}
 			}
 		}
-	};
+	});
 }
 
 })( jQuery );
\ No newline at end of file

From 2a8a2b61488e7857b116bedc9eb75bd971772c2f Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Sun, 3 Apr 2011 16:49:48 -0400
Subject: [PATCH 61/91] Move the if statement in jQuery.fn.removeAttr to
 jQuery.removeAttr

- Extra testing on removeAttr and IE form weirdness( all good )
---
 src/attributes.js | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index 7c03cddb..b472e617 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -16,9 +16,7 @@ jQuery.fn.extend({
 
 	removeAttr: function( name ) {
 		return this.each(function() {
-			if ( this.nodeType === 1 ) {
-				jQuery.removeAttr( this, name );
-			}
+			jQuery.removeAttr( this, name );
 		});
 	},
 	
@@ -335,15 +333,17 @@ jQuery.extend({
 	},
 	
 	removeAttr: function( elem, name ) {
-		name = jQuery.attrFix[ name ] || name;
+		if ( elem.nodeType === 1 ) {
+			name = jQuery.attrFix[ name ] || name;
 		
-		if ( jQuery.support.getSetAttribute ) {
-			elem.removeAttribute( name );
-		} else {
-			// Set to default empty string
-			elem.setAttribute( name, "" );
-			// Attempt to remove completely with DOM level 1
-			elem.removeAttributeNode( elem.getAttributeNode( name ) );
+			if ( jQuery.support.getSetAttribute ) {
+				elem.removeAttribute( name );
+			} else {
+				// Set to default empty string (No longer need to use attr for this)
+				elem.setAttribute( name, "" );
+				// Attempt to remove completely with DOM level 1
+				elem.removeAttributeNode( elem.getAttributeNode( name ) );
+			}
 		}
 	},
 

From ad2b3bc9f908a8e529c4479c8c9baead23c2d827 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Sun, 3 Apr 2011 18:18:32 -0400
Subject: [PATCH 62/91] Found a problem removing the style attribute in IE

- Style is now a special case in IE6/7 to set cssText.  My goal is to avoid calling attr again for the performance benefit, and at this point it would also cause an infinite loop for the boolean attributes hooks such as selected & checked.  Nevertheless, style seems to be the only one requiring a special call.
---
 src/attributes.js       | 27 +++++++++++++++------------
 test/unit/attributes.js | 13 +++++++++----
 2 files changed, 24 insertions(+), 16 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index b472e617..ced9977e 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -276,7 +276,8 @@ jQuery.extend({
 	
 	attrFix: {
 		// Always normalize to ensure hook usage
-		tabindex: "tabIndex"
+		tabindex: "tabIndex",
+		readonly: "readOnly"
 	},
 	
 	attr: function( elem, name, value, pass ) {
@@ -339,10 +340,14 @@ jQuery.extend({
 			if ( jQuery.support.getSetAttribute ) {
 				elem.removeAttribute( name );
 			} else {
-				// Set to default empty string (No longer need to use attr for this)
-				elem.setAttribute( name, "" );
-				// Attempt to remove completely with DOM level 1
-				elem.removeAttributeNode( elem.getAttributeNode( name ) );
+				// Only style is a special case.
+				if ( name === "style" ) {
+					elem.style.cssText = "";
+				} else {
+					elem.setAttribute( name, "" );
+					// Attempt to remove completely with DOM level 1
+					elem.removeAttributeNode( elem.getAttributeNode( name ) );
+				}
 			}
 		}
 	},
@@ -415,7 +420,6 @@ if ( !jQuery.support.getSetAttribute ) {
 	jQuery.attrFix = jQuery.extend( jQuery.attrFix, {
 		"for": "htmlFor",
 		"class": "className",
-		readonly: "readOnly",
 		maxlength: "maxLength",
 		cellspacing: "cellSpacing",
 		rowspan: "rowSpan",
@@ -447,12 +451,10 @@ if ( !jQuery.support.getSetAttribute ) {
 }
 
 // Remove certain attrs if set to false
-jQuery.each([ "selected", "checked", "readonly", "disabled" ], function( i, name ) {
-	name = jQuery.attrFix[ name ] || name;
-
+jQuery.each([ "selected", "checked", "readOnly", "disabled" ], function( i, name ) {
 	jQuery.attrHooks[ name ] = jQuery.extend( jQuery.attrHooks[ name ], {
 		set: function( elem, value ) {
-			if ( !value ) { // '', undefined, false, null will remove attr
+			if ( !value ) {
 				jQuery.removeAttr( elem, name );
 				return false;
 			}
@@ -472,9 +474,10 @@ if ( !jQuery.support.hrefNormalized ) {
 }
 
 if ( !jQuery.support.style ) {
-	jQuery.propHooks.style = jQuery.attrHooks.style = {
+	jQuery.attrHooks.style = {
 		get: function( elem ) {
-			return elem.style.cssText;
+			// Return undefined in the case of empty string
+			return elem.style.cssText || undefined;
 		},
 		set: function( elem, value ) {
 			return (elem.style.cssText = "" + value);
diff --git a/test/unit/attributes.js b/test/unit/attributes.js
index ad051649..0e86a8bf 100644
--- a/test/unit/attributes.js
+++ b/test/unit/attributes.js
@@ -15,9 +15,9 @@ test("jQuery.attrFix integrity test", function() {
 	if ( !jQuery.support.getSetAttribute ) {
 		propsShouldBe = {
 			tabindex: "tabIndex",
+			readonly: "readOnly",
 			"for": "htmlFor",
 			"class": "className",
-			readonly: "readOnly",
 			maxlength: "maxLength",
 			cellspacing: "cellSpacing",
 			rowspan: "rowSpan",
@@ -27,7 +27,8 @@ test("jQuery.attrFix integrity test", function() {
 		};
 	} else {
 		propsShouldBe = {
-			tabindex: "tabIndex"
+			tabindex: "tabIndex",
+			readonly: "readOnly"
 		};
 	}
 
@@ -172,7 +173,7 @@ test("attr(Hash)", function() {
 });
 
 test("attr(String, Object)", function() {
-	expect(29);
+	expect(30);
 
 	var div = jQuery("div").attr("foo", "bar"),
 		fail = false;
@@ -195,6 +196,8 @@ test("attr(String, Object)", function() {
 	equals( jQuery("#name").attr('name'), undefined, 'Remove name attribute' );
 	jQuery("#check2").attr('checked', true);
 	equals( document.getElementById('check2').checked, true, 'Set checked attribute' );
+	jQuery("#check2").attr('checked', '');
+	equals( document.getElementById('check2').checked, false, 'Setting checked to empty string removes it' );
 	jQuery("#check2").attr('checked', false);
 	equals( document.getElementById('check2').checked, false, 'Set checked attribute' );
 	jQuery("#text1").attr('readonly', true);
@@ -397,9 +400,11 @@ test("attr('tabindex', value)", function() {
 });
 
 test("removeAttr(String)", function() {
-	expect(2);
+	expect(4);
 	equals( jQuery('#mark').removeAttr( "class" )[0].className, "", "remove class" );
 	equals( jQuery('#form').removeAttr('id').attr('id'), undefined, 'Remove id' );
+	equals( jQuery('#foo').attr('style', 'position:absolute;').removeAttr('style').attr('style'), undefined, 'Check removing style attribute' );
+	equals( jQuery('#form').attr('style', 'position:absolute;').removeAttr('style').attr('style'), undefined, 'Check removing style attribute on a form' );
 });
 
 test("removeProp(String)", function() {

From 6f79bee3e3ea874f27389a7e691c1bd7541f2ef6 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Sun, 3 Apr 2011 18:47:44 -0400
Subject: [PATCH 63/91] Normalize css property names to lowercase for
 comparisons on a .attr('style') call since IE uppercases everything

---
 src/attributes.js       | 3 ++-
 test/unit/attributes.js | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index ced9977e..15d4d50e 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -477,7 +477,8 @@ if ( !jQuery.support.style ) {
 	jQuery.attrHooks.style = {
 		get: function( elem ) {
 			// Return undefined in the case of empty string
-			return elem.style.cssText || undefined;
+			// Normalize to lowercase since IE uppercases css property names
+			return elem.style.cssText.toLowerCase() || undefined;
 		},
 		set: function( elem, value ) {
 			return (elem.style.cssText = "" + value);
diff --git a/test/unit/attributes.js b/test/unit/attributes.js
index 0e86a8bf..4289bc3b 100644
--- a/test/unit/attributes.js
+++ b/test/unit/attributes.js
@@ -135,8 +135,8 @@ test("attr(String)", function() {
 	equals( $img.attr('height'), "53", "Retrieve height attribute an an element with display:none." );
 
 	// Check for style support
-	ok( !!~jQuery('#dl').attr('style').indexOf('absolute'), 'Check style attribute getter' );
-	ok( !!~jQuery('#foo').attr('style', 'position:absolute;').attr('style').indexOf('absolute'), 'Check style setter' );
+	ok( !!~jQuery('#dl').attr('style').indexOf('position'), 'Check style attribute getter, also normalize css props to lowercase' );
+	ok( !!~jQuery('#foo').attr('style', 'position:absolute;').attr('style').indexOf('position'), 'Check style setter' );
 
 	ok( jQuery("<div/>").attr("doesntexist") === undefined, "Make sure undefined is returned when no attribute is found." );
 	ok( jQuery().attr("doesntexist") === undefined, "Make sure undefined is returned when no element is there." );

From 94fff6ff625be9fbbb54db53d9acec63f0919370 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Mon, 4 Apr 2011 14:22:58 -0400
Subject: [PATCH 64/91] Remove the unused radiocheck regex

---
 src/attributes.js | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index 4c59a675..c8106e98 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -6,8 +6,7 @@ var rclass = /[\n\t\r]/g,
 	rspecialurl = /^(?:href|src|style)$/,
 	rtype = /^(?:button|input)$/i,
 	rfocusable = /^(?:button|input|object|select|textarea)$/i,
-	rclickable = /^a(?:rea)?$/i,
-	rradiocheck = /^(?:radio|checkbox)$/i;
+	rclickable = /^a(?:rea)?$/i;
 
 jQuery.props = {
 	"for": "htmlFor",

From f7ccec1b70a42de21b55dbb7b3d65da5628ade9e Mon Sep 17 00:00:00 2001
From: louisremi <louisremi@louisremi-laptop.(none)>
Date: Mon, 31 Jan 2011 18:57:23 +0100
Subject: [PATCH 65/91] use requestAnimationFrame instead of setInterval for
 animations, when available.

---
 src/effects.js | 6 +++++-
 src/support.js | 8 ++++++++
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/src/effects.js b/src/effects.js
index d9e9a8b3..a41efc28 100644
--- a/src/effects.js
+++ b/src/effects.js
@@ -363,7 +363,9 @@ jQuery.fx.prototype = {
 		t.elem = this.elem;
 
 		if ( t() && jQuery.timers.push(t) && !timerId ) {
-			timerId = setInterval(fx.tick, fx.interval);
+			jQuery.support.requestAnimationFrame ?
+				window[jQuery.support.requestAnimationFrame](fx.tick):
+				timerId = setInterval(fx.tick, fx.interval);
 		}
 	},
 
@@ -468,6 +470,8 @@ jQuery.extend( jQuery.fx, {
 
 		if ( !timers.length ) {
 			jQuery.fx.stop();
+		} else if ( jQuery.support.requestAnimationFrame ) {
+			window[jQuery.support.requestAnimationFrame](this);
 		}
 	},
 
diff --git a/src/support.js b/src/support.js
index 4c309562..6d331868 100644
--- a/src/support.js
+++ b/src/support.js
@@ -58,6 +58,14 @@
 		// (WebKit defaults to false instead of true, IE too, if it's in an optgroup)
 		optSelected: opt.selected,
 
+		// Verify requestAnimationFrame mechanism existence
+		// use the prefixed name as the value
+		requestAnimationFrame: mozRequestAnimationFrame ?
+			'mozRequestAnimationFrame' :
+			webkitRequestAnimationFrame ?
+				'webkitRequestAnimationFrame' :
+				false,
+
 		// Will be defined later
 		deleteExpando: true,
 		optDisabled: false,

From 9dc63971877d583dac5bb5c8b0c3d73d1127f144 Mon Sep 17 00:00:00 2001
From: louisremi <louisremi@louisremi-laptop.(none)>
Date: Tue, 1 Feb 2011 12:02:02 +0100
Subject: [PATCH 66/91] omitting 'window.' was causing undefined errors

---
 src/support.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/support.js b/src/support.js
index 6d331868..725575b3 100644
--- a/src/support.js
+++ b/src/support.js
@@ -60,9 +60,9 @@
 
 		// Verify requestAnimationFrame mechanism existence
 		// use the prefixed name as the value
-		requestAnimationFrame: mozRequestAnimationFrame ?
+		requestAnimationFrame: window.mozRequestAnimationFrame ?
 			'mozRequestAnimationFrame' :
-			webkitRequestAnimationFrame ?
+			window.webkitRequestAnimationFrame ?
 				'webkitRequestAnimationFrame' :
 				false,
 

From 933ea8c5fa44f93085a7b720ac50c473a394251e Mon Sep 17 00:00:00 2001
From: louisremi <louisremi@louisremi-laptop.(none)>
Date: Tue, 1 Feb 2011 16:00:19 +0100
Subject: [PATCH 67/91] 'this' is the window

---
 src/effects.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/effects.js b/src/effects.js
index a41efc28..196807ec 100644
--- a/src/effects.js
+++ b/src/effects.js
@@ -471,7 +471,7 @@ jQuery.extend( jQuery.fx, {
 		if ( !timers.length ) {
 			jQuery.fx.stop();
 		} else if ( jQuery.support.requestAnimationFrame ) {
-			window[jQuery.support.requestAnimationFrame](this);
+			window[jQuery.support.requestAnimationFrame](jQuery.fx.tick);
 		}
 	},
 

From 6de29b24b197f4fbbf3e48369343d457e7a80523 Mon Sep 17 00:00:00 2001
From: louisremi <louisremi@louisremi-laptop.(none)>
Date: Tue, 1 Feb 2011 18:26:41 +0100
Subject: [PATCH 68/91] timerId has to be set to true, to avoid starting
 multiple animation queues

---
 src/effects.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/effects.js b/src/effects.js
index 196807ec..82548611 100644
--- a/src/effects.js
+++ b/src/effects.js
@@ -363,9 +363,9 @@ jQuery.fx.prototype = {
 		t.elem = this.elem;
 
 		if ( t() && jQuery.timers.push(t) && !timerId ) {
-			jQuery.support.requestAnimationFrame ?
-				window[jQuery.support.requestAnimationFrame](fx.tick):
-				timerId = setInterval(fx.tick, fx.interval);
+			timerId = jQuery.support.requestAnimationFrame ?
+				!window[jQuery.support.requestAnimationFrame](fx.tick):
+				setInterval(fx.tick, fx.interval);
 		}
 	},
 

From 03e6f7235bd671330f807642fefd297c42413c45 Mon Sep 17 00:00:00 2001
From: louisremi <louisremi@louisremi-laptop.(none)>
Date: Tue, 1 Feb 2011 19:57:14 +0100
Subject: [PATCH 69/91] there was no way to 'manually' stop an animation

---
 src/effects.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/effects.js b/src/effects.js
index 82548611..6a72a88f 100644
--- a/src/effects.js
+++ b/src/effects.js
@@ -470,7 +470,7 @@ jQuery.extend( jQuery.fx, {
 
 		if ( !timers.length ) {
 			jQuery.fx.stop();
-		} else if ( jQuery.support.requestAnimationFrame ) {
+		} else if ( jQuery.support.requestAnimationFrame && timerId) {
 			window[jQuery.support.requestAnimationFrame](jQuery.fx.tick);
 		}
 	},

From 15e34d1f07d0c687d040af22dbc66f3978715217 Mon Sep 17 00:00:00 2001
From: louisremi <louisremi@louisremi-laptop.(none)>
Date: Wed, 2 Feb 2011 10:26:04 +0100
Subject: [PATCH 70/91] reduce impact of requestAnimationFrame on incompatible
 browsers by minimizing number of lookups

---
 src/effects.js | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/src/effects.js b/src/effects.js
index 6a72a88f..12b87bd4 100644
--- a/src/effects.js
+++ b/src/effects.js
@@ -363,9 +363,17 @@ jQuery.fx.prototype = {
 		t.elem = this.elem;
 
 		if ( t() && jQuery.timers.push(t) && !timerId ) {
-			timerId = jQuery.support.requestAnimationFrame ?
-				!window[jQuery.support.requestAnimationFrame](fx.tick):
-				setInterval(fx.tick, fx.interval);
+			if ( jQuery.support.requestAnimationFrame ) {
+				timerId = true;
+				(function raf() {
+					if (timerId) {
+						window[jQuery.support.requestAnimationFrame](raf);
+					}
+					fx.tick();
+				})();
+			} else {
+				timerId = setInterval(fx.tick, fx.interval);
+			}
 		}
 	},
 
@@ -470,8 +478,6 @@ jQuery.extend( jQuery.fx, {
 
 		if ( !timers.length ) {
 			jQuery.fx.stop();
-		} else if ( jQuery.support.requestAnimationFrame && timerId) {
-			window[jQuery.support.requestAnimationFrame](jQuery.fx.tick);
 		}
 	},
 

From c95ab2a39c178eee47ce7b1cbdffa812d7914bb6 Mon Sep 17 00:00:00 2001
From: louisremi <louisremi@louisremi-laptop.(none)>
Date: Wed, 2 Feb 2011 11:25:09 +0100
Subject: [PATCH 71/91] first tick should not occur immediatly; no tick should
 happen after a stop() + comments

---
 src/effects.js | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/src/effects.js b/src/effects.js
index 12b87bd4..e5a10295 100644
--- a/src/effects.js
+++ b/src/effects.js
@@ -363,17 +363,16 @@ jQuery.fx.prototype = {
 		t.elem = this.elem;
 
 		if ( t() && jQuery.timers.push(t) && !timerId ) {
-			if ( jQuery.support.requestAnimationFrame ) {
-				timerId = true;
-				(function raf() {
+			// Use requestAnimationFrame instead of setInterval if available
+			( timerId = jQuery.support.requestAnimationFrame ) ?
+				window[timerId](function raf() {
+					// timerId will be true as long as the animation hasn't been stopped
 					if (timerId) {
-						window[jQuery.support.requestAnimationFrame](raf);
+						window[timerId](raf);
+						fx.tick();
 					}
-					fx.tick();
-				})();
-			} else {
+				}):
 				timerId = setInterval(fx.tick, fx.interval);
-			}
 		}
 	},
 

From 5b0369366a83d7339f925bfef3a277d7287c9bd2 Mon Sep 17 00:00:00 2001
From: louisremi <louisremi@louisremi-laptop.(none)>
Date: Fri, 11 Mar 2011 11:33:15 +0100
Subject: [PATCH 72/91] shorten requestAnimationFrame test

---
 src/support.js | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/support.js b/src/support.js
index 725575b3..64a54b83 100644
--- a/src/support.js
+++ b/src/support.js
@@ -13,7 +13,8 @@
 		a = div.getElementsByTagName("a")[0],
 		select = document.createElement("select"),
 		opt = select.appendChild( document.createElement("option") ),
-		input = div.getElementsByTagName("input")[0];
+		input = div.getElementsByTagName("input")[0],
+		raf = "RequestAnimationFrame";
 
 	// Can't get basic test support
 	if ( !all || !all.length || !a ) {
@@ -60,11 +61,10 @@
 
 		// Verify requestAnimationFrame mechanism existence
 		// use the prefixed name as the value
-		requestAnimationFrame: window.mozRequestAnimationFrame ?
-			'mozRequestAnimationFrame' :
-			window.webkitRequestAnimationFrame ?
-				'webkitRequestAnimationFrame' :
-				false,
+		requestAnimationFrame:
+			window['moz' + raf] ? 'moz' + raf :
+			window['webkit' + raf] ? 'webkit' + raf :
+			false,
 
 		// Will be defined later
 		deleteExpando: true,

From fe3203bb5bdc0049467214e7f0979a3487d5681b Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Mon, 4 Apr 2011 19:25:12 -0400
Subject: [PATCH 73/91] Some adjustments and style edits on lrbabe's pull for
 requestAnimationFrame

- Moved support.js check to effects.js.  This is just an assignment to the function if it exists.  Removed string concatenations.

  + Still need to do the checks on window, but after that, window is no longer needed.

- Switched ternary to an if statmenet

- assigned timerId to a number rather than the function. I did perf tests to check which is faster.
---
 src/effects.js | 20 ++++++++++++--------
 src/support.js | 10 +---------
 2 files changed, 13 insertions(+), 17 deletions(-)

diff --git a/src/effects.js b/src/effects.js
index e5a10295..9835e959 100644
--- a/src/effects.js
+++ b/src/effects.js
@@ -11,7 +11,8 @@ var elemdisplay = {},
 		[ "width", "marginLeft", "marginRight", "paddingLeft", "paddingRight" ],
 		// opacity animations
 		[ "opacity" ]
-	];
+	],
+	requestAnimationFrame = window.webkitRequestAnimationFrame || window.mozRequestionAnimationFrame;
 
 jQuery.fn.extend({
 	show: function( speed, easing, callback ) {
@@ -364,15 +365,18 @@ jQuery.fx.prototype = {
 
 		if ( t() && jQuery.timers.push(t) && !timerId ) {
 			// Use requestAnimationFrame instead of setInterval if available
-			( timerId = jQuery.support.requestAnimationFrame ) ?
-				window[timerId](function raf() {
-					// timerId will be true as long as the animation hasn't been stopped
-					if (timerId) {
-						window[timerId](raf);
+			if ( requestAnimationFrame ) {
+				timerId = 1;
+				requestAnimationFrame(function raf() {
+					// When timerId gets set to null at any point, this stops
+					if ( timerId ) {
+						requestAnimationFrame( raf );
 						fx.tick();
 					}
-				}):
-				timerId = setInterval(fx.tick, fx.interval);
+				});
+			} else {
+				timerId = setInterval( fx.tick, fx.interval );
+			}
 		}
 	},
 
diff --git a/src/support.js b/src/support.js
index 64a54b83..4c309562 100644
--- a/src/support.js
+++ b/src/support.js
@@ -13,8 +13,7 @@
 		a = div.getElementsByTagName("a")[0],
 		select = document.createElement("select"),
 		opt = select.appendChild( document.createElement("option") ),
-		input = div.getElementsByTagName("input")[0],
-		raf = "RequestAnimationFrame";
+		input = div.getElementsByTagName("input")[0];
 
 	// Can't get basic test support
 	if ( !all || !all.length || !a ) {
@@ -59,13 +58,6 @@
 		// (WebKit defaults to false instead of true, IE too, if it's in an optgroup)
 		optSelected: opt.selected,
 
-		// Verify requestAnimationFrame mechanism existence
-		// use the prefixed name as the value
-		requestAnimationFrame:
-			window['moz' + raf] ? 'moz' + raf :
-			window['webkit' + raf] ? 'webkit' + raf :
-			false,
-
 		// Will be defined later
 		deleteExpando: true,
 		optDisabled: false,

From c72371f71474cbd6e2318c8ad909a2f92dcb915c Mon Sep 17 00:00:00 2001
From: Dan Heberden <danheberden@gmail.com>
Date: Mon, 4 Apr 2011 23:59:54 -0700
Subject: [PATCH 74/91] Improve speed of $.map with object support (-5%
 previous speed) and improve .length detection

---
 src/core.js       | 15 +++++++--------
 src/sizzle        |  2 +-
 test/qunit        |  2 +-
 test/unit/core.js |  4 ++--
 4 files changed, 11 insertions(+), 12 deletions(-)

diff --git a/src/core.js b/src/core.js
index 49c191b9..c9b560ae 100644
--- a/src/core.js
+++ b/src/core.js
@@ -704,16 +704,15 @@ jQuery.extend({
 		return ret;
 	},
 
-		// arg is for internal usage only
+	// arg is for internal usage only
 	map: function( elems, callback, arg ) {
 		var value, ret = [],
-			i = 0,		
+			i = 0,
 			length = elems.length,
-			// process .length if it's just an object member
-			isArray = length !== undefined && ( elems[ length - 1 ] || jQuery.isArray( elems ) );
-		
+			// jquery objects are treated as arrays
+			isArray = elems instanceof jQuery || length !== undefined && typeof length === "number" && ( ( length > 0 && elems[ 0 ] && elems[ length -1 ] ) || jQuery.isArray( elems ) ) ;
+
 		// Go through the array, translating each of the items to their
-		// new value (or values).
 		if ( isArray ) {
 			for ( ; i < length; i++ ) {
 				value = callback( elems[ i ], i, arg );
@@ -723,8 +722,8 @@ jQuery.extend({
 				}
 			}
 
-		// Go thorugh every key on the object, 
-		} else {		
+		// Go thorugh every key on the object,
+		} else {
 			for ( key in elems ) {
 				value = callback( elems[ key ], key, arg );
 
diff --git a/src/sizzle b/src/sizzle
index ef19279f..f12b9309 160000
--- a/src/sizzle
+++ b/src/sizzle
@@ -1 +1 @@
-Subproject commit ef19279f54ba49242c6461d47577c703f4f4e80e
+Subproject commit f12b9309269ba7e705a99efe099f86ed1fe98d58
diff --git a/test/qunit b/test/qunit
index cc8460c7..d404faf8 160000
--- a/test/qunit
+++ b/test/qunit
@@ -1 +1 @@
-Subproject commit cc8460c7b44f023c4f84ab1810b72bf6c6ee4542
+Subproject commit d404faf8f587fcbe6b8907943022e6318dd51e0c
diff --git a/test/unit/core.js b/test/unit/core.js
index 08d80400..c15884fc 100644
--- a/test/unit/core.js
+++ b/test/unit/core.js
@@ -625,7 +625,7 @@ test("map()", function() {
 		q("ap","ap","ap"),
 		"Single Map"
 	);
-	
+
 	//for #2616
 	var keys = jQuery.map( {a:1,b:2}, function( v, k ){
 		return k;
@@ -636,7 +636,7 @@ test("map()", function() {
 		return v;
 	});
 	equals( values.join(""), "12", "Map the values from a hash to an array" );
-	
+
 	// object with length prop
 	var values = jQuery.map( {a:1,b:2, length:3}, function( v, k ){
 		return v;

From c0389e3e37447aa7eb70cfb4837f4df6cdec5bba Mon Sep 17 00:00:00 2001
From: Dan Heberden <danheberden@gmail.com>
Date: Tue, 5 Apr 2011 08:33:14 -0700
Subject: [PATCH 75/91] Add missing var declaration for

---
 src/core.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/core.js b/src/core.js
index c9b560ae..f2101099 100644
--- a/src/core.js
+++ b/src/core.js
@@ -706,7 +706,7 @@ jQuery.extend({
 
 	// arg is for internal usage only
 	map: function( elems, callback, arg ) {
-		var value, ret = [],
+		var value, key, ret = [],
 			i = 0,
 			length = elems.length,
 			// jquery objects are treated as arrays

From 23a411b6bcbb96edbbfe53e11ec1671dccaa92b6 Mon Sep 17 00:00:00 2001
From: rwldrn <waldron.rick@gmail.com>
Date: Tue, 5 Apr 2011 15:55:40 -0400
Subject: [PATCH 76/91] Ticket #8753 Allow special properties to explicitly
 defined on jQuery.Event objects

---
 src/event.js       | 17 ++++++++++++++---
 test/unit/event.js | 29 +++++++++++++++++++++++------
 2 files changed, 37 insertions(+), 9 deletions(-)

diff --git a/src/event.js b/src/event.js
index bc2cf76e..eadfa05c 100644
--- a/src/event.js
+++ b/src/event.js
@@ -1,6 +1,7 @@
 (function( jQuery ) {
 
-var rnamespaces = /\.(.*)$/,
+var hasOwn = Object.prototype.hasOwnProperty,
+	rnamespaces = /\.(.*)$/,
 	rformElems = /^(?:textarea|input|select)$/i,
 	rperiod = /\./g,
 	rspace = / /g,
@@ -581,6 +582,15 @@ jQuery.Event = function( src ) {
 		this.originalEvent = src;
 		this.type = src.type;
 
+		// Push explicitly provided properties onto the event object
+		for ( var prop in src ) {
+			//	Ensure we don't clobber jQuery.Event prototype
+			//	with own properties.
+			if ( hasOwn.call( src, prop ) ) {
+				this[ prop ] = src[ prop ];
+			}
+		}
+
 		// Events bubbling up the document may have been marked as prevented
 		// by a handler lower down the tree; reflect the correct value.
 		this.isDefaultPrevented = (src.defaultPrevented || src.returnValue === false ||
@@ -868,10 +878,10 @@ function trigger( type, elem, args ) {
 // Create "bubbling" focus and blur events
 if ( document.addEventListener ) {
 	jQuery.each({ focus: "focusin", blur: "focusout" }, function( orig, fix ) {
-	
+
 		// Attach a single capturing handler while someone wants focusin/focusout
 		var attaches = 0;
-		
+
 		jQuery.event.special[ fix ] = {
 			setup: function() {
 				if ( attaches++ === 0 ) {
@@ -1184,3 +1194,4 @@ jQuery.each( ("blur focus focusin focusout load resize scroll unload click dblcl
 });
 
 })( jQuery );
+
diff --git a/test/unit/event.js b/test/unit/event.js
index 2a6d8a66..d19c7ec4 100644
--- a/test/unit/event.js
+++ b/test/unit/event.js
@@ -685,7 +685,6 @@ test("hover()", function() {
 
 test("mouseover triggers mouseenter", function() {
 	expect(1);
-	
 	var count = 0,
 		elem = jQuery("<a />");
 	elem.mouseenter(function () {
@@ -693,7 +692,6 @@ test("mouseover triggers mouseenter", function() {
 	});
 	elem.trigger('mouseover');
 	equals(count, 1, "make sure mouseover triggers a mouseenter" );
-	
 	elem.remove();
 });
 
@@ -930,6 +928,27 @@ test("trigger(eventObject, [data], [fn])", function() {
 	$parent.unbind().remove();
 });
 
+test("jQuery.Event({ /* props */ })", function() {
+
+	expect(4);
+
+	var event = jQuery.Event({ type: "keydown", keyCode: 64 }),
+			handler = function( event ) {
+				ok( "keyCode" in event, "Special property 'keyCode' exists" );
+				equal( event.keyCode, 64, "event.keyCode has explicit value '64'" );
+			};
+
+	// Supports jQuery.Event implementation
+	equal( event.type, "keydown", "Verify type" );
+
+	ok( "keyCode" in event, "Special 'keyCode' property exists" );
+
+	jQuery("body").bind( "keydown", handler ).trigger( event );
+
+	jQuery("body").unbind( "keydown" );
+
+});
+
 test("jQuery.Event.currentTarget", function(){
 	expect(1);
 
@@ -1982,8 +2001,7 @@ test("window resize", function() {
 
 test("focusin bubbles", function() {
 	expect(5);
-	
-	var input = jQuery( '<input type="text" />' ).prependTo( "body" ), 
+	var input = jQuery( '<input type="text" />' ).prependTo( "body" ),
 		order = 0;
 
 	jQuery( "body" ).bind( "focusin.focusinBubblesTest", function(){
@@ -1996,12 +2014,10 @@ test("focusin bubbles", function() {
 
 	// DOM focus method
 	input[0].focus();
-	
 	// To make the next focus test work, we need to take focus off the input.
 	// This will fire another focusin event, so set order to reflect that.
 	order = 1;
 	jQuery("#text1")[0].focus();
-	
 	// jQuery trigger, which calls DOM focus
 	order = 0;
 	input.trigger( "focus" );
@@ -2027,3 +2043,4 @@ test("event properties", function() {
 	}).click();
 });
 */
+

From b1b2e83394ef6ebcbaa5167d95e827f86655b74c Mon Sep 17 00:00:00 2001
From: rwldrn <waldron.rick@gmail.com>
Date: Tue, 5 Apr 2011 16:20:55 -0400
Subject: [PATCH 77/91] Move this.type setting to after prop set; avoid setting
 twice

---
 src/event.js | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/event.js b/src/event.js
index eadfa05c..7f2e1d8b 100644
--- a/src/event.js
+++ b/src/event.js
@@ -580,7 +580,6 @@ jQuery.Event = function( src ) {
 	// Event object
 	if ( src && src.type ) {
 		this.originalEvent = src;
-		this.type = src.type;
 
 		// Push explicitly provided properties onto the event object
 		for ( var prop in src ) {
@@ -591,6 +590,10 @@ jQuery.Event = function( src ) {
 			}
 		}
 
+		if ( !this.type ) {
+			this.type = src.type;
+		}
+
 		// Events bubbling up the document may have been marked as prevented
 		// by a handler lower down the tree; reflect the correct value.
 		this.isDefaultPrevented = (src.defaultPrevented || src.returnValue === false ||

From 9db18ddd84adf63166f411a4f2c776b51d1840e0 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Tue, 5 Apr 2011 16:28:25 -0400
Subject: [PATCH 78/91] Per rwaldron's request, added oRequestAnimationFrame as
 a possibility

---
 src/effects.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/effects.js b/src/effects.js
index 9835e959..727c1a7a 100644
--- a/src/effects.js
+++ b/src/effects.js
@@ -12,7 +12,9 @@ var elemdisplay = {},
 		// opacity animations
 		[ "opacity" ]
 	],
-	requestAnimationFrame = window.webkitRequestAnimationFrame || window.mozRequestionAnimationFrame;
+	requestAnimationFrame = window.webkitRequestAnimationFrame ||
+	    window.mozRequestAnimationFrame ||
+	    window.oRequestAnimationFrame;
 
 jQuery.fn.extend({
 	show: function( speed, easing, callback ) {

From 92a4d59c3221ada339177ca860570893766a6429 Mon Sep 17 00:00:00 2001
From: rwldrn <waldron.rick@gmail.com>
Date: Tue, 5 Apr 2011 16:32:42 -0400
Subject: [PATCH 79/91] Remove this.type assignment

---
 src/event.js | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/event.js b/src/event.js
index 7f2e1d8b..fe197189 100644
--- a/src/event.js
+++ b/src/event.js
@@ -590,10 +590,6 @@ jQuery.Event = function( src ) {
 			}
 		}
 
-		if ( !this.type ) {
-			this.type = src.type;
-		}
-
 		// Events bubbling up the document may have been marked as prevented
 		// by a handler lower down the tree; reflect the correct value.
 		this.isDefaultPrevented = (src.defaultPrevented || src.returnValue === false ||

From d47c0ae4228a59fcf731f626d650bb55c4e34609 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Tue, 5 Apr 2011 22:40:12 -0400
Subject: [PATCH 80/91] Performance testing: localize val to each block and
 only set val to value when not a function

---
 src/attributes.js | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index c8106e98..9fdb1492 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -153,15 +153,15 @@ jQuery.fn.extend({
 	},
 
 	val: function( value ) {
-		var hooks, val,
+		var hooks, ret,
 			elem = this[0];
 		
 		if ( !arguments.length ) {
 			if ( elem ) {
 				hooks = jQuery.valHooks[ elem.nodeName.toLowerCase() ] || jQuery.valHooks[ elem.type ];
 
-				if ( hooks && "get" in hooks && (val = hooks.get( elem )) !== undefined ) {
-					return val;
+				if ( hooks && "get" in hooks && (ret = hooks.get( elem )) !== undefined ) {
+					return ret;
 				}
 
 				return (elem.value || "").replace(rreturn, "");
@@ -173,15 +173,16 @@ jQuery.fn.extend({
 		var isFunction = jQuery.isFunction( value );
 
 		return this.each(function( i ) {
-			var self = jQuery(this);
+			var self = jQuery(this), val;
 
 			if ( this.nodeType !== 1 ) {
 				return;
 			}
 
-			val = value;
 			if ( isFunction ) {
 				val = value.call( this, i, self.val() );
+			} else {
+				val = value;
 			}
 
 			// Treat null/undefined as ""; convert numbers to string

From 5dde3eb44169c3cdc8517aee693fe8f4d783d715 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Carl=20F=C3=BCrstenberg?= <azatoth@gmail.com>
Date: Fri, 8 Apr 2011 20:56:56 +0200
Subject: [PATCH 81/91] Git for dummies

Per request, here is an simple git for dummies quick sheet, with some
useful commands.
---
 README.md | 83 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 83 insertions(+)

diff --git a/README.md b/README.md
index d56576c8..17b38de6 100644
--- a/README.md
+++ b/README.md
@@ -56,6 +56,89 @@ Sometimes, the various git repositories get into an inconsistent state where bui
 (usually this results in the jquery.js or jquery.min.js being 0 bytes). If this happens, run `make clean`, then
 run `make` again.
 
+Git for dummies
+---------------
+
+As the source code is handled by the version control system Git, it's useful to know some features used.
+
+### Submodules ###
+
+The repository uses submodules, which normally are handles directly by the Makefile, but sometimes you want to
+be able to work with them manually.
+
+Following are the steps to manually get the submodules:
+
+1. `git clone https://github.com/jquery/jquery.git`
+2. `git submodule init`
+3. `git submodule update`
+
+Or:
+
+1. `git clone https://github.com/jquery/jquery.git`
+2. `git submodule update --init`
+
+Or:
+
+1. `git clone --recursive https://github.com/jquery/jquery.git`
+
+If you want to work inside a submodule, it is possible, but first you need to checkout a branch:
+
+1. `cd src/sizzle`
+2. `git checkout master`
+
+After you've commited your changes to the submodule, you'll update the jquery project to point to the new commit,
+but remember to push the submodule changes before pushing the new jquery commit:
+
+1. `cd src/sizzle`
+2. `git push origin master`
+3. `cd ..`
+4. `git add src/sizzle`
+5. `git commit`
+
+The makefile has some targets to simplify submodule handling:
+
+#### `make update_submodules` ####
+
+checks out the commit pointed to byu jquery, but merges your local changes, if any. This target is executed 
+when you are doing a normal `make`.
+
+#### `make pull_submodules` ####
+
+updates the content of the submoduels to what is probably the latest upstream code
+
+#### `make pull` ####
+
+make a `make pull_submodules` and after that a `git pull`. if you have no remote tracking in your master branch, you can
+execute this command as `make pull REMOTE=origin BRANCH=master` instead.
+
+### cleaning ###
+
+If you want to purge your working directory back to the status of upstream, following commands can be used (remember everything you've worked on is gone after these):
+
+1. `git reset --hard upstream/master`
+2. `git clean -fdx`
+
+### rebasing ###
+
+For feature/topic branches, you should always used the `--rebase` flag to `git pull`, or if you are usually handling many temporary "to be in a github pull request" branches, run following to automate this:
+
+* `git config branch.autosetuprebase local` (see `man git-config` for more information)
+
+### handling merge conflicts ###
+
+If you're getting merge conflicts when merging, instead of editing the conflicted files manually, you can use the feature
+`git mergetool`. Even though the default tool `xxdiff` looks awful/old, it's rather useful.
+
+Following are some commands that can be used there:
+
+* `Ctrl + Alt + M` - automerge as much as possible
+* `b` - jump to next merge conflict
+* `s` - change the order of the conflicted lines
+* `u` - undo an merge
+* `left mouse button` - mark a block to be the winner
+* `middle mouse button` - mark a line to be the winner
+* `Ctrl + S` - save
+* `Ctrl + Q` - quit
 
 Questions?
 ----------

From 17afd80d485b4ca36145a40fd7ac8f81f7099f7c Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Sat, 9 Apr 2011 15:56:35 -0400
Subject: [PATCH 82/91] IE8 testing for lowercasing the css properties on
 retrieving style; had assumed the style support check failed in IE8, which it
 now does

---
 src/support.js          | 6 +++---
 test/unit/attributes.js | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/support.js b/src/support.js
index b227293d..89d2bfea 100644
--- a/src/support.js
+++ b/src/support.js
@@ -8,7 +8,7 @@
 
 	div.style.display = "none";
 	div.setAttribute("className", "t");
-	div.innerHTML = "   <link/><table></table><a href='/a' style='color:red;float:left;opacity:.55;'>a</a><input type='checkbox'/>";
+	div.innerHTML = "   <link/><table></table><a href='/a' style='top:1px;float:left;opacity:.55;'>a</a><input type='checkbox'/>";
 	
 	var all = div.getElementsByTagName("*"),
 		a = div.getElementsByTagName("a")[0],
@@ -34,8 +34,8 @@
 		htmlSerialize: !!div.getElementsByTagName("link").length,
 
 		// Get the style information from getAttribute
-		// (IE uses .cssText insted)
-		style: /red/.test( a.getAttribute("style") ),
+		// (IE uses .cssText instead, and capitalizes all property names)
+		style: /top/.test( a.getAttribute("style") ),
 
 		// Make sure that URLs aren't manipulated
 		// (IE normalizes it by default)
diff --git a/test/unit/attributes.js b/test/unit/attributes.js
index 4289bc3b..3611b03e 100644
--- a/test/unit/attributes.js
+++ b/test/unit/attributes.js
@@ -110,8 +110,8 @@ test("attr(String)", function() {
 	equals( jQuery('#tAnchor5').attr('href'), "#5", 'Check for non-absolute href (an anchor)' );
 
 	// list attribute is readonly by default in browsers that support it
-	jQuery("#list-test").attr("list", "datalist");
-	equals( jQuery("#list-test").attr("list"), "datalist", "Check setting list attribute" );
+	jQuery('#list-test').attr('list', 'datalist');
+	equals( jQuery('#list-test').attr('list'), 'datalist', 'Check setting list attribute' );
 
 	// Related to [5574] and [5683]
 	var body = document.body, $body = jQuery(body);

From 3a1b4661f5b8249ce7a741084824ec5445c75719 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Sat, 9 Apr 2011 17:25:06 -0400
Subject: [PATCH 83/91]  #8150 - When removing the width and height attributes
 in IE6/7, setting to "" actually sets to 0 instead of auto

- Having fixed this automatically with the use of removeAttribute in browsers that support it, this will fix it for IE6/7 as well.

- This has no effect on width/height styles set elsewhere( test added to removeAttr )

- With this addition, I need to call attr in removeAttr for IE6/7, which means boolean calls like .attr("checked", "") will no longer remove the attribute, which I think is fine.  .attr("checked", false) will still remove.  If I had left it, it would have gone in an infinite loop since setting to empty string is the only way to remove it in these browsers.

- The hrefNormalized hooks were returning null if they weren't present.  Added the null check to the getter.

- Now that the style support fails in IE8 as well due to uppercasing everything, no need to have style included with the hrefNormalized hooks
---
 src/attributes.js       | 33 +++++++++++++++++++++------------
 test/unit/attributes.js | 10 +++++-----
 2 files changed, 26 insertions(+), 17 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index 15d4d50e..b4330a86 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -338,16 +338,11 @@ jQuery.extend({
 			name = jQuery.attrFix[ name ] || name;
 		
 			if ( jQuery.support.getSetAttribute ) {
+				// Use removeAttribute in browsers that support it
 				elem.removeAttribute( name );
 			} else {
-				// Only style is a special case.
-				if ( name === "style" ) {
-					elem.style.cssText = "";
-				} else {
-					elem.setAttribute( name, "" );
-					// Attempt to remove completely with DOM level 1
-					elem.removeAttributeNode( elem.getAttributeNode( name ) );
-				}
+				jQuery.attr( elem, name, "" );
+				elem.removeAttributeNode( elem.getAttributeNode( name ) );
 			}
 		}
 	},
@@ -448,15 +443,28 @@ if ( !jQuery.support.getSetAttribute ) {
 			}
 		}
 	};
+
+	// Set width and height to auto instead of 0 on empty string( Bug #8150 )
+	// This is for removals
+	jQuery.each([ "width", "height" ], function( i, name ) {
+		jQuery.attrHooks[ name ] = jQuery.extend( jQuery.attrHooks[ name ], {
+			set: function( elem, value ) {
+				if ( value === "" ) {
+					elem.setAttribute( name, "auto" );
+					return value;
+				}
+			}
+		});
+	});
 }
 
 // Remove certain attrs if set to false
 jQuery.each([ "selected", "checked", "readOnly", "disabled" ], function( i, name ) {
 	jQuery.attrHooks[ name ] = jQuery.extend( jQuery.attrHooks[ name ], {
 		set: function( elem, value ) {
-			if ( !value ) {
+			if ( value === false ) {
 				jQuery.removeAttr( elem, name );
-				return false;
+				return value;
 			}
 		}
 	});
@@ -464,10 +472,11 @@ jQuery.each([ "selected", "checked", "readOnly", "disabled" ], function( i, name
 
 // Some attributes require a special call on IE
 if ( !jQuery.support.hrefNormalized ) {
-	jQuery.each([ "href", "src", "style", "width", "height", "list" ], function( i, name ) {
+	jQuery.each([ "href", "src", "width", "height", "list" ], function( i, name ) {
 		jQuery.attrHooks[ name ] = jQuery.extend( jQuery.attrHooks[ name ], {
 			get: function( elem ) {
-				return elem.getAttribute( name, 2 );
+				var ret = elem.getAttribute( name, 2 );
+				return ret === null ? undefined : ret;
 			}
 		});
 	});
diff --git a/test/unit/attributes.js b/test/unit/attributes.js
index 3611b03e..fa30ff04 100644
--- a/test/unit/attributes.js
+++ b/test/unit/attributes.js
@@ -76,7 +76,7 @@ test("prop(String, Object)", function() {
 });
 
 test("attr(String)", function() {
-	expect(31);
+	expect(32);
 
 	equals( jQuery('#text1').attr('type'), "text", 'Check for type attribute' );
 	equals( jQuery('#radio1').attr('type'), "radio", 'Check for type attribute' );
@@ -90,6 +90,7 @@ test("attr(String)", function() {
 	equals( jQuery('#text1').attr('name'), "action", 'Check for name attribute' );
 	ok( jQuery('#form').attr('action').indexOf("formaction") >= 0, 'Check for action attribute' );
 	equals( jQuery('#form').attr('blah', 'blah').attr('blah'), 'blah', 'Set non-existant attribute on a form' );
+	equals( jQuery('#foo').attr('height'), undefined, 'Non existent height attribute should return undefined' );
 	
 	// [7472] & [3113] (form contains an input with name="action" or name="id")
 	var extras = jQuery('<input name="id" name="name" /><input id="target" name="target" />').appendTo('#testForm');
@@ -173,7 +174,7 @@ test("attr(Hash)", function() {
 });
 
 test("attr(String, Object)", function() {
-	expect(30);
+	expect(29);
 
 	var div = jQuery("div").attr("foo", "bar"),
 		fail = false;
@@ -196,8 +197,6 @@ test("attr(String, Object)", function() {
 	equals( jQuery("#name").attr('name'), undefined, 'Remove name attribute' );
 	jQuery("#check2").attr('checked', true);
 	equals( document.getElementById('check2').checked, true, 'Set checked attribute' );
-	jQuery("#check2").attr('checked', '');
-	equals( document.getElementById('check2').checked, false, 'Setting checked to empty string removes it' );
 	jQuery("#check2").attr('checked', false);
 	equals( document.getElementById('check2').checked, false, 'Set checked attribute' );
 	jQuery("#text1").attr('readonly', true);
@@ -400,11 +399,12 @@ test("attr('tabindex', value)", function() {
 });
 
 test("removeAttr(String)", function() {
-	expect(4);
+	expect(5);
 	equals( jQuery('#mark').removeAttr( "class" )[0].className, "", "remove class" );
 	equals( jQuery('#form').removeAttr('id').attr('id'), undefined, 'Remove id' );
 	equals( jQuery('#foo').attr('style', 'position:absolute;').removeAttr('style').attr('style'), undefined, 'Check removing style attribute' );
 	equals( jQuery('#form').attr('style', 'position:absolute;').removeAttr('style').attr('style'), undefined, 'Check removing style attribute on a form' );
+	equals( jQuery('#fx-test-group').attr('height', '3px').removeAttr('height').css('height'), "1px", 'Removing height attribute has no effect on height set with style attribute' );
 });
 
 test("removeProp(String)", function() {

From 8c40c00fac2f30fa0804ae8097642636f9718ddd Mon Sep 17 00:00:00 2001
From: Rick Waldron <waldron.rick@gmail.com>
Date: Sun, 10 Apr 2011 14:31:31 -0400
Subject: [PATCH 84/91] Fixes #8814. Clean up inArray.

---
 src/core.js | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/src/core.js b/src/core.js
index 3331969a..b05d4138 100644
--- a/src/core.js
+++ b/src/core.js
@@ -658,8 +658,9 @@ jQuery.extend({
 	},
 
 	inArray: function( elem, array ) {
-		if ( array.indexOf ) {
-			return array.indexOf( elem );
+
+		if ( indexOf ) {
+			return indexOf.call( array, elem );
 		}
 
 		for ( var i = 0, length = array.length; i < length; i++ ) {
@@ -843,12 +844,6 @@ if ( jQuery.browser.webkit ) {
 	jQuery.browser.safari = true;
 }
 
-if ( indexOf ) {
-	jQuery.inArray = function( elem, array ) {
-		return indexOf.call( array, elem );
-	};
-}
-
 // IE doesn't match non-breaking spaces with \s
 if ( rnotwhite.test( "\xA0" ) ) {
 	trimLeft = /^[\s\xA0]+/;
@@ -898,3 +893,4 @@ function doScrollCheck() {
 return jQuery;
 
 })();
+

From 8c318bf41412d493604beed1879c4a273ff05a57 Mon Sep 17 00:00:00 2001
From: Alexis Abril <alexis.abril@gmail.com>
Date: Sun, 10 Apr 2011 15:17:00 -0400
Subject: [PATCH 85/91] Fixes #7328. When getting data- attributes, after-cap
 any embedded dashes per the W3C HTML5 spec.

---
 src/data.js       | 12 ++++++++----
 test/unit/data.js | 19 ++++++++++++++++++-
 2 files changed, 26 insertions(+), 5 deletions(-)

diff --git a/src/data.js b/src/data.js
index 2d53a710..c2fd558f 100644
--- a/src/data.js
+++ b/src/data.js
@@ -1,6 +1,7 @@
 (function( jQuery ) {
 
-var rbrace = /^(?:\{.*\}|\[.*\])$/;
+var rbrace = /^(?:\{.*\}|\[.*\])$/,
+	rmultiDash = /([a-z])([A-Z])/g;
 
 jQuery.extend({
 	cache: {},
@@ -223,12 +224,13 @@ jQuery.fn.extend({
 				data = jQuery.data( this[0] );
 
 				if ( this[0].nodeType === 1 ) {
-					var attr = this[0].attributes, name;
+			    var attr = this[0].attributes, name;
 					for ( var i = 0, l = attr.length; i < l; i++ ) {
 						name = attr[i].name;
 
 						if ( name.indexOf( "data-" ) === 0 ) {
-							name = name.substr( 5 );
+							name = jQuery.camelCase( name.substring(5) );
+
 							dataAttr( this[0], name, data[ name ] );
 						}
 					}
@@ -282,7 +284,9 @@ function dataAttr( elem, key, data ) {
 	// If nothing was found internally, try to fetch any
 	// data from the HTML5 data-* attribute
 	if ( data === undefined && elem.nodeType === 1 ) {
-		data = elem.getAttribute( "data-" + key );
+		name = "data-" + key.replace( rmultiDash, "$1-$2" ).toLowerCase();
+
+		data = elem.getAttribute( name );
 
 		if ( typeof data === "string" ) {
 			try {
diff --git a/test/unit/data.js b/test/unit/data.js
index 8fb7f35a..94fa2a01 100644
--- a/test/unit/data.js
+++ b/test/unit/data.js
@@ -485,4 +485,21 @@ if (window.JSON && window.JSON.stringify) {
 
 		equals( JSON.stringify(obj), '{"foo":"bar"}', "Expando is hidden from JSON.stringify" );
 	});
-}
\ No newline at end of file
+}
+
+test("jQuery.data should follow html5 specification regarding camel casing", function() {
+	expect(6);
+
+	var div = jQuery("<div id='myObject' data-foo='a' data-foo-bar='b' data-foo-bar-baz='c'></div>")
+		.prependTo("body");
+
+	equals(div.data().foo, "a", "Verify single word data-* key");
+	equals(div.data().fooBar, "b", "Verify multiple word data-* key");
+	equals(div.data().fooBarBaz, "c", "Verify multiple word data-* key");
+
+	equals(div.data("foo"), "a", "Verify single word data-* key");
+	equals(div.data("fooBar"), "b", "Verify multiple word data-* key");
+	equals(div.data("fooBarBaz"), "c", "Verify multiple word data-* key");
+
+	div.remove();
+});
\ No newline at end of file

From 9ed5c774e4222a4f100b5a06e5f90327aa2d4b18 Mon Sep 17 00:00:00 2001
From: jeresig <jeresig@gmail.com>
Date: Sun, 10 Apr 2011 15:38:54 -0400
Subject: [PATCH 86/91] Pulling in latest Sizzle.

---
 src/sizzle | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/sizzle b/src/sizzle
index f12b9309..80f2b81d 160000
--- a/src/sizzle
+++ b/src/sizzle
@@ -1 +1 @@
-Subproject commit f12b9309269ba7e705a99efe099f86ed1fe98d58
+Subproject commit 80f2b81d1fbc13d62afb91cb87e1452fbbec1ef4

From da89d8768cb53daac59f17a8acd8e6323a4d3be6 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Sun, 10 Apr 2011 15:40:49 -0400
Subject: [PATCH 87/91] Had some stale code in test/unit/attributes.js

---
 test/unit/attributes.js | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/test/unit/attributes.js b/test/unit/attributes.js
index fa30ff04..f3f0bab2 100644
--- a/test/unit/attributes.js
+++ b/test/unit/attributes.js
@@ -127,10 +127,6 @@ test("attr(String)", function() {
 
 	body.removeAttribute('foo'); // Cleanup
 
-	var select = document.createElement("select"), optgroup = document.createElement("optgroup"), option = document.createElement("option");
-	optgroup.appendChild( option );
-	select.appendChild( optgroup );
-
 	var $img = jQuery('<img style="display:none" width="215" height="53" src="http://static.jquery.com/files/rocker/images/logo_jquery_215x53.gif"/>').appendTo('body');
 	equals( $img.attr('width'), "215", "Retrieve width attribute an an element with display:none." );
 	equals( $img.attr('height'), "53", "Retrieve height attribute an an element with display:none." );

From 83dc078055164ab766ab90cd9c239f44d9da88f1 Mon Sep 17 00:00:00 2001
From: jeresig <jeresig@gmail.com>
Date: Sun, 10 Apr 2011 16:28:44 -0400
Subject: [PATCH 88/91] Bringing in the latest Sizzle code.

---
 src/sizzle | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/sizzle b/src/sizzle
index 80f2b81d..c50b0cdd 160000
--- a/src/sizzle
+++ b/src/sizzle
@@ -1 +1 @@
-Subproject commit 80f2b81d1fbc13d62afb91cb87e1452fbbec1ef4
+Subproject commit c50b0cddec48494ba882606d03e14cce647d243b

From 52f31054fd97e20ba423d406a484885b2639178c Mon Sep 17 00:00:00 2001
From: jeresig <jeresig@gmail.com>
Date: Sun, 10 Apr 2011 16:32:40 -0400
Subject: [PATCH 89/91] Fix formatting.

---
 src/traversing.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/traversing.js b/src/traversing.js
index c46ce45f..6a971402 100644
--- a/src/traversing.js
+++ b/src/traversing.js
@@ -60,7 +60,8 @@ jQuery.fn.extend({
 	},
 
 	is: function( selector ) {
-		return !!selector && (typeof selector === "string" ? jQuery.filter( selector, this ).length > 0 :
+		return !!selector && (typeof selector === "string" ?
+			jQuery.filter( selector, this ).length > 0 :
 			this.filter( selector ).length > 0);
 	},
 

From 215c507f796db16a6e9230a2ecc27c57a1b85280 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Sun, 10 Apr 2011 17:08:18 -0400
Subject: [PATCH 90/91] Added back support.js test for getSetAttribute and
 removed some duplicate code that crept into attributes.js

---
 src/attributes.js | 14 --------------
 src/support.js    |  5 +++--
 2 files changed, 3 insertions(+), 16 deletions(-)

diff --git a/src/attributes.js b/src/attributes.js
index f7c2e981..eca7f347 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -24,20 +24,6 @@ jQuery.fn.extend({
 		return jQuery.access( this, name, value, true, jQuery.prop );
 	},
 	
-	removeProp: function( name ) {
-		return this.each(function() {
-			// try/catch handles cases where IE balks (such as removing a property on window)
-			try {
-				this[ name ] = undefined;
-				delete this[ name ];
-			} catch( e ) {}
-		});
-	},
-	
-	prop: function( name, value ) {
-		return jQuery.access( this, name, value, true, jQuery.prop );
-	},
-	
 	removeProp: function( name ) {
 		return this.each(function() {
 			// try/catch handles cases where IE balks (such as removing a property on window)
diff --git a/src/support.js b/src/support.js
index 10696aab..a919e4c7 100644
--- a/src/support.js
+++ b/src/support.js
@@ -19,7 +19,8 @@ jQuery.support = (function() {
 		isSupported;
 
 	// Preliminary tests
-	div.innerHTML = "   <link/><table></table><a href='/a' style='color:red;float:left;opacity:.55;'>a</a><input type='checkbox'/>";
+	div.setAttribute("className", "t");
+	div.innerHTML = "   <link/><table></table><a href='/a' style='top:1px;float:left;opacity:.55;'>a</a><input type='checkbox'/>";
 
 	all = div.getElementsByTagName( "*" );
 	a = div.getElementsByTagName( "a" )[ 0 ];
@@ -48,7 +49,7 @@ jQuery.support = (function() {
 
 		// Get the style information from getAttribute
 		// (IE uses .cssText instead)
-		style: /red/.test( a.getAttribute("style") ),
+		style: /top/.test( a.getAttribute("style") ),
 
 		// Make sure that URLs aren't manipulated
 		// (IE normalizes it by default)

From 791402b4536b8c5cbfeaf27d0a3c639cdb9fd192 Mon Sep 17 00:00:00 2001
From: timmywil <tim.willison@thisismedium.com>
Date: Sun, 10 Apr 2011 17:17:34 -0400
Subject: [PATCH 91/91] Separate raf function definition from passing it to
 requestAnimationFrame

---
 src/effects.js | 8 +++++---
 src/sizzle     | 2 +-
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/effects.js b/src/effects.js
index 727c1a7a..976fe765 100644
--- a/src/effects.js
+++ b/src/effects.js
@@ -350,7 +350,8 @@ jQuery.fx.prototype = {
 	// Start an animation from one number to another
 	custom: function( from, to, unit ) {
 		var self = this,
-			fx = jQuery.fx;
+			fx = jQuery.fx,
+			raf;
 
 		this.startTime = jQuery.now();
 		this.start = from;
@@ -369,13 +370,14 @@ jQuery.fx.prototype = {
 			// Use requestAnimationFrame instead of setInterval if available
 			if ( requestAnimationFrame ) {
 				timerId = 1;
-				requestAnimationFrame(function raf() {
+				raf = function() {
 					// When timerId gets set to null at any point, this stops
 					if ( timerId ) {
 						requestAnimationFrame( raf );
 						fx.tick();
 					}
-				});
+				};
+				requestAnimationFrame( raf );
 			} else {
 				timerId = setInterval( fx.tick, fx.interval );
 			}
diff --git a/src/sizzle b/src/sizzle
index f12b9309..80f2b81d 160000
--- a/src/sizzle
+++ b/src/sizzle
@@ -1 +1 @@
-Subproject commit f12b9309269ba7e705a99efe099f86ed1fe98d58
+Subproject commit 80f2b81d1fbc13d62afb91cb87e1452fbbec1ef4