deac
/
jquery
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix setting value attributes on option elements. Fixes #9071.

1.7/enhancement_8685
timmywil 2011-05-03 14:48:36 -04:00
parent 6d2fd57f45
commit 4ac2fdda2c
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/attributes.js
View File

@ -199,7 +199,7 @@ jQuery.fn.extend({
hooks = jQuery.valHooks[ this.nodeName.toLowerCase() ] || jQuery.valHooks[ this.type ];
// If set returns undefined, fall back to normal setting
if ( !hooks || ("set" in hooks && hooks.set( this, val, "value" ) === undefined) ) {
if ( !hooks || !("set" in hooks) || hooks.set( this, val, "value" ) === undefined ) {
this.value = val;
}
});

4
test/unit/attributes.js
View File

@ -447,7 +447,7 @@ test("removeProp(String)", function() {
});
test("val()", function() {
expect(25);
expect(26);
document.getElementById("text1").value = "bla";
equals( jQuery("#text1").val(), "bla", "Check for modified value of input element" );
@ -513,6 +513,8 @@ test("val()", function() {
var $button = jQuery("<button value='foobar'>text</button>").insertAfter("#button");
equals( $button.val(), "foobar", "Value retrieval on a button does not return innerHTML" );
equals( $button.val("baz").html(), "text", "Setting the value does not change innerHTML" );
equals( jQuery("<option/>").val("test").attr("value"), "test", "Setting value sets the value attribute" );
});
var testVal = function(valueObj) {