deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Remove code for ticket #7717 which has been marked WONTFIX to match existing $.data functionality and to prevent infinite loops caused by circular references.

Browse source
This commit is contained in:
Colin Snover 2010-12-22 14:43:17 -06:00
parent 2a47ceae5b
commit 445fdf720c
2 changed files with 5 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/manipulation.js
View file

@ -382,7 +382,7 @@ function cloneCopyEvent(orig, ret) {
} }
var oldData = jQuery.data( orig[nodeIndex] ), var oldData = jQuery.data( orig[nodeIndex] ),
curData = jQuery.data( this, jQuery.extend(true, {}, oldData) ), curData = jQuery.data( this, oldData ),
events = oldData && oldData.events; events = oldData && oldData.events;
if ( events ) { if ( events ) {

12
test/unit/manipulation.js
View file

@ -924,16 +924,12 @@ test("clone()", function() {
equals( clone.html(), div.html(), "Element contents cloned" ); equals( clone.html(), div.html(), "Element contents cloned" );
equals( clone[0].nodeName.toUpperCase(), "DIV", "DIV element cloned" ); equals( clone[0].nodeName.toUpperCase(), "DIV", "DIV element cloned" );
div = jQuery("<div/>").data({ div = jQuery("<div/>").data({ a: true });
a: true, b: true,
c: { nesty: ["Block", "Head"] }
});
var div2 = div.clone(true); var div2 = div.clone(true);
equals( div2.data("a"), true, "Data cloned." ); equals( div2.data("a"), true, "Data cloned." );
equals( div2.data("b"), true, "Data cloned." ); div2.data("a", false);
var c = div2.data("c"); equals( div2.data("a"), false, "Ensure cloned element data object was correctly modified" );
c.nesty[0] = "Fish"; equals( div.data("a"), true, "Ensure cloned element data object is copied, not referenced" );
equals( div.data("c").nesty[0], "Block", "Ensure cloned element data is deep copied (Bug #7717)" );
var form = document.createElement("form"); var form = document.createElement("form");
form.action = "/test/"; form.action = "/test/";