From 28a1bad7b18b7ca4937666893e268d6e1378ee4f Mon Sep 17 00:00:00 2001 From: "adam j. sontag" Date: Mon, 17 Jan 2011 16:10:14 -0500 Subject: [PATCH 1/4] Add a comment to explain (and enforce the temporary-ness of) an extra line of code added to workaround a Chrome 10 bug --- src/traversing.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/traversing.js b/src/traversing.js index b36ce3db..ee1d78b0 100644 --- a/src/traversing.js +++ b/src/traversing.js @@ -204,6 +204,9 @@ jQuery.each({ }, function( name, fn ) { jQuery.fn[ name ] = function( until, selector ) { var ret = jQuery.map( this, fn, until ), + // The variable 'args' was introduced in + // https://github.com/jquery/jquery/commit/52a02383fa521c51d9996a46f03a7080dd825f11 + // to work around a bug in Chrome 10 (Dev) and should be removed when the bug is fixed. args = slice.call(arguments); if ( !runtil.test( name ) ) { From 4058881784cec4adad881188064421ded69a0258 Mon Sep 17 00:00:00 2001 From: "adam j. sontag" Date: Mon, 17 Jan 2011 17:03:45 -0500 Subject: [PATCH 2/4] Add link to chrome issue ticket --- src/traversing.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/traversing.js b/src/traversing.js index ee1d78b0..c54e2543 100644 --- a/src/traversing.js +++ b/src/traversing.js @@ -207,6 +207,7 @@ jQuery.each({ // The variable 'args' was introduced in // https://github.com/jquery/jquery/commit/52a02383fa521c51d9996a46f03a7080dd825f11 // to work around a bug in Chrome 10 (Dev) and should be removed when the bug is fixed. + // http://code.google.com/p/v8/issues/detail?id=1050 args = slice.call(arguments); if ( !runtil.test( name ) ) { From 78be517727674d1e0a208e3e144eac8840d653e7 Mon Sep 17 00:00:00 2001 From: "adam j. sontag" Date: Mon, 17 Jan 2011 17:08:44 -0500 Subject: [PATCH 3/4] shorten the SHA --- src/traversing.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/traversing.js b/src/traversing.js index c54e2543..f41816cf 100644 --- a/src/traversing.js +++ b/src/traversing.js @@ -205,7 +205,7 @@ jQuery.each({ jQuery.fn[ name ] = function( until, selector ) { var ret = jQuery.map( this, fn, until ), // The variable 'args' was introduced in - // https://github.com/jquery/jquery/commit/52a02383fa521c51d9996a46f03a7080dd825f11 + // https://github.com/jquery/jquery/commit/52a0238 // to work around a bug in Chrome 10 (Dev) and should be removed when the bug is fixed. // http://code.google.com/p/v8/issues/detail?id=1050 args = slice.call(arguments); From d9660e1bf4f378e0fcb77ba266f27cdec7cda022 Mon Sep 17 00:00:00 2001 From: "adam j. sontag" Date: Mon, 17 Jan 2011 17:20:37 -0500 Subject: [PATCH 4/4] Fix tabs vs spaces in initial workaround commit --- src/traversing.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/traversing.js b/src/traversing.js index f41816cf..929547c1 100644 --- a/src/traversing.js +++ b/src/traversing.js @@ -208,7 +208,7 @@ jQuery.each({ // https://github.com/jquery/jquery/commit/52a0238 // to work around a bug in Chrome 10 (Dev) and should be removed when the bug is fixed. // http://code.google.com/p/v8/issues/detail?id=1050 - args = slice.call(arguments); + args = slice.call(arguments); if ( !runtil.test( name ) ) { selector = until;