deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fixed #1701 by passing through the arguments as suggested.

Browse source
This commit is contained in:
David Serduke 2007-11-28 22:23:40 +00:00
parent 5c6c99361f
commit 3ae5fbc16a
2 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/event.js
View file

@ -333,7 +333,7 @@ jQuery.fn.extend({
event.preventDefault(); event.preventDefault();
// and execute the function // and execute the function
return args[this.lastToggle].apply( this, [event] ) || false; return args[this.lastToggle].apply( this, arguments ) || false;
}); });
}, },

8
test/unit/event.js
View file

@ -172,7 +172,7 @@ test("trigger(event, [data], [fn])", function() {
}); });
test("toggle(Function, Function)", function() { test("toggle(Function, Function)", function() {
expect(4); expect(5);
var count = 0, var count = 0,
fn1 = function(e) { count++; }, fn1 = function(e) { count++; },
fn2 = function(e) { count--; }, fn2 = function(e) { count--; },
@ -180,7 +180,11 @@ test("toggle(Function, Function)", function() {
link = $('#mark'); link = $('#mark');
link.click(preventDefault).click().toggle(fn1, fn2).click().click().click().click().click(); link.click(preventDefault).click().toggle(fn1, fn2).click().click().click().click().click();
ok( count == 1, "Check for toggle(fn, fn)" ); ok( count == 1, "Check for toggle(fn, fn)" );
$("#firstp").toggle(function () {
equals(arguments.length, 4, "toggle correctly passes through additional triggered arguments, see #1701" )
}, function() {}).trigger("click", [ 1, 2, 3 ]);
var first = 0; var first = 0;
$("#simon1").one("click", function() { $("#simon1").one("click", function() {
ok( true, "Execute event only once" ); ok( true, "Execute event only once" );