deac/jquery
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Make sure closest works on disconnected DOM nodes. Fixes #7142.

Browse source
This commit is contained in:
John Resig 2010-10-11 07:45:15 -04:00
parent 2c04035cd1
commit 385ca2aa89
2 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/traversing.js
View file

@ -108,7 +108,7 @@ jQuery.fn.extend({
} else { } else {
cur = cur.parentNode; cur = cur.parentNode;
if ( !cur.ownerDocument || cur === context ) { if ( !cur || !cur.ownerDocument || cur === context ) {
break; break;
} }
} }

4
test/unit/traversing.js
View file

@ -122,7 +122,7 @@ test("filter(jQuery)", function() {
}) })
test("closest()", function() { test("closest()", function() {
expect(10); expect(11);
same( jQuery("body").closest("body").get(), q("body"), "closest(body)" ); same( jQuery("body").closest("body").get(), q("body"), "closest(body)" );
same( jQuery("body").closest("html").get(), q("html"), "closest(html)" ); same( jQuery("body").closest("html").get(), q("html"), "closest(html)" );
same( jQuery("body").closest("div").get(), [], "closest(div)" ); same( jQuery("body").closest("div").get(), [], "closest(div)" );
@ -140,6 +140,8 @@ test("closest()", function() {
//Test that .closest() returns unique'd set //Test that .closest() returns unique'd set
equals( jQuery('#main p').closest('#main').length, 1, "Closest should return a unique set" ); equals( jQuery('#main p').closest('#main').length, 1, "Closest should return a unique set" );
// Test on disconnected node
equals( jQuery("<div><p></p></div>").find("p").closest("table").length, 0, "Make sure disconnected closest work." );
}); });
test("closest(Array)", function() { test("closest(Array)", function() {